[Bug 178901] Review Request: gtksourceview-sharp

2006-07-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-07-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-07-21 20:03 EST ---
OK as per comment 31. APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-07-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-07-20 17:25 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec
SRPM Name or Url:
http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-13.src.rpm

Fixes licence

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-07-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-07-19 22:56 EST ---
That patch to autoconf and automake should go upstream if %(libdir) is the
accepted place to drop this.

- rpmlint checks return:
W: gtksourceview-sharp strange-permission gtksourceview-sharp-libdir.patch 0666
W: gtksourceview-sharp strange-permission gtksourceview-sharp.spec 0666
Ignorable, I'm not scared of 666.

W: gtksourceview-sharp incoherent-version-in-changelog 2.0-0.10-12 2.0-12.fc6
Confusion due to the 2.0-0.10 naming in the tarball. Should be fine as long as
the release is always bumped if that extra version number is updated, to say
2.0-0.11.

E: gtksourceview-sharp no-binary
E: gtksourceview-sharp only-non-binary-in-usr-lib
Expected for mono.

W: gtksourceview-sharp-devel no-documentation
Fine.


- package meets naming guidelines
Just watch out for that version.
- package meets packaging guidelines
BLOCKER - license is wrong, is LGPL.
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR (hopefully autoconf and automake will go away sometime)
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

For mono specific stuff the build does call gacutil like the guidelines say.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-07-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-07-09 07:27 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec
SRPM Name or Url:
http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-12.src.rpm

Very minor change to John's version...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-07-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-07-08 21:30 EST ---
Patching configure.in and Makefile.am to use %(libdir) works with lib64.

http://fedorared.org/~john/review/gtksourceview-sharp-2.0-12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-07-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-07-04 17:13 EST ---
For this to compile on a machine that has /usr/lib64 set as _libdir you need to 
add:

%define _libdir %{_exec_prefix}/lib


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-07-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-07-04 17:28 EST ---
I know. The problem is that things now need to comply with the mono packaging
guidelines which I'm having all hells job with trying to get things to work on
all platforms with.

If you're after the actual packages,
http://www.all-the-johnsons.co.uk/mono/rpms.html have the lot as binaries and I
know they're fairly happy as well!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-06-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 17:45 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec
SRPM Name or Url:
http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-10.src.rpm

Fix for devel file

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-06-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-06-04 09:29 EST ---
Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec
SRPM Name or Url:
http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-9.src.rpm

Change of URL

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-06-03 09:37 EST ---
Spec Name or Url: 
http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec
SRPM Name or Url:
http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp-2.0-9.src.rpm

Changed do the libdir bits are explicit rather than just make everything mine

Now please, someone, review it and let's get going on it!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-05-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-05-23 20:33 EST ---
/usr/bin/gapi2-fixup: line 3: which: command not found

Build groups changed recently, I believe. It works for me with
config_opts['buildgroup'] = 'build-minimal build-base build' in the mock 
config.

Well, it does but once I force %_libdir to point to /usr/lib on x86_64.

http://fedorared.org/~john/review/gtksourceview-sharp-2.0-7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-05-08 10:10 EST ---
Created an attachment (id=128745)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128745action=view)
Mock Build Failure Log

gtksourceview-sharp currently fails in Mock.  I've attached the build log, and
if I've got some extra free time later today, I'll look to see what's causing
the problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 178901] Review Request: gtksourceview-sharp

2006-04-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtksourceview-sharp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178901





--- Additional Comments From [EMAIL PROTECTED]  2006-04-27 17:04 EST ---
Spec Name or Url: 
http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec
SRPM Name or Url:
http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp-2.0-6.src.rpm

Quite a lot of fixes from the 0-4 release. I am still having the same x86_64
problems as before, but I have the i386 version running here and at work (work
is x86_64) without a problem.

This version has both boo and java support built in.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review