[Bug 181599] Review Request: gallery2: web based photo album software

2008-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/show_bug.cgi?id=181599


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-07 05:47 EST ---
Probably a bit late now, but if config.php is really a config file, shouldn't it
live under /etc rather than /usr/share ?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-07 10:12 EST ---
Well, that file (/usr/share/gallery2/config.php) is only written to if you run
the installer and select that directory to install in, right? 

You shouldn't ever install a gallery there, you should install under
/srv/gallery2/ which should write out a new config.php in whatever directory you
choose. Or am I confusing multisite mode with standard mode installs?



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-07 10:56 EST ---
That might be the case in multisite mode, but single site it drops config.php
into /usr/share/gallery2 whether you like it or not.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-07 13:27 EST ---
Packages have been built for FC4/5/devel - as soon as I can file a bug regarding
the config.php against the component (read: as soon as gallery2 gets imported as
a component) I'll close this feature request.  Keeping it open for now so I
don't forget to look at that.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-06 05:37 EST ---
(In reply to comment #68)
 The package will work fine with a read-only /usr given that:
 - The admin makes /usr rw to install the package (needed for all packages)
 - The gallery store is outside /usr (e.g. /srv/gallery2)
 
 Additionally, /usr being ro can't be a blocker because that would conflict 
 with
 the updated packaging guidelines stating web apps must go into /usr/share

The application needs to go in /usr/share; its data doesn't need to. Anything
that's writable is data.

(In reply to comment #69)
 It looks like the only thing that would need to get written in
 /usr/share/gallery2 is the login.txt file that the installer requires you to 
 put
 there to authenticate. Is there any chance you could patch it to look for that
 in /srv/gallery2/ instead? 

It might not even need patching; could the file be replaced by a symlink to
somewhere like /etc/gallery2/login.txt, and install the original file there?




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-06 14:42 EST ---
I've made /usr/share/gallery2/login.txt a symlink to /etc/gallery2/login.txt. 
There are two things I'm not quite sure I like about this, either may end up
blocking approval (which I'd be fine with and will then try to patch):

1. When /etc/gallery2/login.txt is marked %config(noreplace), the setup
complains that the login.txt doesn't match (as opposed to simply asking you to
create it).

2. When %ghost-ed, setup complains that it couldn't be read accessed.

In both these situations, the complaint looks like there was a problem with a
previous login.txt, but simply creating the correct one (in both cases) will
resolve the situation.

New packages:
SPEC:  http://www.berningeronline.net/gallery2.spec
SRPM:  http://www.berningeronline.net/gallery2-2.1-0.20.svn20060524.src.rpm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-06 16:28 EST ---
(In reply to comment #72)
 Any login.txt you generate at build time will be wrong when the app runs the
 installer the first time, so shipping any login.txt isn't going to work I 
 don't
 think. 
 
 How about a link from /usr/share/gallery2/login.txt to 
 /srv/gallery2/login.txt?
 
 Then that /srv/gallery2/login.txt could just be a %ghosted file, but make sure
 it gets created with root.root and 600 perms (to prevent a normal user from
 writing it). 
 
 Thoughts?

If it's ghosted, no file will get installed there when the rpm is installed, so
the permissions won't make any difference. Sounds like a patch will be needed
rather than a symlink unfortunately.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-06 16:48 EST ---
Well, I was thinking a %ghost for that file, then in create it in %post...
either an an empty file or as one containing information about why it's there.
It would then be overwritten by the install running user when they are running
the installer. 

A patch would be nicer, not sure how difficult it will be to patch however. 
In addition to the path to login.txt, you need to make sure and change the
install to refer to the new correct directory to upload the file to. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-06 18:08 EST ---
Turns out it's quite easy to patch.  I've done so, %ghost'ed the login.txt, and
re-rolled the package:

SPEC:  http://www.berningeronline.net/gallery2.spec
SRPM:  http://www.berningeronline.net/gallery2-2.1-0.21.svn20060524.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-06 20:48 EST ---
Excellent. I am able to now do new multisite installs without changing anything
under /usr/share/gallery2. The updates seem to work just fine with existing
sites from previous versions. 

I don't see any further blockers... I'm happy to (finally) call this package
APPROVED. 

Thanks for all your hard work John (and all the good comments from everyone). 

Don't forget to close this bug with NEXTRELEASE once it's imported and built. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-06 23:54 EST ---
Package imported, waiting on CVS sync for FC4/5 now.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 13:38 EST ---
Yeah, multisite looks good now here too. 

So with the install under /usr/share/gallery2, further selinux changes will need
to be made to allow it to work with selinux on, right?

Also, since it changes files under that tree, read-only /usr won't work with it,
but not sure how big a deal that is anymore. 

One rpmlint issue in this latest version: 

E: gallery2 non-executable-script /usr/share/gallery2/lib/tools/po/header.pl 
0644

Should that be not shipped? or made 755?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-05 22:51 EST ---
It looks like the only thing that would need to get written in
/usr/share/gallery2 is the login.txt file that the installer requires you to put
there to authenticate. Is there any chance you could patch it to look for that
in /srv/gallery2/ instead? 

Thats the only final issue I see before approval. ;) 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-03 16:21 EST ---
Re comment #61: 

Yeah, that was the problem. It was defaulting to /srv/gallery2 instead of the
data dir that I gave it. This must be a bug in the installer... ;( 
Multi-site is working here if I go to that step and manually edit the config.php
to put in the right path. 

So, outstanding issues I see: 

- Making a README.fedora would be nice (but not required). 

- There was some talk at a recent FESCo meeting about requiring web apps to
install in /usr/share/$name instead of /var/www/$name, but I don't see any hard
requirement on it currently, and I don't think the selinux stuff is in place for
that currently either. 

I want to do a final rebuild/rpmlint/sanity check here before approval. 

If anyone else sees any blockers, speak up now...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-06-03 18:58 EST ---
Note the end of http://fedoraproject.org/wiki/Packaging/Guidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-05-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-05-27 16:13 EST ---
I have no idea. I've tried the -17 packages on FC5 and FC3 and both have worked;
I've pasted the error to upstream and asked if they have any ideas.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-05-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-05-27 20:37 EST ---
I ran into this problem configuring for multisite when I tried out the earlier
RPMS. The problem for me seemed to be that no matter what I put in for the data
directory (the non web accessible data area), after the config file was written,
it had a different (i.e., not the one I specified) /srv based data directory.
After the config file writing step I had to edit the just written config file to
point to the correct data directory or else I would get the same error on the
next step when the install procedure copied over the files to the new multisite.
Hopefully not to obtuse...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-05-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: gallery: web|Review Request: gallery2:
   |based photo album software  |web based photo album
   ||software




--- Additional Comments From [EMAIL PROTECTED]  2006-05-26 11:12 EST ---
Re: comment #54, I couldn't get a multisite to work either (same error as 
you...), but *did* get single-site to work.  I was testing 16svn on a rhel4 
box though...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-05-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-05-26 11:14 EST ---
Small nitpick: Packaging Guidelines say to use (something like)
Release: 0.17.svn20060524
instead of
Release: 0.17svn20060524
(ie, put a . between 0.x and the cvs/svn bits)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 181599] Review Request: gallery2: web based photo album software

2006-05-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gallery2: web based photo album software


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599





--- Additional Comments From [EMAIL PROTECTED]  2006-05-26 11:35 EST ---
I tried both multisite and single site and couldn't get either to work. 
I did try the multisite first tho, and it might have left some junk around that
prevented the single site from working. Selinux is off. Lots of disk space. 

I will try and investigate further later tonight. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review