[Bug 185262] Review Request: kchmviewer - CHM viewer

2007-04-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2007-04-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-07 16:29 EST ---
Package Change Request
==
Package Name: kchmviewer
Updated Fedora Owners: pertusus[ AT ]free.fr, jpo[ AT ]di.uminho.pt

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-05-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262





--- Additional Comments From [EMAIL PROTECTED]  2006-05-17 20:16 EST ---
Created an attachment (id=129378)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=129378&action=view)
Minor patch

Thanks.  Now you can update the package to version 2.5 :)

You need to apply the attached patch (at least for FC-5) and add the following
line to the specfile (%files section):
   %{_datadir}/icons/crystalsvg/*/apps/kchmviewer.png

jpo

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-05-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-05-16 19:29 EST ---
I was on vacations, I hope everything is sorted out now.

The issue raised in the comment #6 should be fixed, I updated
owners.list, and it is built for FC-4 FC-5.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-05-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|CLOSED  |NEW
   Keywords||Reopened
 Resolution|NEXTRELEASE |




--- Additional Comments From [EMAIL PROTECTED]  2006-05-12 14:56 EST ---
Re-opening this until Patrice can:
 * look at comment #6
 * build the package for FC-4 and FC-5 (branches already created)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-05-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-05-08 00:18 EST ---
package is in extras. Please remember to close package reviews once approved and
imported into cvs etc etc

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262





--- Additional Comments From [EMAIL PROTECTED]  2006-05-01 07:44 EST ---
Oops, better yet, change:

desktop-file-install --vendor fedora\
--dir ${RPM_BUILD_ROOT}%{_datadir}/applications \
--add-category X-Fedora \
kio-msits/kchmviewer.desktop

to

desktop-file-install --vendor fedora\
--dir ${RPM_BUILD_ROOT}%{_datadir}/applications \
--add-category X-Fedora \
--delete-original \
$RPM_BUILD_ROOT%{_datadir}/applnk/*/kchmviewer.desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262





--- Additional Comments From [EMAIL PROTECTED]  2006-05-01 07:42 EST ---
Patrice, just use
desktop-file-install --delete-original ...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262





--- Additional Comments From [EMAIL PROTECTED]  2006-05-01 04:27 EST ---
I am importing the package now. Should I remove the
/usr/share/applnk/kchmviewer.desktop
file?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 185262] Review Request: kchmviewer - CHM viewer

2006-04-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kchmviewer - CHM viewer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185262


[EMAIL PROTECTED] changed:

   What|Removed |Added

  QAContact|fedora-extras-  |fedora-package-
   |[EMAIL PROTECTED] |[EMAIL PROTECTED]

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-04-30 22:09 EST ---
 rpmlint checks return:
E: kchmviewer old-menu-entry /usr/share/applnk/kchmviewer.desktop

Not necessary with it already in /usr/share/applications 

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file ok

%description's a bit long, but oh well.

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review