[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-09-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Resolution|NOTABUG |DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-09-09 11:47 EST ---


*** This bug has been marked as a duplicate of 205884 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-08-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEEDINFO|CLOSED
 Resolution||NOTABUG
 AssignedTo|[EMAIL PROTECTED]   |[EMAIL PROTECTED]
OtherBugsDependingO|163778  |201449
  nThis||
   Flag|needinfo?([EMAIL PROTECTED])|




--- Additional Comments From [EMAIL PROTECTED]  2006-08-18 14:50 EST ---
Closing and blocking FE-DEADREVIEW.  The original submitter should feel free to
reopen if he wants to continue this submission later.  If someone else wants to
submit this module, open a new ticket and mark this as a duplicate of the new 
one.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184





--- Additional Comments From [EMAIL PROTECTED]  2006-08-09 20:36 EST ---
In accordince with the stalled review policy, I will close out this review in
one week.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-07-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDINFO
   Flag||needinfo?([EMAIL PROTECTED])




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-06-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184





--- Additional Comments From [EMAIL PROTECTED]  2006-06-15 13:17 EST ---
Version 0.172 is available in CPAN
(http://search.cpan.org/dist/Email-Valid/)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-06-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184





--- Additional Comments From [EMAIL PROTECTED]  2006-06-15 12:29 EST ---
Ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-05-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184





--- Additional Comments From [EMAIL PROTECTED]  2006-05-09 13:34 EST ---
Very sorry, it's on my todo list.  I just had to prioritize my time elsewhere. 
I appreciate the review, will get this one out this week.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-05-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184





--- Additional Comments From [EMAIL PROTECTED]  2006-05-09 11:32 EST ---
Any update?  This package just needs two minor fixes and it's ready to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189184] Review Request: perl-Email-Valid - check validity of email addresses

2006-05-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Email-Valid - check validity of email addresses


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189184





--- Additional Comments From [EMAIL PROTECTED]  2006-05-01 21:51 EST ---
I took another look at this and realized that it's probably best if the test
suite is disabled; it requires network access which is a bad idea since the
builder machines aren't even guaranteed to be on the Internet.  I'm going to
disable it in the spec and proceed with the review, but you should consider
patching out the tests that require the network instead so there's at least a
bit of test coverage.

Issues:
You'll need BuildRequires: Mail::Address (makefile complains about it not being
there).

Two of the files in the build package come out mode 444.  The Perl specfile
template contains a chmod line at the end of %install to fix these up.

I'll approve if you fix these two issues.

Review:
* package meets naming and packaging guidelines.
X specfile is properly named, is cleanly written, uses macros consistently. 
It's missing a bit from the suggested template which causes problems.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   371b1552b81b93ffbf89cf2b1c1376c5  Email-Valid-0.15.tar.gz
   371b1552b81b93ffbf89cf2b1c1376c5  Email-Valid-0.15.tar.gz-srpm
* latest version is being packaged.
X BuildRequires missing perl(Mail::Address).
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X file permissions improper; some files are mode 444.
* %clean is present.
O %check is disabled; test suite requires network access.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review