[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/show_bug.cgi?id=189705 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-06-28 02:04 EST --- A few comments: As in comment #2, Source0 is not a full URL. I suggest using: Source0: http://www.sixxs.net/archive/sixxs/aiccu/unix/aiccu_%{version}.tar.gz Builds fine in mock; rpmlint says: E: aiccu non-readable /etc/aiccu.conf 0600 Understandable since this includes password information. W: aiccu service-default-enabled /etc/init.d/aiccu The init script has: # chkconfig: 345 15 85 So the service will start enabled in runlevels 3, 4, and 5. You should s/345/-/. The makefile strips the binary, which breaks -debuginfo generation. Other than those, things look pretty good although I suspect that once you fix -debuginfo generation, the fact that many of the source files are executable for some reason will cause several other warnings. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 --- Additional Comments From [EMAIL PROTECTED] 2006-06-28 10:20 EST --- Fixed the above, no further warnings are emitted. Spec URL: http://domsch.com/linux/fedora/extras/aiccu/aiccu.spec SRPM URL: http://domsch.com/linux/fedora/extras/aiccu/aiccu-2005.01.31-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 --- Additional Comments From [EMAIL PROTECTED] 2006-06-28 15:30 EST --- Fixed RPM_OPT_FLAGS usage, and removed executable bits on files going into debuginfo so that's sane now. Spec URL: http://domsch.com/linux/fedora/extras/aiccu/aiccu.spec SRPM URL: http://domsch.com/linux/fedora/extras/aiccu/aiccu-2005.01.31- 4.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-28 16:09 EST --- Everything looks fine now; the debuginfo package has the source and build.log shows the proper flags being passed to the compiler. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 --- Additional Comments From [EMAIL PROTECTED] 2006-06-01 09:14 EST --- Not a Review but found one thing in SPEC SOURCE is not URL -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189705] Review Request: aiccu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 --- Additional Comments From [EMAIL PROTECTED] 2006-05-09 11:11 EST --- I need one more trivial fixup, to start the service at level 59 so it starts after ntpd. I'll include that in the final posting. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review