[Bug 189824] Review Request: lasi - C++ library for creating Postscript documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lasi - C++ library for creating Postscript documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189824 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-08 14:05 EST --- APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189824] Review Request: lasi - C++ library for creating Postscript documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lasi - C++ library for creating Postscript documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189824 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-05-08 14:21 EST --- Checked in. Added to owners.list Built on devel. FC-4 and FC-5 to come shortly. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189824] Review Request: lasi - C++ library for creating Postscript documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lasi - C++ library for creating Postscript documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189824 --- Additional Comments From [EMAIL PROTECTED] 2006-05-06 16:11 EST --- One small issue: the summary of lasi-devel should end with a period. Another issue which is probably a mistake by upstream: pkg-config --libs lasi returns the empty string instead of -lLASi Looking at the examples, -lLASi is always explicitly included in the compile command. Also, the policy of FE is to omit static libraries, see Static Libraries in http://fedoraproject.org/wiki/Packaging/Guidelines -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 189824] Review Request: lasi - C++ library for creating Postscript documents
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lasi - C++ library for creating Postscript documents https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189824 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-04-30 19:54 EST --- First the good news: no complaints from rpmlint. Now for the nitpicks:-) 1. The doc directory properly belong in the -devel package, since it is API documentation. 2. In %description I would use LASi instead of libLASi since that is the name. 3. The -devel package needs Requires: pango-devel and freetype-devel These are included in LASi.h -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
