[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-09-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn|191590  |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 23:07 EST ---
Thanks.  AG.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-07-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 17:35 EST ---
Looks good, approved!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-07-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886





--- Additional Comments From [EMAIL PROTECTED]  2006-07-14 00:09 EST ---
(In reply to comment #3)
> 0 rpmlint output is:
> E: fluidsynth obsolete-not-provided iiwusynth
> E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel

Fixed.

> 0 License (LGPL) ok, but license file not included!

Fixed.

> 0 no %doc

Fixed.

> 0 .la files packaged, bad!

Fixed.

> * Alphanumeric parts of the version should be in the Release field, as per:
>  http://fedoraproject.org/wiki/Packaging/NamingGuidelines
>  Then you can drop the "-n fluidsynth-1.0.7" to %setup too

Fixed.

> * Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora
>   package use %package libs same goes for the devel package.

Fixed.

> * The following rpmlint output:
> E: fluidsynth obsolete-not-provided iiwusynth
> E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
> * Don't package .la files, remove them under %install or %exclude them in 
> %files
> * Add a %doc including atleast COPYING, but mosty likely also other candidates

Fixed, as above.

Thanks for your effort. Sorry for the delay.

Updates bits here:
Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7-5.a.src.rpm





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-06-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


Bug 189886 depends on bug 189884, which changed state.

Bug 189884 Summary: Review Request: LASH Audio Session Handler
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189884

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-06-15 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
 CC||[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-06-15 07:47 EST ---
MUST:
=
0 rpmlint output is:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
These both must be fixed.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
0 License (LGPL) ok, but license file not included!
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* shared libraries, ldconfig properly ran
* Not relocatable
* Package owns / or requires all dirs (with some strangeness see Must fix below)
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
0 no %doc
* -devel package as needed
0 .la files packaged, bad!
* no gui -> no .desktop file required


MUST fix:
=
* Alphanumeric parts of the version should be in the Release field, as per:
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines
 Then you can drop the "-n fluidsynth-1.0.7" to %setup too
* Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora
  package use %package libs same goes for the devel package.
* The following rpmlint output:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
* Don't package .la files, remove them under %install or %exclude them in %files
* Add a %doc including atleast COPYING, but mosty likely also other candidates


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-05-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886





--- Additional Comments From [EMAIL PROTECTED]  2006-05-27 20:10 EST ---
(In reply to comment #1)
> Unnecessary build dependence e2fsprogs-devel.

Thanks.  Fixed.

Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7a-4.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-05-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886





--- Additional Comments From [EMAIL PROTECTED]  2006-05-27 10:54 EST ---
Unnecessary build dependence e2fsprogs-devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-05-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||191538
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||189884




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|177841  |
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO||177841
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

2006-05-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886


[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||191590




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review