[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-02 09:14 EST --- Oops, I forgot to set this to FE-ACCEPT, doing so now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 --- Additional Comments From [EMAIL PROTECTED] 2006-06-23 08:14 EST --- Erm. Is it me or haven't you created an Fedora account yet. As far as I'm concerned your good to go to create a Fedora account and then I'll sponsor you. After which you can imprt qjackctl, this one will has to wait until al the deps are done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 --- Additional Comments From [EMAIL PROTECTED] 2006-06-23 18:48 EST --- (In reply to comment #7) Erm. Is it me or haven't you created an Fedora account yet. As far as I'm concerned your good to go to create a Fedora account and then I'll sponsor you. Sorry, no, it is not you, I have had a very busy week... I'll get to it as soon as I can find a minute. I really appreciate your sponsorship. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 --- Additional Comments From [EMAIL PROTECTED] 2006-06-24 00:46 EST --- (In reply to comment #8) Sorry, no, it is not you, I have had a very busy week... I'll get to it as soon as I can find a minute. I really appreciate your sponsorship. No problem we all have those sometimes (busy weeks). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|177841 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-20 14:22 EST --- Looks good, approved and so does qjackctl, concider yourself sponsored. Please create an account (or add yourself to the cvsextras group if you alreayd have). This and the next steps are described here: http://fedoraproject.org/wiki/Extras/Contributors . Notice that I'm keeping the blocker bug as FE-REVIEW for now and that you shouldn't import this yet as not all deps (fluidsynth) have been imported and build. I've done a full review of the deps, but unfortunatly no response sofar. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538
--- Additional Comments From [EMAIL PROTECTED] 2006-06-18 22:22 EST ---
(In reply to comment #4)
* rpmlint output is:
W: qsynth no-version-in-last-changelog
W: qsynth-debuginfo no-version-in-last-changelog
These both must be fixed.
* Source0: http://dl.sf.net/qsynth/qsynth-%{version}.tar.gz
Must be: Source0:
http://dl.sf.net/sourceforge/qsynth/qsynth-%{version}.tar.gz
* %makeinstall is broken (yeah I know, someone should fix it) please use:
make install DESTDIR=$RPM_BUILD_ROOT instead. (Or make that %{__make}
..)
* Under %files I see %{_datadir}/icons/qsynth.png, that is not according to
the
freedesktop.org icon standard, it should go under:
%{_datadir}/icons/hicolor/32x32/apps
Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/
to see the available valid sizes, if the icon doesn't match any pick the
closest.
* Once the icon is in the proper case you must add %post(un) script to update
the icon-cache see:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
All fixed:
Spec URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth.spec
SRPM URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth-0.2.5-4.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538
[EMAIL PROTECTED] changed:
What|Removed |Added
OtherBugsDependingO|163776 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-06-15 08:18 EST ---
MUST:
=
* rpmlint output is:
W: qsynth no-version-in-last-changelog
W: qsynth-debuginfo no-version-in-last-changelog
These both must be fixed.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files Permissions ok
* %clean macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed, no libs / .la files.
* .desktop file as required and properly installed
MUST fix:
=
* rpmlint output is:
W: qsynth no-version-in-last-changelog
W: qsynth-debuginfo no-version-in-last-changelog
These both must be fixed.
* Source0: http://dl.sf.net/qsynth/qsynth-%{version}.tar.gz
Must be: Source0: http://dl.sf.net/sourceforge/qsynth/qsynth-%{version}.tar.gz
* %makeinstall is broken (yeah I know, someone should fix it) please use:
make install DESTDIR=$RPM_BUILD_ROOT instead. (Or make that %{__make} ..)
* Under %files I see %{_datadir}/icons/qsynth.png, that is not according to the
freedesktop.org icon standard, it should go under:
%{_datadir}/icons/hicolor/32x32/apps
Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/
to see the available valid sizes, if the icon doesn't match any pick the
closest.
* Once the icon is in the proper case you must add %post(un) script to update
the icon-cache see:
http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538
--- Additional Comments From [EMAIL PROTECTED] 2006-06-08 13:20 EST ---
Hi Fernando. Here are some comments. Some of these may seem nit-picky - sorry
about that...
* Release should use %{?dist}
* Alignment is inconsistent with rest of Fedora, so..
Summary: Qt based Fluidsynth GUI front end
Name: qsynth
Version: 0.2.5
..should be...
Summary: Qt based Fluidsynth GUI front end
Name:qsynth
Version: 0.2.5
* Some people prefer that we use %makeinstall, although I don't know if it's
required. I've been using it in all my spec files based on somebody's request.
* Don't install the generic INSTALL file.
* Remember to put version info for each changelog entry
rpmlint ../RPMS/i386/qsynth-0.2.5-2.i386.rpm
W: qsynth no-version-in-last-changelog
* I believe you should use the following before %configure...
unset QTDIR || : ; . /etc/profile.d/qt.sh
export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
That's it for now. Thanks!
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 --- Additional Comments From [EMAIL PROTECTED] 2006-06-08 13:28 EST --- One more thing.. I tried this with VintageDreams soundfont, and found that I had to turn the gain down to 10 or less in order to stop the output from red-lining. The gain setting defaults to 100. Is this expected? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538
--- Additional Comments From [EMAIL PROTECTED] 2006-06-09 01:40 EST ---
New version:
Spec URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth.spec
SRPM URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth-0.2.5-3.src.rpm
(In reply to comment #1)
Hi Fernando. Here are some comments. Some of these may seem nit-picky -
sorry
about that...
That's fine, some I will ignore :-)
* Release should use %{?dist}
Fixed.
* Some people prefer that we use %makeinstall, although I don't know if it's
required. I've been using it in all my spec files based on somebody's
request.
Sometimes it does not work, but in this it seems to be fine.
* Don't install the generic INSTALL file.
Fixed.
* Remember to put version info for each changelog entry
rpmlint ../RPMS/i386/qsynth-0.2.5-2.i386.rpm
W: qsynth no-version-in-last-changelog
Yes, I see, that was an internal release, it did not make sense to bump the
release so I did not put anything there. I can repeat the same number, I guess.
I have read that you have to always bump the release no matter what but in some
cases I think it is ridiculous (IMHO).
* I believe you should use the following before %configure...
unset QTDIR || : ; . /etc/profile.d/qt.sh
export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
This I don't see the reason for. Just making sure that you pick the right QT? If
qt is properly installed qt.sh should run in the build system and set up all the
QT* variables. At least it does that for me (using mach).
That's it for now. Thanks!
Tnks for taking the time to take a look.
(In reply to comment #2)
One more thing.. I tried this with VintageDreams soundfont, and found that I
had
to turn the gain down to 10 or less in order to stop the output from
red-lining.
The gain setting defaults to 100. Is this expected?
Hmmm, this I don't know. Which version of fluidsynth? I guess it depends on how
the soundfont was built, 10 seems a bit low. Where can I find the VintageDreams
soundfont to try it out?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||189886 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
