[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607 --- Additional Comments From [EMAIL PROTECTED] 2006-06-01 16:34 EST --- Just got a build failure: /bin/sh ../libtool --silent --mode=link --tag=CXX g++ -Wnon-virtual-dtor -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -O2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common -LNONE -lX11 -lXext -ldl -o xosdplugin.la -rpath /usr/lib64/lineakd/plugins -module -avoid-version xosdplugin.lo xosdctrl.lo -lX11 -llineak -L/usr/lib64 -lxosd -lpthread -lXext -lX11 -lXinerama -lxosd -llineak ../libtool: line 1573: cd: NONE: No such file or directory libtool: link: cannot determine absolute directory name of `NONE' make[2]: *** [xosdplugin.la] Error 1 I'm not really sure what's up here; I'll try to take a closer look later. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-01 19:58 EST --- The issue was simply a missing BuildRequires: libXt-devel; I'll add it and proceed with the review. Note that the ChangeLog file has zero length and should not be packaged: E: lineak-xosdplugin zero-length /usr/share/doc/lineak-xosdplugin-0.8.4/ChangeLog These are pretty quick fixes, so I'll go ahead and approve and you can fix them when you check in. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 36f519b21e7c7257bd9af6543f7fd9fc lineak_xosdplugin-0.8.4.tar.gz 36f519b21e7c7257bd9af6543f7fd9fc lineak_xosdplugin-0.8.4.tar.gz-srpm * latest version is being packaged. O BuildRequires are proper (after adding libXt-devel as above). O package builds in mock (development, x86_64) (after fixing BRs.) X rpmlint complains about ChangeLog. * final provides and requires are sane: lineak_xosdplugin = 0.8.4 xosdplugin.so()(64bit) lineak-xosdplugin = 0.8.4-4.fc6 - libX11.so.6()(64bit) libXext.so.6()(64bit) libXinerama.so.1()(64bit) libdl.so.2()(64bit) liblineak.so.0()(64bit) libxosd.so.2()(64bit) lineakd = 0.8.4 xosd = 2.1 * one shared library is present, but it is internal to lineakd and so there's no need to call ldconfig. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, but please don't package the zero length ChangeLog and don't forget to add the BR: libXt-devel so the package will build. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607 --- Additional Comments From [EMAIL PROTECTED] 2006-05-22 22:06 EST --- More changes, ala request: http://rpm.forevermore.net/lineak/lineak-xosdplugin.spec http://rpm.forevermore.net/lineak/lineak-xosdplugin-0.8.4-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607 --- Additional Comments From [EMAIL PROTECTED] 2006-05-21 04:40 EST --- Shuffling files around on my server, and making a few changes to bring things up to par. http://rpm.forevermore.net/lineak/lineak_xosdplugin.spec http://rpm.forevermore.net/lineak/lineak_xosdplugin-0.8.4-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607 --- Additional Comments From [EMAIL PROTECTED] 2006-05-20 03:09 EST --- SRPM URL: http://forevermore.net/files/packages/lineak/lineak_xosdplugin-0.8.4-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||191604 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
