[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 15:32 EST --- (In reply to comment #8) > Are we allowed to approve php packages now? I thought we were still waiting > for > finished guidelines and an update of the core PHP package. Not that I know of, besides there are alreayd plenty of php packages in extras. I've read nothing of what you're suggesting. Do you have some pointers for this? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 11:42 EST --- Jason, didn't I get something or am I lacking any information? I applied last must fix before comment #5, FE-ACCEPT was added with comment #6. After getting sponsored, I just followed the rest of http://fedoraproject.org/wiki/Packaging/ ReviewGuidelines#head-f3a5010530b260ae2b3d8c835cc6d25e9ac91ceb Are there any blockers, show stoppers or further guidelines I'm not aware of? And as I'm new to that kind of the FE stuff, I'm very confused now... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 11:26 EST --- Are we allowed to approve php packages now? I thought we were still waiting for finished guidelines and an update of the core PHP package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-06-18 11:01 EST --- 11171 (php-idn): Build on target fedora-5-extras succeeded. 11172 (php-idn): Build on target fedora-development-extras succeeded. as per http://fedoraproject.org/wiki/Extras/Contributors I'll close this bug report with NEXTRELEASE now. If I did something wrong or when I missed something, just tell me. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-idn
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479
[EMAIL PROTECTED] changed:
What|Removed |Added
OtherBugsDependingO|163778, 177841 |163779
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-06-17 08:39 EST ---
(In reply to comment #5)
> One line from your comment was trunicated, but I found the complete hack in
> php-
> eaccelerator: %((echo %{default_apiver}; php -i 2>/dev/null | sed -n 's/^PHP
> API
> => //p') | tail -1) - it is applied very similar as suggested.
Aai, sorry about that cut and paste error. Glad you found the full hack
yourself.
That fixes the only MUST fix item -> Approved.
And I must say I'm happy with the shown packageing skills sofat and thus I am
willing to sponsor you, go create an account in the account system as described
here:
http://fedoraproject.org/wiki/Extras/Contributors
And then I'll sponsor you after which you can continue with step described at
the above URL. You need to find another reviewer for you other 2 packages
though, I'm no good in perl and ircbots aren't my thing either :)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-idn
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479
--- Additional Comments From [EMAIL PROTECTED] 2006-06-17 08:02 EST ---
One line from your comment was trunicated, but I found the complete hack in php-
eaccelerator: %((echo %{default_apiver}; php -i 2>/dev/null | sed -n 's/^PHP
API
=> //p') | tail -1) - it is applied very similar as suggested.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 --- Additional Comments From [EMAIL PROTECTED] 2006-06-17 02:02 EST --- MUST: = * rpmlint output is clean * Package and spec file named appropriately * Packaged according to packaging guidelines * License (GPL) ok, license file included * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on FC5-i386 * BR: ok * No locales * No shared libraries (its a plugin) * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * no gui -> no .desktop file required MUST fix: = The use of php-config before the php-devel BR is resolved, see above. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-idn
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479
--- Additional Comments From [EMAIL PROTECTED] 2006-06-17 01:50 EST ---
Ok,
I've found the following "hack" for this, add at the top of your specfile:
# Useful defaults when building in chroots on systems where PHP is unavailable
# during the get BR step of the build
%define default_apiver 20041225
%define php_apiver %((echo %{default_apiver}; php -i 2>/dev/null | sed -n 's/^P
And then change the Requires line to:
Requires: php-api = %{php_apiver}
The same should be done for php-magickwand btw.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-06-17 01:46 EST --- On my current testing system I get this: [EMAIL PROTECTED] ~]$ rpmbuild -ba /usr/src/redhat/SPECS/php-idn.spec sh: php-config: command not found awk: cmd. line:1: fatal: cannot open file `/main/php.h' for reading (No such file or directory) error: line 12: Version required: Requires: php-api = This is because php-devel isn't installed yet, its BuildRequired, but rpmbuild first fully parses the spec before checking BR, so this fails. Some discussion on the mailinglist about a similar problem with python on FC-4 has lead me to believe that the same will happen on the buildsys when building under mock. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 --- Additional Comments From [EMAIL PROTECTED] 2006-06-14 07:51 EST --- When I updated bug #194470 to announce the fixed php-magickwand package, I also updated php-idn to match with all common things - unfortunately this was during the unrecoverable time of Bugzilla... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 194479] Review Request: php-idn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-idn https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194479 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
