[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 [EMAIL PROTECTED] changed: What|Removed |Added Resolution|WONTFIX |DUPLICATE OtherBugsDependingO|215241 | nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-11-26 17:49 EST --- Done. Removed blocker on thunar-archive-plugin. *** This bug has been marked as a duplicate of 217311 *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 --- Additional Comments From [EMAIL PROTECTED] 2006-11-13 06:26 EST --- (In reply to comment #8) http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/xarchiver.spec > http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/xarchiver-0.4.2-0.1.rc2.fc7.src.rpm > > Maybe it's easier to drop the sub-package, but then we'll have to include > fedora-xarchiver.tap in thunar-archive-plugin. Simply leaving it in the > xarchiver main package (without a dependency on the archive plugin) would lead > to an unowned /usr/libexec/thunar-archive-plugin/ if thunar(-archive-plugin) > is > not installed. If the archive plugin is installed, this dir would be owned by > two packages. Bad Idea. I don't think it is a bad idea in that case. Indeed, thunar-archive-plugin has a plugin-script system. This allows for some flexibility we should take advantage of. In my opinion it should be possible to have a random package (preferrably a graphical unarchiver package ;-) drop a script in /usr/libexec/thunar-archive-plugin/ even if thunar-archive-plugin isn't installed. To still have right directory owning, there are 2 possibilities: * have all plugin packages own /usr/libexec/thunar-archive-plugin/ * add a filesystem-like package which holds that directory and that packages depend on. Both options may make sense depending on the case, here I think having multiple owners is the cleanest way. > Opinions? Drop the sub-package and move the file over to > thunar-archive-plugin? No, drop the sub-package and own /usr/libexec/thunar-archive-plugin/. In any case I don't think that having a package only for the thunar-archive-plugin plugin script makes sense. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-11-12 22:46 EST --- (In reply to comment #9) > Christoph: Can you wait a week and if no response submit your package in a new > review request (after closing this one)? Sure, will do. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 --- Additional Comments From [EMAIL PROTECTED] 2006-11-12 21:46 EST --- I'd like to see this package in as well... According to http://fedoraproject.org/wiki/Extras/Policy/StalledReviews we should add a comment that this review is considered stalled, and will be closed in 1 week if there is no response. Consider this that comment. ;) Christoph: Can you wait a week and if no response submit your package in a new review request (after closing this one)? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] OtherBugsDependingO||215241 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-11-12 15:24 EST --- I'd like to take over this package, since there has benn no feedback from Damien for more then 4 months now and I really would like to see this package in Extras soon. Could someone please review these files? http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/xarchiver.spec http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/xarchiver-0.4.2-0.1.rc2.fc7.src.rpm I have packaged xarchiver for a while now (I had not seen this review), but my package looks quite different. I have split the package into xarchiver and xarchiver-thunar-archive-plugin. The latter contains only one file /usr/libexec/fedora-xarchiver.tap, a wrapper script for thunar-archive-plugin (see bug #215241). I don't want xarchiver depend on Thunar. Maybe it's easier to drop the sub-package, but then we'll have to include fedora-xarchiver.tap in thunar-archive-plugin. Simply leaving it in the xarchiver main package (without a dependency on the archive plugin) would lead to an unowned /usr/libexec/thunar-archive-plugin/ if thunar(-archive-plugin) is not installed. If the archive plugin is installed, this dir would be owned by two packages. Bad Idea. Opinions? Drop the sub-package and move the file over to thunar-archive-plugin? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 --- Additional Comments From [EMAIL PROTECTED] 2006-10-27 02:31 EST --- Well, again is this review process proceeding? More than 3 weeks has passed since the last comment was added. I don't use Xfce by default, however my opinion is that we should not wait for Xfce 4.4 final release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 --- Additional Comments From [EMAIL PROTECTED] 2006-10-02 21:34 EST --- We are working at getting Xfce 4.4rc1 in very soon... perhaps the version at: http://www.xfce.org/archive/xfce-4.3.99.1/src/xarchiver-0.4.0.tar.bz2 would be the upstream release being waited on? Or the perhaps the 4.4 final version? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 --- Additional Comments From [EMAIL PROTECTED] 2006-10-02 20:46 EST --- Hi, Damien told me (on IRC) that he's waiting for a new upstream release (I don't really remember the reason why). If Damien still wants to maintain this package, I'll do a review once the issues in comment #1 are addressed (It seems to me those are the only issues keeping this package from being approved). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 --- Additional Comments From [EMAIL PROTECTED] 2006-10-02 07:22 EST --- Sorry, I meant "is this review proceeding?" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO CC||[EMAIL PROTECTED] Flag||needinfo?([EMAIL PROTECTED] ||m) --- Additional Comments From [EMAIL PROTECTED] 2006-10-02 07:19 EST --- Well, what is this review proceeding? Changing the STATUS: ASSIGNED -> NEEDINFO from reporter. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 --- Additional Comments From [EMAIL PROTECTED] 2006-07-24 21:49 EST --- Damien: I'll make a formal review of your package soon, but please try to correct the issues I mentioned above. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xarchiver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 198098] Review Request: xarchiver
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xarchiver
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198098
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-07-09 18:23 EST ---
Hi Damien,
Some comments on your package:
- I think the description grammar could be improved. It says "Xarchiver is a
GTK2 archiver, create, add...", and also refers to "the above formats" (above
what? which formats?).
- You shouldn't own %{_datadir}/pixmaps as it is already owned by filesystem.
- You must own %{_datadir}/%{name}.
- rpmlint complains about the following:
W: xarchiver mixed-use-of-spaces-and-tabs (check the Version tag)
E: xarchiver zero-length /usr/share/doc/xarchiver-0.3.3/NEWS
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
