[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/show_bug.cgi?id=199183 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 --- Additional Comments From [EMAIL PROTECTED] 2006-10-30 07:06 EST --- Andreas, if you're OK with it, I can take it over. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 --- Additional Comments From [EMAIL PROTECTED] 2006-10-29 01:01 EST --- Ping? This has been approved for three weeks now; any reason it hasn't been checked in yet? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-10-05 23:04 EST --- This seems to have dropped through the cracks. I grabbed the package from http://home.bawue.de/~ixs/e2tools/e2tools-0.0.16-5.src.rpm and it builds fine on x86_64. * source files match upstream: 1829b2b261e0e0d07566066769b5b28b e2tools-0.0.16.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: e2tools = 0.0.16-5.fc6 = libcom_err.so.2()(64bit) libext2fs.so.2()(64bit) * %check is present and all tests pass (as far as I can tell) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 07:13 EST --- Okay, new upload at http://home.bawue.de/~ixs/e2tools/e2tools.spec fixing the x86_64 build issue and incorporating Uli's fixes. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 --- Additional Comments From [EMAIL PROTECTED] 2006-07-21 11:29 EST --- Andreas, all, this should fix the compile problem mentioned: http://n-dimensional.de/software/e2tools/e2tools-fedora-fixes.patch http://n-dimensional.de/software/e2tools/e2tools.spec http://n-dimensional.de/software/e2tools/e2tools-0.0.16-5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-21 10:11 EST --- The expression in question is (void *) (verbose) ? &verbose : NULL That should almost certainly read (void *) ( (verbose) ? &verbose : NULL ) instead. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 --- Additional Comments From [EMAIL PROTECTED] 2006-07-21 09:41 EST --- It's obviously a problem in that it fails the build due to -Wall. Whether it woulc actually cause any problems in the running program, I can't say since it didn't build. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-21 02:29 EST --- (In reply to comment #4) > Seems to have some 64-bit problems: > > cc1: warnings being treated as errors > rm.c: In function 'e2rm': > rm.c:248: warning: cast to pointer from integer of different size Is this a problem? It should be, e.g., a 32-bit integer -> 64-bit pointer? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-20 21:06 EST --- Seems to have some 64-bit problems: cc1: warnings being treated as errors rm.c: In function 'e2rm': rm.c:248: warning: cast to pointer from integer of different size -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 --- Additional Comments From [EMAIL PROTECTED] 2006-07-19 12:05 EST --- (In reply to comment #1) > I think you don't need CPPFLAGS="-Wall -Werror" in %build section, because > the build server has his own CPPFLAGS (I think so) and could you explain > what %%check section exaclty does? I wanted them explicitly. %check does a function test of the built binaries, making sure they do work. It's just another build-stage. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3
filesystems
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183
--- Additional Comments From [EMAIL PROTECTED] 2006-07-19 02:18 EST ---
== Not an official review as I'm not yet sponsored ==
Mock build for rawhide i386 is successfull.
* MUST Items:
- rpmlint shows no errors
- dist tag is present.
- The package is named according to the Package Naming Guidelines.
- The spec file name matching the base package e2tools, in the
format e2tools.spec.
- This package meets the Packaging Guidelines.
- The spec file for the package MUST be legible.
- The package is licensed with an open-source compatible license GPL.
- This package includes License file COPYING.
- This source package includes the text of the license in its own file,and
that file, containing the text of the license for the package is included in
%doc.
- The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (1829b2b261e0e0d07566066769b5b28b
e2tools-0.0.16.tar.gz)
- This package successfully compiled and built into binary rpms for i386
architecture.
- This package did not containd any ExcludeArch.
- This package owns all directories that it creates.
- This package did not contain any duplicate files in the %files
listing.
- This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- This package used macros.
- Document files are included like README COPYING ChangeLog TODO AUTHORS.
- Package did NOT contained any .la libtool archives.
Also,
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* I did not test package.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 199183] Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: e2tools - Manipulate files in unmounted ext2/ext3 filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199183 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-07-18 06:13 EST --- Hi! I'm not yet sponsored so this is not official review. * MUST items: - rpmlint doesn't show anything - package is named according to Packaging Naming Guidelines - the spec file name is correct - package meets Packaging Guidelines - package is licensed with an open-source license - GPL, license field match actual license and package contains file with text of license in %doc - spec file is written in American English and is legible - package successfully compile on i386 - package doesn't contain duplicate files in %files section - %files section includes %defattr(...) line - spec file contains proper %clean section - macros is used proper in spec file and all others 'must' doesn't concern this package. I think you don't need CPPFLAGS="-Wall -Werror" in %build section, because the build server has his own CPPFLAGS (I think so) and could you explain what %%check section exaclty does? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
