[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-08-02 09:11 EST --- Thanks! I've added the Requires: pkgconfig and imported soundtouch. After some strugling building it due to ppc issues its now build too, closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-08-01 08:05 EST --- Thanks. Good: mock builds cleanly rpmlint shows nothing of importance software works md5sums are the same upstream version same no dupes no ownership problems On the condition that you add pkgconfig to the R: on the devel package, I'm happy for this to go in. This was discussed at the start of July on IRC (FESCo) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-08-01 07:43 EST --- New version here (I used your attached spec verbatim): Spec URL: http://people.atrpms.net/~hdegoede/soundtouch.spec SRPM URL: http://people.atrpms.net/~hdegoede/soundtouch-1.3.1-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-08-01 06:42 EST --- Thanks. Can you upload a new srpm with the amended spec file so that it can tested again? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: soundtouch - Audio Processing library for changing
Tempo, Pitch and Playback
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664
--- Additional Comments From [EMAIL PROTECTED] 2006-08-01 00:57 EST ---
(In reply to comment #7)
> Needs work/Niggle
> rm -rf $RPM_BUILD_ROOT%{_prefix}/doc/%{name} - why is this going to /usr/doc
> instead of %{_docdir}?
>
This is what upstreams Makefile does, thats why its removed and then later added
under files with %doc.
> Question
> sed -i 's|\r||' README.html COPYING.TXT - is this to remove the incorrect
> termination of the files? I tend to use 's/\r//'
>
Same thing you can use any special char after the s in sed not only / but also |
or ! or :, etc. This is handy when your search or replace string contains / for
example when search replacing file / dir paths using / after the s is a bad
idea.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: soundtouch - Audio Processing library for changing
Tempo, Pitch and Playback
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664
--- Additional Comments From [EMAIL PROTECTED] 2006-07-31 17:29 EST ---
Review
Spec file : (based on my modifiction)
Good - consistant use of macros, upstream md5 is the same as the tarball, no
dupes in the BRs. rpmlint reports clean for all packages (does give no docs in
-devel, this can be ignored, not an error). rpm -qa --requires comes up clean
(nothing missing)
Needs work/Niggle
rm -rf $RPM_BUILD_ROOT%{_prefix}/doc/%{name} - why is this going to /usr/doc
instead of %{_docdir}?
Question
sed -i 's|\r||' README.html COPYING.TXT - is this to remove the incorrect
termination of the files? I tend to use 's/\r//'
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 17:14 EST --- Created an attachment (id=133358) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=133358&action=view) Altered spec file Yep. Altering the BR fixed it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 15:47 EST --- HMM, could you try changing that BR: automake I added to BR: libtool and see if it builds then. I don't mock because of my sucky internet access. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 15:44 EST --- Still not building in mock +sed -i 's|^hardcode_libdir_flag_spec.*|hardcode_libdir_flag_spec=""|g' libtool sed: can't read libtool: No such file or directory -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 01:58 EST --- Hmm, nasty it turns out that soundtouch uses symlinks to instead of copies of some needed automake files. I've fixed this by adding a BR: automake New version here: Spec URL: http://people.atrpms.net/~hdegoede/soundtouch.spec SRPM URL: http://people.atrpms.net/~hdegoede/soundtouch-1.3.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-07-30 18:47 EST --- Created an attachment (id=133296) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=133296&action=view) Build log -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 --- Additional Comments From [EMAIL PROTECTED] 2006-07-30 18:42 EST --- Unable to build in mock (x86) - see attachment Builds fine outside of mock and rpmlint is clean (other no documentation warning for the -devel package) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200664] Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: soundtouch - Audio Processing library for changing Tempo, Pitch and Playback https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200664 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
