[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-11-28 20:12 EST --- owners.list entry is missing! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-11-27 08:38 EST --- thx for the review, package is in cvs. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-11-27 02:03 EST --- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files match upstream. f75d830ca623bf10385b3ad62c48437a GraphicsMagick-1.1.7.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + .pc file present. + -devel,-c++, -c++-devel, -perl subpackages exists + as subpackages are packaging .so files post and postun called /sbin/ldconfig + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + perl subpackage followed perl packagaing. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-11-26 13:03 EST --- Package has been updated at the usual location. Please take a look. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-11-23 23:24 EST --- Ping -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-10-01 15:51 EST --- just IMHO, bumping release and adding changelogs is very usefull during reviews to me. It allows me to see that something was addressed and when. Some submitters have used -0.X during reviews and then bump release to -1 on import. I think thats fine if you are more comfortable with that... Any chance you could push our a new release with new release/changelog entries? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 10:21 EST --- I don't know who you're referring to as "we", but IMO, the same rules that apply toward Fedora (Core/Extras) releases should be applied during reviews too. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 10:16 EST --- Argl. I thought we went over that topic often enough? Wasn't the consensus that bumping release numbers and changelogs during review is purely optional? It really doesn't serve as far as I can see, as the bugzilla entry contains more information then the changelog ever will. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 10:11 EST --- FYI, whenever you make a change to the package, you ought to increment the Release tag and add a changelog entry accordingly. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GraphicsMagick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722 --- Additional Comments From [EMAIL PROTECTED] 2006-07-31 10:07 EST --- thx, changes are incorporated at the original location -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 200722] Review Request: GraphicsMagick
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: GraphicsMagick
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200722
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2006-07-31 07:45 EST ---
Offhand,
1. it appears
%{_includedir}/GraphicsMagick
dir is unowned.
2. in c++-devel subpkg:
Requires: %{name}-c++ = %{version}
Requires: %{name}-devel = %{version}
should be:
Requires: %{name}-c++ = %{version}-%{release}
Requires: %{name}-devel = %{version}-%{release}
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
