[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2008-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|devel   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2007-09-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-09-12 02:09 EST ---
Package Change Request
==
Package Name: gcin
New Branches: EL-4 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2007-09-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2007-09-12 13:49 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 02:12 EST ---
Package is APPROVED.

When you are ready please follow the instructions carefully
to import into extras cvs.

Thanks for contributing gcin to Fedora Extras.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 10:00 EST ---
Created an attachment (id=134711)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134711action=view)
Build log of gcin-1.2.2-8 on fc6-devel with fedora undefined

Hello.

So I cannot sponsor formally for this package (because
I am not a member), who will be the sponsor for this package?
I think that this package leaves little problem, so
it would be better that this package can be released ASAP.

The reason I mentioned little is because 
* I can rebuild this package with mock.
* however, I canNOT rebuild this package without mock even
  with proper BR rpms installed
because usually %{fedora} is undefined and so Patch5 is applied
when rebuilt withOUT mock, this is not right for FC5 and above.

Now, FC4 and below FC4 are marked as regacy, so this package
can be released only for FE5 and FE6-devel. So, Patch5 is
not needed, perhaps?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 10:26 EST ---
(In reply to comment #41)
 Created an attachment (id=134711)
 -- 
(https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134711action=view) 
[edit]
 Build log of gcin-1.2.2-8 on fc6-devel with fedora undefined
 
 Hello.
 
 So I cannot sponsor formally for this package (because
 I am not a member), who will be the sponsor for this package?

It is the submitter that is sponsored, not the package.

 I think that this package leaves little problem, so
 it would be better that this package can be released ASAP.
 
 The reason I mentioned little is because 
 * I can rebuild this package with mock.
 * however, I canNOT rebuild this package without mock even
   with proper BR rpms installed
 because usually %{fedora} is undefined and so Patch5 is applied
 when rebuilt withOUT mock, this is not right for FC5 and above.
 
 Now, FC4 and below FC4 are marked as regacy, so this package
 can be released only for FE5 and FE6-devel. So, Patch5 is
 not needed, perhaps?

You can define the macro manyually if you wish:

$ rpmbuild -ba --define 'fedora 5' --define 'dist .fc5' packagename.spec

I think it would be better though if the default (i.e. with the fedora macro
undefined) was appropriate for the current release (FC5/FC6) and the extra
defines were only needed for the legacy distros,

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 10:42 EST ---
(In reply to comment #42)

 It is the submitter that is sponsored, not the package.
Oh, yes. What I meant was who will sponsor Chung-Yen Chang?

 I think it would be better though if the default (i.e. with the fedora macro
 undefined) was appropriate for the current release (FC5/FC6) and the extra
 defines were only needed for the legacy distros,

I have the same opinion. It would be better that the spec file
assumes that the distro is FC-5 or above if %fedora is not defined.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 20:57 EST ---
Tasaka thanks for you review and test.
This is mistake for patch5, but now I think patch5 is not necessary, so I 
remove it.
Both Howarth's and Tasaka's suggestion are very good.
So I think set fc5/fc6 to default in spec is more appropriate, I will keep in 
mind.

The new files:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-10.src.rpm

I use mock build for fc6/fc5 are cleanly.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 22:07 EST ---
Created an attachment (id=134765)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134765action=view)
gcin.spec-10.patch

If the package is only for fc5 and later, then I think it is better to
just simplify it like this.  (There is no problem to use gcin.conf on
fc4 and earlier afaics.)

As I tried to say in comment 40, I will sponsor Chung-Yen Chang.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 22:23 EST ---
Hi, Petersen,
I try to merge it to spec file (for fc3 fc4 fc5 fc6 and rhel4).
But, after all, I think it is better to simplify it like your patch.
So maybe it is better form me to seperate the spec file for fc5 and later and 
fc4 and earlier and 
rhel4.

And another question, I know use gcon.conf on fc4 and earlier is no problem, 
but I think it is better for 
use gcin then gcin.conf on fc4 and earlier.
(It look a little stranger if use gcin.conf)

[candyz:~] im-switch -z zh_TW -l
xinput-zh_TW - status is manual.
 link currently points to gcin
scim - priority 81
oxim - priority 30
gcin.conf - priority 40
Current `best' version is scim.
===
The following languages currently have input methods configured:
as_IN bn_IN en_US gu_IN hi_IN ja_JP kn_IN ko_KR ml_IN ne_NE or_IN pa_IN si_LK 
ta_IN te_IN th_TH vi_VN 
zh_CN zh_HK zh_SG zh_TW


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Attachment #134765|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 23:05 EST ---
Created an attachment (id=134766)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134766action=view)
gcin.spec-10.1.patch

Okay, you're right - I was being too hasty.  Here is a better patch,
which should handle %fedora correctly.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Attachment #134765|1   |0
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 23:16 EST ---
I merge the gcin.spec-10.1.patch
New files:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-11.src.rpm

Petersen, thanks a lot.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 23:19 EST ---
But sorry, the last patch still doesn't help when %fedora is not defined.
So yes, it is probably easiest just to branch the spec file for fc5 as I 
originally
thought too.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 23:48 EST ---
Now I branch the spec file.

New files:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-12.src.rpm

Spec for fc4 and earlier URL: http://cle.linux.org.tw/candyz/gcin.spec-branch

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 00:08 EST ---
srpm looks good to me and gcin.spec-branch.

(I think you forgot to update gcin.spec.:)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 00:13 EST ---
Sorry, I forgot to update gcin.spec.
Now the gcin.spec updated. :P

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-24 01:06 EST ---
Well, srpm and spec seems well for me. too.
(I only tested for  http://cle.linux.org.tw/candyz/gcin.spec ).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-22 08:44 EST ---
Thanks, Chung-Yen Chang, for doing a pre-review of devilspie (bug 203288).
I think I am able to sponsor you to become an Fedora Extras contributor.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Review Request: gcin -  |Review Request: gcin -
   |Chinese input method server |Chinese input method for
   |for Traditional Chinese |Traditional Chinese
 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 03:56 EST ---
Thanks for all your work on this.  I just tested it on my x86_64
and it seems to work ok (though I'm not very familiar with TC).

A couple of comments:

Is the -devel subpackage really necessary?  Are there any extensions to gcin
that would use the include file it contains?

Probably it would be clearer to rename the xinput file from gcin to
xinput-gcin say.

I will attach a patch for the spec file to improve it further.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 04:03 EST ---
Created an attachment (id=134501)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134501action=view)
gcin.spec-3.patch

More necessary improvements.

- don't use configure macro
- add .conf suffix to xinput.d file and update install scripts for fc6
- move lib to libdir and drop ld.so.conf.d file
- other minor cleanup

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 04:35 EST ---
[I forgot to thanks all the earlier reviewers for their work on this too.:)]

Also you buildrequire desktop-file-utils but don't use it I think.
You probably should to install the .desktop file with it or else remove it 
entirely.
See http://fedoraproject.org/wiki/Packaging/Guidelines#desktop.

Once all these things are fixed I think the package can be accepted.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 04:40 EST ---
Note the changes I made in %post/%preun are only for fc6.
Since like you had is needed for fc5 and earlier btw.
It is hope to you how you want to handle that: either using
%{fedora} and different .spec files on branches say.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 05:19 EST ---
Petersen, thanks for your spec patch
These days I have read all http://fedoraproject.org/wiki/Packaging/* documents.
I merge your spec patch and create a new version, and mock build cleanly for 
fc6 and fc5.

The New files:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 06:46 EST ---
Thanks.

What do you think about removing the -devel package?

You still need to install the desktop file in %install:
check some other spec files for examples, and then you can 
restore the desktop-file-utils buildrequires.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 06:47 EST ---
Created an attachment (id=134505)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134505action=view)
gcin-5.patch

a few more fixes

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 07:10 EST ---
I had email to the upstream author and ask him about the header file is 
necessary?
I am waiting for his reply.
If the header file is not necessay, then the -devel package can be removed.
About desktop file:
make install already install %{_datadir}/applications/gcin-setup.desktop
What should I do?
Remove gcin-setup.desktop and then use desktop-file-install in %install?
Another question, should I use gcin.desktop rather than gcin-setup.desktop?
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 09:20 EST ---
I fixed with the gcin-5.patch and use desktop-file-install in %install (ref. 
from scim's spec file) 

The New files:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 13:12 EST ---
Jens, while it's great that you're reviewing this (as I don't really have the
expertise to review it properly) the fact remains that because this is a
FE-NEEDSPONSOR ticket, and according to the current rules for contributorship
the review must be done by a sponsor.  This does sort of put us in a bit of a
quandary, however, as there might not be an available sponsor.  Might you be
willing to co-maintain this package?  (Assuming of course that Chang would 
agree.)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 22:44 EST ---
I agree.
Jens will you like to co-maintain this package?
And Tibbitts can you sponsor this package?

Another information about -devel subpackage, it seems the gcin-im-client.h only 
need for rxvt/mrxvt.
If the rxvt/mrxvt was patched with gcin IM client support, then it is need 
gcin-im-client.h to build rxvt/
mrxvt.
http://www.csie.nctu.edu.tw/~cp76/linux/mrxvt-gcin-0.4.1.tar.bz2 is a mrxvt 
with gcin IM client 
patched
http://www.csie.nctu.edu.tw/~cp76/linux/rxvt-gcin.tbz is a rxvt with gcin IM 
client patched
But both mrxvt-gcin-0.4.1.tar.bz2 and rxvt-gcin.tbz are a little bit 
out-of-date, so I think the -devel 
subpackage is not necessary now.
So now I remove the -devel subpackage.
The New files with no -devel subpackage:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-7.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 23:18 EST ---
Created an attachment (id=134521)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=134521action=view)
gcin-7.patch

Fix changelog. ;)

Otherwise looks good to me.  IMHO the package could now be approved,
but unfortunately as Jason pointed out I don't have Sponsor status either...

I don't really feel qualified or motivated to maintain this package
in the long term, but if there is a strong demand to have it in Extras
asap then I suppose I could take it for now.  Though I'd really rather
we try to find a sponsor for Chung-Yen Chang.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 23:30 EST ---
Fix changelog:
Spec URL: http://cle.linux.org.tw/candyz/gcin.spec
SRPM URL: http://cle.linux.org.tw/candyz/gcin-1.2.2-8.src.rpm

Now I still need to find a sponsor for this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 00:51 EST ---
Chung-Yen Chang, have you done any pre-reviews of any other packages?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 201337] Review Request: gcin - Chinese input method for Traditional Chinese

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gcin - Chinese input method for Traditional Chinese


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201337





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 01:02 EST ---
Jens, no, I am new to FE bugzilla.
But I will try to do some pre-reviews of other packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review