[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 14:31 EST ---
Builds fine in mock.

It's 19:37 in the UK which can mean only one thing, it's time for the official
UK review procedure...

(cue naff 90's music trying to sounds like crumby '06 noises)

At 10...

No ownership problems
rpmlint is clean (well, spaces/tabs in srpm and config file in rpm)
builds clean in mock (i386)
No dupes
No devel, so no pkgconfig, no .so/.la problems
software does as it should
no problems with documentation
consistent use of macros
upstream matches the package (version and md5)
works fine with smp_mflags

And this weeks number 1...

It controls the lego!

(fade really terrible music)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 13:31 EST ---
Spec URL: http://miskatonic.cs.nmsu.edu/pub/nqc.spec

SRPM URL: 
http://miskatonic.cs.nmsu.edu/pub/fedora/5/srpms/nqc-3.1.4-2.src.rpm

Changes:
- Removed groupdel lego
- Added faq, manual and guide docs
- Added flex BuildRequires and groupadd Requires(pre)
- Added -f option to groupadd (success if group exists)

It build fine in mock (x86_64) now. 

Also, I tested the groupadd -f option to ensure that it doesn't have any 
problems with the group if it's already present.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 11:10 EST ---
Please remove the groupdel from the next iteration of the spec file - it's a
recipe for disaster. Does the %pre check to ensure that lego doesn't already
exist first? It looks like it does.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 08:58 EST ---
*** Bug 185205 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265





--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 06:27 EST ---
rpmlint warnings
.src.rpm : mixed used of spaces and tabs
rpm : non-conffile-in-etc /etc/udev/rules.d/60-legousbtower.rules
  dangerous-command-in-%postun groupdel

I'm not worried about the src.rpm warning, but am about the two in the rpm
(especially the dangerous command one).

Fails to build in mock
/bin/sh: flex: command not found

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-20 06:17 EST ---
%{_sbindir}/groupadd

You don't have anything in Requires(pre) for this (or the similar one in postun)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 203265] Review Request: nqc - Programming environment for Lego's RCX (Mindstorms) bricks

2006-08-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nqc - Programming environment for Lego's RCX 
(Mindstorms) bricks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203265





--- Additional Comments From [EMAIL PROTECTED]  2006-08-19 21:09 EST ---
Simon's original submission is here:
 http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185205

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review