[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225698
Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:
What|Removed |Added
Status|CLOSED |ASSIGNED
Resolution|NEXTRELEASE |
--- Comment #9 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-12-19
03:56:58 EDT ---
Thanks for the update Prarit. I know you did it with good intentions but please
don't close a Merge Review until the reviewer sets the + flag.
I see that some issues are resolved but some are not. And since the package had
updates since I made the initial review, there are additional issues
introduced, thus I'm reopening the bug (sorry!)
(For each issue, I am adding the reference to the respective guideline which
you can find at the bottom.)
First the old issues and questions: (from comment #5)
* The release tag is a mess. Can we continue with the usual convention?:
2%{?dist} [1]
* Source0 must be full URL (with %{name} and %{version} macros) [2]
- Buildroot is improper but it will be obsoleted soon so it's not a problem.
* We prefer %defattr(-,root,root,-) [3]
* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment. [4]
Also additional issues:
* Usage of $RPM_BUILD_ROOT and %{buildroot} in the spec file is against the
macro consistency guideline. Please only use one or the other. [5]
! The patches should be explained and links from upstream bugtracker should be
given as comments, if possible. [6]
! BuildRequires: /usr/bin/aclocal /usr/bin/automake /usr/bin/autoconf
can be replaced by simply
BuildRequires: automake autoconf
since file dependencies should be avoided as much as possible. [7]
[1] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Release
[2] http://fedoraproject.org/wiki/Packaging:SourceURL
[3] https://bugzilla.redhat.com/show_bug.cgi?id=481363
[4] http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
[5] http://fedoraproject.org/wiki/Packaging/Guidelines#macros
[6]
http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
[7] http://fedoraproject.org/wiki/Packaging/Guidelines#File_Dependencies
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 --- Comment #7 from Prarit Bhargava pra...@redhat.com 2009-12-18 09:32:19 EDT --- oget, For some reason I'm not listed in the ACL for dmidecode :/. I'll ping jwilson and see what I can figure out ... P. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 Prarit Bhargava pra...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Prarit Bhargava pra...@redhat.com 2009-12-18 10:27:26 EDT --- in 2.1.0-1.40. P. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 --- Comment #6 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-12-09 22:39:55 EDT --- Ping? The fixes are all rather easy. Please give it a hand so we can close the bug. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225698
Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mcla...@redhat.com,
||oget.fed...@gmail.com
AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
Flag||fedora-review?
--- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-06-07
23:14:52 EDT ---
I reviewed this package. It just needs very trivial fixes:
* rpmlint says
dmidecode.src: W: no-version-in-last-changelog
dmidecode.src:11: E: buildprereq-use /usr/bin/aclocal /usr/bin/automake
/usr/bin/autoconf
dmidecode.src:13: W: unversioned-explicit-obsoletes kernel-utils
dmidecode.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5)
dmidecode-debuginfo.x86_64: W: no-version-in-last-changelog
dmidecode.x86_64: W: no-version-in-last-changelog
dmidecode.x86_64: W: obsolete-not-provided kernel-utils
These are all easy to fix. Use for instance
rpmlint -I buildprereq-use
to see what the complaint is about.
* The release tag is a mess. Can we continue with the usual convention?:
2%{?dist}
* Source0 must be full URL (with %{name} and %{version} macros)
- Buildroot is improper but it will be obsoleted soon so it's not a problem.
* We prefer %defattr(-,root,root,-)
* Parallel make must be supported whenever possible. If it is not supported,
this should be noted in the SPEC file as a comment.
I added mclasen to the CC since he made the last known build. Sorry if this was
not desired.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 Prarit Bhargava pra...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 Robert Scheck red...@linuxnetz.de changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED CC||pra...@redhat.com Resolution|NEXTRELEASE | AssignedTo|pra...@redhat.com |nob...@fedoraproject.org --- Comment #4 from Robert Scheck red...@linuxnetz.de 2009-02-09 17:30:54 EDT --- Prarit, please do not close this bug report until a full formal package review has happened and fedora-review+ is set. Both didn't happen, reopening. The bug report must not to be assigned to you, but to a reviewer; resetting as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 --- Comment #3 from Prarit Bhargava pra...@redhat.com 2009-01-27 11:03:20 EDT --- Created an attachment (id=330102) -- (https://bugzilla.redhat.com/attachment.cgi?id=330102) Patch to resolve this issue I'm waiting for write access to fedora cvs. I'm also going to ping Alan to see if he wants to remain as the owner. P. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 Dave Jones da...@redhat.com changed: What|Removed |Added CC|a...@redhat.com,| |da...@redhat.com, | |pra...@redhat.com | AssignedTo|nob...@fedoraproject.org|pra...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225698] Merge Review: dmidecode
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225698 Robert Scheck redhat-bugzi...@linuxnetz.de changed: What|Removed |Added CC||da...@redhat.com, ||pra...@redhat.com --- Comment #1 from Robert Scheck redhat-bugzi...@linuxnetz.de 2009-01-13 17:21:38 EDT --- dmidecode.i386: W: summary-ended-with-dot Tool to analyse BIOS DMI data. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
