[Bug 225887] Merge Review: hicolor-icon-theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225887 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added CC||mcla...@redhat.com --- Comment #4 from Matthias Clasen mcla...@redhat.com 2009-01-23 21:12:41 EDT --- I've updated the URL, removed the redundant exit 0s and included ChangeLog. dist tag seems pointless for a package that gets build only every few years. I normally don't include ChangeLogs, since a) they tend to be large and b) the user-relevant information is supposed to be in NEWS. In this case, there is no NEWS and ChangeLog is tiny, so you got it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225887] Merge Review: hicolor-icon-theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225887 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Flag|fedora-review? |fedora-review+ --- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-23 21:37:49 EDT --- Thanks. I don't have anything against changelogs. Actually, as a technical user, I like them; they are one of the first things I go and check when I update my Fedora. I'm pretty sure there are some people out there who don't mind large changelogs. Well that's my opinion. -- This Merge Review (hicolor-icon-theme) is APPROVED by oget -- Closing the bug now... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225887] Merge Review: hicolor-icon-theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225887 --- Comment #3 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-12-10 14:05:24 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225887] Merge Review: hicolor-icon-theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225887 Orcan 'oget' Ogetbil [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225887] Merge Review: hicolor-icon-theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225887 Orcan 'oget' Ogetbil [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-10-27 00:27:40 EDT --- This package has been around forever. But let's make it match the guidelines. Here are my notes: * The URL in the SPEC file needs fixed. The new URL is http://icon-theme.freedesktop.org/wiki/HicolorTheme * It would be better if the file Changelog is included in the RPM. * Disttag is missing. Is there a particular reason? * The two exit 0 lines seem unnecessary. Well, that's pretty much it :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225887] Merge Review: hicolor-icon-theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: hicolor-icon-theme https://bugzilla.redhat.com/show_bug.cgi?id=225887 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-11-18 01:27 EST --- After some fixes, rpmlint is silent now -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
