[Bug 431047] Review Request: latencytop - System latency monitor

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=431047


Michal Schmidt mschm...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2009-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=431047


Jeremy West jw...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #15 from Jeremy West jw...@redhat.com  2009-01-26 12:02:42 EDT ---
Package Change Request
==
Package Name: latencytop
New Branches: EL-4 EL-5
Owners: michich

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2009-01-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Comment #16 from Michal Schmidt mschm...@redhat.com  2009-01-26 12:49:46 
EDT ---
Jeremy,

please explain what you mean by the request. Are you willing to maintain the
package in the new branches or do you expect me to do it?
I have doubts about the usefulness of latencytop in EL-4 and EL-5 because their
kernel do not have latencytop support.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2008-02-06 20:52 EST ---
Closing this as this package has been successfully built for all requested
branches on build server.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:29 EST ---
(In reply to comment #10)
 re 1) We must have a misunderstanding about what whitespace you meant. I 
 thought
 you referred to the extra line. Maybe you wanted me to drop the second hunk of
 the patch completely?

Yes. I mean following lines from patch to be removed
=
 #
 # The w in -lncursesw is not a typo; it is the wide-character version
@@ -10,8 +10,7 @@ LDF = -Wl,--as-needed `pkg-config --libs
 # libncursesw5-dev package.
 #
 latencytop: latencytop.o display.o latencytop.h translate.o Makefile
-   gcc $(CFLAGS) latencytop.o display.o translate.o $(LDF)-o latencytop
-
+   gcc $(CFLAGS) latencytop.o display.o translate.o $(LDF) -o latencytop

 clean:
rm -f *~ latencytop DEADJOE *.o
=  
 
 
 re 2 and 3) I agree it would be nice if upstream provided a README. I already
 asked for one when I was asking for the COPYING file. We'll see if a new
 upstream version adds them.
  Thanks.

 
 
 I can see Rawhide has kernel-2.6.24-9 currently. This kernel does not have
 LATENCYTOP support yet. The patch was merged upstream after the release of
 2.6.24 in git commit 9745512ce... sched: latencytop support.
 So you'd need to compile the kernel from the current git tree. Make sure you
 have CONFIG_LATENCYTOP enabled. After boot, start the measurement with:
 echo 1  /proc/sys/kernel/latencytop
 Then you can run latencytop and see the output similar to the screenshot at
 http://www.latencytop.org/ .

 Hope to see our kernels will get compiled with CONFIG_LATENCYTOP enabled.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 07:19 EST ---
re 1) We must have a misunderstanding about what whitespace you meant. I thought
you referred to the extra line. Maybe you wanted me to drop the second hunk of
the patch completely?

re 2 and 3) I agree it would be nice if upstream provided a README. I already
asked for one when I was asking for the COPYING file. We'll see if a new
upstream version adds them.


I can see Rawhide has kernel-2.6.24-9 currently. This kernel does not have
LATENCYTOP support yet. The patch was merged upstream after the release of
2.6.24 in git commit 9745512ce... sched: latencytop support.
So you'd need to compile the kernel from the current git tree. Make sure you
have CONFIG_LATENCYTOP enabled. After boot, start the measurement with:
echo 1  /proc/sys/kernel/latencytop
Then you can run latencytop and see the output similar to the screenshot at
http://www.latencytop.org/ .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 14:35 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-02-04 11:29 EST ---
Alright, I removed the second part of the patch. Now it's just a one-liner
changing the CFLAGS.

Updated package:
http://michich.fedorapeople.org/latencytop/latencytop-0.3-3.fc9.src.rpm
http://michich.fedorapeople.org/latencytop/latencytop.spec

Rawhide kernels usually do have many debugging options enabled. I expect
LATENCYTOP will be enabled too.

Thank you for the review.

New Package CVS Request
===
Package Name: latencytop
Short Description: System latency monitor
Owners: michich
Branches: F-8
InitialCC:
Cvsextras Commits: yes


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:41 EST ---
Review:
+ package builds in mock (rawhide).
+ rpmlint on for SRPM and RPM.
latencytop.i386: W: no-documentation
+ source files match upstream.
3ed2878fb7772e2a500ec71aa01abbb2  latencytop-0.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in source code.
- %doc files NOT present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Compiler flags used correctly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

SHHOULD:
  1)Better recreate latencytop-standard-cflags.patch that will remove
unnecessary space caught in last few lines of patch.
  2)Try to ask upstream to include some README where it should be written what
this tool does and what are its limitations like this works on kernel = 2.6.24
  3) Hope to see upstream will include license file in next upstream release.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:29 EST ---
(In reply to comment #5)
 I updated the package:
 http://michich.fedorapeople.org/latencytop/latencytop.spec
 http://michich.fedorapeople.org/latencytop/latencytop-0.3-2.fc9.src.rpm
 
 ad 1) latencytop-standard-cflags.patch now removes the extra whitespace.
  Can't see this fixed in new SRPM.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-03 23:44 EST ---
Can you tell me how can I test this on rawhide?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-01 08:13 EST ---
I updated the package:
http://michich.fedorapeople.org/latencytop/latencytop.spec
http://michich.fedorapeople.org/latencytop/latencytop-0.3-2.fc9.src.rpm

ad 1) latencytop-standard-cflags.patch now removes the extra whitespace.
ad 2) Arjan van de Ven agreed to provide the COPYING file in the future.

I noticed another problem with the program. Targeted SELinux policy denies write
access to /proc/*/{sched,latency} even to unconfined_t processes. I'll file a
bug in the policy and see what Dan Walsh thinks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-02-01 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-02-01 11:13 EST ---
I filed bug 431221 for the SELinux policy issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-01-31 08:31 EST ---
The package builds successfully in mock on my x86_64 system.

$ rpmlint /var/lib/mock/fedora-development-x86_64/result/
latencytop.x86_64: W: no-documentation

This is expected. Upstream tarball contains no documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-01-31 10:02 EST ---
CONFIG_LATENCYTOP is a very new feature merged into Linux after 2.6.24 was
released. Currently one has to run a self-built kernel from Linus's git tree to
use it.

I'll fix issue #1 and contact upstream about #2.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-01-31 09:43 EST ---
The issue I see with this package on F8 machine when tried to run latencytop =
Please enable the CONFIG_LATENCYTOP configuration in your kernel.
Exiting...

Is CONFIG_LATENCYTOP is enabled in newer builds of kernel. If not then how can
one test functionality of this package?

About Packaging issues =
1)Better recreate latencytop-standard-cflags.patch that will remove unnecessary
space caught in last few lines of patch.
  
2) Try to ask upstream to include some README and COPYING file. If this will
take some time then ask them to include it in next release. 
Note :- This is not a blocker for review


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 431047] Review Request: latencytop - System latency monitor

2008-01-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: latencytop - System latency monitor


https://bugzilla.redhat.com/show_bug.cgi?id=431047





--- Additional Comments From [EMAIL PROTECTED]  2008-01-31 22:11 EST ---
waiting for your updated SRPM

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review