[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 seth vidal svi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #14 from Kevin Fenzi ke...@tummy.com 2009-01-13 16:24:34 EDT --- Can you add a cvs template here? http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #15 from seth vidal svi...@redhat.com 2009-01-13 16:50:56 EDT --- New Package CVS Request === Package Name: system-autodeath Short Description: Automatically disable system default route on a specific date Owners: skvidal Branches: F10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #16 from Kevin Fenzi ke...@tummy.com 2009-01-13 16:55:08 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #9 from Tim Lauridsen tim.laurid...@googlemail.com 2009-01-07 03:45:44 EDT --- I must be blind :), cant see any changes at http://skvidal.fedorapeople.org/system-autodeath/system-autodeath.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469189
--- Comment #10 from seth vidal svi...@redhat.com 2009-01-07 07:23:24 EDT ---
You can't see the %{?dist} and %config?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469189
--- Comment #11 from Tim Lauridsen tim.laurid...@googlemail.com 2009-01-07
08:59:19 EDT ---
No.
snip
Name: system-autodeath
Version: 0.2
Release: 1
/snip
snip
%files
%defattr(-, root, root)
%doc README COPYING
%{_sysconfdir}/cron.daily/system-autodeath.sh
%{_sysconfdir}/sysconfig/system-autodeath.conf
%{_mandir}/man8/system-autodeath.*
%changelog
/snip
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #12 from seth vidal svi...@redhat.com 2009-01-07 09:06:48 EDT --- okay, I think something is very wrong here. I can definitely see it. Can you download the file using wget and tell me if you see it there? Maybe some sort of weird browser caching? Either that or you're behind a very laggy transparent proxy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 Tim Lauridsen tim.laurid...@googlemail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #13 from Tim Lauridsen tim.laurid...@googlemail.com 2009-01-07 09:11:42 EDT --- Look good now :) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469189
--- Comment #7 from Tim Lauridsen tim.laurid...@googlemail.com 2009-01-06
05:08:13 EDT ---
Hi Seth, any comments for this ones.
Problems.
%{?dist} is missing from release tag.
/etc/sysconfig/system-autodeath.conf should be a config file in the %files
section
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #8 from seth vidal svi...@redhat.com 2009-01-06 09:31:25 EDT --- OKay fixed both and updated the spec file in the original location. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 Matthew Miller [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #5 from Matthew Miller [EMAIL PROTECTED] 2008-11-03 11:26:37 EDT --- Tim's package review comments look correct to me. I have a few concerns which basically amount to documentation and features. Documentation: The descriptive paragraph duplicated in the spec file, README, and man page has a typo: notifying that the system with autodie on a specific date should be will autodie. (Although I'd actually like to see the word autodie replaced with remove itself from the network -- no need to go out of our way to scare people.) Also, everyday should be every day. There should also be a descriptive comment (maybe the same paragraph yet again?) in system-autodeath.conf explaining what's okay there. And, it'd be nice if there were some off values like disabled that could be used. I'm also a little concerned about the default date 2009-12-01 in the current config file. I think it should either be more conservative by default or based on the Fedora release the package is built for. At the current rate, Fedora 10 is likely to be maintained for a month or two beyond Dec 2009. So, something like: Fedora 8: 2009-02-25; Fedora 9: 2009-08-25; Fedora 10: 2010-02-25; etc. This would require a little vigilance from the package maintainer as schedules change, but would make the package useful out of the box. Alternately, one crazy idea would be to make the default be based on the file date of /etc/fedora-release (at package build time) + 18 months. I know you'll hate that but throwing it out there. :) Failing that, the default should be something like package build time + 4 years. The last thing we want is this thing going off by accident on a supported system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #6 from seth vidal [EMAIL PROTECTED] 2008-11-03 11:57:28 EDT --- Fixed the typos and changed 'autodie' phrase. New description is: system-autodeath is a cron job that runs daily, checking the current time versus a configured death date for the machine. Within one week of this date the system will emit log notices to syslog.alert notifying that the system will remove its default network route on a specific date. On the date the system will have its default route deleted. It will continue to do this every day until someone does something about it. With regard to the timing: 1. I'll make it a separate source in the config so it is easy to change 2. this pkg will not be installed by default so it's not a risk to anyone 3. basing the date on other values is a bad plan - since we've had to replace fedora-release in the last 2 releases (f8 and f9) and we're not changing the EOL for them b/c of the fedora-release rebuild. 4. I'll bump it to 2010-01-15. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469189
--- Comment #4 from Tim Lauridsen [EMAIL PROTECTED] 2008-10-31 08:35:38 EDT
---
# rpmlint Download/system-autodeath-0.2-1.src.rpm
system-autodeath.src: W: no-version-in-last-changelog
system-autodeath.src: W: strange-permission system-autodeath.spec 0600
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
These should be OK.
# rpmlint ~/rpmbuild/RPMS/noarch/system-autodeath-0.2-1.noarch.rpm
system-autodeath.noarch: W: non-conffile-in-etc
/etc/sysconfig/system-autodeath.conf
system-autodeath.noarch: W: no-version-in-last-changelog
/etc/sysconfig/system-autodeath.conf should be a config file in the %files
section
(. not checked, * = ok, X = not OK)
MUST:
* Package is matching naming guidelines.
* spec file in named %{name}.spec
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible have the right good license shortname :
GPLv2+
* License file must be in %doc (it it exists)
* Spec file is written in American English
* Spec file is legible.
* Sources match upstream.
MD5SUM:
ea889c8a377cac44361576f6112f2868
/home/tim/rpmbuild/SOURCES/system-autodeath-0.2.tar.gz
ea889c8a377cac44361576f6112f2868
/home/tim/Download/system-autodeath-0.2.tar.gz
* summary and description fine
* correct buildroot
X %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine
* Packager/Vendor/Distribution/Copyright tags not used
* Summary tag does not end in a period
* Package compiles and build into RPM's on : i386 etc.
* no Exclude Arch
* BuildRequires for all build requerements (- the ones on the Exception list)
* no locales
* no shared libs
* Package own all created directories.
* No duplicate files in %files
* Every %files section includes a %defattr(...) line
* Package has a %clean with a rm -rf %{buildroot} or $RPM_BUILD_ROOT
* consistently use of macros
* Package contains code or or permissable content.
* No large documentation
* files in %doc dont affect runtime.
* no header files
* no static libs
* package has no pkgconfig (.pc) files
* no -devel subpackage
* no ..la libtool archives
* not a gui application
* package don't own files and dirs owned by other packages.
* %install starts with an rm -rf %{buildroot}
* rpm package filenames is in valid UTF-8.
* no Rpath
* no config files
* no %makeinstall used
* no Requires(pre,post)
Problems.
%{?dist} is missing from release tag.
/etc/sysconfig/system-autodeath.conf should be a config file in the %files
section
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 Tim Lauridsen [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] ||m AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] ||m Flag||fedora-review? --- Comment #1 from Tim Lauridsen [EMAIL PROTECTED] 2008-10-30 11:34:43 EDT --- i will review this one -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #2 from Tim Lauridsen [EMAIL PROTECTED] 2008-10-30 11:49:44 EDT --- Preliminary stuff: rpmlint system-autodeath-0.2-0.src.rpm system-autodeath.src: W: no-%build-section system-autodeath.src: W: summary-ended-with-dot Automatically disable system default route on a specific date. system-autodeath.src: W: no-version-in-last-changelog system-autodeath.src: W: strange-permission system-autodeath.spec 0600 1 packages and 0 specfiles checked; 0 errors, 4 warnings. * Add an empty %build section * remove ending '.' in summary * all changlog entries need to be in same format (with / without version) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 469189] Review Request: system-autodeath - Automatically disable system default route on a specific date.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469189 --- Comment #3 from seth vidal [EMAIL PROTECTED] 2008-10-30 12:04:54 EDT --- Uploaded a new spec, same location. Uploaded a new srpm. Not putting the frelling changelog versions on so that one can go hang itself :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
