[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Mamoru Tasaka changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|fedora-review?, | |needinfo?(alexes...@yahoo.c | |om) | --- Comment #24 from Mamoru Tasaka 2009-05-21 10:34:15 EDT --- Once closing. If someone wants to import this package into Fedora, please file a new review request and mark this bug as a duplicate of the new one, thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #23 from Mamoru Tasaka 2009-05-13 12:30:47 EDT --- I will close this bug as NOTABUG if no response is received from the reporter within ONE WEEK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #22 from Mamoru Tasaka 2009-05-09 12:39:42 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(alexes...@yahoo.c ||om) --- Comment #21 from Mamoru Tasaka 2009-04-25 13:14:30 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #20 from Mamoru Tasaka 2009-04-12 14:13:37 EDT --- Well, for 1.0-5: * GTK icon cache scriptlets, %define -> %global change - Guidelines again changed so please update to follow the last ones: https://fedoraproject.org/wiki/Packaging/Python#System_Architecture https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache Then: - NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on my wiki page: http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets (Check "No one is reviewing") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #19 from Mamoru Tasaka 2009-04-12 12:37:07 EDT --- Sorry, I missed your last comments. I will re-review this package soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Alex Eskin changed: What|Removed |Added Flag|needinfo?(alexes...@yahoo.c | |om) | --- Comment #18 from Alex Eskin 2009-04-05 17:02:15 EDT --- Thanks for your patience. I addressed most of the comments in the new version. Python 2.6 patch will be addressed when I get back home (a few weeks). New Spec URL: http://www.math.uchicago.edu/~eskin/xword/xword.spec New SRPM URL: http://www.math.uchicago.edu/~eskin/xword/xword-1.0-5.fc9.src.rpm --Alex -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #17 from Mamoru Tasaka 2009-04-04 12:16:55 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(alexes...@yahoo.c ||om) --- Comment #16 from Mamoru Tasaka 2009-03-26 10:19:03 EDT --- If my patch won't work on F-9, for now you can just ignore it because my patch is just to suppress warnings. By the way I am still waiting your pre-review or another review request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Alex Eskin changed: What|Removed |Added Flag|needinfo?(alexes...@yahoo.c | |om) | --- Comment #15 from Alex Eskin 2009-03-11 00:21:14 EDT --- The proposed python2.6 patch fails on fedora 9. I will fix it, but it will take a bit of time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #14 from Mamoru Tasaka 2009-03-09 12:33:07 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(alexes...@yahoo.c ||om) --- Comment #13 from Mamoru Tasaka 2009-03-01 10:31:17 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #12 from Mamoru Tasaka 2009-02-13 12:57:39 EDT --- (In reply to comment #11) > Also I do not have a rawhide system handy. Did you test it > on rawhide already? Like other packages I reviewed I don't know how to use this software so I did just some basic test for this software (like if the software lauches) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Alex Eskin changed: What|Removed |Added Flag|needinfo?(alexes...@yahoo.c | |om) | --- Comment #11 from Alex Eskin 2009-02-13 12:28:09 EDT --- Sorry, I was away for a bit. I will test your patch and respond to the other comments this weekend. Also I do not have a rawhide system handy. Did you test it on rawhide already? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Mamoru Tasaka changed: What|Removed |Added Flag||needinfo?(alexes...@yahoo.c ||om) --- Comment #10 from Mamoru Tasaka 2009-02-13 10:44:10 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=470155
--- Comment #9 from Mamoru Tasaka 2009-02-01
09:35:06 EDT ---
Created an attachment (id=330550)
--> (https://bugzilla.redhat.com/attachment.cgi?id=330550)
python 2.6 patch (proposed)
For 1.0-4
* Dependency
---
$ grep 'import ' xword
import pygtk
import gtk
import gtk.gdk
import gobject
import gnomeprint
import gnomeprint.ui
import pango
import sys
import time
import os, os.path
import md5
import pickle
import ConfigParser
---
- It seems "Requires: pygtk2 gnome-python2-gnomeprint" is
sufficient.
* Scriptlets
- For desktop-file-install, now "--vendor=fedora" is not needed
(guidelines changed):
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage
- "Requires: shared-mime-info" is not needed:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo
* Some misc issue
---
%prep
mkdir mime
cp -p %SOURCE2 mime
---
- What are these lines for?
---
gzip $RPM_BUILD_ROOT%{_mandir}/man1/%{name}.1
---
- Not needed. rpmbuild itself gzip's this automatically.
* Macros in %changelog
- In changelog, when you write macros please use %% instead
of % to prevent macros from being expanded.
* Python warning
- By the way now rawhide uses python 2.6 and xword
causes some warnings:
./xword:50: DeprecationWarning: the md5 module is deprecated; use hashlib
instead
import md5
Would you check if the attached patch works for you?
Then I will wait for your another review request or
your pre-review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Mamoru Tasaka changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp Flag||fedora-review? --- Comment #8 from Mamoru Tasaka 2009-01-31 14:29:03 EDT --- Well, I have not checked your package at all, however - NOTE: Before being sponsored: Before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on my wiki page: http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets (Check "No one is reviewing") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #7 from Alex Eskin 2009-01-31 11:04:05 EDT --- Yes, I still would like to import it. Thanks! --Alex -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Mamoru Tasaka changed: What|Removed |Added CC||mtas...@ioa.s.u-tokyo.ac.jp --- Comment #6 from Mamoru Tasaka 2009-01-30 13:07:06 EDT --- Hello, Alex: It seems that no one tried to review your package for more than 2 months. Do you still want to import your srpm into Fedora? If so, I will try to review your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Itamar Reis Peixoto changed: What|Removed |Added CC||ita...@ispbrasil.com.br Alias||xword -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #5 from Alex Eskin <[EMAIL PROTECTED]> 2008-11-20 04:16:03 EDT --- Thanks a lot for for the review! I added the %doc LICENSE New Spec URL: http://www.math.uchicago.edu/~eskin/xword/xword.spec New SRPM URL: http://www.math.uchicago.edu/~eskin/xword/xword-1.0-4.fc9.src.rpm --Alex -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #4 from Alec Leamas <[EMAIL PROTECTED]> 2008-11-17 17:54:18 EDT --- OK, now I can download. Rpmlint is dead quiet on package and spec file. The naming is OK, as is the base name of the spec file. Package builds cleanly in mock, on a Fedora 9/X86_64 configuration. After building and installing, the program starts just fine. Nothing strange at a first sight. The license: tag is valid, and the code has a proper license file and copyright notice in the source. The package meets to my understanding the Packaging Guidelines. The License file is not in %doc (there is no %doc at all). It should be. The upstream md5sum matches the srpm source (5e1963b488dfa0aca75be3bc3af04887) As a summary, I see no problems at all with this package besides the missing %doc LICENSE. And it looks fun. You know, it's harder if it's not your native language... I have actually walked down the complete review checklist, but it's really no point to describe all "complies" here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #3 from Alex Eskin <[EMAIL PROTECTED]> 2008-11-17 11:22:57 EDT --- Sorry about that. Try it now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Alec Leamas <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Alec Leamas <[EMAIL PROTECTED]> 2008-11-16 04:14:42 EDT --- I need a sponsor, so I need to make some informal reviews. A short look at the spec file looks good, for what value that can be. But I get an "Access denied" for the srpm. No good, that is :-) --alec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 --- Comment #1 from Alex Eskin <[EMAIL PROTECTED]> 2008-11-10 17:43:26 EDT --- Fixed a stupid packaging bug involving $RPM_BUILD_ROOT. New Spec URL: www.math.uchicago.edu/~eskin/xword/xword.spec New SRPM URL: www.math.uchicago.edu/~eskin/xword/xword-1.0-3.fc9.src.rpm rpmlint now reports no errors or warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 470155] Review Request: xword - Reads and writes crossword puzzles in the Across Lite file format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470155 Jason Tibbitts <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
