[Bug 475135] Review Request: portmidi - Real-time Midi I/O Library

2009-10-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475135


Lucian Langa  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475135] Review Request: portmidi - Real-time Midi I/O Library

2009-01-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475135


Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA




--- Comment #5 from Fedora Update System   
2009-01-29 18:07:34 EDT ---
portmidi-131-2.fc10 has been pushed to the Fedora 10 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update portmidi'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1149

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475135] Review Request: portmidi - Real-time Midi I/O Library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475135


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #4 from Kevin Fenzi   2009-01-28 00:33:20 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475135] Review Request: portmidi - Real-time Midi I/O Library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475135


Orcan 'oget' Ogetbil  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #3 from Orcan 'oget' Ogetbil   2009-01-27 
13:54:55 EDT ---

> Suggestions:
> 
> - There is a doxygen style documentation provided in this package, you should
> include it in the -devel and don't forget to pickup doxygen as a BR.
> - Please consider preserving timestamps of installed files
> 
> APPROVED.

Thanks! Will do.

New Package CVS Request
===
Package Name: portmidi
Short Description: Real-time Midi I/O Library
Owners: oget
Branches: F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475135] Review Request: portmidi - Real-time Midi I/O Library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475135


Lucian Langa  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #2 from Lucian Langa   2009-01-27 13:17:46 EDT 
---
Review:
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  summary is OK.
OK  description is OK.
OK  dist tag is present.
OK  build root is OK.
OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires are sane:
portmidi-131-1.fc11.x86_64.rpm
libportmidi.so.0()(64bit)
libporttime.so.0()(64bit)
portmidi = 131-1.fc11
portmidi(x86-64) = 131-1.fc11
  =
/sbin/ldconfig
libasound.so.2()(64bit)
libc.so.6()(64bit)
libm.so.6()(64bit)
libportmidi.so.0()(64bit)
libporttime.so.0()(64bit)
libpthread.so.0()(64bit)

portmidi-devel-131-1.fc11.x86_64.rpm
portmidi-devel = 131-1.fc11
portmidi-devel(x86-64) = 131-1.fc11
  =
libportmidi.so.0()(64bit)
libporttime.so.0()(64bit)
portmidi = 131-1.fc11

OK  %check is not present; no test suite upstream.
OK  shared libraries installed; ldconfig called properly
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  headers are in a separate -devel package.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.

Suggestions:

- There is a doxygen style documentation provided in this package, you should
include it in the -devel and don't forget to pickup doxygen as a BR.
- Please consider preserving timestamps of installed files

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475135] Review Request: portmidi - Real-time Midi I/O Library

2009-01-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475135


Lucian Langa  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||co...@gnome.eu.org
 AssignedTo|nob...@fedoraproject.org|co...@gnome.eu.org
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 475135] Review Request: portmidi - Real-time Midi I/O Library

2009-01-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475135





--- Comment #1 from Orcan 'oget' Ogetbil   2009-01-11 
01:36:56 EDT ---
New upstream release
Spec URL: http://oget.fedorapeople.org/review/portmidi.spec
SRPM URL: http://oget.fedorapeople.org/review/portmidi-131-1.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review