[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 David Nalley da...@gnsa.us changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #12 from Brian Pepple bdpep...@gmail.com 2009-02-15 11:22:04 EDT --- If this has been built, and pushed to stable this bug can be closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-01-21 16:37:49 EDT --- zapplet-0.1-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zapplet'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-0837 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-01-21 16:38:14 EDT --- zapplet-0.1-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update zapplet'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-0850 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-01-19 08:11:10 EDT --- zapplet-0.1-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/zapplet-0.1-4.fc10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2009-01-19 08:11:06 EDT --- zapplet-0.1-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/zapplet-0.1-4.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi ke...@tummy.com 2009-01-15 15:15:14 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 David Nalley da...@gnsa.us changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from David Nalley da...@gnsa.us 2009-01-14 22:14:59 EDT --- New Package CVS Request === Package Name: zapplet Short Description: Zenoss Tray monitoring applet Owners: ke4qqq Branches: F-9 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Brian Pepple bdpep...@gmail.com 2009-01-13 19:40:41 EDT --- Sorry about not being able to finish this up sooner, but I've been swamped with work the last few weeks. Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Valid license tag. * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Rpmlint produces no warnings or errors. * Package builds in Mock fine. Note: I was unable to test that this works since I don't have a Zenoss installation available. +1 APPROVED. Apply for the packager group in FAS, and I'll be your sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #3 from Brian Pepple bdpep...@gmail.com 2008-12-28 17:36:50 EDT --- Couple of quick items: 1. The requires on python is unnecessary. The requires: python(abi) = 2.6 in the build log does this for you. 2. Likewise the BR on python-setuptools is also unnecessary. The -devel package will pull this in for you. 3. I haven't had a chance to look at the source closely yet, but I'm thinking the requires should be pygtk2, not gtk2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #4 from David Nalley da...@gnsa.us 2008-12-28 17:57:18 EDT --- Brian: I believe I have addressed all of the above items, and you are correct about pygtk2. New spec file: http://ke4qqq.fedorapeople.org/zapplet.spec New SRPM: http://ke4qqq.fedorapeople.org/zapplet-0.1-3.src.rpm [ke4...@nalleyt61 SPECS]$ rpmlint ../SRPMS/zapplet-0.1-3.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 SPECS]$ rpmlint ../RPMS/noarch/zapplet-0.1-3.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4...@nalleyt61 SPECS]$ rpmlint ./zapplet.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings Thanks for taking the time to review this package! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476536
Fabian Affolter fab...@bernewireless.net changed:
What|Removed |Added
CC||fab...@bernewireless.net
--- Comment #1 from Fabian Affolter fab...@bernewireless.net 2008-12-27
17:27:46 EDT ---
Just some comments on your spec file
- The echo call in the %prep section is a bit unusual
- The license is not GPLv2, it's GPLv2+ according to the header in the source
file
- One line per BR would be nice
- There is no need for '\' in the description
- From my point of view, there is no need for 'chmod 755
%{buildroot}%{_bindir}/%{name}'
The guidelines says that the BuildRequires for python packages should be
'BuildRequires: python' and the egg stuff 'BuildRequires:
python-setuptools-devel'
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 --- Comment #2 from David Nalley da...@gnsa.us 2008-12-28 01:18:26 EDT --- Fabian - I believe I have addressed all of your comments you can find the new spec and srpm files here: http://ke4qqq.fedorapeople.org/zapplet-0.1-2.src.rpm http://ke4qqq.fedorapeople.org/zapplet.spec Thanks for taking the time to review the package! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 476536] Review Request: zapplet - Zenoss monitoring tray applet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476536 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|bdpep...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
