[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added CC||berra...@redhat.com --- Comment #2 from Richard W.M. Jones rjo...@redhat.com 2009-01-13 07:09:27 EDT --- I imported this package into the Fedora MinGW temporary repository because I want to have other packages depend on it. Here is an updated package: Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/dlfcn/mingw32-dlfcn.spec SRPM URL: http://koji.fedoraproject.org/koji/getfile?taskID=1049268name=mingw32-dlfcn-0.1-0.2.r11.fc11.src.rpm * Tue Jan 13 2009 Richard W.M. Jones rjo...@redhat.com - 0.1-0.2.r11 - Import into fedora-mingw temporary repository because there are packages which will depend on this. - Fix the version/release according to packaging guidelines. - Tidy up the spec file. - Use dos2unix and keep the timestamps. Here is a successful Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1049267 rpmlint says: mingw32-dlfcn.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/lib/libdl.dll.a mingw32-dlfcn.noarch: W: devel-file-in-non-devel-package /usr/i686-pc-mingw32/sys-root/mingw/include/dlfcn.h mingw32-dlfcn.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libdl.dll.a mingw32-dlfcn.noarch: W: non-standard-dir-in-usr i686-pc-mingw32 2 packages and 0 specfiles checked; 1 errors, 3 warnings. These are all errors which can be ignored for MinGW packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Alias||mingw32-dlfcn -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Blocks||468376 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Blocks||467376 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Flag|needinfo?(ita...@ispbrasil. | |com.br) | --- Comment #3 from Richard W.M. Jones rjo...@redhat.com 2009-01-13 08:06:06 EDT --- Doesn't need to be in NEEDINFO any more. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478640
Adel Gadllah adel.gadl...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||adel.gadl...@gmail.com
Flag||fedora-review?
--- Comment #4 from Adel Gadllah adel.gadl...@gmail.com 2009-01-13 15:03:31
EDT ---
Fix it with sed in the %prep section: %{__sed} -i 's/\r//' src/somefile --
DONT use dos2unix, that can cause build fail on FC3.
Well you should stick to the guidelines even if FC3 is long dead.
Pass %{?_smp_mflags} to make unless you have a reason not to do so.
Will do a formal review later this week (limited time).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478640
--- Comment #5 from Richard W.M. Jones rjo...@redhat.com 2009-01-13 19:03:00
EDT ---
(In reply to comment #4)
Fix it with sed in the %prep section: %{__sed} -i 's/\r//' src/somefile --
DONT use dos2unix, that can cause build fail on FC3.
Well you should stick to the guidelines even if FC3 is long dead.
I'm missing the context here. Was the above in reply to something?
Pass %{?_smp_mflags} to make unless you have a reason not to do so.
I agree, this should be added.
Will do a formal review later this week (limited time).
Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Depends on||454410 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 --- Comment #1 from Richard W.M. Jones rjo...@redhat.com 2009-01-03 05:49:55 EDT --- Itamar, can you try making a Koji scratch-build of this please. It will make it easier to review. You will need to do something like: koji build --scratch dist-f11 mingw32-dlfcn-r11-1.fc10.src.rpm (I'm not exactly sure if that is the correct command, and upgraded my machine yesterday so Koji is now broken for me, so please check it). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Flag||needinfo?(ita...@ispbrasil. ||com.br) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Itamar Reis Peixoto ita...@ispbrasil.com.br changed: What|Removed |Added CC||rjo...@redhat.com Fixed In Version|rjo...@redhat.com | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478640] Review Request: dlfcn - mingw32-dlfcn
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478640 Itamar Reis Peixoto ita...@ispbrasil.com.br changed: What|Removed |Added Fixed In Version||rjo...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
