[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Lubomir Rintel changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Lubomir Rintel 2009-01-18 14:21:00 EDT --- This seems imported & built. Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi 2009-01-11 11:57:02 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Marek Mahut changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Marek Mahut 2009-01-09 06:33:09 EDT --- Thank you. New Package CVS Request === Package Name: cpm Short Description: Console Password Manager Owners: mmahut Branches: F-10 F-9 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Lubomir Rintel changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Lubomir Rintel 2009-01-09 06:21:15 EDT --- Well done, good to go APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 --- Comment #4 from Marek Mahut 2009-01-09 04:32:42 EDT --- Try this stuff! Spec URL: http://mmahut.fedorapeople.org/reviews/cpm/cpm.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/cpm/cpm-0.23-0.1.beta.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 --- Comment #3 from Lubomir Rintel 2009-01-08 13:48:18 EDT --- cpm.i386: W: file-not-utf8 /usr/share/doc/cpm-0.23/cpm.1.gz cpm.i386: W: file-not-utf8 /usr/share/man/man1/cpm.1.gz This file is included twice. Remove it from %doc Furthermore it is not a valid roff source to a manual page, but a formatted txt file which looks well when viewed as a manual page. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 --- Comment #2 from Marek Mahut 2009-01-08 11:25:49 EDT --- :) Thank you for comments, I belive all is fixed now. Spec URL: http://mmahut.fedorapeople.org/reviews/cpm/cpm.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/cpm/cpm-0.23-0.1.beta.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478846
--- Comment #1 from Lubomir Rintel 2009-01-08 10:58:28 EDT ---
Created an attachment (id=328474)
--> (https://bugzilla.redhat.com/attachment.cgi?id=328474)
Fix the std{in,out,err} openness test
Much better than initial package; thanks for the patches! Upstream may be
interested in them as well!
1.) Useless requires
Requires: cracklib
Requires: gpgme
Requires: cdk
Requires: dotconf
Requires: ncurses
Requires: libxml2 >= 2.6.16
Requires: zlib
All these are useless please remove them. They appropriate dependnecies are
generated automatically.
2.) You don't use optflags. Marek! What a shame!
The culprit is CFLAGS= that you pass to %configure which uses its CFLAGS=.
Please change it to CPPFLAGS!
Once FORTIFY_SOURCE is in effect it will reveal that you use open()
incorrectly. I attached a fix.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Bug 478846 depends on bug 478773, which changed state. Bug 478773 Summary: Review Request: cdk - Curses Development Kit https://bugzilla.redhat.com/show_bug.cgi?id=478773 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Lubomir Rintel changed: What|Removed |Added CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 478846] Review Request: cpm - Console Password Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478846 Marek Mahut changed: What|Removed |Added Depends on||478773 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
