[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 --- Comment #12 from Pascal Parois 2009-09-16 07:16:43 EDT --- I am updating this package and ran into an issue. The release version does not compile, so I would like to use the beta version instead (which is working) but the versioning is 1.8.X The current version I have is 1.8.1 which is "newer" than 1.8.X. :( I don't if the next version will be 1.8.2 or 1.9. Any comments welcome -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 --- Comment #11 from Pascal Parois 2009-08-05 13:21:52 EDT --- Sorry, notification mails got lost in my mailbox, I am still here, just very busy. So I'll look at this later. sometimes this month, as soon as I submit my thesis. As I need newmat-c++, I'll look at this one first (https://bugzilla.redhat.com/show_bug.cgi?id=479978) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 --- Comment #10 from Jussi Lehtola 2009-08-05 05:00:28 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482757
--- Comment #9 from Jussi Lehtola 2009-07-08 13:24:43
EDT ---
(In reply to comment #8)
> - Instead of
> find . -type d -name .svn -print0 | xargs -0r rm -rf
> you can just use
> find . -name *.svn -exec rm -rf {} \;
> (or maybe even
> find . -name *.svn -delete;
> )
Ugh, the .svn's are directories, so what you want to run is
find . -name .svn -exec rm -rf {} \;
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482757
Jussi Lehtola changed:
What|Removed |Added
CC||jussi.leht...@iki.fi
--- Comment #8 from Jussi Lehtola 2009-07-08 13:10:05
EDT ---
- Use %global instead of %define. Put the revision definition at the top of the
spec file:
%global revision R1119
- Include the revision in the release tag:
Release:2.%{revision}%{?dist}
(every time you update the spec file update the release tag if the version
hasn't been updated).
- No explicit Requires: are allowed for libraries; drop
Requires: wxGTK, fftw, freeglut
http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- Drop the commented patch line
#%patch0 -p0
- Instead of
find . -type d -name .svn -print0 | xargs -0r rm -rf
you can just use
find . -name *.svn -exec rm -rf {} \;
(or maybe even
find . -name *.svn -delete;
)
- Preserve time stamps by adding -p to install commands.
- Use "rm" instead of "unlink".
- Install the pixmap to /usr/share/pixmaps, drop the hicolor stuff. (Also, you
were missing Requires: hicolor-icon-theme.)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 --- Comment #7 from Pascal 2009-04-11 11:06:21 EDT --- new srpm: http://fedora.debroglie.net/SRPMS/10/objcryst-fox-1.8.1.2-1.fc10.debroglie.src.rpm spec: http://svn.debroglie.net/specs/trunk/objcryst-fox.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482757
--- Comment #6 from Pascal 2009-02-21 13:22:57 EDT ---
(In reply to comment #5)
>
> * You can use the macro %{name} instead of Fox in a number of places in the
The name of the package is not the name of the archive.
I used the same name as debian used for their deb:
http://packages.debian.org/fr/sid/objcryst-fox
>
> * Please add an extra \n between two change in the changelog (some tool used
Done in the spec but new srpm/rpm not updated
>
> It might be nice also to give to the reviewer an input file and an output file
> so that the software could actually be tested :)
There are example files in /usr/share/doc/objcryst-fox...
A tutorial is here:
http://vincefn.net/Fox/Tutorials
>
> You might also be interested to join the SciTech SIG:
> https://fedoraproject.org/wiki/Category:SciTech_SIG
>
Yes, good idea, I'll see when this get pushed in fedora.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=482757
Pierre-YvesChibon changed:
What|Removed |Added
CC||pin...@pingoured.fr
--- Comment #5 from Pierre-YvesChibon 2009-02-18
11:13:43 EDT ---
I cannot do the review since I'm not a sponsor but I looked at the spec file
Several minor points:
* You can use the macro %{name} instead of Fox in a number of places in the
spec
ie:
> Source0:
> http://dfn.dl.sourceforge.net/sourceforge/objcryst/Fox-1.8.0.3-R1088.tar.bz2
becomes
> Source0:
> http://dfn.dl.sourceforge.net/sourceforge/objcryst/%{name}-%{version}-R1088.tar.bz2
that can save you some problem for later update
* Please add an extra \n between two change in the changelog (some tool used
within Fedora need these white line between the change):
ie:
> * Sat Feb 14 2009 Pascal < pascal...@parois.net > - 1.8.0.3-1
> - Fixed reading, writing files and display of labels in the linux unicode
> version of Fox
> * Fri Feb 06 2009 Pascal < pascal...@parois.net > - 1.8.0-2
becomes
> * Sat Feb 14 2009 Pascal < pascal...@parois.net > - 1.8.0.3-1
> - Fixed reading, writing files and display of labels in the linux unicode
> version of Fox
It might be nice also to give to the reviewer an input file and an output file
so that the software could actually be tested :)
You might also be interested to join the SciTech SIG:
https://fedoraproject.org/wiki/Category:SciTech_SIG
> * Fri Feb 06 2009 Pascal < pascal...@parois.net > - 1.8.0-2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 --- Comment #4 from Pascal 2009-02-18 04:41:59 EDT --- rpmlint is silent. I runned the spec through mock, fedora 9/10 and epel 5 both x86_64 and i386 are ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 MERCIER changed: What|Removed |Added CC||bioinfornat...@gmail.com --- Comment #3 from MERCIER 2009-02-14 18:03:16 EDT --- what's the rpmlint issue: rpmlint /home/builder/SPEC/objcryst-fox.spec rpmlint /home/builder/SRPMS/objcryst-fox-1.8.0.3-1.fc10.debroglie.src.rpm rpmlint /home/builder/RPMS/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 --- Comment #2 from Pascal 2009-02-14 08:29:39 EDT --- Update to match new upstream release. srpm: http://fedora.debroglie.net/SRPMS/10/objcryst-fox-1.8.0.3-1.fc10.debroglie.src.rpm spec: http://svn.debroglie.net/specs/trunk/objcryst-fox.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 --- Comment #1 from Pascal 2009-02-06 16:08:23 EDT --- New srpm: http://fedora.debroglie.net/SRPMS/10/objcryst-fox-1.8.0-2.fc10.debroglie.src.rpm New spec: http://svn.debroglie.net/specs/trunk/objcryst-fox.spec I runned the spec through mock, fedora 9/10 and epel 5 both x86_64 are ok. I corrected some errors on the build require -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 manuel wolfshant changed: What|Removed |Added Depends on||479978 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 482757] Review Request: objcryst-fox - Viewing and solving crystal structures from powder diffraction data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=482757 manuel wolfshant changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
