[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 --- Comment #8 from Fedora Update System 2009-02-06 00:24:55 EDT --- hatools-2.00-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 --- Comment #7 from Fedora Update System 2009-02-06 00:19:58 EDT --- hatools-2.00-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #6 from Kevin Fenzi 2009-02-02 23:09:16 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 --- Comment #5 from Oliver Falk 2009-02-01 15:23:28 EDT --- New Package CVS Request === Package Name: hatools Short Description: Improved shell scripting in High Availability environment Owners: oliver Branches: EPEL-4 EPEL-5 F-9 F-10 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 Oliver Falk changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 Jochen Schmitt changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Jochen Schmitt 2009-02-01 14:45:13 EDT --- Good: + License tag say GPLv2+ as an OSS license wich matches with the copyright notes in the source files. + Adding blank lines betweens the paragraphs. *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 --- Comment #3 from Oliver Falk 2009-01-30 08:08:58 EDT --- Updated the spec, including TODO and BAD :-) I did *not* increase the release number. Thx Jochen for reviewing! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 Jochen Schmitt changed: What|Removed |Added Status|NEW |ASSIGNED CC||joc...@herr-schmitt.de AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de Flag||fedora-review? --- Comment #2 from Jochen Schmitt 2009-01-29 11:22:55 EDT --- Good: + Basename of the SPEC files matches with package name + Package contains the most current release + SPEC file is written in English + Could download source via spectool -g + Packaged tar ball matches with upstream (md5sum: ba137a37f6725076c7d2c729cbccf4a5) + Package contains no patches + Package contains a license tag + Package contains a verbatin copy of the license text + Package contains proper BuildRoot specification + Consistently use of rpm macros + Package contains no patches + Package doesn't need any BRs or Reqs. + Package use parallel make + Buildroot will be cleaned at the beginning of %clean and %install + Local build works fine + Build honors $RPM_OPT_FLAGS + Koji build works fine + Debuginfo package contains source files + Local install works fine + Start of command without arguments doesn't crashed + Local uninstall works fine + Package doesn't have subpackages + Default files permission are ok. + Files have proper file permission + %files stanza doesn't have duplicated entries + All packaged files are owned by the package + No packaged file has a conflict with ohter packages + %doc stanza is small, so we don't need a separate subpackage + %changelog is in a proper format Bad: - License tag says GPL as license. It's necessary to specified the version of the used GPL. A look on the source files says, that GPLv2+ may the right specification for the license tag. TODO: * I thing a blank line beetween the paragraph of the description will incerease the readability of it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483026] Review Request: hatools - Improved shell scripting in High Availability environment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483026 --- Comment #1 from Oliver Falk 2009-01-29 07:20:12 EDT --- I'm not sure about the GPL license... Maybe with more knowledge about licensing should take that this review... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
