[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 Jussi Lehtola changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE --- Comment #10 from Jussi Lehtola 2009-03-17 19:43:52 EDT --- Allisson: Remember to close the Review Request once the package hits the distribution. (You can make the update manager do this.) Closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #9 from Kevin Fenzi 2009-02-08 16:48:19 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 Allisson Azevedo changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Allisson Azevedo 2009-02-06 12:21:21 EDT --- New Package CVS Request === Package Name: eina Short Description: A classic player for a modern era Owners: allisson Branches: F-9 F-10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 Jussi Lehtola changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #7 from Jussi Lehtola 2009-02-06 02:12:03 EDT --- - chrpath is a last resort. Please patch libtool instead as stated in the Packaging guidelines: %configure sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool You can do this once you import to CVS. The package has been APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 --- Comment #6 from Allisson Azevedo 2009-02-05 18:19:14 EDT --- Update package: Spec URL: http://allisson.fedorapeople.org/packages/eina/eina.spec SRPM URL: http://allisson.fedorapeople.org/packages/eina/eina-0.7.3-4.fc10.src.rpm Changelog: * Thu Feb 5 2009 Allisson Azevedo 0.7.3-4 - Fix to consistently use macros. - Fix devel requires. - Disable Rpath. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483857
--- Comment #5 from Jussi Lehtola 2009-02-05 17:26:35
EDT ---
Oh, that's right. No problem then.
- Now you have two rel 3's in the changelog.
Review:
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
- Home page (1) states liblomo is under LGPL, but I can't find any mention of
LGPL in the source files or the LGP license file. Thus License: GPLv2+ is OK.
MUST: Each package must consistently use macros.
- You use $RPM_BUILD_ROOT, thus you should also use $RPM_OPT_FLAGS instead of
%{optflags}
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
- You need Requires: pkgconfig
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
- Fix this, too.
rpmlint output:
[jzleh...@politzer RPMS]$ rpmlint *
eina.x86_64: W: shared-lib-calls-exit /usr/lib64/liblomo-1.0.so.1.0.0
e...@glibc_2.2.5
eina.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/eina ['/usr/lib64']
eina-devel.x86_64: W: no-documentation
eina.src:103: W: macro-in-%changelog files
4 packages and 0 specfiles checked; 1 errors, 2 warnings.
- You need to patch libtool to get rid of the rpath.
http://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath
- You need to use %%files instead of %files in %changelog.
OK'd items omitted.
(1) http://eina.sourceforge.net/about.php
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 --- Comment #4 from Allisson Azevedo 2009-02-05 16:58:22 EDT --- Update package: Spec URL: http://allisson.fedorapeople.org/packages/eina/eina.spec SRPM URL: http://allisson.fedorapeople.org/packages/eina/eina-0.7.3-3.fc10.src.rpm Notes: - This package not build for F-11 without this patch (F-10 and F-9 works without this patch). - The changelog format is valid, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483857
--- Comment #3 from Jussi Lehtola 2009-02-05 16:37:29
EDT ---
- Why do you disable the GTK version check?
- You need to have
%{_datadir}/eina
%{_libdir}/eina
in the %files section, since the package has to own the directories it creates.
- Put
%defattr(-,root,root,-)
in the devel files section, so that the attributes are the same as for the main
package.
- Changelog entries
* Thu Feb 5 2009 Allisson Azevedo 0.7.3-2
should be
* Thu Feb 5 2009 Allisson Azevedo - 0.7.3-2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 --- Comment #2 from Allisson Azevedo 2009-02-05 16:14:57 EDT --- Update package: Spec URL: http://allisson.fedorapeople.org/packages/eina/eina.spec SRPM URL: http://allisson.fedorapeople.org/packages/eina/eina-0.7.3-2.fc10.src.rpm Notes: - The plugins of Eina results in .so files under main package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483857
--- Comment #1 from Jussi Lehtola 2009-02-05 10:24:45
EDT ---
You didn't paste rpmlint output. However it seems okay:
eina.i386: W: shared-lib-calls-exit /usr/lib/liblomo-1.0.so.1.0.0
e...@glibc_2.0
eina-devel.i386: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
The spec file needs some work, however.
- The patch has no explanation. Why do you need it?
- Disable building static libraries with
%configure --disable-static
- After that, you may need to remove the .la files manually
http://fedoraproject.org/wiki/Packaging/Guidelines
and you can remove the %files sections relating .a and .la files.
- Package does not use Fedora optimization flags. Use
make %{?_smp_mflags} CFLAGS="%{optflags}"
- The desktop file has to be handled, see
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
- %files section is *awfully* messy, I can't figure out what it says. Either
list all files, or use wildcards and a couple of excludes. Don't use %{dir}.
- Main package has a couple of .so files, these should be in -devel.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 483857] Review Request: Eina - A classic player for a modern era
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483857 Jussi Lehtola changed: What|Removed |Added Status|NEW |ASSIGNED CC||jussi.leht...@iki.fi AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
