[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #58 from leigh scott 2009-10-16 16:08:35 EDT --- Thanks Rex. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #57 from Rex Dieter 2009-10-12 08:38:26 EDT --- Previous flags policy was overturned yes, https://fedoraproject.org/wiki/Package_Maintainers_Flags_Policy More gory details, http://fedoraproject.org/wiki/FWN/Issue177#In_a_Flap_Over_Flags -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #56 from leigh scott 2009-10-12 08:06:35 EDT --- Christoph Wickert has told me the flags policy has changed, is it OK to drop the flags patch? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #55 from leigh scott 2009-04-30 09:35:46 EDT --- (In reply to comment #54) > Either > Version: 1.4.0 > Release: 0.1.beta2 > or > Version: 1.4.0 > Release: 0.1.svn > works, conforming to Naming guidelines: > http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Version Thank you, I went with your second example. http://koji.fedoraproject.org/koji/buildinfo?buildID=100393 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #54 from Rex Dieter 2009-04-30 08:43:08 EDT --- Either Version: 1.4.0 Release: 0.1.beta2 or Version: 1.4.0 Release: 0.1.svn works, conforming to Naming guidelines: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Version -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #53 from leigh scott 2009-04-30 08:13:04 EDT --- Bump! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #52 from leigh scott 2009-04-28 09:09:05 EDT --- Hi Rex, I have built a F-12 package from svn as the 1.4.0beta2 source isn't that complete. http://bazaar.launchpad.net/~vcs-imports/qbittorrent/trunk/changes I reported the faults and got them fixed upstream, I was wondering what would be the correct way to version the F-12 package ? http://koji.fedoraproject.org/koji/buildinfo?buildID=99635 Thanks Leigh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #51 from leigh scott 2009-04-25 13:55:47 EDT --- (In reply to comment #50) > fyi, F-11 branches have already been made for all packages. (you may need a > cvs -d up) Thank you for the info. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Rex Dieter changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #50 from Rex Dieter 2009-04-25 13:32:33 EDT --- fyi, F-11 branches have already been made for all packages. (you may need a cvs -d up) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 leigh scott changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #49 from leigh scott 2009-04-25 12:49:50 EDT --- Package Change Request == Package Name: qbittorrent New Branches: F-11 Owners leigh123linux -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Fedora Update System changed: What|Removed |Added Fixed In Version|1.2.1-2.fc10|0.9.3-1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #48 from Fedora Update System 2009-02-25 11:26:32 EDT --- qbittorrent-0.9.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||1.2.1-2.fc10 Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #47 from Fedora Update System 2009-02-24 15:57:52 EDT --- qbittorrent-1.2.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #46 from Fedora Update System 2009-02-24 11:22:31 EDT --- qbittorrent-0.9.3-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/qbittorrent-0.9.3-1.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #45 from leigh scott 2009-02-10 18:32:40 EDT --- If qbittorrent 1.2.1 is also accepted, how do I import it to CVS ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #44 from Kevin Fenzi 2009-02-10 17:39:06 EDT --- cvs done. You may also want to look at: http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #43 from leigh scott 2009-02-10 15:17:15 EDT --- Here's a F10 version that uses rb_libtorrent-devel >= 0.13.1 Spec URL: http://dnmouse.org/fedora/qbittorrent_review/10/qbittorrent.spec SRPM URL: http://dnmouse.org/fedora/qbittorrent_review/10/qbittorrent-1.2.1-2.fc10.src.rpm Patch URL: http://dnmouse.org/fedora/qbittorrent_review/10/qbittorrent_flag.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #42 from leigh scott 2009-02-10 15:13:32 EDT --- (In reply to comment #39) > I've pointed out in comment 12 that it won't build on anything older than F11 > Development (Rawhide). Requesting branches is pointless. Unless you get > rb_libtorrent version upgrades for F-10 and F-9. I am aware of the rb_libtorrent issue with F-9 & F-10, I am just running qbittorrent-1.2.1-2.fc10.src.rpm though mock now and I will upload the spec & srpm for inspection when it's complete. qbittorrent-1.2.1-2.fc10.src.rpm will build OK with rb_libtorrent-devel >= 0.13.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #41 from Eli Wapniarski 2009-02-10 14:53:58 EDT --- Any particular reason why rb_libtorrent 0.14 is not being built for Fedora 10 and 9. I conducted my review on Fedora 10 after successfully building rb_libtorrent on Fedora 10. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #40 from leigh scott 2009-02-10 14:42:46 EDT --- (In reply to comment #39) > I've pointed out in comment 12 that it won't build on anything older than F11 > Development (Rawhide). Requesting branches is pointless. Unless you get > rb_libtorrent version upgrades for F-10 and F-9. I am aware of the rb_libtorrent issue with F-9 & F-10, I am just running qbittorrent-1.2.1-2.fc10.src.rpm though mock now and I will upload the spec & srpm for inspection when it's complete. qbittorrent-1.2.1-2.fc10.src.rpm will build OK with rb_libtorrent-devel >= 0.13.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #39 from Michael Schwendt 2009-02-10 14:04:10 EDT --- I've pointed out in comment 12 that it won't build on anything older than F11 Development (Rawhide). Requesting branches is pointless. Unless you get rb_libtorrent version upgrades for F-10 and F-9. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 leigh scott changed: What|Removed |Added Flag||fedora-cvs? --- Comment #38 from leigh scott 2009-02-10 13:35:14 EDT --- New Package CVS Request === Package Name: qbittorrent Short Description: A bittorrent Client Owners: leigh123linux Branches: F-9 F-10 InitialCC:leigh123linux -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #37 from leigh scott 2009-02-10 12:30:26 EDT --- (In reply to comment #36) > alrighty, looks good, sponsored. I believe the next step is to request a CVS module and branches with the CVSAdminProcedure, is this correct? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Rex Dieter changed: What|Removed |Added Blocks|177841 | --- Comment #36 from Rex Dieter 2009-02-10 12:21:12 EDT --- alrighty, looks good, sponsored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #34 from leigh scott 2009-02-10 12:13:46 EDT --- (In reply to comment #33) > Lemme look over things quick (looks good at first glance), and I'll do the > sponsor thing. > > Leigh, have you a fas account created? If so, what username? If not, do so > asap. :) See: > > http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account Hi Rex, Thank you for sponsoring me, my fas username= Leigh123linux Leigh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #35 from leigh scott 2009-02-10 12:15:51 EDT --- (In reply to comment #34) > (In reply to comment #33) > > Lemme look over things quick (looks good at first glance), and I'll do the > > sponsor thing. > > > > Leigh, have you a fas account created? If so, what username? If not, do so > > asap. :) See: > > > > http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account > > > Hi Rex, > > Thank you for sponsoring me, my fas username= Leigh123linux > > > Leigh Sorry I made a mistake , it should be username= leigh123linux -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #33 from Rex Dieter 2009-02-10 12:06:16 EDT --- Lemme look over things quick (looks good at first glance), and I'll do the sponsor thing. Leigh, have you a fas account created? If so, what username? If not, do so asap. :) See: http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #32 from Eli Wapniarski 2009-02-10 12:00:45 EDT --- Your welcome. Now, this I'm certain of, you will have to follow the procedure outlined in https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Cheers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #31 from leigh scott 2009-02-10 06:01:38 EDT --- (In reply to comment #30) > Oops reread that and yep. You're quite right. Sorry Leigh. > > Anyway... I think things are OK... So you get a passing grade of fedora-review > + :). Hi Eli, Thanks for reviewing qbittorrent. Leigh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Eli Wapniarski changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #30 from Eli Wapniarski 2009-02-10 00:21:39 EDT --- Oops reread that and yep. You're quite right. Sorry Leigh. Anyway... I think things are OK... So you get a passing grade of fedora-review + :). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #29 from Rex Dieter 2009-02-09 15:28:24 EDT --- (Eli, that's something the reviewer usually does) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 leigh scott changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #28 from Eli Wapniarski 2009-02-09 15:18:56 EDT --- Please edit flags at the top of this bug report and set the fedora-review flag to ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #27 from leigh scott 2009-02-09 09:52:03 EDT --- Buildlogs for the F11 rawhide 1.3.1-7 build i386 buildlogs URL: http://leigh123.homelinux.com/Rawhide/i386/new_1/ x86_64 buildlogs URL: http://leigh123.homelinux.com/Rawhide/x86_64/new_1/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #26 from leigh scott 2009-02-09 08:03:03 EDT --- (In reply to comment #25) > Thanks for the info Michael, but it still shouldn't make my computer come to a > screeching halt compiling inside Konsole. I've got a 1 gig system on an > x86_64. > Things should be reasonable, but they aren't. I had to add another 1Gb or RAM to my machine (2Gb total) as some of the compiling processes take in excess of 700Mb , this forces the PC to start using the swap space (hence the machine runs slower) > > Leigh... OK... I can confirm that the flags have been removed from the > compiled > program. I will continue with the review. I will do my level best to get it > done as quickly as I am able. This is going to be my first review so please be > a little patient with me as I want to get this right. No problem :cool: Here are the build logs from mock for Rawhide if it helps. i386 buildlogs URL: http://leigh123.homelinux.com/Rawhide/i386/ x86_64 buildlogs URL: http://leigh123.homelinux.com/Rawhide/x86_64/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #25 from Eli Wapniarski 2009-02-09 07:40:50 EDT --- Thanks for the info Michael, but it still shouldn't make my computer come to a screeching halt compiling inside Konsole. I've got a 1 gig system on an x86_64. Things should be reasonable, but they aren't. Leigh... OK... I can confirm that the flags have been removed from the compiled program. I will continue with the review. I will do my level best to get it done as quickly as I am able. This is going to be my first review so please be a little patient with me as I want to get this right. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #24 from Michael Schwendt 2009-02-09 07:32:28 EDT --- It's C++. Compiling C++ is more resource hungry than e.g. compiling C. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #23 from leigh scott 2009-02-09 06:39:47 EDT --- (In reply to comment #20) > NON SHOW STOPPERS > - > 1) Not a show stopper, but, I had to grab rb_libtorrent-0.14.1-2 from koji so > that I could rebuild on Fedora 10. I don't have Fedora 11 alpha. > > 2) When rebuilding both rb_libtorrent and qbtorrent from within Konsole the > compiling seems to chew up a lot of system resources. From runlevel 3 both > rebuilt in a reasonable amount of time. I have no idea if this is a problem > with KDE, qt, cmake, gcc... If somebody could help figure this out, it would > be > great. > > > SHOW STOPPER > - > In the Preferences dialog box under languages, country flags appear. They need > to be removed to conform to Fedora packaging guidelines. If someone knows how > to create a patch to remove them it would be good. I have removed the flags :) , I have also noticed that it takes a lot of ram to compile rb_libtorrent and qbittorrent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #22 from leigh scott 2009-02-09 06:29:07 EDT --- Here are the new SRPM & Spec file Spec URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_4/qbittorrent.spec SRPM URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_4/qbittorrent-1.3.1-7.fc10.src.rpm patch URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_4/qbittorrent_flag.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #21 from leigh scott 2009-02-09 06:20:42 EDT --- Created an attachment (id=331303) --> (https://bugzilla.redhat.com/attachment.cgi?id=331303) Patch to remove flags from the preferences menu -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Eli Wapniarski changed: What|Removed |Added CC||e...@orbsky.homelinux.org AssignedTo|nob...@fedoraproject.org|e...@orbsky.homelinux.org --- Comment #20 from Eli Wapniarski 2009-02-09 05:41:47 EDT --- NON SHOW STOPPERS - 1) Not a show stopper, but, I had to grab rb_libtorrent-0.14.1-2 from koji so that I could rebuild on Fedora 10. I don't have Fedora 11 alpha. 2) When rebuilding both rb_libtorrent and qbtorrent from within Konsole the compiling seems to chew up a lot of system resources. From runlevel 3 both rebuilt in a reasonable amount of time. I have no idea if this is a problem with KDE, qt, cmake, gcc... If somebody could help figure this out, it would be great. SHOW STOPPER - In the Preferences dialog box under languages, country flags appear. They need to be removed to conform to Fedora packaging guidelines. If someone knows how to create a patch to remove them it would be good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484229
--- Comment #19 from leigh scott 2009-02-08
08:17:56 EDT ---
Heres the output for rpmlint
srpm
qbittorrent.src: I: checking
qbittorrent.src:27: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
qbittorrent.src:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
built package
qbittorrent.x86_64: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #18 from leigh scott 2009-02-08 08:14:06 EDT --- (In reply to comment #17) > Created an attachment (id=331236) --> (https://bugzilla.redhat.com/attachment.cgi?id=331236) [details] > patch for spec file > > > I have read the packaging guidelines and found nothing that > > expressly prohibits this , so fixing this error isn't mandatory , > > is this correct ? > > No. For this review a fix will be mandatory. I'm going to test-build with > attached patch, as I believe it to be the correct way to package this app. > > The buildroot path being used in %build (instead of just %install) usually is > a > packaging mistake/pitfall. It has lead to trouble several times before. > > The guidelines aren't as complete as necessary to cover each and every > packaging detail. In corner-cases it may be "okay" to use the buildroot path > in > %build. But then you should have a much better rationale than a spec file > comment such as "needs the RPM_BUILD_ROOT in prefix to build". That's too > vague > and unconvincing. Thank you for the patch it works fine, I didn't know about the INSTALL_ROOT option. Here are the new SRPM & Spec file with your changes from you patch Spec URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_3/qbittorrent.spec SRPM URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_3/qbittorrent-1.3.1-6.fc10.src.rpm Thank you for your help. Leigh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #17 from Michael Schwendt 2009-02-08 07:37:21 EDT --- Created an attachment (id=331236) --> (https://bugzilla.redhat.com/attachment.cgi?id=331236) patch for spec file > I have read the packaging guidelines and found nothing that > expressly prohibits this , so fixing this error isn't mandatory , > is this correct ? No. For this review a fix will be mandatory. I'm going to test-build with attached patch, as I believe it to be the correct way to package this app. The buildroot path being used in %build (instead of just %install) usually is a packaging mistake/pitfall. It has lead to trouble several times before. The guidelines aren't as complete as necessary to cover each and every packaging detail. In corner-cases it may be "okay" to use the buildroot path in %build. But then you should have a much better rationale than a spec file comment such as "needs the RPM_BUILD_ROOT in prefix to build". That's too vague and unconvincing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #16 from leigh scott 2009-02-07 20:12:39 EDT --- > I have also found this. > > http://www.mail-archive.com/fedora-package-review@redhat.com/msg96285.html > > Fix if possible. > > nss.src: E: no-cleaning-of-buildroot %install > You should clean $RPM_BUILD_ROOT in the %clean section and just after the > beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT" Disregard this, I miss read it :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484229
--- Comment #15 from leigh scott 2009-02-07
20:09:57 EDT ---
Here are the new spec and srpm
Spec URL:
http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_2/qbittorrent.spec
SRPM URL:
http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_2/qbittorrent-1.3.1-5.fc10.src.rpm
rpmlint -vi qbittorrent-1.3.1-5.fc10.x86_64.rpm qbittorrent.x86_64: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -vi qbittorrent-1.3.1-5.fc10.src.rpmqbittorrent.src: I: checking
qbittorrent.src:27: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
qbittorrent.src:30: W: rpm-buildroot-usage %build ./configure
--prefix=$RPM_BUILD_ROOT%{_prefix}
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.
qbittorrent.src:30: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484229
--- Comment #14 from leigh scott 2009-02-07
20:01:19 EDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > * Source0 points to a web page. The following Source0 location actually
> > points
> > to a wget/curl-downloadable tarball:
> >
> > http://downloads.sf.net/qbittorrent/qbittorrent-1.3.0.tar.gz
> >
> >
> > > ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
> >
> > This --prefix is wrong. That's too much risk that the buildroot path finds
> > its
> > way into compiled/built files. Use --prefix=%{_prefix} only.
> >
> >
> > > gmake %{?_smp_mflags}
> >
> > "gmake" is a softlink to "make", why not just use "make" from package "make"
> > then? ;)
> >
> >
> > > %doc README INSTALL NEWS COPYING AUTHORS TODO Changelog
> >
> > File "INSTALL" is irrelevant to the package users.
> >
> >
> > * Run "rpmlint" on your src.rpm and built rpms and apply fixes as
> > appropriate:
> >
> > $ rpmlint qbittorrent-1.3.0-4.fc10.src.rpm
> > qbittorrent.src:27: W: configure-without-libdir-spec
> > qbittorrent.src:29: W: rpm-buildroot-usage %build ./configure
> > --prefix=$RPM_BUILD_ROOT%{_prefix}
> > qbittorrent.src:29: W: configure-without-libdir-spec
> > qbittorrent.src: E: description-line-too-long A Bittorrent client using C++
> > /
> > rb_libtorrent and a Qt4 Graphical User Interface.
> > 1 packages and 0 specfiles checked; 1 errors, 3 warnings.
> >
> > * The Warning about missing --libdir usage can be ignored.
> >
> >
> > * Testbuild will need Rawhide (F11 devel):
> > Checking for libtorrent-rasterbar >= 0.14 ... no
>
>
> This isn't possible !
>
> > > ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
> >
> > This --prefix is wrong. That's too much risk that the buildroot path finds
> > its
> > way into compiled/built files. Use --prefix=%{_prefix} only.
>
>
> I have read the packaging guidelines and found nothing that expressly
> prohibits
> this , so fixing this error isn't mandatory , is this correct ?
I have also found this.
http://www.mail-archive.com/fedora-package-review@redhat.com/msg96285.html
Fix if possible.
nss.src: E: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT"
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484229
--- Comment #13 from leigh scott 2009-02-07
19:59:05 EDT ---
(In reply to comment #12)
> * Source0 points to a web page. The following Source0 location actually points
> to a wget/curl-downloadable tarball:
>
> http://downloads.sf.net/qbittorrent/qbittorrent-1.3.0.tar.gz
>
>
> > ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
>
> This --prefix is wrong. That's too much risk that the buildroot path finds its
> way into compiled/built files. Use --prefix=%{_prefix} only.
>
>
> > gmake %{?_smp_mflags}
>
> "gmake" is a softlink to "make", why not just use "make" from package "make"
> then? ;)
>
>
> > %doc README INSTALL NEWS COPYING AUTHORS TODO Changelog
>
> File "INSTALL" is irrelevant to the package users.
>
>
> * Run "rpmlint" on your src.rpm and built rpms and apply fixes as appropriate:
>
> $ rpmlint qbittorrent-1.3.0-4.fc10.src.rpm
> qbittorrent.src:27: W: configure-without-libdir-spec
> qbittorrent.src:29: W: rpm-buildroot-usage %build ./configure
> --prefix=$RPM_BUILD_ROOT%{_prefix}
> qbittorrent.src:29: W: configure-without-libdir-spec
> qbittorrent.src: E: description-line-too-long A Bittorrent client using C++ /
> rb_libtorrent and a Qt4 Graphical User Interface.
> 1 packages and 0 specfiles checked; 1 errors, 3 warnings.
>
> * The Warning about missing --libdir usage can be ignored.
>
>
> * Testbuild will need Rawhide (F11 devel):
> Checking for libtorrent-rasterbar >= 0.14 ... no
This isn't possible !
> > ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
>
> This --prefix is wrong. That's too much risk that the buildroot path finds its
> way into compiled/built files. Use --prefix=%{_prefix} only.
I have read the packaging guidelines and found nothing that expressly prohibits
this , so fixing this error isn't mandatory , is this correct ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=484229
Michael Schwendt changed:
What|Removed |Added
CC||bugs.mich...@gmx.net
--- Comment #12 from Michael Schwendt 2009-02-07
17:16:48 EDT ---
* Source0 points to a web page. The following Source0 location actually points
to a wget/curl-downloadable tarball:
http://downloads.sf.net/qbittorrent/qbittorrent-1.3.0.tar.gz
> ./configure --prefix=$RPM_BUILD_ROOT%{_prefix}
This --prefix is wrong. That's too much risk that the buildroot path finds its
way into compiled/built files. Use --prefix=%{_prefix} only.
> gmake %{?_smp_mflags}
"gmake" is a softlink to "make", why not just use "make" from package "make"
then? ;)
> %doc README INSTALL NEWS COPYING AUTHORS TODO Changelog
File "INSTALL" is irrelevant to the package users.
* Run "rpmlint" on your src.rpm and built rpms and apply fixes as appropriate:
$ rpmlint qbittorrent-1.3.0-4.fc10.src.rpm
qbittorrent.src:27: W: configure-without-libdir-spec
qbittorrent.src:29: W: rpm-buildroot-usage %build ./configure
--prefix=$RPM_BUILD_ROOT%{_prefix}
qbittorrent.src:29: W: configure-without-libdir-spec
qbittorrent.src: E: description-line-too-long A Bittorrent client using C++ /
rb_libtorrent and a Qt4 Graphical User Interface.
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
* The Warning about missing --libdir usage can be ignored.
* Testbuild will need Rawhide (F11 devel):
Checking for libtorrent-rasterbar >= 0.14 ... no
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #10 from Rex Dieter 2009-02-05 13:03:44 EDT --- I adjusted the Summary of this bz ticket no longer include "using C++ Qt4", to match the "Summary:" tag in qbittorrent.spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #11 from leigh scott 2009-02-05 13:06:12 EDT --- Here are the new spec and srpm Spec URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_1/qbittorrent.spec SRPM URL: http://dnmouse.org/fedora/qbittorrent_review/review_changes/new_1/qbittorrent-1.3.0-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #9 from leigh scott 2009-02-05 13:00:11 EDT --- (In reply to comment #7) > Adjusting bz Summary to match spec. > What does this mean ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 --- Comment #8 from leigh scott 2009-02-05 12:55:01 EDT --- (In reply to comment #7) > Adjusting bz Summary to match spec. > > If the qBittorrent.desktop file contains MimeTypes= (I assume it does, for > .torrent files), then you probably ought to include scriptlets to update the > system file associations: > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database Yes it does, I will make the necessary changes . [le...@localhost applications]$ cat '/home/leigh/development/rpmbuild/RPMS/x86_64/usr/share/applications/qBittorrent.desktop' [Desktop Entry] Categories=Qt;Network;P2P; Comment=V1.2.0 Exec=qbittorrent %f GenericName=Bittorrent client GenericName[bg]=Торент клиент GenericName[de]=Bittorren Client GenericName[el]=Τορεντ πελάτης GenericName[es]=Cliente Bittorrent GenericName[fr]=Client Bittorrent GenericName[it]=Client Bittorrent GenericName[ja]=Bittorrent クライアント GenericName[ko]=비토렌트 클라이언트 GenericName[nl]=Bittorrent client GenericName[pl]=Klient Bittorrent GenericName[ru]=клиент Bittorrent GenericName[sv]=Bittorrent-klient GenericName[tr]=Bittorrent istemcisi GenericName[uk]=Bittorrent-клієнт GenericName[zh]=Bittorrent之用户 Icon=qbittorrent MimeType=application/x-bittorrent; Name=qBittorrent Name[ko]=큐비토런트 Terminal=false Type=Application X-Desktop-File-Install-Version=0.15 [le...@localhost applications]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 484229] Review Request: qbittorrent - A bittorrent Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Rex Dieter changed: What|Removed |Added Summary|Review Request: Qbittorrent |Review Request: qbittorrent |- A lightweight bittorrent |- A bittorrent Client |Client using C++ Qt4 | Alias||qbittorrent --- Comment #7 from Rex Dieter 2009-02-05 12:50:07 EDT --- Adjusting bz Summary to match spec. If the qBittorrent.desktop file contains MimeTypes= (I assume it does, for .torrent files), then you probably ought to include scriptlets to update the system file associations: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
