[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||0.20091126-3.fc12
 Resolution||ERRATA




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792





--- Comment #11 from Fedora Update System upda...@fedoraproject.org  
2009-12-11 13:15:28 EDT ---
woff-0.20091126-3.fc12 has been pushed to the Fedora 12 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792





--- Comment #12 from Fedora Update System upda...@fedoraproject.org  
2009-12-11 13:34:20 EDT ---
woff-0.20091126-3.fc11 has been pushed to the Fedora 11 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|0.20091126-3.fc12   |0.20091126-3.fc11




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792





--- Comment #9 from Fedora Update System upda...@fedoraproject.org  
2009-12-10 04:34:39 EDT ---
woff-0.20091126-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/woff-0.20091126-3.fc11

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792





--- Comment #10 from Fedora Update System upda...@fedoraproject.org  
2009-12-10 04:34:44 EDT ---
woff-0.20091126-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/woff-0.20091126-3.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


sandeep shedmake sshed...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from sandeep shedmake sshed...@redhat.com  2009-12-09 05:25:29 
EDT ---
New Package CVS Request

Package Name: woff
Short Description: Encoding and Decoding for WOFF file format
Owners: sandeeps, pnemade
Branches: F-11, F-12
InitialCC: i18n-team

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792





--- Comment #6 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-12-09 
05:32:47 EDT ---
Please also put the fonts sig in CC

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792





--- Comment #7 from sandeep shedmake sshed...@redhat.com  2009-12-09 06:14:30 
EDT ---
New Package CVS Request

Package Name: woff
Short Description: Encoding and Decoding for WOFF file format
Owners: sandeeps, pnemade
Branches: F-11, F-12
InitialCC: i18n-team, fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


Kevin Fenzi ke...@tummy.com changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #8 from Kevin Fenzi ke...@tummy.com  2009-12-09 12:44:37 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


sandeep shedmake sshed...@redhat.com changed:

   What|Removed |Added

   Keywords||Reopened
 Status|CLOSED  |ASSIGNED
 CC||sshed...@redhat.com
 Resolution|NOTABUG |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+




--- Comment #4 from Parag AN(पराग) panem...@gmail.com  2009-12-09 02:20:24 
EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=1863928
- rpmlint output for SRPM and for RPM.
woff.i686: W: incoherent-version-in-changelog 0.20091126-2.fc12
['0.20091126-2.fc13', '0.20091126-2']
The last entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.
== can be fixed easily
+ source files match upstream url (sha1sum)
59879f1bdeeafce7fc9d4b51406e80d7a4cd0293  woff-code-latest.zip
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions:
1) I think you can also add woff-2009-10-03.html to %doc as it contains
specification information.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-12-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


Parag pnem...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG




--- Comment #3 from Parag pnem...@redhat.com  2009-12-07 08:14:41 EDT ---
seems no one interested. Closing this review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-11-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


Parag pnem...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(pnem...@redhat.co |
   |m)  |




--- Comment #2 from Parag pnem...@redhat.com  2009-11-29 12:16:50 EDT ---
Thanks for having look at this package.

Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/woff.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/woff-0.20091126-2.fc12.src.rpm

koji build:- http://koji.fedoraproject.org/koji/taskinfo?taskID=1836270

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 541792] Review Request: woff - Encoding and Decoding for Web Open Font Format(Woff)

2009-11-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541792


Nicolas Mailhot nicolas.mail...@laposte.net changed:

   What|Removed |Added

   Flag||needinfo?(pnem...@redhat.co
   ||m)




--- Comment #1 from Nicolas Mailhot nicolas.mail...@laposte.net  2009-11-28 
12:42:53 EDT ---
IMHO woff is a terrible idea, a waste of resources, will only muddy waters, and
I doubt defining a new format just in case ie may want to pick it up sometime
will end up well, but I guess that if this format starts being used in the
field we may as well be able to decode it.

However, this package does not even build in mock

+ umask 022
+ cd /builddir/build/BUILD
+ cd woff-0.20091126
+ LANG=C
+ export LANG
+ unset DISPLAY
+ make 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' -j2
cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic   -c -o sfnt2woff.o sfnt2woff.c
cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic   -c -o woff.o woff.c
cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic   -c -o woff2sfnt.o woff2sfnt.c
woff.c:43:18: error: zlib.h: No such file or directory
woff.c: In function 'woffEncode':
woff.c:255: error: 'uLong' undeclared (first use in this function)
woff.c:255: error: (Each undeclared identifier is reported only once
woff.c:255: error: for each function it appears in.)
woff.c:255: error: expected ';' before 'sourceLen'
woff.c:276: error: 'sourceLen' undeclared (first use in this function)
woff.c:280: error: 'destLen' undeclared (first use in this function)
woff.c:280: warning: implicit declaration of function 'compressBound'
woff.c:287: warning: implicit declaration of function 'compress2'
woff.c:287: error: 'Bytef' undeclared (first use in this function)
woff.c:287: error: expected expression before ')' token
woff.c:288: error: expected ')' before 'Bytef'
woff.c:288: warning: type defaults to 'int' in declaration of 'type name'
woff.c:288: warning: cast from pointer to integer of different size
woff.c:289: error: 'Z_OK' undeclared (first use in this function)
woff.c:135: warning: unused variable 'tableBase'
woff.c: In function 'rebuildWoff':
woff.c:406: warning: unused variable 'tableData'
woff.c: In function 'woffSetMetadata':

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review