[FFmpeg-cvslog] nutdec: stop skipping bytes at EOF

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Wed May 20 00:31:24 2015 +0200| [9c3d306ba43747e17d93504b08127b94fcb31f73] | committer: Michael Niedermayer nutdec: stop skipping bytes at EOF This can unnecessarily waste a lot of time. Reviewed-by: Michael

[FFmpeg-cvslog] rtpenc_jpeg: handle case of picture dimensions not dividing by 8

2015-07-20 Thread Andrey Utkin
ffmpeg | branch: release/2.6 | Andrey Utkin andrey.krieger.ut...@gmail.com | Sat Apr 11 00:54:10 2015 +0300| [4c2a1e673bfd269af9ab5c21483b5b6ec0d14063] | committer: Michael Niedermayer rtpenc_jpeg: handle case of picture dimensions not dividing by 8 This fixes the calculation of the number of

[FFmpeg-cvslog] avformat/nutdec: Return error on EOF from get_str()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed May 20 17:13:15 2015 +0200| [862ba8b4b4d802fef30116e25a726c47e8ae9d86] | committer: Michael Niedermayer avformat/nutdec: Return error on EOF from get_str() Signed-off-by: Michael Niedermayer michae...@gmx.at (cherry

[FFmpeg-cvslog] rtsp: Make sure we don' t write too many transport entries into a fixed-size array

2015-07-20 Thread Martin Storsjö
ffmpeg | branch: release/2.6 | Martin Storsjö mar...@martin.st | Fri Apr 24 12:38:09 2015 +0300| [94a3d2e49caa23f9a9506b226ada1344a91ce24d] | committer: Michael Niedermayer rtsp: Make sure we don't write too many transport entries into a fixed-size array (cherry picked from commit

[FFmpeg-cvslog] avcodec/golomb: get_ur_golomb_jpegls: Fix reading huge k values

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Sun May 17 19:07:17 2015 +0200| [3bb17d2692cd790a7213d49f59032b6810e16a02] | committer: Michael Niedermayer avcodec/golomb: get_ur_golomb_jpegls: Fix reading huge k values Signed-off-by: Michael Niedermayer michae...@gmx.at

[FFmpeg-cvslog] wmalosslessdec: reset frame-nb_samples on packet loss

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Fri Jul 3 00:02:44 2015 +0200| [6d6ca8b82e344ccd59d7236d44feace730c62564] | committer: Michael Niedermayer wmalosslessdec: reset frame-nb_samples on packet loss Otherwise a frame with non-zero nb_samples but

[FFmpeg-cvslog] avcodec/mpegvideo: Clear pointers in ff_mpv_common_init()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Thu Jul 9 22:16:15 2015 +0200| [27a88f9d45d6fbd08796d8edc274a6758b3d170f] | committer: Michael Niedermayer avcodec/mpegvideo: Clear pointers in ff_mpv_common_init() This ensures that no stale pointers leak through on any

[FFmpeg-cvslog] avcodec/alac: Clear pointers in allocate_buffers()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 13 15:46:10 2015 +0200| [0cb600b7bfb7ea1cc333cabce7d5c02a68bb15cb] | committer: Michael Niedermayer avcodec/alac: Clear pointers in allocate_buffers() Fixes:

[FFmpeg-cvslog] avfilter/vf_transpose: Fix rounding error

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Tue Jun 30 16:01:15 2015 +0200| [1ea58c6c6a8884689dd009d40cb21bbb0fa5bb36] | committer: Michael Niedermayer avfilter/vf_transpose: Fix rounding error Fixes out of array access Fixes:

[FFmpeg-cvslog] ffmpeg: Fix cleanup with ost = NULL

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 13 23:33:18 2015 +0200| [fca28d35e4936c1914527fefc7dd2d680201aba7] | committer: Michael Niedermayer ffmpeg: Fix cleanup with ost = NULL Fixes:

[FFmpeg-cvslog] avcodec/sanm: Reset sizes in destroy_buffers()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 13 16:05:21 2015 +0200| [df6f2daccf66954f900be9b785a07d699ab5beda] | committer: Michael Niedermayer avcodec/sanm: Reset sizes in destroy_buffers() Fixes crash in

[FFmpeg-cvslog] swscale/utils: Clear pix buffers

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Wed Jul 15 19:20:19 2015 +0200| [fb47b6cb4b897fad03c6977b20c36a954f3f2de3] | committer: Michael Niedermayer swscale/utils: Clear pix buffers Fixes use of uninitialized memory Fixes:

[FFmpeg-cvslog] avutil/fifo: Fix the case where func() returns less bytes than requested in av_fifo_generic_write()

2015-07-20 Thread Zhang Rui
ffmpeg | branch: release/2.6 | Zhang Rui bbcal...@gmail.com | Tue Jul 14 14:47:26 2015 +0800| [5db095793a28b1fa9b5547394c51edcf273ddb31] | committer: Michael Niedermayer avutil/fifo: Fix the case where func() returns less bytes than requested in av_fifo_generic_write() Signed-off-by: Michael

[FFmpeg-cvslog] swscale/swscale_unscaled: Fix rounding difference with RGBA output between little and big endian

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Mon Jun 29 13:51:43 2015 +0200| [49ad1658b2dbc43c6cfe9fae1455e0c74e26bc2a] | committer: Michael Niedermayer swscale/swscale_unscaled: Fix rounding difference with RGBA output between little and big endian Fixes

[FFmpeg-cvslog] avcodec/pngdec: Require a IHDR chunk before fctl

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Mon Jun 29 21:57:12 2015 +0200| [873b08f4111af41d2456662db86075a450d3ca81] | committer: Michael Niedermayer avcodec/pngdec: Require a IHDR chunk before fctl This is required by the APNG spec Signed-off-by: Michael

[FFmpeg-cvslog] avformat/mov: Fix deallocation when MOVStreamContext failed to allocate

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Tue Jul 14 14:14:16 2015 +0200| [e604662d047606263c0d7b81cccdb992a97cd0df] | committer: Michael Niedermayer avformat/mov: Fix deallocation when MOVStreamContext failed to allocate Fixes:

[FFmpeg-cvslog] ffmpeg: Fix crash with ost-last_frame allocation failure

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Tue Jul 14 13:02:19 2015 +0200| [77eddee375357452ec8e0e22b3cd877b38c0a5e9] | committer: Michael Niedermayer ffmpeg: Fix crash with ost-last_frame allocation failure Fixes:

[FFmpeg-cvslog] ffmpeg: Do not use the data/size of a bitstream filter after failure

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed Jun 24 13:27:39 2015 +0200| [3b136179a3087e0a6c005348407c66898606049d] | committer: Michael Niedermayer ffmpeg: Do not use the data/size of a bitstream filter after failure Found-by: Rodger Combs Signed-off-by: Michael

[FFmpeg-cvslog] oggparsedirac: check return value of init_get_bits

2015-07-20 Thread Chris Watkins
ffmpeg | branch: release/2.6 | Chris Watkins w...@chromium.org | Tue Jul 7 10:23:44 2015 -0700| [77f5302465ca7d9a1d4744cae22f510116d5b2a8] | committer: Michael Niedermayer oggparsedirac: check return value of init_get_bits If init_get_bits fails the GetBitContext is invalid and must not be

[FFmpeg-cvslog] swscale/x86/rgb2rgb_template: fix signedness of v in shuffle_bytes_2103_{mmx, mmxext}

2015-07-20 Thread James Almer
ffmpeg | branch: release/2.6 | James Almer jamr...@gmail.com | Tue Jun 23 01:15:07 2015 -0300| [48127e2ad6e25721dd4a371df897d9f88553abe1] | committer: Michael Niedermayer swscale/x86/rgb2rgb_template: fix signedness of v in shuffle_bytes_2103_{mmx,mmxext} Reviewed-by: Michael Niedermayer

[FFmpeg-cvslog] ffmpeg: Fix cleanup after failed allocation of output_files

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Tue Jul 14 15:49:41 2015 +0200| [7dbfeeeb944893f841345d7f7b2d3039d353f675] | committer: Michael Niedermayer ffmpeg: Fix cleanup after failed allocation of output_files Fixes:

[FFmpeg-cvslog] avcodec/rawenc: Use ff_alloc_packet() instead of ff_alloc_packet2()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Sun Jul 5 20:00:15 2015 +0200| [a4cb97067b4c679a1bc5f8fa5406b81978885e8a] | committer: Michael Niedermayer avcodec/rawenc: Use ff_alloc_packet() instead of ff_alloc_packet2() the later is not optimal when the buffer size is

[FFmpeg-cvslog] Update for 2.6.4

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 20 11:10:34 2015 +0200| [827a8bfc64a49ebcbe84ea1646f621f3e8b3b05c] | committer: Michael Niedermayer Update for 2.6.4 Signed-off-by: Michael Niedermayer mich...@niedermayer.cc

[FFmpeg-cvslog] avcodec/put_bits: Update size_in_bits in set_put_bits_buffer_size()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Mon May 25 04:53:09 2015 +0200| [4947158b1f34c7a1b90cac7a6e205529353af1b6] | committer: Michael Niedermayer avcodec/put_bits: Update size_in_bits in set_put_bits_buffer_size() Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] avformat/wavdec: Increase dts packet threshold to fix more misdetections

2015-07-20 Thread Rodger Combs
ffmpeg | branch: release/2.6 | Rodger Combs rodger.co...@gmail.com | Sat May 23 14:07:14 2015 +0200| [308bcf53f9d6c9c0001f3466e36a1e09a611ed58] | committer: Michael Niedermayer avformat/wavdec: Increase dts packet threshold to fix more misdetections Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] nutdec: fix infinite resync loops

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Wed May 20 00:06:05 2015 +0200| [d4d8c3553d086fd8755d7535367b2e6a8dbb41af] | committer: Michael Niedermayer nutdec: fix infinite resync loops nut-last_syncpoint_pos doesn't necessarily change between resync

[FFmpeg-cvslog] swresample/swresample: Cleanup on init failure.

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Thu Jun 4 03:47:55 2015 +0200| [ed5bfeca04fbd4a09ef8f866eaecb098fe7f4249] | committer: Michael Niedermayer swresample/swresample: Cleanup on init failure. This avoids leaks if the user doest call swr_close() after a failed

[FFmpeg-cvslog] avcodec/atrac3plusdec: consume only as many bytes as available

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Thu Jun 4 22:47:24 2015 +0200| [c2595b448571651c2cb5bbcd43238f6adb2d784c] | committer: Michael Niedermayer avcodec/atrac3plusdec: consume only as many bytes as available Signed-off-by: Michael Niedermayer michae...@gmx.at

[FFmpeg-cvslog] takdec: ensure chan2 is a valid channel index

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Wed Jun 10 00:12:38 2015 +0200| [d15f4f5f22eeca76d224184d4de2fef20a243b3f] | committer: Michael Niedermayer takdec: ensure chan2 is a valid channel index If chan2 is not smaller than the number of channels, it

[FFmpeg-cvslog] avcodec/adpcm: Check for overreads

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Thu Jun 4 22:34:12 2015 +0200| [e354ec95d6bbf602e16f71b2c72c22c77666150c] | committer: Michael Niedermayer avcodec/adpcm: Check for overreads See: vlc ticket 14649 Reported-by: carl Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] avdevice/lavfi: do not rescale AV_NOPTS_VALUE in lavfi_read_packet()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed Jun 10 00:47:43 2015 +0200| [33ec70785f4a0ac3b2f93ef26cd1486e678c2d03] | committer: Michael Niedermayer avdevice/lavfi: do not rescale AV_NOPTS_VALUE in lavfi_read_packet() Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] avcodec/alsdec: Check for overread

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Thu Jun 4 22:59:34 2015 +0200| [2b31264e1a6b4296d691ebd946325a9c33e57766] | committer: Michael Niedermayer avcodec/alsdec: Check for overread Signed-off-by: Michael Niedermayer michae...@gmx.at (cherry picked from commit

[FFmpeg-cvslog] libavutil/softfloat: Fix av_normalize1_sf bias.

2015-07-20 Thread Nedeljko Babic
ffmpeg | branch: release/2.6 | Nedeljko Babic nedeljko.ba...@imgtec.com | Wed Jun 3 16:17:39 2015 +0200| [c8377cc49b2fe1d97836e1f8df4c3490b07612d1] | committer: Michael Niedermayer libavutil/softfloat: Fix av_normalize1_sf bias. av_normalize1_sf doesn't properly address border case when

[FFmpeg-cvslog] mov: abort on EOF in ff_mov_read_chan

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Sat May 23 23:32:12 2015 +0200| [274121179f4050a6c5f6db365d5103eed615613a] | committer: Michael Niedermayer mov: abort on EOF in ff_mov_read_chan Otherwise the loop can take a lot of time if num_descr is very

[FFmpeg-cvslog] matroskadec: validate audio channels and bitdepth

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Mon Jun 15 21:06:51 2015 +0200| [476cf3eb7e6f959bb2afe5959c86cb18f253eb26] | committer: Michael Niedermayer matroskadec: validate audio channels and bitdepth In the TTA extradata re-construction the values are

[FFmpeg-cvslog] swscale/rgb2rgb_template: Disable shuffle_bytes_2103_c on big endian

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Mon Jun 22 22:23:22 2015 +0200| [80cec4e4960bb75c00ac58264bec68bf88f7b3f8] | committer: Michael Niedermayer swscale/rgb2rgb_template: Disable shuffle_bytes_2103_c on big endian The function is specific to little endian

[FFmpeg-cvslog] swscale/rgb2rgb_template: Fix signedness of v in shuffle_bytes_2103_c()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Tue Jun 23 05:09:11 2015 +0200| [e920af2cdf3fb4aca3d95954770a9fa085814975] | committer: Michael Niedermayer swscale/rgb2rgb_template: Fix signedness of v in shuffle_bytes_2103_c() Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] wmalosslessdec: avoid reading 0 bits with get_bits

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Fri Jul 3 00:01:56 2015 +0200| [1ca226989c31c49a7d96ba834679dc26d9b4083a] | committer: Michael Niedermayer wmalosslessdec: avoid reading 0 bits with get_bits Reviewed-by: Michael Niedermayer michae...@gmx.at

[FFmpeg-cvslog] avcodec/aacsbr: Assert that bs_num_env is positive

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed Jul 1 02:08:25 2015 +0200| [4fad45ad146c117197168a39cb0493ffc4fdb60d] | committer: Michael Niedermayer avcodec/aacsbr: Assert that bs_num_env is positive Signed-off-by: Michael Niedermayer michae...@gmx.at (cherry

[FFmpeg-cvslog] vp9/update_prob: prevent out of bounds table read

2015-07-20 Thread James Zern
ffmpeg | branch: release/2.6 | James Zern jz...@google.com | Mon Jun 29 23:03:14 2015 -0700| [002bbc36875dffe0f7e54c67409683bd5756cf5e] | committer: Michael Niedermayer vp9/update_prob: prevent out of bounds table read the max value of the lookup in expanded form is: (((1 7) - 1) 1) - 65 + 1

[FFmpeg-cvslog] avcodec/pngdec: Check values before updating context in decode_fctl_chunk( )

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Mon Jun 29 22:32:02 2015 +0200| [917544b2eace14097b2e4437dc0df972e8016e97] | committer: Michael Niedermayer avcodec/pngdec: Check values before updating context in decode_fctl_chunk() Signed-off-by: Michael Niedermayer

[FFmpeg-cvslog] swresample/dither: check memory allocation

2015-07-20 Thread Ganesh Ajjanagadde
ffmpeg | branch: release/2.6 | Ganesh Ajjanagadde gajjanaga...@gmail.com | Tue Jun 2 23:17:48 2015 -0400| [9d749d69b224542d4d8665518dc2919dac519884] | committer: Michael Niedermayer swresample/dither: check memory allocation check memory allocation in swri_get_dither() Signed-off-by: Michael

[FFmpeg-cvslog] libopenjpegdec: check existence of image component data

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Sat May 30 16:18:48 2015 +0200| [c7ef69c23c01aa23f557d41ebc307554a5432c41] | committer: Michael Niedermayer libopenjpegdec: check existence of image component data libopenjpeg can return images with components

[FFmpeg-cvslog] avcodec/pngdec: Only allow one IHDR chunk

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Mon Jun 29 21:08:05 2015 +0200| [63ef4014c5ff13953025af861976f79c85cf373f] | committer: Michael Niedermayer avcodec/pngdec: Only allow one IHDR chunk Multiple IHDR chunks are forbidden in PNG Fixes inconsistency and out of

[FFmpeg-cvslog] swscale/rgb2rgb_template: Implement shuffle_bytes_0321_c and fix shuffle_bytes_2103_c on BE

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Tue Jun 23 04:36:02 2015 +0200| [12e166dacb544e55dd02b456f8e548be70c0be2e] | committer: Michael Niedermayer swscale/rgb2rgb_template: Implement shuffle_bytes_0321_c and fix shuffle_bytes_2103_c on BE Signed-off-by: Michael

[FFmpeg-cvslog] swscale/x86/rgb2rgb_template: add missing xmm clobbers

2015-07-20 Thread James Almer
ffmpeg | branch: release/2.6 | James Almer jamr...@gmail.com | Tue Jun 23 01:14:16 2015 -0300| [860dc1e19b9998ef29303d4612be15a1b66e9cb3] | committer: Michael Niedermayer swscale/x86/rgb2rgb_template: add missing xmm clobbers Reviewed-by: Michael Niedermayer michae...@gmx.at Signed-off-by:

[FFmpeg-cvslog] avcodec/aacsbr: check that the element type matches before applying SBR

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed Jul 1 02:05:43 2015 +0200| [1674c5beafc4004587a0c7d84e7c94d665cd71e0] | committer: Michael Niedermayer avcodec/aacsbr: check that the element type matches before applying SBR Fixes out of array access Fixes:

[FFmpeg-cvslog] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Sun Jun 28 12:40:12 2015 +0200| [0324008de61b1a3142f57683641bda46fac96dd4] | committer: Michael Niedermayer wmavoice: limit wmavoice_decode_packet return value to packet size Claiming to have decoded more bytes

[FFmpeg-cvslog] vda: unlock the pixel buffer base address.

2015-07-20 Thread Sebastien Zwickert
ffmpeg | branch: release/2.6 | Sebastien Zwickert dilar...@gmail.com | Sat Jun 20 13:19:29 2015 +0200| [be6a569e3ab8e36a63136ce3fe854764efe99e2a] | committer: Michael Niedermayer vda: unlock the pixel buffer base address. The pixel buffer base address is never unlocked this causes a bug with

[FFmpeg-cvslog] avcodec/h264_slice: Use w/h from the AVFrame instead of mb_w/h

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Tue Jun 30 19:37:12 2015 +0200| [11142fb83bb8ca88c4bb80bd110a1dfdc23d978a] | committer: Michael Niedermayer avcodec/h264_slice: Use w/h from the AVFrame instead of mb_w/h Fixes out of array access Fixes:

[FFmpeg-cvslog] arm: only enable setend on ARMv6

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Thu Jun 4 23:07:44 2015 +0200| [b477f97ab984ba31c3c75481b5572f0352ff0772] | committer: Michael Niedermayer arm: only enable setend on ARMv6 Without this check it causes SIGILL crashes on ARMv5. Reviewed-by:

[FFmpeg-cvslog] swresample: Check the return value of resampler-init()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed Jun 3 00:48:29 2015 +0200| [9591f2fe94fc1e218b68d777abaffc3f3670f0a0] | committer: Michael Niedermayer swresample: Check the return value of resampler-init() Signed-off-by: Michael Niedermayer michae...@gmx.at (cherry

[FFmpeg-cvslog] avcodec/h264_slice: Use AVFrame diemensions for grayscale handling

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed Jun 10 11:37:48 2015 +0200| [0afa8a6c859bbcaf38a347647d3945054d76be1f] | committer: Michael Niedermayer avcodec/h264_slice: Use AVFrame diemensions for grayscale handling The AVFrame values are closer to the AVFrame

[FFmpeg-cvslog] avformat/ffmdec: Check ffio_set_buf_size() return value

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Sun Jun 7 14:55:10 2015 +0200| [e21db6e3399ff875828a51d028a4e55814ca09f6] | committer: Michael Niedermayer avformat/ffmdec: Check ffio_set_buf_size() return value Signed-off-by: Michael Niedermayer michae...@gmx.at (cherry

[FFmpeg-cvslog] avcodec/jpeg2000dec: Check that coords match before applying ICT

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Tue Jun 9 00:37:26 2015 +0200| [6b4c6b7ff5c1650e2045ff19ee42f70386cc9168] | committer: Michael Niedermayer avcodec/jpeg2000dec: Check that coords match before applying ICT This avoid potential out of array accesses

[FFmpeg-cvslog] libopenjpegenc: add NULL check for img before accessing it

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Mon Jun 1 00:51:30 2015 +0200| [d6d328c2947c2864267bf913873c7db963e42327] | committer: Michael Niedermayer libopenjpegenc: add NULL check for img before accessing it If opj_image_create fails to allocate an

[FFmpeg-cvslog] libavutil/channel_layout: Correctly return layout when channel specification ends with a trailing ' c'.

2015-07-20 Thread Simon Thelen
ffmpeg | branch: release/2.6 | Simon Thelen ffmpeg-...@c-14.de | Tue Jun 9 04:55:57 2015 +0200| [3c7e41df27e264f4952cda66dbd0a4618021d8c2] | committer: Michael Niedermayer libavutil/channel_layout: Correctly return layout when channel specification ends with a trailing 'c'. Return layout

[FFmpeg-cvslog] vp9: change type of tile_size from unsigned to int64_t

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Sun Jun 7 18:50:43 2015 +0200| [c10871aca817398cdbea39e06f87a85911953bad] | committer: Michael Niedermayer vp9: change type of tile_size from unsigned to int64_t Otherwise the check 'tile_size size' treats a

[FFmpeg-cvslog] sonic: set avctx-channels in sonic_decode_init

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Tue Jun 9 22:41:24 2015 +0200| [3ea15a4547f83b4d7b5b9c408cb02478703730f2] | committer: Michael Niedermayer sonic: set avctx-channels in sonic_decode_init Otherwise it can be 0 in sonic_decode_frame, causing

[FFmpeg-cvslog] avformat: Fix bug in parse_rps for HEVC.

2015-07-20 Thread Deliang Fu
ffmpeg | branch: release/2.6 | Deliang Fu agoals...@gmail.com | Wed Jun 10 12:30:46 2015 +0800| [35e46e74bc2483f3898cf191a26435cd3ddfb086] | committer: Michael Niedermayer avformat: Fix bug in parse_rps for HEVC. Make the logic in libavformat/hevc.c parse_rps align with libavcodec/hevc_ps.c

[FFmpeg-cvslog] ffmpeg_opt: Check for localtime() failure

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Fri Jun 12 15:36:20 2015 +0200| [1c5d25f2c00849a2120a00c2d8c86c07386b93c5] | committer: Michael Niedermayer ffmpeg_opt: Check for localtime() failure Found-by: Daemon404 Signed-off-by: Michael Niedermayer michae...@gmx.at

[FFmpeg-cvslog] examples/demuxing_decoding: use properties from frame instead of video_dec_ctx

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Sun Jun 14 20:34:16 2015 +0200| [7b1c5fa5e5790eb4649287f53f8ade496f596661] | committer: Michael Niedermayer examples/demuxing_decoding: use properties from frame instead of video_dec_ctx This is more robust.

[FFmpeg-cvslog] avio: fix potential crashes when combining ffio_ensure_seekback + crc

2015-07-20 Thread wm4
ffmpeg | branch: release/2.6 | wm4 nfx...@googlemail.com | Wed Jun 17 00:21:02 2015 +0200| [c049e979b60542c53894e812d5921a455b7c16a3] | committer: Michael Niedermayer avio: fix potential crashes when combining ffio_ensure_seekback + crc Calling ffio_ensure_seekback() if ffio_init_checksum()

[FFmpeg-cvslog] ffmpeg: Free last_frame instead of just unref

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Thu Jun 18 05:27:08 2015 +0200| [a5e8ca7e73f8aa7eade5541b6ca3cee66cff7cf0] | committer: Michael Niedermayer ffmpeg: Free last_frame instead of just unref Fixes Ticket4611 Signed-off-by: Michael Niedermayer michae...@gmx.at

[FFmpeg-cvslog] h264: er: Copy from the previous reference only if compatible

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Sun Jun 14 12:40:18 2015 +0200| [008229b7f978593392e1238eb6a6041a8d9b56c6] | committer: Michael Niedermayer h264: er: Copy from the previous reference only if compatible Also use the frame pixel format instead

[FFmpeg-cvslog] postproc: fix unaligned access

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Thu Jun 18 20:15:12 2015 +0200| [cd85dd1373d636e810dad84ef297ed2827782630] | committer: Michael Niedermayer postproc: fix unaligned access QP_store is only 8-bit-aligned, so accessing it as uint32_t causes

[FFmpeg-cvslog] vp8: change mv_{min,max}.{x,y} type to int

2015-07-20 Thread Andreas Cadhalpun
ffmpeg | branch: release/2.6 | Andreas Cadhalpun andreas.cadhal...@googlemail.com | Mon Jun 8 22:38:29 2015 +0200| [31dd78363138bae0d2d36cd114cd9384acbfa6dd] | committer: Michael Niedermayer vp8: change mv_{min,max}.{x,y} type to int If one of the dimensions is larger than 8176, s-mb_width or

[FFmpeg-cvslog] avcodec/dpxenc: implement write16/32 as functions

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Fri Jun 19 16:46:06 2015 +0200| [47e950848599d3196860b1984a43ca6fd5429ecc] | committer: Michael Niedermayer avcodec/dpxenc: implement write16/32 as functions Fixes undefined behavior and segfault Signed-off-by: Michael

[FFmpeg-cvslog] avfilter/af_aresample: Check ff_all_* for allocation failures

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Fri Jul 17 20:27:25 2015 +0200| [b7f1d51b9c1162c71c8abeaa77df88de73c74742] | committer: Michael Niedermayer avfilter/af_aresample: Check ff_all_* for allocation failures Fixes:

[FFmpeg-cvslog] avcodec/vp8: Fix null pointer dereference in ff_vp8_decode_free()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Sat Jul 18 19:02:26 2015 +0200| [e3a521d817cb7d36acc6e1e7cda8d6a70e967be6] | committer: Michael Niedermayer avcodec/vp8: Fix null pointer dereference in ff_vp8_decode_free() Fixes:

[FFmpeg-cvslog] bytestream2: set the reader to the end when reading more than available

2015-07-20 Thread Anton Khirnov
ffmpeg | branch: release/2.6 | Anton Khirnov an...@khirnov.net | Fri Jul 10 09:31:24 2015 +0200| [c5c141bc699f9b6f2e5613bc826b0943b70e1011] | committer: Michael Niedermayer bytestream2: set the reader to the end when reading more than available This prevents possible infinite loops with the

[FFmpeg-cvslog] avcodec/vp8: Check buffer size in vp8_decode_frame_header()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Sat Jul 18 19:18:24 2015 +0200| [e8ce2770b12ad8d1dfb9adce66b6fd3fc560aeda] | committer: Michael Niedermayer avcodec/vp8: Check buffer size in vp8_decode_frame_header() avoids null pointer dereference Fixes:

[FFmpeg-cvslog] avformat/nutdec: Fix recovery when immedeately after seeking a failure happens

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Wed May 20 17:32:48 2015 +0200| [627040156193a48415761d61be27491c74e0119b] | committer: Michael Niedermayer avformat/nutdec: Fix recovery when immedeately after seeking a failure happens Found-by: Andreas Cadhalpun

[FFmpeg-cvslog] avcodec/utils: use a minimum 32pixel width in avcodec_align_dimensions2() for H.264

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer michae...@gmx.at | Fri Jul 10 02:01:17 2015 +0200| [6c98d5e7c83f18f8e9b65c0214d5593c0436a473] | committer: Michael Niedermayer avcodec/utils: use a minimum 32pixel width in avcodec_align_dimensions2() for H.264 Fixes Assertion failure

[FFmpeg-cvslog] avcodec/diracdec: Check for hpel_base allocation failure

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Sat Jul 18 17:55:19 2015 +0200| [0de6cf5fdd9e1d89f5259eb0cc0795e424cfa6af] | committer: Michael Niedermayer avcodec/diracdec: Check for hpel_base allocation failure Fixes null pointer dereference Fixes:

[FFmpeg-cvslog] avcodec/rv34: Clear pointers in ff_rv34_decode_init_thread_copy()

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Sat Jul 18 11:24:45 2015 +0200| [620b3e680c388af7dd4a2ef2eb9544dc9cbdc092] | committer: Michael Niedermayer avcodec/rv34: Clear pointers in ff_rv34_decode_init_thread_copy() Avoids leaving stale pointers Fixes:

[FFmpeg-cvslog] avcodec/pthread_frame: clear priv_data, avoid stale pointer in error case

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: release/2.6 | Michael Niedermayer mich...@niedermayer.cc | Thu Jul 16 11:52:33 2015 +0200| [ed6d8e185a4e8145b68a48e946b9bd22fc4efce5] | committer: Michael Niedermayer avcodec/pthread_frame: clear priv_data, avoid stale pointer in error case Fixes:

[FFmpeg-cvslog] avcodec: loongson constants redefined with macros

2015-07-20 Thread 周晓勇
ffmpeg | branch: master | 周晓勇 zhouxiaoy...@loongson.cn | Mon Jul 20 11:25:48 2015 +0800| [4bd619339762258949c0a90189be83a1d6fa226b] | committer: Michael Niedermayer avcodec: loongson constants redefined with macros Signed-off-by: ZhouXiaoyong zhouxiaoy...@loongson.cn Signed-off-by: Michael

[FFmpeg-cvslog] avcodec: loongson relocate constants of idctdsp and h264pred

2015-07-20 Thread 周晓勇
ffmpeg | branch: master | 周晓勇 zhouxiaoy...@loongson.cn | Mon Jul 20 13:45:49 2015 +0800| [fdac5ff682f0c8070e5be39a44dd0f29bd0fa435] | committer: Michael Niedermayer avcodec: loongson relocate constants of idctdsp and h264pred Signed-off-by: Michael Niedermayer mich...@niedermayer.cc

[FFmpeg-cvslog] avcodec/apngdec: Fix typos in decoder causing incorrect results

2015-07-20 Thread Donny Yang
ffmpeg | branch: master | Donny Yang w...@kota.moe | Sun Jul 19 20:20:56 2015 +| [0030613d6925406bfef8e1b206bf9731f53c8ccc] | committer: Paul B Mahol avcodec/apngdec: Fix typos in decoder causing incorrect results Signed-off-by: Donny Yang w...@kota.moe

[FFmpeg-cvslog] Adding myself as maintainer for qsv*

2015-07-20 Thread Ivan Uskov
ffmpeg | branch: master | Ivan Uskov ivan.us...@nablet.com | Fri Jul 17 04:38:57 2015 -0400| [fec0485c43803172ef11b5fcd06e70500fc9dfe6] | committer: Michael Niedermayer Adding myself as maintainer for qsv* Signed-off-by: Michael Niedermayer mich...@niedermayer.cc

[FFmpeg-cvslog] x86/vf_ssim: fix some instruction comments

2015-07-20 Thread James Almer
ffmpeg | branch: master | James Almer jamr...@gmail.com | Mon Jul 20 00:50:10 2015 -0300| [e1778fb657ca56da517cbe2296317178484b05f9] | committer: James Almer x86/vf_ssim: fix some instruction comments Reviewed-by: Michael Niedermayer michae...@gmx.at Signed-off-by: James Almer jamr...@gmail.com

[FFmpeg-cvslog] libavcodec/qsvdec.c: missed MFXVideoDECODE_Close() call

2015-07-20 Thread Ivan Uskov
ffmpeg | branch: master | Ivan Uskov ivan.us...@nablet.com | Mon Jul 20 09:48:29 2015 -0400| [264ba3d847f93a5be8989d139a6bd4abce195304] | committer: Michael Niedermayer libavcodec/qsvdec.c: missed MFXVideoDECODE_Close() call Signed-off-by: Michael Niedermayer mich...@niedermayer.cc

[FFmpeg-cvslog] avcodec: Implementation of AAC_fixed_decoder (SBR-module)

2015-07-20 Thread Djordje Pesut
ffmpeg | branch: master | Djordje Pesut djordje.pe...@imgtec.com | Mon Jul 20 13:36:17 2015 +0200| [f85bc147fb87de048ccc5767e186ac59ec0284ef] | committer: Michael Niedermayer avcodec: Implementation of AAC_fixed_decoder (SBR-module) Add fixed poind code. Signed-off-by: Nedeljko Babic

[FFmpeg-cvslog] avutil/arm/intmath: return int for uint8 / uint16 clip

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: master | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 20 17:16:20 2015 +0200| [d82d11397f613f8881328585b7442f29aec462c1] | committer: Michael Niedermayer avutil/arm/intmath: return int for uint8 / uint16 clip The C functions return uint8/16_t but that is effectively

[FFmpeg-cvslog] configure: check for erf() and copysign()

2015-07-20 Thread James Almer
ffmpeg | branch: master | James Almer jamr...@gmail.com | Mon Jul 20 04:04:46 2015 -0300| [736a3860555adb4e786c45c294c3ef7ccc8ba1f7] | committer: James Almer configure: check for erf() and copysign() They are not available on some compilers. Reviewed-by: Michael Niedermayer michae...@gmx.at

[FFmpeg-cvslog] x86/vf_ssim: add ff_ssim_4x4_line_xop

2015-07-20 Thread James Almer
ffmpeg | branch: master | James Almer jamr...@gmail.com | Mon Jul 20 00:50:52 2015 -0300| [e3851169eedce6c90534ca41edf3e05e2576453e] | committer: James Almer x86/vf_ssim: add ff_ssim_4x4_line_xop ~20% faster than ssse3. Also enabled for x86_32 Reviewed-by: Ronald S. Bultje rsbul...@gmail.com

[FFmpeg-cvslog] avcodec: Table creation for AAC_fixed_decoder (SBR-module)

2015-07-20 Thread Jovan Zelincevic
ffmpeg | branch: master | Jovan Zelincevic jovan.zelince...@imgtec.com | Mon Jul 20 13:36:16 2015 +0200| [b0414da90d6da34144ad9dadd5445fe62cf755a6] | committer: Michael Niedermayer avcodec: Table creation for AAC_fixed_decoder (SBR-module) Create tables for fixed point code. Signed-off-by:

[FFmpeg-cvslog] Gather all coded_frame allocations and free functions to a single place

2015-07-20 Thread Vittorio Giovara
ffmpeg | branch: master | Vittorio Giovara vittorio.giov...@gmail.com | Wed Jul 15 18:41:20 2015 +0100| [d6604b29ef544793479d7fb4e05ef6622bb3e534] | committer: Vittorio Giovara Gather all coded_frame allocations and free functions to a single place Allocating coded_frame is what most encoders

[FFmpeg-cvslog] Merge commit 'd6604b29ef544793479d7fb4e05ef6622bb3e534'

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: master | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 20 22:59:45 2015 +0200| [b1fad7ac200d0779a44fc267085d7d46ce2391b9] | committer: Michael Niedermayer Merge commit 'd6604b29ef544793479d7fb4e05ef6622bb3e534' * commit 'd6604b29ef544793479d7fb4e05ef6622bb3e534':

[FFmpeg-cvslog] Merge commit '91f9b6579ac684c4b51c4cd0dbaed0a4f8295edf'

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: master | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 20 22:36:18 2015 +0200| [439c9760b046caaffceacc08c40692f2e8cb3f03] | committer: Michael Niedermayer Merge commit '91f9b6579ac684c4b51c4cd0dbaed0a4f8295edf' * commit '91f9b6579ac684c4b51c4cd0dbaed0a4f8295edf':

[FFmpeg-cvslog] ffv1enc: Use input frame to set SAR and interlacing

2015-07-20 Thread Vittorio Giovara
ffmpeg | branch: master | Vittorio Giovara vittorio.giov...@gmail.com | Wed Jul 15 18:41:18 2015 +0100| [75c1ed2e4c7250f5e75a11d0140727054ff0136b] | committer: Vittorio Giovara ffv1enc: Use input frame to set SAR and interlacing

[FFmpeg-cvslog] flashsvenc: Keep coded_frame.key_frame a write-only variable

2015-07-20 Thread Vittorio Giovara
ffmpeg | branch: master | Vittorio Giovara vittorio.giov...@gmail.com | Wed Jul 15 18:41:19 2015 +0100| [91f9b6579ac684c4b51c4cd0dbaed0a4f8295edf] | committer: Vittorio Giovara flashsvenc: Keep coded_frame.key_frame a write-only variable

[FFmpeg-cvslog] Merge commit '95e2317ed85502dd8d96bcd9b12084dbfb8f9e8e'

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: master | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 20 21:31:42 2015 +0200| [6497aab022bf791f43a22d1ef2171994ef8e8980] | committer: Michael Niedermayer Merge commit '95e2317ed85502dd8d96bcd9b12084dbfb8f9e8e' * commit '95e2317ed85502dd8d96bcd9b12084dbfb8f9e8e':

[FFmpeg-cvslog] libxvid: Do not entangle coded_frame

2015-07-20 Thread Vittorio Giovara
ffmpeg | branch: master | Vittorio Giovara vittorio.giov...@gmail.com | Wed Jul 15 18:41:13 2015 +0100| [7fc8d8a1b3da1666176b3d92e989ee74f3ef014e] | committer: Vittorio Giovara libxvid: Do not entangle coded_frame

[FFmpeg-cvslog] Merge commit '7fc8d8a1b3da1666176b3d92e989ee74f3ef014e'

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: master | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 20 22:01:41 2015 +0200| [70c648db8948b11a86699f22e883b7310ccae6ce] | committer: Michael Niedermayer Merge commit '7fc8d8a1b3da1666176b3d92e989ee74f3ef014e' * commit '7fc8d8a1b3da1666176b3d92e989ee74f3ef014e':

[FFmpeg-cvslog] libvpxenc: Do not entangle coded_frame

2015-07-20 Thread Vittorio Giovara
ffmpeg | branch: master | Vittorio Giovara vittorio.giov...@gmail.com | Wed Jul 15 18:41:14 2015 +0100| [d6006dd9f0d4d01023359230212f1f9fa4800e5b] | committer: Vittorio Giovara libvpxenc: Do not entangle coded_frame Keep coded_frame.key_frame a write-only variable.

[FFmpeg-cvslog] mpegvideo_enc: Drop unnneded initialization

2015-07-20 Thread Vittorio Giovara
ffmpeg | branch: master | Vittorio Giovara vittorio.giov...@gmail.com | Wed Jul 15 18:41:08 2015 +0100| [1f171de8cae9d0c527c5f0bae2a597dbd65fd3a4] | committer: Vittorio Giovara mpegvideo_enc: Drop unnneded initialization coded_frame is already initialized where needed.

[FFmpeg-cvslog] Merge commit '1f171de8cae9d0c527c5f0bae2a597dbd65fd3a4'

2015-07-20 Thread Michael Niedermayer
ffmpeg | branch: master | Michael Niedermayer mich...@niedermayer.cc | Mon Jul 20 21:20:46 2015 +0200| [16b68bd2ee5f36194b0bd9accc87a62a4b6048d2] | committer: Michael Niedermayer Merge commit '1f171de8cae9d0c527c5f0bae2a597dbd65fd3a4' * commit '1f171de8cae9d0c527c5f0bae2a597dbd65fd3a4':

[FFmpeg-cvslog] roqvideoenc: Drop unneeded initialization

2015-07-20 Thread Vittorio Giovara
ffmpeg | branch: master | Vittorio Giovara vittorio.giov...@gmail.com | Wed Jul 15 18:41:09 2015 +0100| [95e2317ed85502dd8d96bcd9b12084dbfb8f9e8e] | committer: Vittorio Giovara roqvideoenc: Drop unneeded initialization Its fields are never initialized to begin with.

  1   2   >