Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 07:34:50AM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 12:01:51AM +0200, Michael Niedermayer wrote: On Wed, Aug 20, 2014 at 11:30:27PM +0200, Clément Bœsch wrote: --- doc/APIchanges| 2 +- libavutil/motion_vector.h | 8

Re: [FFmpeg-devel] Filters

2014-08-21 Thread Clément Bœsch
On Mon, Aug 18, 2014 at 06:51:41PM +0100, JULIAN GARDNER wrote: [...] Thanks for this, its 99% what i need apart from I lose the audio on the [vid] output. I want the small picture [160x100] output without audio and the 640x360 output with audio Commandlineffmpeg -threads 0 -i

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_lenscorrection: get rid of floats i init code

2014-08-21 Thread Daniel Oberhoff
--- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 20, 2014, at 4:20 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Aug 20, 2014 at 03:48:39PM +0200, Daniel Oberhoff wrote: --- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 20, 2014, at 3:11 PM, Michael

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 09:32:29AM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 07:34:50AM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 12:01:51AM +0200, Michael Niedermayer wrote: On Wed, Aug 20, 2014 at 11:30:27PM +0200, Clément Bœsch wrote: --- doc/APIchanges

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_lenscorrection: get rid of floats i init code

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 10:41:57AM +0200, Daniel Oberhoff wrote: --- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 20, 2014, at 4:20 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Aug 20, 2014 at 03:48:39PM +0200, Daniel Oberhoff wrote: --- Daniel Oberhoff

[FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Tsukasa OMOTO
Hello, I added support of ARIB subtitles to mpegts in libavformat. Regards, Tsukasa. 0001-mpegts-support-ARIB-subtitles-in-libavformat.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Carl Eugen Hoyos
Tsukasa OMOTO henry0312 at gmail.com writes: I added support of ARIB subtitles to mpegts in libavformat. Shouldn't you add ARIB to DESC_types[]? Could you provide samples for both types? (Ideally even for all stream_identifiers but I guess this isn't possible.) Carl Eugen

[FFmpeg-devel] [PATCH] imc: reject files with unfathomable sampling rates

2014-08-21 Thread Christophe Gisquet
Hi, ticket #3868 is about a fuzzed file containing a weird sampling rate. richardpl (?) suggestion is perfectly fine in my opinion. I didn't put one, but don't hesitate to put the proper -by. -- Christophe From 412a719ac4ab830ddc35b3d7e99fab2ccb543279 Mon Sep 17 00:00:00 2001 From: Christophe

[FFmpeg-devel] [PATCH] avfilter/vf_lenscorrection: add assert to ensure there are not more planes than the correction array is large

2014-08-21 Thread Michael Niedermayer
Exceeding the count would write out of array, and should not occur with any current pixel format Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavfilter/vf_lenscorrection.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_lenscorrection.c

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector.h: fix coordinate types

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 11:42:53AM +0200, Michael Niedermayer wrote: On Thu, Aug 21, 2014 at 09:32:29AM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 07:34:50AM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 12:01:51AM +0200, Michael Niedermayer wrote: On Wed, Aug 20, 2014 at

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lenscorrection: add assert to ensure there are not more planes than the correction array is large

2014-08-21 Thread Daniel Oberhoff
--- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 21, 2014, at 12:34 PM, Michael Niedermayer michae...@gmx.at wrote: Exceeding the count would write out of array, and should not occur with any current pixel format Signed-off-by: Michael Niedermayer michae...@gmx.at ---

[FFmpeg-devel] [PATCH]Fail in h264 nal unit decoding if slice header decoding failed

2014-08-21 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #3873 here, I don't know if it has any unexpected side-effects. Please review, Carl Eugen diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 389307b..2b299bc 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -1585,8 +1585,11 @@ again:

[FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Christophe Gisquet
Hi, the fuzzed file from ticket #3866 somehow ends on reading a dref atom, where a size element is not validated. The reading then skips that arbitrary amount without reporting an issue. I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to

[FFmpeg-devel] [PATCH] mark null encoder as ts-nonstrict , avoids error messages for null output

2014-08-21 Thread compn
https://gist.github.com/anonymous/0e26f490ec13d67996fd commit e94a44543a96b13aa6a23efce2f0378a5479d530 Author: Rodger Combs rodger.co...@gmail.com Date: Wed Aug 20 15:38:12 2014 -0700 avformat/nullenc: mark null as timestamp-nonstrict This avoids unnecessary error messages for null

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread compn
On Thu, 21 Aug 2014 10:26:18 + (UTC) Carl Eugen Hoyos ceho...@ag.or.at wrote: Could you provide samples for both types? uploaded to incoming/private-aribu_sub_sample.ts -compn ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 11:23:41AM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: I thought the purpose is to allow educated developers to use pkg-config while (uneducated) users (like me) will not understand how this is easier than using configure parameters.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lenscorrection: add assert to ensure there are not more planes than the correction array is large

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 12:57:08PM +0200, Daniel Oberhoff wrote: --- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 21, 2014, at 12:34 PM, Michael Niedermayer michae...@gmx.at wrote: Exceeding the count would write out of array, and should not occur with any current pixel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lenscorrection: add assert to ensure there are not more planes than the correction array is large

2014-08-21 Thread Daniel Oberhoff
--- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 21, 2014, at 1:52 PM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Aug 21, 2014 at 12:57:08PM +0200, Daniel Oberhoff wrote: --- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 21, 2014, at 12:34 PM, Michael

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lenscorrection: add assert to ensure there are not more planes than the correction array is large

2014-08-21 Thread Daniel Oberhoff
--- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 21, 2014, at 1:53 PM, Daniel Oberhoff daniel.oberh...@gmail.com wrote: --- Daniel Oberhoff daniel.oberh...@gmail.com On Aug 21, 2014, at 1:52 PM, Michael Niedermayer michae...@gmx.at wrote: On Thu, Aug 21, 2014 at

Re: [FFmpeg-devel] [PATCH] mark null encoder as ts-nonstrict , avoids error messages for null output

2014-08-21 Thread Hendrik Leppkes
On Thu, Aug 21, 2014 at 1:38 PM, compn te...@mi.rr.com wrote: https://gist.github.com/anonymous/0e26f490ec13d67996fd commit e94a44543a96b13aa6a23efce2f0378a5479d530 Author: Rodger Combs rodger.co...@gmail.com Date: Wed Aug 20 15:38:12 2014 -0700 avformat/nullenc: mark null as

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Hendrik Leppkes
On Thu, Aug 21, 2014 at 1:49 PM, Tsukasa OMOTO henry0...@gmail.com wrote: Hi, Carl Shouldn't you add ARIB to DESC_types[]? I don't know which ISO_types or DESC_types I should add to. Do you think DESC_types is better? Tsukasa ISO defines id 0x6 as a generic type for private data, its

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Carl Eugen Hoyos
Tsukasa OMOTO henry0312 at gmail.com writes: Shouldn't you add ARIB to DESC_types[]? I don't know which ISO_types or DESC_types I should add to. Do you think DESC_types is better? I probably mixed up stream descriptions and stream identifiers, so ignore this suggestion. But I believe you

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 12:16:35PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: [...] Sorry, I seem to have lost track of what you fear will not work if pkg-config is used for x264 detection but will fallback to the current system if pkg-config does not find the

Re: [FFmpeg-devel] [PATCH] imc: reject files with unfathomable sampling rates

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 12:32:52PM +0200, Christophe Gisquet wrote: Hi, ticket #3868 is about a fuzzed file containing a weird sampling rate. richardpl (?) suggestion is perfectly fine in my opinion. I didn't put one, but don't hesitate to put the proper -by. added -- Christophe

Re: [FFmpeg-devel] [PATCH 2/3] wavpackenc: report too small buffer

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-19 18:28 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com: 2014-08-19 16:20 GMT+02:00 Nicolas George geo...@nsup.org: IMHO, the correct error depends on how sure you are that a buffer too small SHOULD not happen. If you are very sure, then av_assert0(). That would be

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 02:24:40PM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 12:16:35PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: [...] Sorry, I seem to have lost track of what you fear will not work if pkg-config is used for x264 detection but

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Tsukasa ŌMOTO
But I believe you should simply remove the hunk that sets ISO_types for ARIB. updated the patch. Like this? 0001-mpegts-support-ARIB-subtitles-in-libavformat.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Derek Buitenhuis
On 8/21/2014 12:09 PM, Christophe Gisquet wrote: I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop from Elemental seems to include completely rewritten dref code -- is it worth

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Scott Leno
On Aug 21, 2014 8:07 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: ISO defines id 0x6 as a generic type for private data, its certainly not specified by ISO for ARIB subtitles. I wonder if adding this might run into problems at some point though, if something elses uses 0x6. I have seen

Re: [FFmpeg-devel] [PATCH] set bitrate from rc_max_rate for duration estimation will fix ticket #3678

2014-08-21 Thread Marc-Antoine ARNAUD
I have analysed a little more of code, and in fact the duration was not present in the MXF. It's for this reason who we pass in the estimation based on the bitrate. You can see here the selection of the method: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/utils.c#L2458 About the max

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread Hendrik Leppkes
On Thu, Aug 21, 2014 at 12:42 AM, James Almer jamr...@gmail.com wrote: * Reduced xmm register count to 7 (As such they are now enabled for x86_32). * Removed four movdqa (affects the sse2 version only). * pxor is now used to clear m0 only once. ~5% faster. Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-21 14:55 GMT+02:00 Derek Buitenhuis derek.buitenh...@gmail.com: On 8/21/2014 12:09 PM, Christophe Gisquet wrote: I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop

[FFmpeg-devel] [PATCH 1/2] avcodec/h264: do proper cleanup in ff_h264_alloc_tables() in case DPB alloc fails

2014-08-21 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/h264.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 389307b..5082c14 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -473,7 +473,7 @@ int

[FFmpeg-devel] [PATCH 2/2] avcodec/h264_slice: More complete cleanup in h264_slice_header_init()

2014-08-21 Thread Michael Niedermayer
Fixes null pointer dereference Fixes Ticket3873 Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/h264_slice.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index fc744f2..c5a9784 100644

Re: [FFmpeg-devel] [PATCH]Fail in h264 nal unit decoding if slice header decoding failed

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 01:09:06PM +0200, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #3873 here, I don't know if it has any unexpected side-effects. Please review, Carl Eugen posted an altenative patch [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 01:55:05PM +0100, Derek Buitenhuis wrote: On 8/21/2014 12:09 PM, Christophe Gisquet wrote: I'm not sure it is the best fix, but I don't think this could happen in any valid file, nor it would help to swallow the error. Perhaps off-topic, but the source drop from

Re: [FFmpeg-devel] [PATCH] lavfi/apad: fix logic when whole_len or pad_len options are specified

2014-08-21 Thread Stefano Sabatini
On date Wednesday 2014-08-20 15:36:26 +0200, Michael Niedermayer encoded: On Wed, Aug 20, 2014 at 12:43:22PM +0200, Stefano Sabatini wrote: On date Tuesday 2014-08-19 01:29:42 +0200, Michael Niedermayer encoded: On Mon, Aug 18, 2014 at 02:53:45PM +0200, Stefano Sabatini wrote: ---

Re: [FFmpeg-devel] [PATCH] doc/filters/apad: extend documentation

2014-08-21 Thread Stefano Sabatini
On date Wednesday 2014-08-20 12:44:15 +0200, Stefano Sabatini encoded: On date Monday 2014-08-18 14:53:52 +0200, Stefano Sabatini encoded: --- doc/filters.texi | 47 +-- 1 file changed, 45 insertions(+), 2 deletions(-) Up. -- FFmpeg =

Re: [FFmpeg-devel] [PATCH] mov: better check dref atome validity

2014-08-21 Thread Derek Buitenhuis
On 8/21/2014 4:13 PM, Michael Niedermayer wrote: can you provide a link ? Provided on IRC. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mark null encoder as ts-nonstrict , avoids error messages for null output

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 02:00:22PM +0200, Hendrik Leppkes wrote: On Thu, Aug 21, 2014 at 1:38 PM, compn te...@mi.rr.com wrote: https://gist.github.com/anonymous/0e26f490ec13d67996fd commit e94a44543a96b13aa6a23efce2f0378a5479d530 Author: Rodger Combs rodger.co...@gmail.com Date: Wed

[FFmpeg-devel] [PATCH] avformat/mov: use 64bit for size in mov_skip_multiple_stsd()

2014-08-21 Thread Michael Niedermayer
Fixes integer overflow Fixes Ticket 3866 Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/mov.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1255824..b3eb287 100644 --- a/libavformat/mov.c +++

Re: [FFmpeg-devel] [PATCH] avformat/mov: use 64bit for size in mov_skip_multiple_stsd()

2014-08-21 Thread Christophe Gisquet
2014-08-21 17:43 GMT+02:00 Michael Niedermayer michae...@gmx.at: static int mov_skip_multiple_stsd(MOVContext *c, AVIOContext *pb, int codec_tag, int format, - int size) + int64_t size) Nice

Re: [FFmpeg-devel] [PATCH 2/3] wavpackenc: report too small buffer

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 02:32:46PM +0200, Christophe Gisquet wrote: Hi, 2014-08-19 18:28 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com: 2014-08-19 16:20 GMT+02:00 Nicolas George geo...@nsup.org: IMHO, the correct error depends on how sure you are that a buffer too small

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread James Almer
On 21/08/14 10:03 AM, Hendrik Leppkes wrote: On Thu, Aug 21, 2014 at 12:42 AM, James Almer jamr...@gmail.com wrote: * Reduced xmm register count to 7 (As such they are now enabled for x86_32). * Removed four movdqa (affects the sse2 version only). * pxor is now used to clear m0 only once.

Re: [FFmpeg-devel] [RFC] [PATCH] hevc_ps: reorder SPS reading to allow some errors

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-21 3:06 GMT+02:00 Michael Niedermayer michae...@gmx.at: heres a narrower solution for this file not sure its better i can apply whichever you prefer, probably we wont find out which is the best solution before pushing something and waiting for more bug reports Thanks for

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-21 0:42 GMT+02:00 James Almer jamr...@gmail.com: * Reduced xmm register count to 7 (As such they are now enabled for x86_32). * Removed four movdqa (affects the sse2 version only). * pxor is now used to clear m0 only once. OK. -- Christophe

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 09:42:30PM +0900, Tsukasa ŌMOTO wrote: But I believe you should simply remove the hunk that sets ISO_types for ARIB. updated the patch. Like this? libavcodec/avcodec.h|2 ++ libavcodec/codec_desc.c | 14 ++ libavformat/mpegts.c| 34

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread James Almer
On 21/08/14 2:15 PM, Christophe Gisquet wrote: Hi, 2014-08-21 0:42 GMT+02:00 James Almer jamr...@gmail.com: * Reduced xmm register count to 7 (As such they are now enabled for x86_32). * Removed four movdqa (affects the sse2 version only). * pxor is now used to clear m0 only once. OK.

Re: [FFmpeg-devel] [RFC] [PATCH] hevc_ps: reorder SPS reading to allow some errors

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 07:14:03PM +0200, Christophe Gisquet wrote: Hi, 2014-08-21 3:06 GMT+02:00 Michael Niedermayer michae...@gmx.at: heres a narrower solution for this file not sure its better i can apply whichever you prefer, probably we wont find out which is the best solution

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread Kieran Kunhya
It does that, but on older SSE2 cpus with not-so-good OOO execution grouping instructions like this might help reduce dependencies a bit. Are any older SSE2 CPUs actually capable of decoding reasonable HEVC? ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH v2] libavformat/ftp: Do not leak memory in routine ftp_features

2014-08-21 Thread Alexander Strasser
Setting the pointer to NULL inside both ftp_send_command and ftp_features is redundant. Generally always setting to NULL in ftp_send_command seems safer, but throughout the file that parameter was always passed initialized. So I do it here too for consistency. Should fix CID1231988

Re: [FFmpeg-devel] [PATCH] mpegts: support ARIB subtitles in libavformat

2014-08-21 Thread Kieran Kunhya
On 21 August 2014 13:55, Scott Leno ffm...@scottleno.net wrote: On Aug 21, 2014 8:07 AM, Hendrik Leppkes h.lepp...@gmail.com wrote: ISO defines id 0x6 as a generic type for private data, its certainly not specified by ISO for ARIB subtitles. I wonder if adding this might run into problems at

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread James Almer
On 21/08/14 5:40 PM, Kieran Kunhya wrote: It does that, but on older SSE2 cpus with not-so-good OOO execution grouping instructions like this might help reduce dependencies a bit. Are any older SSE2 CPUs actually capable of decoding reasonable HEVC? Probably not (at least nothing above dvd

Re: [FFmpeg-devel] [PATCH] libavformat/ftp: Do not leak memory in routine ftp_features

2014-08-21 Thread Alexander Strasser
On 2014-08-20 06:27 +0200, Alexander Strasser wrote: On 2014-08-20 01:25 +0200, Alexander Strasser wrote: Should fix CID1231988 (RESOURCE_LEAK) Signed-off-by: Alexander Strasser eclip...@gmx.net --- WARNING: Sorry, I only compile-tested so far. There is one remaining thing, I

Re: [FFmpeg-devel] [PATCH] Disable chunked output for Icecast

2014-08-21 Thread Michael Niedermayer
On Wed, Aug 20, 2014 at 10:31:39AM +0300, Maksym Veremeyenko wrote: hi, attached patch fix input stream detection by Icecast that do not understand chunked http input. how can this issue/bug be reproduced ? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 1/5] dpxenc: fix padding in encode_gbrp12

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 02:11:17PM +0200, Christophe Gisquet wrote: Hi, 2014-08-20 11:35 GMT+02:00 James Darnley james.darn...@gmail.com: (In an effort to help review...) This does move from per-pixel to per-line so if this is supposed to be correct then it looks good to me. Yes,

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_slice: More complete cleanup in h264_slice_header_init()

2014-08-21 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: Fixes null pointer dereference Fixes Ticket3873 Thank you! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] h264: Move AFD to side data to match MPEG-2

2014-08-21 Thread Christophe Gisquet
Hi, 2014-08-09 2:45 GMT+02:00 Kieran Kunhya kier...@obe.tv: +AVFrameSideData *sd = +av_frame_new_side_data(cur-f, + AV_FRAME_DATA_AFD, 1); +if (!sd) +return; You're not responsible for what has already been committed

[FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-21 Thread Deb Mukherjee
Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However if both are present, the 'constrained quality' mode is used as before. ---

Re: [FFmpeg-devel] [PATCH] avcodec/fic: Check if a frame is available before using it

2014-08-21 Thread Michael Niedermayer
On Thu, Aug 14, 2014 at 05:46:08AM +0200, Michael Niedermayer wrote: Fixes null pointer dereference Fixes: ficvf.avi Found-by: Piotr Bandurski ami_st...@o2.pl Signed-off-by: Michael Niedermayer michae...@gmx.at applied [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH 1/2] vidstab*: Remove accidentally exported av_2_vs_pixel_format()

2014-08-21 Thread Timothy Gu
Also correctly namespace other functions in vidstabutils, and decrease difference from Libav. Initial-patch-by: Vittorio Giovara vittorio.giov...@gmail.com Signed-off-by: Timothy Gu timothyg...@gmail.com --- libavfilter/vf_vidstabdetect.c| 5 +++-- libavfilter/vf_vidstabtransform.c | 6

[FFmpeg-devel] [PATCH 2/2] vidstabutils: improve documentation

2014-08-21 Thread Timothy Gu
Signed-off-by: Timothy Gu timothyg...@gmail.com --- libavfilter/vidstabutils.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/libavfilter/vidstabutils.h b/libavfilter/vidstabutils.h index 93278f6..c6d6ced 100644 --- a/libavfilter/vidstabutils.h +++

Re: [FFmpeg-devel] [PATCH] delete the old segment file from hls list

2014-08-21 Thread Steven Liu
repost new patch: when update the hls m3u8 list, the old file is not unlinked this patch can do this operation delete the old ts segment which not show in m3u8, use hls_sync_list. Signed-off-by: Steven Liu qi@chinacache.com --- libavformat/hlsenc.c | 15 ++- 1 files changed,

[FFmpeg-devel] Codec Routing

2014-08-21 Thread Chuck Burfoot
I have been investigating the ways and means of the 'routing' of FFMPEG internally. I've built from source binaries with Windows and C99to89. I build with --enable-libvpx. I was keenly interested in the ability of libvpx to create/encode webm with alpha. ( output from ffprobe ffprobe version

Re: [FFmpeg-devel] Codec Routing

2014-08-21 Thread Timothy Gu
Hi, This question belongs in ffmpeg-u...@ffmpeg.org mailing list. I have CC'd this mail to that mailing list, and please don't reply to ffmpeg-devel anymore. On Thu, Aug 21, 2014 at 4:55 PM, Chuck Burfoot ch...@burfoots.com wrote: I build with --enable-libvpx. I was keenly interested in the

Re: [FFmpeg-devel] [RFC] [PATCH] hevc_ps: reorder SPS reading to allow some errors

2014-08-21 Thread Timothy Gu
On Aug 21, 2014 10:14 AM, Christophe Gisquet christophe.gisq...@gmail.com wrote: Hi, 2014-08-21 3:06 GMT+02:00 Michael Niedermayer michae...@gmx.at: heres a narrower solution for this file not sure its better i can apply whichever you prefer, probably we wont find out which is the best

Re: [FFmpeg-devel] [PATCH] x86/hevc_res_add: refactor ff_hevc_transform_add{16, 32}_8

2014-08-21 Thread Reimar Döffinger
On 21.08.2014, at 22:40, Kieran Kunhya kier...@obe.tv wrote: It does that, but on older SSE2 cpus with not-so-good OOO execution grouping instructions like this might help reduce dependencies a bit. Are any older SSE2 CPUs actually capable of decoding reasonable HEVC? Of course they are. Not

Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-21 Thread Reimar Döffinger
On 22.08.2014, at 04:06, Michael Niedermayer michae...@gmx.at wrote: On Sat, Aug 16, 2014 at 02:43:46PM +0200, Reimar Döffinger wrote: On Wed, Aug 13, 2014 at 01:57:56PM +0200, Michael Niedermayer wrote: On Mon, Aug 11, 2014 at 09:17:18PM +0200, Reimar Döffinger wrote: Unfortunately this was