Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: also export 0, 0 motion vectors

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 09:59:54AM +0100, Clément Bœsch wrote: On Mon, Jan 19, 2015 at 11:58:09PM +0100, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/mpegvideo.c |2 -- tests/ref/fate/filter-codecview-mvs | 30

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-22 Thread Andreas Cadhalpun
Hi, On 22.01.2015 02:58, Timothy Gu wrote: I'd rather have an option disabling it. Sounds cleaner. In which way cleaner? Replacing the date/time with a reproducible one is the least invasive change. Removing it altogether would produce a different end result. Best regards, Andreas

Re: [FFmpeg-devel] [shan...@gmail.com: [libav-devel] Decoder for CEA-608 and World System Teletext]

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 06:42:30AM +, Shan wrote: On 2015-01-20T11:52:39+0100 u...@pkh.me relayed: The patches are welcome though, it might be easier to work with. Here's a base64 patch for the CEA-608, EIA-708, Teletext, DVB VBI and MXF VANC decoder, as well as some other related

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: fix format string generation

2015-01-22 Thread Michael Niedermayer
On Wed, Jan 21, 2015 at 09:36:53AM -0600, Rodger Combs wrote: --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied merged commit that changes it to PRId64 thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: accept AVMEDIA_TYPE_SUBTITLE instead of DATA for subtitles

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 11:43:25AM +, Paul B Mahol wrote: On 1/20/15, Michael Niedermayer michae...@gmx.at wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/flvenc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) lgtm applied

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread wm4
On Thu, 22 Jan 2015 01:38:11 +0530 arwa arif arwaarif1...@gmail.com wrote: From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001 From: Arwa Arif arwaarif1...@gmail.com Date: Mon, 19 Jan 2015 03:56:48 +0530 Subject: [PATCH] Port mp=eq/eq2 to FFmpeg Code adapted from James

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: also export 0, 0 motion vectors

2015-01-22 Thread Clément Bœsch
On Mon, Jan 19, 2015 at 11:58:09PM +0100, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/mpegvideo.c |2 -- tests/ref/fate/filter-codecview-mvs | 30 +++--- 2 files changed, 15 insertions(+), 17

Re: [FFmpeg-devel] [PATCH] avformat/mov: Stricter sanity checks on the display_matrix

2015-01-22 Thread Michael Niedermayer
On Wed, Jan 21, 2015 at 05:02:01PM +0100, Michael Niedermayer wrote: Fixes broken tkhd Found-by: koda Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/mov.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

2015-01-22 Thread Benoit Fouet
Hi, Le 21/01/2015 23:10, Andreas Cadhalpun a écrit : Hi, Debian tries to make binary packages build reproducible [1]. FFmpeg embeds date and time in the program and documentation, which makes it hard to have binary reproducible packages. The attached patch allows to specify the build date

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 02:44:55PM +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 5 + 1 file changed, 5 insertions(+) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does

Re: [FFmpeg-devel] [PATCH] avformat: allow .264 as extension for raw H.264 stream

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 10:02:36PM +0100, Werner Robitza wrote: In addition to .h264, .264 is also commonly used by people to name raw H.264 streams. Enables automatic recognition of the h264 format for the .264 extension. Signed-off-by: Werner Robitza werner.robi...@gmail.com ---

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread Christophe Gisquet
So... 2015-01-21 21:08 GMT+01:00 arwa arif arwaarif1...@gmail.com: Updated the patch. There are trailing spaces, and the patch does not apply here (error on libavfilter/x86/Makefile) Furthemore, I think that hunk is incorrect: +set_gamma(eq); +set_contrast(eq); +

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-22 Thread Derek Buitenhuis
On 1/22/2015 2:44 PM, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 5 + 1 file changed, 5 insertions(+) This is v2. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] web/download: Change main snapshot url to point to github

2015-01-22 Thread Michael Niedermayer
The url did just end at a 403 - Snapshots not allowed We also could point to ffmpeg.org, but the snapshots there are upto 24h old with the current cronjob --- src/download |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/download b/src/download index 20c42f8..4e56bc1

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 09:09:53AM -0800, jon wrote: I never heard back about this and I think I have a new better are you subscribed to ffmpeg-devel ? solution now. I don't think the current mov.c timecode processing is handling the case where the timecode is in counter mode. Please read

Re: [FFmpeg-devel] [PATCH] mark null encoder as ts-nonstrict , avoids error messages for null output

2015-01-22 Thread Michael Niedermayer
On Wed, Aug 27, 2014 at 08:13:24PM -0500, Rodger Combs wrote: On Thu, Aug 21, 2014 at 02:00:22PM +0200, Hendrik Leppkes wrote: On Thu, Aug 21, 2014 at 1:38 PM, compn tempn at mi.rr.com http://ffmpeg.org/mailman/listinfo/ffmpeg-devel wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/h264: Partially decode and display single fields try #2

2015-01-22 Thread Michael Niedermayer
On Wed, Jan 21, 2015 at 02:28:36PM +, Kieran Kunhya wrote: yes, its overall 3 lines shorter as well ive locally changed it to this: Thanks, much easier to understand. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/nvenc: Fix b-frame parameter handling

2015-01-22 Thread Michael Niedermayer
On Fri, Jan 16, 2015 at 01:02:38AM +0100, Timo Rothenpieler wrote: --- libavcodec/nvenc.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 5cd7727..90856be 100644 --- a/libavcodec/nvenc.c +++

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-22 Thread Michael Niedermayer
Hi On Wed, Jan 21, 2015 at 01:26:18AM +0530, supraja reddy wrote: Hello, Thanks for you reviews. I see this is only use during init but if it still matters speedwise and assuming this is a galois field multiplication the it can be written as EXP_GF256[LOG_GF256[a] + LOG_GF256[b]]

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread wm4
On Thu, 22 Jan 2015 16:43:16 -0300 James Almer jamr...@gmail.com wrote: On 22/01/15 4:27 PM, wm4 wrote: Then I'd definitely vote for remove. The asm probably mattered on ancient CPUs and ancient compilers, but there's no reason to keep it anymore. No. If the handwritten asm is better

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread James Almer
On 22/01/15 4:52 PM, wm4 wrote: On Thu, 22 Jan 2015 16:43:16 -0300 James Almer jamr...@gmail.com wrote: On 22/01/15 4:27 PM, wm4 wrote: Then I'd definitely vote for remove. The asm probably mattered on ancient CPUs and ancient compilers, but there's no reason to keep it anymore. No. If

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread James Almer
On 22/01/15 4:27 PM, wm4 wrote: Then I'd definitely vote for remove. The asm probably mattered on ancient CPUs and ancient compilers, but there's no reason to keep it anymore. No. If the handwritten asm is better than the C code, even if slightly, then it should not be removed. And if

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread wm4
On Thu, 22 Jan 2015 21:45:04 +0530 arwa arif arwaarif1...@gmail.com wrote: On Thu, Jan 22, 2015 at 2:59 PM, wm4 nfx...@googlemail.com wrote: On Thu, 22 Jan 2015 01:38:11 +0530 arwa arif arwaarif1...@gmail.com wrote: From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread Clément Bœsch
On Thu, Jan 22, 2015 at 09:45:04PM +0530, arwa arif wrote: [...] I checked the runtime of the codes with and without asm, it turns out that there is not much difference. The difference is coming out to be in milliseconds. 26.014s with asm and 26.129 without asm. So, should I remove the

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread wm4
On Wed, 21 Jan 2015 20:38:20 +0530 arwa arif arwaarif1...@gmail.com wrote: I still expect that eq and eq2 should have the same performances, since the adjust callback is set depending on the parameter values. So we should have a single eq filter. Please investigate about why you get

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

2015-01-22 Thread wm4
On Thu, 22 Jan 2015 16:59:24 -0300 James Almer jamr...@gmail.com wrote: On 22/01/15 4:52 PM, wm4 wrote: On Thu, 22 Jan 2015 16:43:16 -0300 James Almer jamr...@gmail.com wrote: On 22/01/15 4:27 PM, wm4 wrote: Then I'd definitely vote for remove. The asm probably mattered on ancient

[FFmpeg-devel] [PATCH] avformat: allow .264 as extension for raw H.264 stream

2015-01-22 Thread Werner Robitza
In addition to .h264, .264 is also commonly used by people to name raw H.264 streams. Enables automatic recognition of the h264 format for the .264 extension. Signed-off-by: Werner Robitza werner.robi...@gmail.com --- libavformat/rawenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)