Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-17 Thread Andreas Cadhalpun
On 17.03.2015 10:17, tomas.har...@codemill.se wrote: On 2015-03-14 18:03, Andreas Cadhalpun wrote: [PATCH 2/2] mxfenc: don't try to write footer without header: +if (!mxf-header_written || +(s-oformat == ff_mxf_opatom_muxer !mxf-body_partition_offset)) { +err =

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 07:44:54AM -0500, Jeremy Luce wrote: It appears that c/C doesn't pause the input threads, which results in higher CPU usage than the 'p' pause method. Also, since the input threads continue to read data, the input buffer will continue to grow, which may lead to

[FFmpeg-devel] [PATCH] 3GPP TS 26.245 Timed Text decoder: decode rich formatting in sample modifier boxes

2015-03-17 Thread Wesley Castro
Bold, italic, and underlined type will be converted to their equivilent ASS styles when encountered in a text style sample modifier box. Signed-off-by: Wesley Castro root...@gmail.com --- libavcodec/movtextdec.c | 72 ++--- 1 file changed, 69

[FFmpeg-devel] [PATCH] [GSoC] movtextdec: decode rich formatting from text sample modifier boxes in 3GPP timed text subtitles

2015-03-17 Thread Wesley Castro
This is to partially fulfil my qualification task for the Implement full support for 3GPP Timed Text (movtext, QuickTime?) subtitle as part of this year's GSoC. This does not meet all the requirements of the task, but I will submit additional patches before the end of the application period to

Re: [FFmpeg-devel] [PATCH] 3GPP TS 26.245 Timed Text decoder: decode rich formatting in sample modifier boxes

2015-03-17 Thread Wes
My cover letter was sent in a separate email, apologies! Wesley On Tue, Mar 17, 2015 at 9:09 PM, Wesley Castro root...@gmail.com wrote: Bold, italic, and underlined type will be converted to their equivilent ASS styles when encountered in a text style sample modifier box. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] 3GPP TS 26.245 Timed Text decoder: decode rich formatting in sample modifier boxes

2015-03-17 Thread Philip Langdale
On Tue, 17 Mar 2015 21:12:43 -0700 Wes root...@gmail.com wrote: My cover letter was sent in a separate email, apologies! No need to apologise. That's how git send-email works, and it's to be expected. --phil ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] 3GPP TS 26.245 Timed Text decoder: decode rich formatting in sample modifier boxes

2015-03-17 Thread Philip Langdale
On Tue, 17 Mar 2015 21:09:44 -0700 Wesley Castro root...@gmail.com wrote: Bold, italic, and underlined type will be converted to their equivilent ASS styles when encountered in a text style sample modifier box. Signed-off-by: Wesley Castro root...@gmail.com --- Hi Wesley, Thanks for

Re: [FFmpeg-devel] [PATCH 1/2] libavutil: add av_zhb

2015-03-17 Thread Reimar Döffinger
On 17.03.2015, at 05:08, James Almer jamr...@gmail.com wrote: Signed-off-by: James Almer jamr...@gmail.com --- Better name (av_zero_high_bits?) and doxygen welcome. Maybe av_wrap_intp2? (to align with clip function naming) Or av_mod_p2? Essentially it does a modulo with a power of 2.

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec_fixed: fix compilation when ac3dec is disabled

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 05:08:27PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are

[FFmpeg-devel] [PATCH] replace cookies with updated values

2015-03-17 Thread Micah Galizia
Hi, The current Set-Cookie handling appends cookies to the string without checking to see if a cookie with the same name should have its value updated. This is my second attempt to fix this issue -- last time it was a bit of a string parsing nightmare. This time its a little less complex (using

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-17 Thread tomas . hardin
On 2015-03-14 18:03, Andreas Cadhalpun wrote: On 14.03.2015 02:17, Mark Reid wrote: On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 13.03.2015 11:59, Tomas Härdin wrote: A better solution would be to figure out why mxf-body_partition_offset

Re: [FFmpeg-devel] [PATCH] mxfenc: ensure mxf-body_partition_offset is not NULL before using it

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 10:17:06AM +0100, tomas.har...@codemill.se wrote: On 2015-03-14 18:03, Andreas Cadhalpun wrote: On 14.03.2015 02:17, Mark Reid wrote: On Fri, Mar 13, 2015 at 6:02 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: [...] Memleak patch is obviously OK.

Re: [FFmpeg-devel] [FFMpeg-Devel] Ideas for changes to libpostproc

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 08:39:02PM -0400, Tucker DiNapoli wrote: This isn't really a patch, but it's easiest to express my ideas in the form of code. As a patch it creates a single file which is mostly composed of a rewrite of the main postprocessing loop. I've tried to express most of my

Re: [FFmpeg-devel] [FFMpeg-Devel] Ideas for changes to libpostproc

2015-03-17 Thread Michael Niedermayer
On Wed, Mar 18, 2015 at 02:30:29AM +0100, Michael Niedermayer wrote: On Tue, Mar 17, 2015 at 08:39:02PM -0400, Tucker DiNapoli wrote: This isn't really a patch, but it's easiest to express my ideas in the form of code. As a patch it creates a single file which is mostly composed of a

Re: [FFmpeg-devel] GSoc Qualification Task - Implementing Compression technique B44 as a part of exr format (libavcodec/exr.c)

2015-03-17 Thread Michael Niedermayer
On Mon, Mar 16, 2015 at 11:49:09PM +0530, greeshma wrote: Hello , I have implemented B44 lossy compression technique.The first patch is hereby attached.Please have a look. The diff file is also attached. Did you use any previously existing code to implement this? If so please add a link to

[FFmpeg-devel] [FFMpeg-Devel] Ideas for changes to libpostproc

2015-03-17 Thread Tucker DiNapoli
This isn't really a patch, but it's easiest to express my ideas in the form of code. As a patch it creates a single file which is mostly composed of a rewrite of the main postprocessing loop. I've tried to express most of my ideas in the form of changes to the code, but in cases where that would

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec_fixed: fix compilation when ac3dec is disabled

2015-03-17 Thread James Almer
On 17/03/15 6:38 PM, Michael Niedermayer wrote: On Tue, Mar 17, 2015 at 05:08:27PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM Pushed, thanks.

[FFmpeg-devel] [GSOC] Various things

2015-03-17 Thread Michael Niedermayer
Hi If you are a student, Make sure you submit an application to google before the google deadline (27th march) if you dont do that you will not be able to participate in GSoC Make sure you submit your qualification task early, patches always require multiple review and resumbit cycles If you

Re: [FFmpeg-devel] [PATCH] avfilter/showwaves: add single_pic option

2015-03-17 Thread Clément Bœsch
On Mon, Mar 16, 2015 at 04:11:24PM +0100, Stefano Sabatini wrote: On date Sunday 2014-12-28 12:48:19 +0100, Clément Bœsch encoded: On Fri, Dec 26, 2014 at 01:16:07AM +0100, Stefano Sabatini wrote: On date Friday 2014-12-26 00:17:53 +0100, Clément Bœsch encoded: [...] The first case has

[FFmpeg-devel] [PATCH] avcodec/ac3dec_fixed: fix compilation when ac3dec is disabled

2015-03-17 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/ac3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c index 4e6e124..e3bf292 100644 --- a/libavcodec/ac3dec.c +++ b/libavcodec/ac3dec.c @@ -196,10 +196,10 @@ static av_cold

Re: [FFmpeg-devel] [PATCH] lavfi/eq: factorize code in process_command through a macro

2015-03-17 Thread Michael Niedermayer
On Sun, Mar 15, 2015 at 02:59:58PM +0100, Stefano Sabatini wrote: On date Friday 2015-03-13 20:05:35 +0100, Michael Niedermayer encoded: On Fri, Mar 13, 2015 at 05:16:53PM +0100, Stefano Sabatini wrote: --- libavfilter/vf_eq.c | 56

Re: [FFmpeg-devel] [PATCH 2/2] libavutil: add bmi2 optimized av_zhb

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 01:08:06AM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- GCC apparently can't generate a bzhi instruction on its own from the c version, so here's a custom implementation. Before: gcc -O3 av_zhb_c: 0: 89 f1

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-17 Thread Jeremy Luce
It appears that c/C doesn't pause the input threads, which results in higher CPU usage than the 'p' pause method. Also, since the input threads continue to read data, the input buffer will continue to grow, which may lead to undesirable results. I'm not sure if this is by design or not, so I'm

Re: [FFmpeg-devel] [PATCH] doc/protocols: Fixed missing example section marker

2015-03-17 Thread Michael Niedermayer
On Tue, Mar 17, 2015 at 02:07:50PM +0100, Tobias Rapp wrote: Attached (trivial) patch adds some missing @example section marker to protocols.texi Regards, Tobias protocols.texi |2 ++ 1 file changed, 2 insertions(+) c16beb3e1a1f99bd221417a2343a9fbf9cafa04c

[FFmpeg-devel] [PATCH] doc/protocols: Fixed missing example section marker

2015-03-17 Thread Tobias Rapp
Attached (trivial) patch adds some missing @example section marker to protocols.texi Regards, Tobias From 26410261c11aa48622a30b1032023f80fc9062c1 Mon Sep 17 00:00:00 2001 From: Tobias Rapp t.r...@noa-audio.com Date: Wed, 11 Mar 2015 11:22:04 +0100 Subject: [PATCH] doc/protocols: Fixed missing

Re: [FFmpeg-devel] GSoc Qualification Task - Implementing Compression technique B44 as a part of exr format (libavcodec/exr.c)

2015-03-17 Thread Michael Niedermayer
Hi On Mon, Mar 16, 2015 at 11:49:09PM +0530, greeshma wrote: Hello , I have implemented B44 lossy compression technique.The first patch is hereby attached.Please have a look. The diff file is also attached. the inline patch is corrupted by line breaks, the attached patch is corrupted by an

Re: [FFmpeg-devel] [PATCH] AAC: [PATCH] AAC: Add support for 7350Hz sampling rates

2015-03-17 Thread Claudio Freire
On Mon, Mar 16, 2015 at 12:41 AM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Mar 13, 2015 at 03:53:56PM -0300, Claudio Freire wrote: On Fri, Mar 13, 2015 at 3:06 PM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Mar 13, 2015 at 02:34:08PM -0300, Claudio Freire wrote: On Fri,

[FFmpeg-devel] [PATCH v2] mov: Add option to keep exact packet sequence after seeking

2015-03-17 Thread Derek Buitenhuis
The current behavior may produce a different sequence of packets after seeking, compared to demuxing linearly from the beginning. This is because the MOV demuxer seeks in each stream individually, based on timestamp, which may set each stream at a slightly different position than if the file would

Re: [FFmpeg-devel] GSoc Qualification Task - Implementing Compression technique B44 as a part of exr format (libavcodec/exr.c)

2015-03-17 Thread Paul B Mahol
On 3/16/15, greeshma greeshmabalaba...@gmail.com wrote: Hello , I have implemented B44 lossy compression technique.The first patch is hereby attached.Please have a look. The diff file is also attached. diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 6251fb7..e540d4c 100644 ---

Re: [FFmpeg-devel] [PATCH] avcodec: add libdcadec decoder

2015-03-17 Thread James Almer
On 17/03/15 1:07 PM, Hendrik Leppkes wrote: diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index cdc8aa1..48e212f 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2851,6 +2851,7 @@ typedef struct AVCodecContext { #define FF_PROFILE_DTS_96_24 40 #define

Re: [FFmpeg-devel] [PATCH 1/2] libavutil: add av_zhb

2015-03-17 Thread James Almer
On 17/03/15 5:28 AM, Reimar Döffinger wrote: On 17.03.2015, at 05:08, James Almer jamr...@gmail.com wrote: Signed-off-by: James Almer jamr...@gmail.com --- Better name (av_zero_high_bits?) and doxygen welcome. Maybe av_wrap_intp2? (to align with clip function naming) Or av_mod_p2?

[FFmpeg-devel] [PATCH] avcodec: add libdcadec decoder

2015-03-17 Thread Hendrik Leppkes
--- libdcadec is found here: https://github.com/foo86/dcadec I wrote this mostly for myself, as its lossless and quite stable, and allows easy comparison to the state of the native decoder. Since I got a request to share it, I figured I might just send it, may it benefit anyone that is

Re: [FFmpeg-devel] [PATCH] avcodec: add libdcadec decoder

2015-03-17 Thread Derek Buitenhuis
On 3/17/2015 4:26 PM, James Almer wrote: We don't have a generic decorrelate dsp? I think there was something in fmtconvert, but libav nuked it for being unused. Can we not just use a different return format? - Derek ___ ffmpeg-devel mailing list