Re: [FFmpeg-devel] [PATCH] ffm: reject a negative codec_id

2015-12-14 Thread Michael Niedermayer
On Tue, Dec 15, 2015 at 12:03:22AM +0100, Andreas Cadhalpun wrote: > A negative codec_id cannot be handled by the found_decoder API of > AVStream->info: if the codec_id is not recognized, found_decoder is set > to -codec_id, which has to be '<0' according to the API documentation. > > This can

Re: [FFmpeg-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-14 Thread Michael Niedermayer
On Tue, Dec 15, 2015 at 01:15:58AM +0100, Andreas Cadhalpun wrote: > On 14.12.2015 23:14, Michael Niedermayer wrote: > > On Mon, Dec 14, 2015 at 08:43:38PM +0100, Andreas Cadhalpun wrote: > >> opus_silk.c |2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >>

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-14 Thread Ganesh Ajjanagadde
On Wed, Dec 9, 2015 at 6:55 PM, Ganesh Ajjanagadde wrote: > exp2 suffices here. Some trivial (~ 4x) speedup is done in addition here by > reusing results. > > This is bit-identical to the old values. > > Signed-off-by: Ganesh Ajjanagadde > --- >

Re: [FFmpeg-devel] [PATCH] ffm: reject a negative codec_id

2015-12-14 Thread Andreas Cadhalpun
On 15.12.2015 00:43, Michael Niedermayer wrote: > On Tue, Dec 15, 2015 at 12:03:22AM +0100, Andreas Cadhalpun wrote: >> A negative codec_id cannot be handled by the found_decoder API of >> AVStream->info: if the codec_id is not recognized, found_decoder is set >> to -codec_id, which has to be '<0'

Re: [FFmpeg-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-14 Thread Andreas Cadhalpun
On 14.12.2015 23:14, Michael Niedermayer wrote: > On Mon, Dec 14, 2015 at 08:43:38PM +0100, Andreas Cadhalpun wrote: >> opus_silk.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> cc0c02e14c1bda0ab35813c8d4629e742af7d23f >>

Re: [FFmpeg-devel] [PATCH] ffm: reject a negative codec_id

2015-12-14 Thread Michael Niedermayer
On Tue, Dec 15, 2015 at 01:19:01AM +0100, Andreas Cadhalpun wrote: > On 15.12.2015 00:43, Michael Niedermayer wrote: > > On Tue, Dec 15, 2015 at 12:03:22AM +0100, Andreas Cadhalpun wrote: > >> A negative codec_id cannot be handled by the found_decoder API of > >> AVStream->info: if the codec_id is

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality and clamp initial qp value to [1, 51]

2015-12-14 Thread Timo Rothenpieler
> No, it won't affect performance, we did lots of internal tests, mainly > focused on quality improvement. But if it makes performance worse we > won't apply it anyway. Split and applied, thanks. > Agatha Hu > > ___ > ffmpeg-devel mailing list >

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Carl Eugen Hoyos
On Monday 14 December 2015 09:37:22 am Hendrik Leppkes wrote: > On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for > > me. I can't see how duplicating the code from mov.c could be

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Nicolas George
Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > It can be both, ffmpeg also has a mode to forward the source types, if > the user really wants that. But its of course not on by default. Ok. Then I suggest to fix the commit message: the scene-change hints come from the application.

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Mats Peterson
On 12/14/2015 12:21 PM, Mats Peterson wrote: On 12/14/2015 12:16 PM, Mats Peterson wrote: On 12/14/2015 12:15 PM, Carl Eugen Hoyos wrote: On Monday 14 December 2015 12:10:48 pm Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 12:03 PM, Carl Eugen Hoyos wrote: On Monday 14 December 2015

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Carl Eugen Hoyos
On Monday 14 December 2015 12:10:48 pm Hendrik Leppkes wrote: > On Mon, Dec 14, 2015 at 12:03 PM, Carl Eugen Hoyos wrote: > > On Monday 14 December 2015 09:37:22 am Hendrik Leppkes wrote: > >> On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos wrote: > >> > Hi! > >> > > >> > Attached patch based on

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Mats Peterson
On 12/14/2015 12:03 PM, Carl Eugen Hoyos wrote: On Monday 14 December 2015 09:37:22 am Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos wrote: Hi! Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for me. I can't see how

[FFmpeg-devel] [PATCH] avfilter/vf_delogo: fix show option when clipping

2015-12-14 Thread Jean Delvare
The show option did not take clipping into account, so the borders on the clipped side wouldn't show up. Fix it. Signed-off-by: Jean Delvare --- libavfilter/vf_delogo.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- ffmpeg.orig/libavfilter/vf_delogo.c

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Mats Peterson
On 12/14/2015 12:15 PM, Carl Eugen Hoyos wrote: On Monday 14 December 2015 12:10:48 pm Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 12:03 PM, Carl Eugen Hoyos wrote: On Monday 14 December 2015 09:37:22 am Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos wrote: Hi!

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Fix integer overflow in length computation

2015-12-14 Thread Tomas Härdin
On Wed, 2015-12-09 at 18:13 +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > Fixes: CID1341577 > > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfenc.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Mats Peterson
On 12/14/2015 09:37 AM, Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos wrote: Hi! Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for me. I can't see how duplicating the code from mov.c could be acceptable. Personally I

Re: [FFmpeg-devel] [PATCH] avfilter/vf_delogo: fix show option when clipping

2015-12-14 Thread Michael Niedermayer
On Mon, Dec 14, 2015 at 11:23:05AM +0100, Jean Delvare wrote: > The show option did not take clipping into account, so the borders on > the clipped side wouldn't show up. Fix it. > > Signed-off-by: Jean Delvare > --- > libavfilter/vf_delogo.c |4 ++-- > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Hendrik Leppkes
On Mon, Dec 14, 2015 at 9:46 AM, Nicolas George wrote: > Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : >> Strictly speaking, by default the input frames will not have pict_type >> set, unless you explicitly instruct ffmpeg to set it. So it is >> optional. > > Are

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Mats Peterson
On 12/14/2015 08:06 AM, Mats Peterson wrote: On 12/14/2015 06:32 AM, Mats Peterson wrote: On 12/14/2015 03:40 AM, Carl Eugen Hoyos wrote: Hi! Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for me. I can't see how duplicating the code from mov.c could be acceptable.

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Mats Peterson
On 12/14/2015 12:30 PM, Mats Peterson wrote: On 12/14/2015 12:21 PM, Mats Peterson wrote: On 12/14/2015 12:16 PM, Mats Peterson wrote: On 12/14/2015 12:15 PM, Carl Eugen Hoyos wrote: On Monday 14 December 2015 12:10:48 pm Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 12:03 PM, Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Hendrik Leppkes
On Mon, Dec 14, 2015 at 12:03 PM, Carl Eugen Hoyos wrote: > On Monday 14 December 2015 09:37:22 am Hendrik Leppkes wrote: >> On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos wrote: >> > Hi! >> > >> > Attached patch based on 3ece3e4c by Martin Storsjö fixes

Re: [FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

2015-12-14 Thread Jean Delvare
Hallo Michael, On Mon, 14 Dec 2015 23:18:39 +0100, Michael Niedermayer wrote: > On Mon, Dec 14, 2015 at 07:36:51PM +0100, Jean Delvare wrote: > > As I understand it, the temporary stack buffer "src_data" was > > introduced solely to avoid a compiler warning. I believe that a better > > way to

Re: [FFmpeg-devel] avcodec/qsv: export session management functionality

2015-12-14 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Nicolas George > Gesendet: Montag, 14. Dezember 2015 16:55 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] avcodec/qsv: export session management >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: use arc4random() when available

2015-12-14 Thread Ganesh Ajjanagadde
On Thu, Dec 10, 2015 at 3:31 PM, Ganesh Ajjanagadde wrote: > On Wed, Dec 9, 2015 at 8:08 AM, Ganesh Ajjanagadde > wrote: >> On Sun, Dec 6, 2015 at 10:56 PM, Ganesh Ajjanagadde >> wrote: >>> arc4random() was designed as a

[FFmpeg-devel] avcodec/qsv: export session management functionality

2015-12-14 Thread Sven Dueking
Updated patch according to Hendriks feedback. Thanks, Sven 0001-export-session-management-functionality.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-14 Thread Michael Niedermayer
On Mon, Dec 14, 2015 at 08:25:01AM +, Eran Kornblau wrote: > Hi, > > Bumping up this thread... please let me if you want me to make any additional > changes or this can be merged. > Attaching the patch files again (same ones I sent in my last post) [...] > +int

Re: [FFmpeg-devel] avcodec/qsv: export session management functionality

2015-12-14 Thread Nicolas George
Le quartidi 24 frimaire, an CCXXIV, Sven Dueking a écrit : > Updated patch according to Hendriks feedback. Is it really necessary to have the moves from a file to another in the same patch as the functional changes? It makes seeing what did actually change much harder, almost impossible.

Re: [FFmpeg-devel] avcodec/qsv: export session management functionality

2015-12-14 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Nicolas George > Gesendet: Montag, 14. Dezember 2015 16:32 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] avcodec/qsv: export session management >

Re: [FFmpeg-devel] avcodec/qsv: export session management functionality

2015-12-14 Thread Nicolas George
Le quartidi 24 frimaire, an CCXXIV, Sven Dueking a écrit : > Thanks for your feedback, I think it´s necessary because : > > 1. qsv_api.c is single file where qsv-related public functions are located > 2. there is big question that qsv.c will exists in future most likely it > will merged with

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-12-14 Thread Lou Logan
On Mon, Dec 14, 2015, at 12:24 PM, Ray Cole wrote: > Quite honestly I decided it isn't worth the frustration of trying to > submit a patch. It works for me and I'm happy with it. > > -- Ray Our guidelines and peer reviews may seem stringent, but consider it a quality control to help get the best

[FFmpeg-devel] Cyrillic devices name support in libavdevice/dshow

2015-12-14 Thread Michael Savin
Hi, please review this patch for cyrillic devices name support in libavdevice/dshow. Bug described here: https://trac.ffmpeg.org/ticket/5045 -- Michael Savin, +7 (343) 206-88-51 www.facebook.com/mv.savin ffmpeg_cyrillic.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-14 Thread Michael Niedermayer
On Wed, Dec 09, 2015 at 06:55:25PM -0500, Ganesh Ajjanagadde wrote: > exp2 suffices here. Some trivial (~ 4x) speedup is done in addition here by > reusing results. > > This is bit-identical to the old values. That may be true with a specific compiler and version but C makes no such guarantee

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-12-14 Thread Ray Cole
Quite honestly I decided it isn't worth the frustration of trying to submit a patch. It works for me and I'm happy with it. -- Ray On 12/14/2015 03:19 PM, Michael Niedermayer wrote: On Tue, Sep 29, 2015 at 11:02:33AM -0500, Ray Cole wrote: Here is an updated patch. I cleaned the code up to

Re: [FFmpeg-devel] [PATCH 2/2] lavf: use a video frame pool for each link of the filtergraph

2015-12-14 Thread Matthieu Bouron
On Fri, Dec 11, 2015 at 1:45 PM, Moritz Barsnick wrote: > > Subject: [FFmpeg-devel] [PATCH 2/2] lavf: use a video frame pool for each > > link of the filtergraph > > Since Ganesh just recently mentioned the confusion: Wouldn't this be > lavfi instead of lavf? > Updated in new

Re: [FFmpeg-devel] [PATCH 2/2] lavf: use a video frame pool for each link of the filtergraph

2015-12-14 Thread Matthieu Bouron
On Fri, Dec 11, 2015 at 1:32 PM, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > libavfilter/avfilter.c | 1 + > libavfilter/avfilter.h | 5 + > libavfilter/video.c| 38 +++--- > 3

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Will Kelleher
On 12/14, Nicolas George wrote: > Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > > It can be both, ffmpeg also has a mode to forward the source types, if > > the user really wants that. But its of course not on by default. > > Ok. Then I suggest to fix the commit message: the

Re: [FFmpeg-devel] [PATCH] swr/resample: use fma when it is faster

2015-12-14 Thread Ganesh Ajjanagadde
On Sun, Dec 13, 2015 at 10:25 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Dec 13, 2015 at 7:29 PM, Ganesh Ajjanagadde > wrote: > >> The worst part is that it is a bad idea to do runtime dispatch on the >> fma() itself, as the function call overhead will be

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add AVVideoFramePool

2015-12-14 Thread Matthieu Bouron
On Sun, Dec 13, 2015 at 12:51 AM, Michael Niedermayer wrote: > On Fri, Dec 11, 2015 at 07:35:08PM +0100, Matthieu Bouron wrote: > > On Fri, Dec 11, 2015 at 7:07 PM, Michael Niedermayer > > wrote: > > > > > On Fri, Dec 11, 2015 at 01:32:46PM +0100, Matthieu

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Will Kelleher
On 12/14, Ivan Uskov wrote: > Hello Will, > > Friday, December 11, 2015, 6:47:28 PM, you wrote: > > WK> Since adaptive_i support is broken, this allows the QSV encoder to use > scene- > WK> change hints from the input stream if force_key_frames = source is used. > The > WK> result will be

Re: [FFmpeg-devel] [PATCH 2/2] lavf: use a video frame pool for each link of the filtergraph

2015-12-14 Thread Matthieu Bouron
On Fri, Dec 11, 2015 at 2:04 PM, Clément Bœsch wrote: > On Fri, Dec 11, 2015 at 01:32:47PM +0100, Matthieu Bouron wrote: > [...] > > diff --git a/libavfilter/video.c b/libavfilter/video.c > > index 0274fc1..5b0b7f9 100644 > > --- a/libavfilter/video.c > > +++ b/libavfilter/video.c >

[FFmpeg-devel] [PATCH] lavc/utils: use AVPixFmtDescriptor to probe palette formats

2015-12-14 Thread Matthieu Bouron
From: Matthieu Bouron Also use the input frame format instead of the AVCodecContext one according to the documentation of AVCodecContext.get_buffer2(). --- The current code rely on the fact that avpriv_set_systematic_pal2 will error out if the format is not a

Re: [FFmpeg-devel] [PATCH] lavfi/vf_decimate: do not compare the first frame to itself.

2015-12-14 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 07:45:49PM +0200, Nicolas George wrote: > This is a waste of computing power and will result to 0, > making it always dropped. > Use maximum difference values instead. > > Signed-off-by: Nicolas George > --- > libavfilter/vf_decimate.c | 9 ++--- > 1

Re: [FFmpeg-devel] [PATCH] golomb: always check for invalid UE golomb codes in get_ue_golomb

2015-12-14 Thread Andreas Cadhalpun
On 14.12.2015 00:51, Michael Niedermayer wrote: > On Sun, Dec 13, 2015 at 09:56:06PM +0100, Andreas Cadhalpun wrote: >> Also correct the check to reject log < 7, because UPDATE_CACHE only >> guarantees 25 meaningful bits. >> >> This fixes undefined behavior: >> runtime error: shift exponent is

Re: [FFmpeg-devel] [PATCH] QSV : making three qsv routines public

2015-12-14 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Hendrik Leppkes > Gesendet: Donnerstag, 10. Dezember 2015 10:19 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] [PATCH] QSV : making three qsv routines

Re: [FFmpeg-devel] [PATCH] QSV : making three qsv routines public

2015-12-14 Thread Hendrik Leppkes
On 14.12.2015 09:57, Sven Dueking wrote: >-Ursprüngliche Nachricht- >Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag >von Hendrik Leppkes >Gesendet: Donnerstag, 10. Dezember 2015 10:19 >An: FFmpeg development discussions and patches >Betreff: Re: [FFmpeg-devel]

[FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

2015-12-14 Thread Jean Delvare
As I understand it, the temporary stack buffer "src_data" was introduced solely to avoid a compiler warning. I believe that a better way to solve this warning it to explicitly cast src->data. This should be somewhat faster, and just as safe. Signed-off-by: Jean Delvare Cc:

Re: [FFmpeg-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-14 Thread Andreas Cadhalpun
On 14.12.2015 02:38, Michael Niedermayer wrote: > On Sun, Dec 13, 2015 at 10:51:31PM +0100, Andreas Cadhalpun wrote: >> nlsf can be negative, but a negative index for silk_cosine doesn't work. >> --- >> libavcodec/opus_silk.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff

[FFmpeg-devel] Configure with --cpu=host and Clang

2015-12-14 Thread yukari yakumo
Hi everyone! I'm Gentoo Linux user and currently I play with Clang as default compiler. And currently I tried to build ffmpeg 2.3.8 with Clang 3.7.0 and -march=native in C(XX)FLAGS (ffmpeg-2.3.8.ebuild automatically convert this to --cpu=host configure flag). But I get `--cpu=host not supported

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Ivan Uskov
Hello Will, Friday, December 11, 2015, 6:47:28 PM, you wrote: WK> Since adaptive_i support is broken, this allows the QSV encoder to use scene- WK> change hints from the input stream if force_key_frames = source is used. The WK> result will be improved transcoding quality at scene change

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-14 Thread Eran Kornblau
Hi, Bumping up this thread... please let me if you want me to make any additional changes or this can be merged. Attaching the patch files again (same ones I sent in my last post) Thank you Eran 0001-libavutil-add-aes-ctr-support.patch Description: 0001-libavutil-add-aes-ctr-support.patch

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-14 Thread Carl Eugen Hoyos
Hi! On Monday 14 December 2015 09:25:01 am Eran Kornblau wrote: > diff --git a/libavformat/isom.h b/libavformat/isom.h > index a082e40..3b0230a 100644 > --- a/libavformat/isom.h > +++ b/libavformat/isom.h > @@ -37,6 +37,8 @@ extern const AVCodecTag ff_codec_movsubtitle_tags[]; > int

Re: [FFmpeg-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-14 Thread Michael Niedermayer
On Mon, Dec 14, 2015 at 08:43:38PM +0100, Andreas Cadhalpun wrote: > On 14.12.2015 02:38, Michael Niedermayer wrote: > > On Sun, Dec 13, 2015 at 10:51:31PM +0100, Andreas Cadhalpun wrote: > >> nlsf can be negative, but a negative index for silk_cosine doesn't work. > >> --- > >>

Re: [FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

2015-12-14 Thread Michael Niedermayer
On Mon, Dec 14, 2015 at 07:36:51PM +0100, Jean Delvare wrote: > As I understand it, the temporary stack buffer "src_data" was > introduced solely to avoid a compiler warning. I believe that a better > way to solve this warning it to explicitly cast src->data. This > should be somewhat faster, and

Re: [FFmpeg-devel] [libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

2015-12-14 Thread Andreas Cadhalpun
On 14.12.2015 22:34, Luca Barbato wrote: > On 14/12/15 20:43, Andreas Cadhalpun wrote: >> +nlsf[i] = FFMIN(nlsf[i - 1] + min_delta[i], INT16_MAX); > > maybe av_clip_int16 ? Sure, updated patch attached. Best regards, Andreas >From 2894ea930251562c1551b1c5326fc4af231e015a Mon Sep 17

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-14 Thread compn
On Mon, 14 Dec 2015 08:25:01 + Eran Kornblau wrote: > Hi, > > Bumping up this thread... please let me if you want me to make any > additional changes or this can be merged. Attaching the patch files > again (same ones I sent in my last post) dumb question

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-14 Thread Jan Ekstrom
On Mon, Dec 14, 2015 at 10:48 PM, compn wrote: > dumb question > > are these encrypted mp4 files some kind of standard encryption? > > rephrased... will encrypted files created by ffmpeg be able to be > decrypted/decoded and played by quicktime? or any other player? >

Re: [FFmpeg-devel] Proposed vf_decimate enhancement

2015-12-14 Thread Michael Niedermayer
On Tue, Sep 29, 2015 at 11:02:33AM -0500, Ray Cole wrote: > Here is an updated patch. I cleaned the code up to hopefully be closer to > standards. It works well for me, but your mileage may vary... > > --- vf_decimate.c 2015-09-29 10:56:46.171698492 -0500 > +++ vf_decimatex.c2015-09-29

Re: [FFmpeg-devel] [PATCH] golomb: always check for invalid UE golomb codes in get_ue_golomb

2015-12-14 Thread Michael Niedermayer
On Mon, Dec 14, 2015 at 08:58:46PM +0100, Andreas Cadhalpun wrote: > On 14.12.2015 00:51, Michael Niedermayer wrote: > > On Sun, Dec 13, 2015 at 09:56:06PM +0100, Andreas Cadhalpun wrote: > >> Also correct the check to reject log < 7, because UPDATE_CACHE only > >> guarantees 25 meaningful bits. >

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Hendrik Leppkes
On Mon, Dec 14, 2015 at 9:02 AM, Ivan Uskov wrote: > Hello Will, > > Friday, December 11, 2015, 6:47:28 PM, you wrote: > > WK> Since adaptive_i support is broken, this allows the QSV encoder to use > scene- > WK> change hints from the input stream if force_key_frames =

Re: [FFmpeg-devel] [PATCH]lavf/matroskadec: Parse stsd atom in mkv with the appropriate mov function

2015-12-14 Thread Hendrik Leppkes
On Mon, Dec 14, 2015 at 3:40 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch based on 3ece3e4c by Martin Storsjö fixes ticket #5071 for me. > I can't see how duplicating the code from mov.c could be acceptable. > Personally I found toying with st->priv_data to make it look

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Nicolas George
Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > Strictly speaking, by default the input frames will not have pict_type > set, unless you explicitly instruct ffmpeg to set it. So it is > optional. Are you sure these "hints" come from the source? Reading the patch, it seems to make

Re: [FFmpeg-devel] [libav-devel] [PATCH] exr: fix out of bounds read in get_code

2015-12-14 Thread Andreas Cadhalpun
On 14.12.2015 22:37, Luca Barbato wrote: > On 13/12/15 23:37, Andreas Cadhalpun wrote: >> This macro unconditionally used out[-1], which causes an out of bounds >> read, if out is the very beginning of the buffer. >> >> Signed-off-by: Andreas Cadhalpun >> --- >>

[FFmpeg-devel] Sample QuickTime file that doesn't render correctly

2015-12-14 Thread Mats Peterson
I found the following QuickTime file called "smoothie.mov" with Apple Graphics/SMC video at Funet that doesn't render correctly. It is unrelated to the QT palette issue in Matroska, since it's a "normal" QuickTime file. Compare the output from FFplay/MPlayer with the one in Windows or Mac.

Re: [FFmpeg-devel] Sample QuickTime file that doesn't render correctly

2015-12-14 Thread Hendrik Leppkes
On Mon, Dec 14, 2015 at 11:50 PM, Mats Peterson wrote: > I found the following QuickTime file called "smoothie.mov" with Apple > Graphics/SMC video at Funet that doesn't render correctly. It is unrelated > to the QT palette issue in Matroska, since it's a

Re: [FFmpeg-devel] Sample QuickTime file that doesn't render correctly

2015-12-14 Thread Mats Peterson
On 12/14/2015 11:55 PM, Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 11:50 PM, Mats Peterson wrote: I found the following QuickTime file called "smoothie.mov" with Apple Graphics/SMC video at Funet that doesn't render correctly. It is unrelated to the QT

Re: [FFmpeg-devel] Sample QuickTime file that doesn't render correctly

2015-12-14 Thread Mats Peterson
On 12/14/2015 11:56 PM, Mats Peterson wrote: On 12/14/2015 11:55 PM, Hendrik Leppkes wrote: On Mon, Dec 14, 2015 at 11:50 PM, Mats Peterson wrote: I found the following QuickTime file called "smoothie.mov" with Apple Graphics/SMC video at Funet that doesn't

[FFmpeg-devel] [PATCH] ffm: reject a negative codec_id

2015-12-14 Thread Andreas Cadhalpun
A negative codec_id cannot be handled by the found_decoder API of AVStream->info: if the codec_id is not recognized, found_decoder is set to -codec_id, which has to be '<0' according to the API documentation. This can cause NULL pointer dereferencing in try_decode_frame. Signed-off-by: Andreas