Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: use correct type for chl

2019-04-29 Thread Clément Bœsch
On Mon, Apr 29, 2019 at 04:47:52PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/f_ebur128.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c > index f613d8def2..f25d5f096e 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-27 Thread Clément Bœsch
On Sat, Apr 27, 2019 at 12:29:44PM +0200, Paul B Mahol wrote: > On 4/27/19, Clément Bœsch wrote: > > On Thu, Apr 25, 2019 at 04:47:00PM +0200, Paul B Mahol wrote: > >> On 4/25/19, Reto Kromer wrote: > >> > Paul B Mahol wrote: > >> > > >>

Re: [FFmpeg-devel] [PATCH] avformat/subtitles: ignore extra '\r' at line endings

2019-04-27 Thread Clément Bœsch
On Thu, Apr 25, 2019 at 11:22:47PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/microdvddec.c | 2 ++ > libavformat/subtitles.c | 2 +- > libavformat/subtitles.h | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: fix range domain processing for .cube format

2019-04-27 Thread Clément Bœsch
On Thu, Apr 25, 2019 at 02:57:26PM +0200, Paul B Mahol wrote: > The ranges are for input, not for output. > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_lut3d.c | 73 +- > 1 file changed, 51 insertions(+), 22 deletions(-) > LGTM, thanks --

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

2019-04-27 Thread Clément Bœsch
On Thu, Apr 25, 2019 at 04:47:00PM +0200, Paul B Mahol wrote: > On 4/25/19, Reto Kromer wrote: > > Paul B Mahol wrote: > > > >>Found 65x65x65 3D LUT in wild > > > > FYI: 128x128x128 3D LUTs do also exist in film production. > > > > Thank you, changed locally. This means one single malloc of 24M

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: add cineSpace 1D lut parsing

2019-04-20 Thread Clément Bœsch
On Fri, Apr 19, 2019 at 07:53:36PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 2 ++ > libavfilter/vf_lut3d.c | 77 ++ > 2 files changed, 79 insertions(+) > LGTM -- Clément B. signature.asc Description:

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: add cineSpace 3D lut support

2019-04-20 Thread Clément Bœsch
On Fri, Apr 19, 2019 at 07:53:37PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 2 + > libavfilter/vf_lut3d.c | 91 ++ > 2 files changed, 93 insertions(+) > LGTM -- Clément B. signature.asc Description:

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 05:50:37PM +0800, myp...@gmail.com wrote: [...] > > Ok, makes sense. Would you mind updating the comment to something like: > > > > /* Note: WEIGHT_LUT_SIZE must be larger than max_meaningful_diff > > * (log(255)*max(h)^2, which is approximately 50 with the

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 05:19:53PM +0800, myp...@gmail.com wrote: > On Fri, Feb 1, 2019 at 5:11 PM Clément Bœsch wrote: > > > > On Fri, Feb 01, 2019 at 04:57:37PM +0800, myp...@gmail.com wrote: > > [...] > > > > > -#define WEIGHT_LUT_NBITS 9 &g

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 04:57:37PM +0800, myp...@gmail.com wrote: [...] > > > -#define WEIGHT_LUT_NBITS 9 > > > -#define WEIGHT_LUT_SIZE (1< > > +#define WEIGHT_LUT_SIZE (80) // need to > 300 * 300 * log(255) > > > > So the LUT is now 3.2MB? > > > > Why 300? 300*300*log(255) is closer to

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

2019-02-01 Thread Clément Bœsch
On Fri, Feb 01, 2019 at 10:45:24AM +0800, Jun Zhao wrote: > Remove the pdiff_lut_scale in nlmeans and increase weight_lut table size > from 2^9 to 80, this change will avoid using pdiff_lut_scale in > nlmeans_slice() for weight_lut table search, it's will improve the > performance about 12%.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_paletteuse: don't constantly free and realloc internal frames

2019-01-17 Thread Clément Bœsch
On Tue, Jan 15, 2019 at 01:14:34AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vf_paletteuse.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c > index

Re: [FFmpeg-devel] [PATCH] palettegen: Fill with last color, not black

2019-01-17 Thread Clément Bœsch
On Wed, Jan 16, 2019 at 01:40:20PM +0100, Tomas Härdin wrote: > Hi > > I was helping the fine folks at peppercarrot.com with web video > nonsense, and I notice palettegen outputs more colors than it should > due to padding the generated palette with pure black. > > Compare this (ffmpeg version

Re: [FFmpeg-devel] [PATCH] lavfi/nlmeans: fixup aarch64 assembly with clang

2018-07-27 Thread Clément Bœsch
On Fri, Jul 27, 2018 at 12:03:46AM +0300, Jan Ekström wrote: > Clang is more strict about some things. > --- > libavfilter/aarch64/vf_nlmeans_neon.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/aarch64/vf_nlmeans_neon.S >

Re: [FFmpeg-devel] [FFmpeg-cvslog] checkasm: add vf_nlmeans test for ssd_integral_image

2018-05-18 Thread Clément Bœsch
On Thu, May 10, 2018 at 02:10:00AM +0200, Michael Niedermayer wrote: > On Tue, May 08, 2018 at 08:29:00AM +0000, Clément Bœsch wrote: > > ffmpeg | branch: master | Clément Bœsch <u...@pkh.me> | Sun May 6 10:57:23 > > 2018 +0200| [f679711c1b516786a39f9e582622a200502fff74]

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter/vf_nlmeans: add amount parameter

2018-05-18 Thread Clément Bœsch
On Sat, May 12, 2018 at 10:24:35PM +0200, Paul B Mahol wrote: > For better control of denoising. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 4 > libavfilter/vf_nlmeans.c | 5 - > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_nlmeans: better weighting of centered pixel

2018-05-18 Thread Clément Bœsch
On Sat, May 12, 2018 at 10:24:34PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_nlmeans.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c > index

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

2018-05-17 Thread Clément Bœsch
On Mon, May 14, 2018 at 05:50:25PM +0100, Derek Buitenhuis wrote: [...] > 1. Implement a formal CoC enforcement system. This has been mostly > copypasted >from VideoLAN's, and is meant as more of a blueprint. This will no > doubt >be controversial. So as mentioned already in

[FFmpeg-devel] [PATCH] Revert "configure: check that the required header for Linux Perf is available"

2018-05-08 Thread Clément Bœsch
This reverts commit 234a5e08313c6b8b0774796dfa1f285a3f877d14. Linux perf is not enabled if you set --target=android, which you are supposed to when building for Android. --- configure | 3 --- 1 file changed, 3 deletions(-) diff --git a/configure b/configure index 7c143238a8..bdca93a9ee 100755

Re: [FFmpeg-devel] Misc improvements in nlmeans filter [v2]

2018-05-08 Thread Clément Bœsch
On Mon, May 07, 2018 at 07:32:55PM +0200, Paul B Mahol wrote: > On 5/7/18, Clement Boesch wrote: > > Changes since v1: > > > > - fixed float operation in double as pointed out by Moritz > > - fix broken commit split as pointed out by Michael > > - added patch 10: "use unsigned for

Re: [FFmpeg-devel] [PATCH v2 04/10] lavfi/nlmeans: add AArch64 SIMD for compute_safe_ssd_integral_image

2018-05-08 Thread Clément Bœsch
On Tue, May 08, 2018 at 04:06:26AM +0200, Michael Niedermayer wrote: > On Mon, May 07, 2018 at 07:24:16PM +0200, Clément Bœsch wrote: > > ssd_integral_image_c: 49204.6 > > ssd_integral_image_neon: 28346.8 > > --- > > libavfilter/aarch64/Makefile | 3

[FFmpeg-devel] [PATCH v2 07/10] lavfi/nlmeans: switch from double to float

2018-05-07 Thread Clément Bœsch
Overall speed appears to be 1.1x faster with no noticeable quality impact. --- libavfilter/vf_nlmeans.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index f37f1183f7..aba587f46b 100644 ---

[FFmpeg-devel] [PATCH v2 10/10] lavfi/nlmeans: use unsigned for the integral patch value

2018-05-07 Thread Clément Bœsch
This value can not be negative. --- libavfilter/vf_nlmeans.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index 22d26a12e3..547cb80acd 100644 --- a/libavfilter/vf_nlmeans.c +++ b/libavfilter/vf_nlmeans.c

[FFmpeg-devel] [PATCH v2 08/10] lavfi/nlmeans: move final weighted averaging out of nlmeans_plane

2018-05-07 Thread Clément Bœsch
This helps figuring out where the filter is slow: 70.53% ffmpeg_g ffmpeg_g [.] nlmeans_slice 25.73% ffmpeg_g ffmpeg_g [.] compute_safe_ssd_integral_image_c 1.74% ffmpeg_g ffmpeg_g [.] compute_unsafe_ssd_integral_image 0.82% ffmpeg_g ffmpeg_g

[FFmpeg-devel] [PATCH v2 09/10] lavfi/nlmeans: reorder memory accesses in get_integral_patch_value

2018-05-07 Thread Clément Bœsch
This doesn't seem to make much of a difference but it can't hurt. --- libavfilter/vf_nlmeans.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index 72a75a6e7a..22d26a12e3 100644 --- a/libavfilter/vf_nlmeans.c +++

[FFmpeg-devel] [PATCH v2 06/10] lavfi/nlmeans: make compute_safe_ssd_integral_image_c faster

2018-05-07 Thread Clément Bœsch
before: ssd_integral_image_c: 49204.6 after: ssd_integral_image_c: 44272.8 Unrolling by 4 for made the biggest different on odroid-c2 (aarch64); unrolling by 2 or 8 both raised 46k cycles vs 44k for 4. Additionally, this is a much better reference when writing SIMD (SIMD vectorization will

[FFmpeg-devel] [PATCH v2 05/10] checkasm: add vf_nlmeans test for ssd_integral_image

2018-05-07 Thread Clément Bœsch
synth_filter(void); diff --git a/tests/checkasm/vf_nlmeans.c b/tests/checkasm/vf_nlmeans.c new file mode 100644 index 00..5e2c934226 --- /dev/null +++ b/tests/checkasm/vf_nlmeans.c @@ -0,0 +1,113 @@ +/* + * Copyright (c) 2018 Clément Bœsch + * + * This file is part of FFmpeg. + * + * FF

[FFmpeg-devel] [PATCH v2 02/10] lavfi/nlmeans: add SIMD-friendly assumptions for compute_safe_ssd_integral_image

2018-05-07 Thread Clément Bœsch
SIMD code will not have to deal with padding itself. Overwriting in that function may have been possible but involve large overreading of the sources. Instead, we simply make sure the width to process is always a multiple of 16. Additionally, there must be some actual area to process so the SIMD

[FFmpeg-devel] [PATCH v2 04/10] lavfi/nlmeans: add AArch64 SIMD for compute_safe_ssd_integral_image

2018-05-07 Thread Clément Bœsch
ns_neon.S new file mode 100644 index 00..6308a428db --- /dev/null +++ b/libavfilter/aarch64/vf_nlmeans_neon.S @@ -0,0 +1,80 @@ +/* + * Copyright (c) 2018 Clément Bœsch + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the

[FFmpeg-devel] [PATCH v2 03/10] lavfi/nlmeans: use ptrdiff_t for linesizes

2018-05-07 Thread Clément Bœsch
Similarly to previous commit, this will help writing SIMD code by not having manual zero-extension in SIMD code --- libavfilter/vf_nlmeans.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index

[FFmpeg-devel] [PATCH v2 01/10] lavfi/nlmeans: random code shuffling to help compiler

2018-05-07 Thread Clément Bœsch
This makes nlmeans_slice() slightly faster at least on GCC 7.3. --- libavfilter/vf_nlmeans.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index e4952e187e..d222d3913e 100644 --- a/libavfilter/vf_nlmeans.c +++

[FFmpeg-devel] Misc improvements in nlmeans filter [v2]

2018-05-07 Thread Clément Bœsch
Changes since v1: - fixed float operation in double as pointed out by Moritz - fix broken commit split as pointed out by Michael - added patch 10: "use unsigned for the integral patch" - misc instruction shuffling in AArch64 SIMD for better performances I plan to push this soon unless someone

Re: [FFmpeg-devel] [PATCH 7/9] lavfi/nlmeans: switch from double to float

2018-05-07 Thread Clément Bœsch
On Sun, May 06, 2018 at 04:53:54PM +0200, Moritz Barsnick wrote: > On Sun, May 06, 2018 at 13:40:58 +0200, Clément Bœsch wrote: > > Overall speed appears to be 1.1x faster with no noticeable quality impact. > > Probably platform dependant? > > > struct weight

Re: [FFmpeg-devel] [PATCH 2/9] lavfi/nlmeans: add SIMD-friendly assumptions for compute_safe_ssd_integral_image

2018-05-07 Thread Clément Bœsch
On Mon, May 07, 2018 at 12:14:37AM +0200, Michael Niedermayer wrote: > On Sun, May 06, 2018 at 01:40:53PM +0200, Clément Bœsch wrote: > > SIMD code will not have to deal with padding itself. Overwriting in that > > function may have been possible but involve large overreading of

Re: [FFmpeg-devel] [PATCH] opt: print a deprecation indicator when listing options

2018-05-06 Thread Clément Bœsch
On Sat, May 05, 2018 at 09:45:26PM +0100, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavutil/opt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/opt.c b/libavutil/opt.c > index 99282605f5..73295356a1 100644 > ---

[FFmpeg-devel] [PATCH 7/9] lavfi/nlmeans: switch from double to float

2018-05-06 Thread Clément Bœsch
Overall speed appears to be 1.1x faster with no noticeable quality impact. --- libavfilter/vf_nlmeans.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index f37f1183f7..201e4feb41 100644 ---

[FFmpeg-devel] [PATCH 8/9] lavfi/nlmeans: move final weighted averaging out of nlmeans_plane

2018-05-06 Thread Clément Bœsch
This helps figuring out where the filter is slow: 70.53% ffmpeg_g ffmpeg_g [.] nlmeans_slice 25.73% ffmpeg_g ffmpeg_g [.] compute_safe_ssd_integral_image_c 1.74% ffmpeg_g ffmpeg_g [.] compute_unsafe_ssd_integral_image 0.82% ffmpeg_g ffmpeg_g

[FFmpeg-devel] [PATCH 6/9] lavfi/nlmeans: make compute_safe_ssd_integral_image_c faster

2018-05-06 Thread Clément Bœsch
before: ssd_integral_image_c: 49204.6 after: ssd_integral_image_c: 44272.8 Unrolling by 4 for made the biggest different on odroid-c2 (aarch64); unrolling by 2 or 8 both raised 46k cycles vs 44k for 4. Additionally, this is a much better reference when writing SIMD (SIMD vectorization will

[FFmpeg-devel] [PATCH 9/9] lavfi/nlmeans: reorder memory accesses in get_integral_patch_value

2018-05-06 Thread Clément Bœsch
This doesn't seem to make much of a difference but it can't hurt. --- libavfilter/vf_nlmeans.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index abe708a2fc..38c50bc94a 100644 --- a/libavfilter/vf_nlmeans.c +++

[FFmpeg-devel] [PATCH 4/9] lavfi/nlmeans: add AArch64 SIMD for compute_safe_ssd_integral_image

2018-05-06 Thread Clément Bœsch
ns_neon.S new file mode 100644 index 00..4de573cf7f --- /dev/null +++ b/libavfilter/aarch64/vf_nlmeans_neon.S @@ -0,0 +1,78 @@ +/* + * Copyright (c) 2018 Clément Bœsch + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the

[FFmpeg-devel] [PATCH 5/9] checkasm: add vf_nlmeans test for ssd_integral_image

2018-05-06 Thread Clément Bœsch
synth_filter(void); diff --git a/tests/checkasm/vf_nlmeans.c b/tests/checkasm/vf_nlmeans.c new file mode 100644 index 00..5e2c934226 --- /dev/null +++ b/tests/checkasm/vf_nlmeans.c @@ -0,0 +1,113 @@ +/* + * Copyright (c) 2018 Clément Bœsch + * + * This file is part of FFmpeg. + * + * FF

[FFmpeg-devel] [PATCH 3/9] lavfi/nlmeans: use ptrdiff_t for linesizes

2018-05-06 Thread Clément Bœsch
Similarly to previous commit, this will help writing SIMD code by not having manual zero-extension in SIMD code --- libavfilter/vf_nlmeans.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index

[FFmpeg-devel] [PATCH 2/9] lavfi/nlmeans: add SIMD-friendly assumptions for compute_safe_ssd_integral_image

2018-05-06 Thread Clément Bœsch
SIMD code will not have to deal with padding itself. Overwriting in that function may have been possible but involve large overreading of the sources. Instead, we simply make sure the width to process is always a multiple of 16. Additionally, there must be some actual area to process so the SIMD

[FFmpeg-devel] [PATCH 1/9] lavfi/nlmeans: random code shuffling to help compiler

2018-05-06 Thread Clément Bœsch
This makes nlmeans_slice() slightly faster at least on GCC 7.3. --- libavfilter/vf_nlmeans.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_nlmeans.c b/libavfilter/vf_nlmeans.c index e4952e187e..d222d3913e 100644 --- a/libavfilter/vf_nlmeans.c +++

[FFmpeg-devel] Misc improvements in nlmeans filter

2018-05-06 Thread Clément Bœsch
The biggest change is the introduction of the dsp infrastructure such that more SIMD can be added, in particular x86 version(s) of the integral computation function. Only aarch64 was added so far (because the ASM is easy), and I don't plan to work on other arch for now. The filter is still pretty

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_edgedetect: add more formats support to canny mode

2018-05-04 Thread Clément Bœsch
On Thu, May 03, 2018 at 03:44:44PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_edgedetect.c | 48 > ++--- > 1 file changed, 28 insertions(+), 20 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/vf_edgedetect: add planes option

2018-05-04 Thread Clément Bœsch
On Thu, May 03, 2018 at 03:44:43PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi| 4 +++- > libavfilter/vf_edgedetect.c | 25 + > 2 files changed, 28 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_edgedetect: add canny mode

2018-05-04 Thread Clément Bœsch
On Thu, May 03, 2018 at 03:44:42PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi| 3 +++ > libavfilter/vf_edgedetect.c | 5 + > 2 files changed, 8 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: add planar rgb support

2018-05-04 Thread Clément Bœsch
On Thu, May 03, 2018 at 08:08:03PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_lut3d.c | 114 > +++-- > 1 file changed, 111 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_lut3d.c

Re: [FFmpeg-devel] [PATCH] avformat/hls: don't propagate deprecated "user-agent" AVOption

2018-04-29 Thread Clément Bœsch
On Sat, Apr 28, 2018 at 08:37:06PM +0200, wm4 wrote: > This code will print a warning if any user agent is set - even if the > API user used the proper non-deprecated "user_agent" option. > > This change should not even break anything, because even if the user > sets the deprecated "user-agent"

Re: [FFmpeg-devel] [PATCH 1/2] lavu/opt: add AV_OPT_FLAG_DEPRECATED

2018-04-26 Thread Clément Bœsch
On Sun, Apr 22, 2018 at 05:00:45PM +0200, wm4 wrote: > On Sun, 22 Apr 2018 16:38:08 +0200 > Clément Bœsch <u...@pkh.me> wrote: > > > --- > > TODO: APIChanges + lavu minor bump (not done yet because it will > > conflict with the threadmessage patch)

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-26 Thread Clément Bœsch
On Mon, Apr 23, 2018 at 02:13:41AM +0200, Michael Niedermayer wrote: [...] > doesnt document the AVERROR case > added > should be ok otherwise, no more comments from me > thx, applied -- Clément B. signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-22 Thread Clément Bœsch
On Sun, Apr 22, 2018 at 12:33:14PM +0200, Marton Balint wrote: > > > On Sun, 22 Apr 2018, Clément Bœsch wrote: > > > On Sun, Apr 22, 2018 at 02:51:16AM +0100, Rostislav Pehlivanov wrote: > > [...] > > > I think av_thread_message_queue_elems would be a better na

[FFmpeg-devel] [PATCH 2/2] lavf/http: use AV_OPT_FLAG_DEPRECATED for user-agent option

2018-04-22 Thread Clément Bœsch
--- There are probably a bunch of other options and I don't plan to look for them, I just needed at least one example of use. --- libavformat/http.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index aa6348f28b..3a35bc7eac 100644

[FFmpeg-devel] [PATCH 1/2] lavu/opt: add AV_OPT_FLAG_DEPRECATED

2018-04-22 Thread Clément Bœsch
--- TODO: APIChanges + lavu minor bump (not done yet because it will conflict with the threadmessage patch) --- libavutil/opt.c | 6 ++ libavutil/opt.h | 1 + 2 files changed, 7 insertions(+) diff --git a/libavutil/opt.c b/libavutil/opt.c index 3b0aab4ee8..99282605f5 100644 ---

Re: [FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-22 Thread Clément Bœsch
On Sun, Apr 22, 2018 at 02:51:16AM +0100, Rostislav Pehlivanov wrote: [...] > I think av_thread_message_queue_elems would be a better name, had to think > for a good period of time what "nelem" meant. I'm afraid of "queue_elems" implying "queuing elements" so I went for the more explicit

[FFmpeg-devel] [PATCH] lavu/threadmessage: add av_thread_message_queue_nelem()

2018-04-21 Thread Clément Bœsch
--- Been away from FFmpeg for way too long. Hope this patch get me back on track. Feel free to nitpick on the name. --- doc/APIchanges | 3 +++ libavutil/threadmessage.c | 9 + libavutil/threadmessage.h | 5 + libavutil/version.h|

Re: [FFmpeg-devel] [PATCH 1/2] vf_paletteuse: Add error checking to apply_palette

2018-01-02 Thread Clément Bœsch
On Tue, Jan 02, 2018 at 10:02:25PM +, Derek Buitenhuis wrote: > On 1/2/2018 9:52 PM, Clément Bœsch wrote: > > not exactly sure why you haven't just checked if `out` wasn't NULL, but it > > should be fine that way too if you prefer it. > > > > I guess that's only to

Re: [FFmpeg-devel] [PATCH 1/2] vf_paletteuse: Add error checking to apply_palette

2018-01-02 Thread Clément Bœsch
On Mon, Jan 01, 2018 at 11:28:36AM -0500, Derek Buitenhuis wrote: > This fixes a segfault caused by passing NULL to ff_filter_frame > when an error occurs. > > Signed-off-by: Derek Buitenhuis > --- > libavfilter/vf_paletteuse.c | 25 - > 1

Re: [FFmpeg-devel] [PATCH 2/2] vf_paletteuse: Don't free the second frame from ff_framesync_dualinput_get_writable on error

2018-01-02 Thread Clément Bœsch
On Mon, Jan 01, 2018 at 11:28:37AM -0500, Derek Buitenhuis wrote: > This fixes a double free in he error case. > > Signed-off-by: Derek Buitenhuis > --- > This does fix the double free, but I am unsure if it is the correct free > to removed to fix it. Comments

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-12-25 Thread Clément Bœsch
On Mon, Dec 25, 2017 at 11:57:31AM +, Rostislav Pehlivanov wrote: [...] > > What you call "dead project" did basically all of the hardware > > transcoding improvements that were merged into ffmpeg. How very > > insincere of you. > > > > Didn't mean dead as an offense, just as an honest fact.

Re: [FFmpeg-devel] DVD subtitles hacking

2017-12-19 Thread Clément Bœsch
On Fri, Dec 15, 2017 at 09:16:02AM -0600, Matt Zagrabelny wrote: > On Thu, Dec 14, 2017 at 8:06 PM, Carl Eugen Hoyos > wrote: > > > > > You could implement a hack (similar to what the CC code does) > > that allows processing the subs but it is likely that the patch > > would

Re: [FFmpeg-devel] [PATCH] configure: Allow users to disable all hwaccel libraries

2017-11-30 Thread Clément Bœsch
On Thu, Nov 30, 2017 at 03:58:21PM +0530, Gyan Doshi wrote: > I added --disable-hwaccels during configure and noticed that all > autodetected hwaccel libs were still being linked - 6 in my case, which > makes for a more bloated binary than warranted. > > Turns out the option only disables native

Re: [FFmpeg-devel] [FFmpeg-devel 1/1] avcodec/samidec: check av_strdup() return value

2017-11-29 Thread Clément Bœsch
On Mon, Nov 27, 2017 at 02:56:32PM +0800, Pan Bian wrote: > In function sami_paragraph_to_ass(), the return value of av_strdup() is > not checked. To avoid potential NULL dereference, the return value > should be checked against NULL. > > Signed-off-by: Pan Bian > --- > V2:

Re: [FFmpeg-devel] Accurately describing ffmpeg-cvslog list [was: Re: [PATCH] Refactor Developer Docs, update dev list section (v2)]

2017-11-28 Thread Clément Bœsch
On Mon, Nov 27, 2017 at 11:19:01PM +, Rostislav Pehlivanov wrote: > On 27 November 2017 at 23:05, Ronald S. Bultje wrote: > > > Hi, > > > > On Mon, Nov 27, 2017 at 6:03 PM, Carl Eugen Hoyos > > wrote: > > > > > 2017-11-26 22:57 GMT+01:00 Jim DeLaHunt

Re: [FFmpeg-devel] [PATCH 3/3] avformat: deprecate AVFMT_FLAG_AUTO_BSFr

2017-11-26 Thread Clément Bœsch
On Sun, Nov 26, 2017 at 05:51:04PM -0300, James Almer wrote: > The bitstream filters inserted by this option should not be optional. Will ffmpeg error out if it's built without the required bsf? (or is there a hard dep in the configure?) -- Clément B. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: Treat escaped and unescaped decoding error equal in decode_extradata_ps_mp4()

2017-11-25 Thread Clément Bœsch
On Sat, Nov 25, 2017 at 10:49:09PM +0100, Michael Niedermayer wrote: > Fixes: lorex.mp4 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/h264_parse.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c >

Re: [FFmpeg-devel] [PATCH v3 2/3] libavcodec/utils.c: simplify avcodec locking with atomics

2017-11-25 Thread Clément Bœsch
On Sat, Nov 25, 2017 at 05:01:56PM +, Rostislav Pehlivanov wrote: [...] > -volatile int ff_avcodec_locked; > +static atomic_bool ff_avcodec_locked; > static atomic_int entangled_thread_counter = ATOMIC_VAR_INIT(0); > static void *codec_mutex; > static void *avformat_mutex; > @@ -1937,6

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

2017-11-25 Thread Clément Bœsch
On Fri, Nov 17, 2017 at 03:58:16PM +, Rostislav Pehlivanov wrote: [...] > diff --git a/libavresample/utils.c b/libavresample/utils.c > index b4fb906556..3e629fe901 100644 > --- a/libavresample/utils.c > +++ b/libavresample/utils.c > @@ -37,6 +37,9 @@ int avresample_open(AVAudioResampleContext

Re: [FFmpeg-devel] [PATCH] 8-bit hevc decoding optimization on aarch64 with neon

2017-11-25 Thread Clément Bœsch
On Sat, Nov 18, 2017 at 06:35:48PM +0100, Rafal Dabrowa wrote: > > This is a proposal of performance optimizations for 8-bit > hevc video decoding on aarch64 platform with neon (simd) extension. > > I'm testing my optimizations on NanoPi M3 device. I'm using > mainly "Big Buck Bunny" video file

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: change license to LGPL

2017-11-16 Thread Clément Bœsch
e but were part of larger refactorings that > changed > lavfi APIs and other LGPL filters as well. See > https://github.com/FFmpeg/FFmpeg/commits/master/libavfilter/vf_cropdetect.c > > Stefano Sabatini > Michael Niedermayer > Anton Khirnov > Clément Bœsch > Paul

Re: [FFmpeg-devel] [PATCH] avutil: add API for mb_types

2017-11-12 Thread Clément Bœsch
On Sun, Nov 12, 2017 at 01:55:14AM +, Rostislav Pehlivanov wrote: [...] > The range should be derived from the codec ID. The frame doesn't contain the codec ID, so this information should be added to that struct somehow (it needs to reach the filters who are agnostics). [...] -- Clément B.

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Fri, Nov 10, 2017 at 12:18:07AM +0100, Aurelien Jacobs wrote: [...] > > > Also, allowing this but not the mixed statements and declarations means > > > this is a style decision and not a technical one anymore. > > Allowing limiting the scope of a variable to a loop seems like a > technical

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: [...] > > - this require a Changelog entry as it has a technical impact (which could > > be considered negligible). > > No, Changelog is not for this kind of change. > Sorry, I should have elaborated: I meant to document in the

Re: [FFmpeg-devel] [PATCH 1/9] lavfi/paletteuse: check get_color return value

2017-11-09 Thread Clément Bœsch
On Wed, Nov 08, 2017 at 07:17:45PM +0100, Timo Rothenpieler wrote: > Fixes CID #1420396 > --- > libavfilter/vf_paletteuse.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c > index ed80ab04d5..1980907e70 100644

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451 100644 >

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Clément Bœsch
On Wed, Nov 01, 2017 at 11:01:22PM +0100, Nicolas George wrote: > Le primidi 11 brumaire, an CCXXVI, Clement Boesch a écrit : > > nb_filters and nb_outputs are signed so the counters better be the same > > type. > > I re-checked, I think you are mistaken. > My bad, you're right, I was looking

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

2017-11-01 Thread Clément Bœsch
On Wed, Nov 01, 2017 at 09:39:52PM +0100, Nicolas George wrote: > For now, check the image size. > Inspired by a patch from Paul B Mahol. > > Invalid sizes would be detected later by allocation failures, > detecting problems earlier is cleaner. > > Signed-off-by: Nicolas George

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

2017-10-29 Thread Clément Bœsch
On Sun, Oct 29, 2017 at 01:47:03AM +0200, Carl Eugen Hoyos wrote: > 2017-10-28 23:50 GMT+02:00 Clément Bœsch <u...@pkh.me>: > > On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote: > >> 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos <ceffm...@gmail.com&g

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-10-28 Thread Clément Bœsch
On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > fftools/ffplay.c | 67 > +--- > 1 file changed, 35 insertions(+), 32 deletions(-) > Won't this prevent using ffplay without

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

2017-10-28 Thread Clément Bœsch
On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote: > 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos : > > > Attached patch is useful in combination with the transparency patch > > for paletteuse. > > > +{ "background", "set a background color for

Re: [FFmpeg-devel] [PATCH] lavfi/paletteuse: fix to support transparency

2017-10-28 Thread Clément Bœsch
On Mon, Oct 23, 2017 at 07:12:57PM -0400, Bjorn Roche wrote: > This patch enables paletteuse to identify the transparency in incoming > video and tag transparent pixels on outgoing video with the correct > index from the palette. > > This requires tracking the transparency index in the palette, >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Clément Bœsch
On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote: > On 10/28/17, Clement Boesch wrote: > > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: > >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : > >> > Signed-off-by: Paul B Mahol >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Clément Bœsch
On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: > Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit : > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/vf_tile.c | 8 > > 1 file changed, 8 deletions(-) > > Nack. > > ./ffmpeg_g -lavfi

Re: [FFmpeg-devel] [PATCH] lavc: drop VDA

2017-10-23 Thread Clément Bœsch
On Fri, Sep 29, 2017 at 06:59:56PM -0300, James Almer wrote: [...] > Then IMO we should wait until the major bump (Which is not too far > away). Leaving a stub object for the symbols and configure clutter > should be avoided. Patch applied. Thanks -- Clément B. signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH 1/2] ffserver: Fix off by 1 error in path

2017-10-23 Thread Clément Bœsch
On Mon, Oct 23, 2017 at 10:42:53AM +0200, Clément Bœsch wrote: [...] > how about changing the whole chunk with (untested): > > prog = av_strdup(my_program_name); > dirname = av_dirname(prog); > pathname = *dirname ? av_asprintf("%s/%

Re: [FFmpeg-devel] [PATCH 1/2] ffserver: Fix off by 1 error in path

2017-10-23 Thread Clément Bœsch
On Sun, Oct 22, 2017 at 05:11:20PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > fftools/ffserver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffserver.c b/fftools/ffserver.c > index

Re: [FFmpeg-devel] [PATCH] avcodec/version: Postpone FF_API_DEBUG_MV

2017-10-23 Thread Clément Bœsch
On Sun, Oct 22, 2017 at 12:09:04PM -0400, Ronald S. Bultje wrote: [...] > > > The replacement will never be written if: > > > a) nobody cares; AND > > > b) we keep delaying the removal > > > > > > I'm considering veto'ing this patch. > > > > Personally I'm with Clement in this. The deprecation was

Re: [FFmpeg-devel] [PATCH] avcodec/version: Postpone FF_API_DEBUG_MV

2017-10-22 Thread Clément Bœsch
On Sun, Oct 22, 2017 at 10:43:35AM -0300, James Almer wrote: [...] > Personally I'm with Clement in this. The deprecation was poorly handled, > and the feature currently has no replacement. Michael uses it for > debugging, so removing it does not seem productive. Not just Michael, it's generally

Re: [FFmpeg-devel] [PATCH 0/6] Patchset to remove ffserver

2017-10-22 Thread Clément Bœsch
On Sun, Oct 22, 2017 at 10:51:38AM +0200, Marton Balint wrote: > > On Sun, 22 Oct 2017, Clément Bœsch wrote: > > > On Sun, Oct 22, 2017 at 02:55:38AM +0200, Michael Niedermayer wrote: > > > On Sat, Oct 21, 2017 at 04:15:37PM -0300, James Almer wrote: > > > &

Re: [FFmpeg-devel] [PATCH 0/6] Patchset to remove ffserver

2017-10-22 Thread Clément Bœsch
On Sun, Oct 22, 2017 at 02:55:38AM +0200, Michael Niedermayer wrote: > On Sat, Oct 21, 2017 at 04:15:37PM -0300, James Almer wrote: > > On 10/21/2017 3:54 PM, Rostislav Pehlivanov wrote: > > > This patchset removes the long-deprecated ffserver program and all > > > its privately exposed things

Re: [FFmpeg-devel] [PATCH] avcodec/version: Postpone FF_API_DEBUG_MV

2017-10-22 Thread Clément Bœsch
On Sat, Oct 21, 2017 at 11:23:29PM -0300, James Almer wrote: [...] > >> The commit even states it should have removed "all traces of its use", > >> but it looks like with the years more and more code was added to it, > >> seeing the removal commit 8933ac2079644fb09916f1875c569103aefe84b1 in > >>

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-21 Thread Clément Bœsch
On Sat, Oct 21, 2017 at 09:47:47PM +0200, Carl Eugen Hoyos wrote: > 2017-10-21 21:43 GMT+02:00 Clément Bœsch <u...@pkh.me>: > > On Sat, Oct 21, 2017 at 09:37:06PM +0200, Carl Eugen Hoyos wrote: > >> 2017-10-21 18:40 GMT+02:00 Clément Bœsch <u...@pkh.me>: > >>

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-21 Thread Clément Bœsch
On Sat, Oct 21, 2017 at 09:37:06PM +0200, Carl Eugen Hoyos wrote: > 2017-10-21 18:40 GMT+02:00 Clément Bœsch <u...@pkh.me>: > > > Aside from these nitpicks, I'm still concerned about how it's going > > to conflict with GIF encoding where the transparent color is act

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-21 Thread Clément Bœsch
> Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency The commit message needs adjustment "lavfi/paletteuse: ..." [...] > struct color_node { > -uint8_t val[3]; > +uint8_t val[4]; > uint8_t palette_id; > int split; > int left_id, right_id; > @@ -86,6

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-20 Thread Clément Bœsch
On Fri, Oct 20, 2017 at 12:35:00AM +0200, Carl Eugen Hoyos wrote: > 2017-10-20 0:00 GMT+02:00 Bjorn Roche : > > The palettes generated by palettegen include one transparent color. > > This patch enables paletteuse to identify the transparency in incoming > > video and tag

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '7cb1d9e2dbbe5bf4652be5d78cdd68e956fa3d63'

2017-10-12 Thread Clément Bœsch
On Thu, Oct 12, 2017 at 02:22:08PM -0400, Helmut K. C. Tessarek wrote: > On 2017-10-12 13:25, James Almer wrote: > > That'd be because showcqt is missing its fontconfig and freetype deps in > > configure, a mistake that was hidden by extralibs being global before > > this merge. > > This does not

Re: [FFmpeg-devel] [PATCH] Add support for libopenjpeg 2.3

2017-10-08 Thread Clément Bœsch
On Sun, Oct 08, 2017 at 04:51:49PM +0530, Gyan Doshi wrote: > OpenJPEG 2.3 was released a few days ago. Changelog reports "No API/ABI > break compared to v2.2.0 but additional symbols for subset of components > decoding" > > This patch is adapted from an earlier patch which added support for 2.2.

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-07 Thread Clément Bœsch
On Sat, Oct 07, 2017 at 01:48:16PM +0200, Clément Bœsch wrote: > > Subject: Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support > > transparency > > "lavf/paletteuse: add support for transparency" > Sorry, "lavfi", not "lavf&

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-07 Thread Clément Bœsch
> Subject: Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency "lavf/paletteuse: add support for transparency" On Fri, Oct 06, 2017 at 04:59:55PM -0400, Bjorn Roche wrote: > --- > libavfilter/vf_paletteuse.c | 175 > > 1 file

  1   2   3   4   5   6   7   8   9   10   >