Re: [FFmpeg-devel] [PATCH v2 06/11] cbs: Add support functions for handling unit content references

2019-05-21 Thread James Almer
On 5/20/2019 8:02 PM, Mark Thompson wrote: > Use the unit type table to determine what we need to do to clone the > internals of the unit content when making copies for refcounting or > writeability. (This will still fail for units with complex content > if they do not have a defined clone

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread James Almer
On 5/21/2019 3:42 PM, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > >> diff --git a/configure b/configure >> index 9b4305cf0d..61eb774116 100755 >> --- a/configure >> +++ b/configure >> @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" >>

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread James Almer
On 5/21/2019 6:34 AM, Tomas Härdin wrote: > tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: >> --- >> >> what's changed: >> * apply #if CONFIG_VP4_DECODER around large vp4 code blocks >> * improved vp4_read_mb_value thanks to reminars suggestions >> * improved configure vp3_decoder_select >>

Re: [FFmpeg-devel] [PATCH v2 01/11] cbs: Mention all codecs in unit type comment

2019-05-20 Thread James Almer
On 5/20/2019 8:02 PM, Mark Thompson wrote: > --- > libavcodec/cbs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h > index 967dcd1468..e8b2d41ecb 100644 > --- a/libavcodec/cbs.h > +++ b/libavcodec/cbs.h > @@ -49,6 +49,8 @@ struct

[FFmpeg-devel] [PATCH] avformat/matroskadec: request frame header parsing for HEVC

2019-05-20 Thread James Almer
-by: James Almer --- libavformat/matroskadec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index cba2b3d1f8..e282c01fc1 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -2525,8 +2525,7 @@ static

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-20 Thread James Almer
On 5/20/2019 5:43 PM, Daniel Kučera wrote: > po 20. 5. 2019 o 21:12 James Almer napísal(a): >> >> On 5/20/2019 4:01 PM, Marton Balint wrote: >>> >>> On Mon, 20 May 2019, Carl Eugen Hoyos wrote: >>> >>>> Marton, >>>

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fine tune thread distribution

2019-05-20 Thread James Almer
On 5/13/2019 11:31 AM, James Almer wrote: > As suggested by Ronald, don't map auto threads to frame threads only, and > instead distribute them between frame and tile more efficiently. > Add a new framethreads override option, similar to the tilethreads one. > > Signed-off-

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-20 Thread James Almer
On 5/20/2019 4:01 PM, Marton Balint wrote: > > On Mon, 20 May 2019, Carl Eugen Hoyos wrote: > >> Marton, >> >> Am Mo., 13. Mai 2019 um 13:42 Uhr schrieb Daniel Kucera >> : >>> >>> From: Daniel Kucera >>> >>> Signed-off-by: Daniel Kucera >>> --- >>>  doc/ffplay.texi  | 2 ++ >>>  

Re: [FFmpeg-devel] [PATCH] web/download: set realistic release schedule

2019-05-20 Thread James Almer
On 5/20/2019 4:00 PM, Lou Logan wrote: > Major releases have been every 6 months approximately; not every 3 months. > > Signed-off-by: Lou Logan > --- > src/download | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/download b/src/download > index 07f4439..9544de2

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use unspecified language by default

2019-05-20 Thread James Almer
On 5/20/2019 6:58 AM, Carl Eugen Hoyos wrote: > Am So., 19. Mai 2019 um 20:10 Uhr schrieb Marton Balint : > >> English was used before. > > A version bump is necessary. > > I would also like a Changelog entry, most people prefer an entry to > apichanges though. No API is being changed or

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-19 Thread James Almer
On 5/19/2019 4:22 AM, Peter Ross wrote: > On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote: >> On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: >>> ah, i see what you did there! it works perfectly, just missing >>> UPDATE_CACHE at the start and in the loop. >>> >>> test

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-19 Thread James Almer
On 5/19/2019 6:43 AM, Daniel Kučera wrote: > Dňa pi 17. 5. 2019, 21:12 Daniel Kučera > napísal(a): > >> >> >> Dňa št 16. 5. 2019, 12:04 Daniel Kučera >> napísal(a): >> >>> >>> >>> Dňa st 15. 5. 2019, 11:14 Daniel Kučera >>> napísal(a): >>> > > Ping. > > -- > > S

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-18 Thread James Almer
On 5/18/2019 9:24 AM, Paul B Mahol wrote: > On 5/18/19, Reimar Döffinger wrote: >> Voting is not yet another mobbing tool for when you get tired of other ways. >> If you wish for an end to that feud, you can ask other developers to try and >> help, but you've kept this going for years and usually

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-17 Thread James Almer
On 5/17/2019 4:25 PM, Paul B Mahol wrote: > Hi, > > $subject. > > He is constantly against my patches, and derailing it with other things > to just block them. > > He is also misguiding other fellow developers with unreasonable and > impossible refactoring task, see that frame rotating patch

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 6:06 PM, Lynne wrote: > May 16, 2019, 8:43 PM by geo...@nsup.org: > >> Lynne (12019-05-16): >> >>> I'm not, I still want the 2 checks. >>> >> >> Arguments please. As I explained, the first check is harmful to >> applications because it hides bug. >> > > Nevermind, its not really

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 3:11 PM, Nicolas George wrote: > James Almer (12019-05-16): >> There are two precedents in the codebase, one checking for both the >> passed argument and then the struct pointer pointed by it (av_bsf_free >> and av_buffer_unref as i mentioned above),

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 11:31 AM, Nicolas George wrote: > James Almer (12019-05-16): >> An assert is meant to detect developer errors, not user errors. Crashing >> the user's whole application because they misused the API is not really >> acceptable. >> >> I can't find

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 5:03 AM, Nicolas George wrote: > Ruiling Song (12019-05-16): >> ctx is a pointer to pointer here. >> >> Signed-off-by: Ruiling Song >> --- >> libavutil/tx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavutil/tx.c b/libavutil/tx.c >> index

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread James Almer
On 5/16/2019 8:35 AM, Peter Ross wrote: > --- > > what's changed: > * reordered AV_CODEC_ID_VP4 > * minor read_mb_values improvement (reproducible 0.5% speedup) > * configure/Makefile fix > * squished data tables to fill 80 columns. > > UNCHECKED_BITSTREAM_READER doesn't give any performance

Re: [FFmpeg-devel] [PATCH] avutil/tx: should check against (*ctx)

2019-05-15 Thread James Almer
On 5/16/2019 1:47 AM, Ruiling Song wrote: > ctx is a pointer to pointer here. > > Signed-off-by: Ruiling Song > --- > libavutil/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/tx.c b/libavutil/tx.c > index 934ef27c81..2bf4aa1c28 100644 > ---

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-15 Thread James Almer
On 5/15/2019 2:57 PM, Lynne wrote: > May 14, 2019, 7:41 PM by d...@lynne.ee: > >> May 14, 2019, 7:12 PM by > one...@gmail.com > : >> >>> On 5/14/19, Carl Eugen Hoyos <> >> ceffm...@gmail.com >>> >> > ceffm...@gmail.com >>>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3enc: Avoid SEEK_END as it is unsupported

2019-05-14 Thread James Almer
On 5/14/2019 8:04 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3enc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c > index dd662f5473..f4814be80e 100644 > ---

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-14 Thread James Almer
On 5/14/2019 9:37 AM, Peter Ross wrote: > On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: >> On 12.05.2019, at 08:12, Peter Ross wrote: >>> +static int read_mb_value(GetBitContext *gb) >>> +{ >>> +int v = 1; >>> +int size; >>> + >>> +do { >>> +size = 0; >>> +

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread James Almer
On 5/13/2019 5:36 PM, Carl Eugen Hoyos wrote: > Am Mo., 13. Mai 2019 um 22:32 Uhr schrieb James Almer : >> >> On 5/13/2019 5:23 PM, Carl Eugen Hoyos wrote: >>> Am Mo., 13. Mai 2019 um 22:18 Uhr schrieb James Almer : >>>> >>>> On 5/13/2019 5:13 PM, Ca

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread James Almer
On 5/13/2019 5:23 PM, Carl Eugen Hoyos wrote: > Am Mo., 13. Mai 2019 um 22:18 Uhr schrieb James Almer : >> >> On 5/13/2019 5:13 PM, Carl Eugen Hoyos wrote: >>> Am Mo., 13. Mai 2019 um 22:10 Uhr schrieb Marton Balint : >>>> >>>> On Sun, 28

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread James Almer
On 5/13/2019 5:13 PM, Carl Eugen Hoyos wrote: > Am Mo., 13. Mai 2019 um 22:10 Uhr schrieb Marton Balint : >> >> On Sun, 28 Apr 2019, Marton Balint wrote: >> >>> Hi All, >>> >>> There has been discussion on the mailing list several times about the >>> inclusion of support for closed source

[FFmpeg-devel] [PATCH] avcodec/libdav1d: fine tune thread distribution

2019-05-13 Thread James Almer
As suggested by Ronald, don't map auto threads to frame threads only, and instead distribute them between frame and tile more efficiently. Add a new framethreads override option, similar to the tilethreads one. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 16

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread James Almer
On 5/12/2019 7:42 PM, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 23:58 Uhr schrieb Lynne : >> I need *technical* feedback about the API. > > I understand that. Then, if you can't provide technical feedback, please stop replying to this thread (After you provide the source Hendrik

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread James Almer
On 5/12/2019 3:12 AM, Peter Ross wrote: > --- > i have incorporated all suggestions from the first patch posted jan 2019. > > if there's nothing further to change, i will apply it a good week or so. > > cheers, > > > Changelog |1 + > doc/general.texi|2 + >

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-11 Thread James Almer
On 5/11/2019 8:08 PM, Carl Eugen Hoyos wrote: > Am So., 12. Mai 2019 um 01:00 Uhr schrieb Lynne : >> >> May 11, 2019, 11:08 PM by ceffm...@gmail.com: >> >>> Am Sa., 11. Mai 2019 um 14:41 Uhr schrieb Lynne <> d...@lynne.ee >>> > >: >>> May 10, 2019, 8:59 PM by >>

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: Check offset_for_non_ref_pic and offset_for_top_to_bottom_field

2019-05-11 Thread James Almer
On 5/11/2019 2:59 PM, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 + -1 cannot be represented in > type 'int' > Fixes: > 1/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5675880333967360 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-09 Thread James Almer
On 5/10/2019 1:41 AM, Jing Sun wrote: > +if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) { > +EB_BUFFERHEADERTYPE *header_ptr = NULL; > + > +svt_ret = EbH265EncStreamHeader(svt_enc->svt_handle, _ptr); > +if (svt_ret != EB_ErrorNone) { > +av_log(avctx,

[FFmpeg-devel] [PATCH] avcodec/cbs: add missing comment about AV1 specific CodedBitstreamUnitType definition

2019-05-09 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h index 967dcd1468..65b3fe4fe9 100644 --- a/libavcodec/cbs.h +++ b/libavcodec/cbs.h @@ -45,6 +45,7 @@ struct CodedBitstreamType; /** * The codec-specific type

Re: [FFmpeg-devel] [PATCH 01/15] avformat/matroskaenc: Fix relative timestamp check

2019-05-08 Thread James Almer
On 5/6/2019 9:19 PM, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> At this point, ts already includes the ts_offset so that the relative >> time written with the cluster is already given by ts - mkv->cluster_pts. >> It is this number that needs to fit into an int16_t. >> >> Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avcodec/mlp_parser: split off shared code to its own file

2019-05-07 Thread James Almer
On 5/4/2019 4:36 PM, James Almer wrote: > On 5/4/2019 4:04 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/Makefile | 4 +- >> libavcodec/mlp_parse.c | 213 +++ >> libavc

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread James Almer
On 5/6/2019 7:04 PM, Carl Eugen Hoyos wrote: > Am Di., 7. Mai 2019 um 00:03 Uhr schrieb James Almer : >> >> On 5/6/2019 6:26 PM, Michael Niedermayer wrote: >>> also i agree with paul, the API looks good >>> implementation not really reviewed >> >> I

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread James Almer
On 5/6/2019 6:26 PM, Michael Niedermayer wrote: > also i agree with paul, the API looks good > implementation not really reviewed I don't like the avfft_* namespace. It's unlike other modules we have. Since av_fft_* is taken by the lavc implementation and can't be used, maybe this one could be

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: fix demuxing of very small frames

2019-05-05 Thread James Almer
On 5/4/2019 6:41 PM, James Almer wrote: > On 4/25/2019 7:04 PM, James Almer wrote: >> 10 bytes (id3v2 header amount of bytes) were being read before any checks >> were made on the bitstream. The result was that we were overreading into >> the next frame if the current one

Re: [FFmpeg-devel] [PATCH] avcodec/truehd_core: reset state when flushing

2019-05-05 Thread James Almer
On 5/5/2019 5:36 AM, Paul B Mahol wrote: > On 5/5/19, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/truehd_core_bsf.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/libavcodec/truehd_core_bsf.c b/libavcode

Re: [FFmpeg-devel] [PATCH v2] avcodec: add realtime bitstream filter

2019-05-04 Thread James Almer
On 5/4/2019 12:06 PM, Moritz Barsnick wrote: > On Fri, May 03, 2019 at 23:47:47 -0300, James Almer wrote: >> The flush() callback exists to reset the bsf into its initial state >> without the need to destroy and recreate the context. >> For example, some decoders auto-ins

[FFmpeg-devel] [PATCH] avcodec/truehd_core: reset state when flushing

2019-05-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/truehd_core_bsf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/truehd_core_bsf.c b/libavcodec/truehd_core_bsf.c index 409e570eec..9e3ee07eed 100644 --- a/libavcodec/truehd_core_bsf.c +++ b/libavcodec/truehd_core_bsf.c @@ -174,6

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: fix demuxing of very small frames

2019-05-04 Thread James Almer
On 4/25/2019 7:04 PM, James Almer wrote: > 10 bytes (id3v2 header amount of bytes) were being read before any checks > were made on the bitstream. The result was that we were overreading into > the next frame if the current one was 8 or 9 bytes long. > > Fixes tickets #7271 and #78

Re: [FFmpeg-devel] [PATCH] avcodec/mlp_parser: split off shared code to its own file

2019-05-04 Thread James Almer
On 5/4/2019 4:04 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/Makefile | 4 +- > libavcodec/mlp_parse.c | 213 +++ > libavcodec/{mlp_parser.h => mlp_parse.h} | 15 +- > li

[FFmpeg-devel] [PATCH] avcodec/mlp_parser: split off shared code to its own file

2019-05-04 Thread James Almer
Signed-off-by: James Almer --- libavcodec/Makefile | 4 +- libavcodec/mlp_parse.c | 213 +++ libavcodec/{mlp_parser.h => mlp_parse.h} | 15 +- libavcodec/mlp_parser.c | 193 +--- libavcodec/mlpde

Re: [FFmpeg-devel] [PATCH v2] avcodec: add realtime bitstream filter

2019-05-03 Thread James Almer
On 5/2/2019 7:42 AM, Moritz Barsnick wrote: > On Wed, May 01, 2019 at 12:03:41 -0300, James Almer wrote: >>> +if (pkt->pts != AV_NOPTS_VALUE) { >>> +int64_t pts = av_rescale_q(pkt->pts, bsf->time_base_in, >>> AV_TIME_BASE_Q) / ctx->speed; >

Re: [FFmpeg-devel] [PATCH v2] avcodec: add realtime bitstream filter

2019-05-01 Thread James Almer
On 5/1/2019 11:13 AM, Moritz Barsnick wrote: > Works for video and audio streams. > > Similar to the "-re" option in ffmpeg, but unlike that option does not > only work for input files, and is not only implemented for the > command line tool. This filter is available through the libraries, > and

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-01 Thread James Almer
On 4/29/2019 1:34 AM, Gyan wrote: > > > On 29-04-2019 05:37 AM, Marton Balint wrote: >> >> >> On Sun, 28 Apr 2019, Marton Balint wrote: >> >>> Hi All, >>> >>> There has been discussion on the mailing list several times about the >>> inclusion of support for closed source components (codecs,

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread James Almer
On 4/29/2019 4:23 AM, Reimar Döffinger wrote: > On 28.04.2019, at 22:02, Marton Balint wrote: > >> Hi All, >> >> There has been discussion on the mailing list several times about the >> inclusion of support for closed source components (codecs, formats, filters, >> etc) in the main ffmpeg

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h2645: use the fixed() macro for forbidden_zero_bit

2019-04-28 Thread James Almer
On 4/28/2019 8:00 PM, Mark Thompson wrote: > On 17/04/2019 03:56, James Almer wrote: >> This follows the spec definition, and removes a field from the relevant >> structs. >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h264

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: rename macros to read and write fields with custom range of values

2019-04-28 Thread James Almer
On 4/28/2019 8:19 PM, Mark Thompson wrote: > On 17/04/2019 03:56, James Almer wrote: >> These are more in line with the new ones introduced in the previous commit. >> >> Signed-off-by: James Almer >> --- >> No more i() macro :p >> >> Figured I'd

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h2645: add macros to read and write fields with no custom range of values

2019-04-28 Thread James Almer
On 4/28/2019 7:59 PM, Mark Thompson wrote: > On 17/04/2019 03:56, James Almer wrote: >> Signed-off-by: James Almer >> --- >> Better macro names welcome. I used the same convention as in cbs_av1. >> >> fate-cbs passes, but i'm sure a bunch of these are not tested

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: add missing value range constrains to timecode Metadata OBU

2019-04-28 Thread James Almer
On 4/28/2019 7:28 PM, Mark Thompson wrote: > On 17/04/2019 16:48, James Almer wrote: >> Also infer the value time_offset_length as 0 when it's not present. >> >> Signed-off-by: James Almer >> --- >> Fun thing, this metadata OBU is clearly base

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread James Almer
On 4/28/2019 5:02 PM, Marton Balint wrote: > Hi All, > > There has been discussion on the mailing list several times about the > inclusion of support for closed source components (codecs, formats, > filters, etc) in the main ffmpeg codebase. > > Also the removal of libNDI happened without

Re: [FFmpeg-devel] [PATCH] avcodec/scpr3: add missing check for decode_value3() return value

2019-04-27 Thread James Almer
On 4/26/2019 12:31 PM, James Almer wrote: > Fixes ticket #7866. > > Signed-off-by: James Almer > --- > libavcodec/scpr3.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c > index f92ccfa902..5cfad9f4d2 100644 > --

Re: [FFmpeg-devel] [PATCH] x86/opusdsp: replace loads with shuffles

2019-04-26 Thread James Almer
On 4/25/2019 2:51 PM, Lynne wrote: > > > > Apr 25, 2019, 6:44 PM by one...@gmail.com: > >> On 4/25/19, Paul B Mahol <> one...@gmail.com > > >> wrote: >> >>> On 4/24/19, Lynne <>> d...@lynne.ee >> > wrote: >>> Has a slight speedup. Can't

[FFmpeg-devel] [PATCH] avcodec/scpr3: add missing check for decode_value3() return value

2019-04-26 Thread James Almer
Fixes ticket #7866. Signed-off-by: James Almer --- libavcodec/scpr3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c index f92ccfa902..5cfad9f4d2 100644 --- a/libavcodec/scpr3.c +++ b/libavcodec/scpr3.c @@ -1038,6 +1038,9 @@ static int

Re: [FFmpeg-devel] [PATCH 3/3] Map 444 pix fmts to new VdpYCbCr types defined in VDPAU.

2019-04-26 Thread James Almer
On 4/26/2019 1:13 AM, ManojGuptaBonda wrote: > New VdpYCbCr Formats VDP_YCBCR_FORMAT_Y_U_V_444 and, > VDP_YCBCR_FORMAT_Y_UV_444 have been added in VDPAU to be used in > get/putbits for YUV 4:4:4 surfaces. Earlier mapping of > AV_PIX_FMT_YUV444P to VDP_YCBCR_FORMAT_YV12 is not valid. > > Hence

[FFmpeg-devel] [PATCH] avformat/aacdec: fix demuxing of very small frames

2019-04-25 Thread James Almer
10 bytes (id3v2 header amount of bytes) were being read before any checks were made on the bitstream. The result was that we were overreading into the next frame if the current one was 8 or 9 bytes long. Fixes tickets #7271 and #7869. Signed-off-by: James Almer --- libavformat/aacdec.c | 34

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-24 Thread James Almer
On 4/16/2019 6:48 PM, Mark Thompson wrote: > On 11/04/2019 04:10, James Almer wrote: >> On 4/10/2019 3:30 PM, James Almer wrote: >>> The spec defines the valid range of values to be INT32_MIN + 1 to >>> INT32_MAX, inclusive. >>> >>> Signed-off-by: J

[FFmpeg-devel] [PATCH] avcodec/cbs_mpeg2: fix leak of extra_information_slice buffer in cbs_mpeg2_read_slice_header()

2019-04-24 Thread James Almer
cbs_mpeg2_free_slice() calls av_buffer_unref() on extra_information_ref, meaning allocating with av_malloc() was not the intention. Signed-off-by: James Almer --- Couldn't find any mpeg2 sample containing these fields, so it's untested. The leak is obvious regardless of that. libavcodec

Re: [FFmpeg-devel] [PATCH v3 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-23 Thread James Almer
On 4/23/2019 7:55 PM, Andreas Rheinhardt wrote: > horizontal/vertical_size_value (containing the twelve least significant > bits of the frame size) mustn't be zero according to the specifications; > and the value 0 is forbidden for the colour_description elements. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-23 Thread James Almer
On 4/23/2019 5:32 PM, Andreas Rheinhardt wrote: > horizontal/vertical_size_value (containing the twelve least significant > bits of the frame size) mustn't be zero according to the specifications; > and the value 0 is forbidden for the colour_description elements. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 1/4] cbs_mpeg2: Correct and use enum values

2019-04-23 Thread James Almer
On 4/23/2019 5:32 PM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_mpeg2.c | 30 +++--- > libavcodec/cbs_mpeg2.h | 2 +- > libavcodec/cbs_mpeg2_syntax_template.c | 10 - > 3 files changed, 23

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h2645: add macros to read and write fields with no custom range of values

2019-04-22 Thread James Almer
On 4/16/2019 11:56 PM, James Almer wrote: > Signed-off-by: James Almer > --- > Better macro names welcome. I used the same convention as in cbs_av1. > > fate-cbs passes, but i'm sure a bunch of these are not tested by it, > so help double checking i didn't screw up is welcome

Re: [FFmpeg-devel] [PATCH 1/4] cbs_mpeg2: Correct and use enum values

2019-04-21 Thread James Almer
On 4/21/2019 11:04 AM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_mpeg2.c | 24 +++- > libavcodec/cbs_mpeg2.h | 2 +- > libavcodec/cbs_mpeg2_syntax_template.c | 10 +- > 3 files changed, 17

Re: [FFmpeg-devel] [PATCH 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-21 Thread James Almer
On 4/21/2019 11:04 AM, Andreas Rheinhardt wrote: > horizontal/vertical_size_value (containing the twelve least significant > bits of the frame size) mustn't be zero according to the specifications; > and the value 0 is forbidden for the colour_description elements. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 3/4] mpeg2_metadata, cbs_mpeg2: Fix handling of colour_description

2019-04-21 Thread James Almer
On 4/21/2019 11:04 AM, Andreas Rheinhardt wrote: > If a sequence display extension is read with colour_description equal to > zero, but a user wants to add one or more of the colour_description > elements, then the colour_description elements the user did not explicitly > request to be set are set

Re: [FFmpeg-devel] [PATCH] avformat/apetag: tag values are unsigned

2019-04-19 Thread James Almer
On 4/18/2019 9:56 PM, Dan Sanders via ffmpeg-devel wrote: >>> +#define APE_TAG_FLAG_CONTAINS_HEADER (1U << 31) >> >> Isn't it enough with this one only? > > Yes, only APE_TAG_FLAG_CONTAINS_HEADER is problematic. I changed all > of them because the tags are only used in unsigned contexts anyway.

Re: [FFmpeg-devel] [PATCH] avformat/apetag: tag values are unsigned

2019-04-18 Thread James Almer
On 4/18/2019 9:12 PM, Dan Sanders via ffmpeg-devel wrote: > Fixes: UBSan runtime error > Found-by: Clusterfuzz > --- > libavformat/apetag.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/apetag.c b/libavformat/apetag.c > index cdc602e1a9..2991f57d5d

Re: [FFmpeg-devel] [FFmpeg-cvslog] tests/fate: add fate-hls-segment-size for hls_segment_size test

2019-04-17 Thread James Almer
On 4/17/2019 10:35 PM, Carl Eugen Hoyos wrote: > 2019-04-17 10:11 GMT+02:00, Steven Liu : >> ffmpeg | branch: master | Steven Liu | Sun Apr 14 >> 21:22:22 2019 +0800| [2a50f1d9e414bdf3d97c6aa649769d17793f2991] | committer: >> Steven Liu >> >> tests/fate: add fate-hls-segment-size for

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: rename macros to read and write fields with custom range of values

2019-04-17 Thread James Almer
On 4/16/2019 11:56 PM, James Almer wrote: > @@ -164,9 +164,9 @@ static int FUNC(profile_tier_level)(CodedBitstreamContext > *ctx, RWContext *rw, > > for (i = 0; i < max_num_sub_layers_minus1; i++) { > if (current->sub_layer_profile_present_flag[i])

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: add missing value range constrains to timecode Metadata OBU

2019-04-17 Thread James Almer
Also infer the value time_offset_length as 0 when it's not present. Signed-off-by: James Almer --- Fun thing, this metadata OBU is clearly based on the H264/5 timecode SEI, yet time_offset_length is unsigned here :p libavcodec/cbs_av1_syntax_template.c | 14 -- 1 file changed, 8

[FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h2645: use the fixed() macro for forbidden_zero_bit

2019-04-16 Thread James Almer
This follows the spec definition, and removes a field from the relevant structs. Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 1 - libavcodec/cbs_h264_syntax_template.c | 2 +- libavcodec/cbs_h265.h | 1 - libavcodec/cbs_h265_syntax_template.c | 2 +- 4

[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h2645: rename macros to read and write fields with custom range of values

2019-04-16 Thread James Almer
These are more in line with the new ones introduced in the previous commit. Signed-off-by: James Almer --- No more i() macro :p Figured I'd leave all the byte and checksum fields using the custom range macro, to have the explicit hex values visible. That's why they were not changed in the first

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h2645: add macros to read and write fields with no custom range of values

2019-04-16 Thread James Almer
Signed-off-by: James Almer --- Better macro names welcome. I used the same convention as in cbs_av1. fate-cbs passes, but i'm sure a bunch of these are not tested by it, so help double checking i didn't screw up is welcome. libavcodec/cbs_h2645.c| 10 +- libavcodec

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/cbs_av1: use the new signed value read/write functions

2019-04-16 Thread James Almer
On 4/16/2019 8:10 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> The sample https://0x0.st/sljR.webm appears to be parsed the exact same way >> after this patch. >&

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/cbs_h264: fix storage type for time_offset in Pic Timing SEI

2019-04-16 Thread James Almer
On 4/16/2019 8:00 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> The spec defines it as a signed value. >> >> Signed-off-by: James Almer >> --- >> The only sample i could find with time_offset values it's in the fate suite, >> and

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

2019-04-16 Thread James Almer
On 4/16/2019 8:24 PM, Mark Thompson wrote: > On 17/04/2019 00:01, James Almer wrote: >> On 4/16/2019 7:57 PM, Mark Thompson wrote: >>> On 15/04/2019 22:17, James Almer wrote: >>>> Signed-off-by: James Almer >>>> --- >>>> libavcodec/cbs_h264

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread James Almer
On 4/16/2019 8:27 PM, Mark Thompson wrote: > On 16/04/2019 23:54, James Almer wrote: >> On 4/16/2019 7:45 PM, Mark Thompson wrote: >>> On 15/04/2019 22:17, James Almer wrote: >>>> Signed-off-by: James Almer >>>>

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/cbs_h265: fix storage type for time_offset_value in Time Code SEI

2019-04-16 Thread James Almer
On 4/16/2019 8:03 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> The spec defines it as an array of signed values, inferred to 0 when not >> present. >> >> Signed-off-by: James Almer >> --- >> Couldn't find any sample

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

2019-04-16 Thread James Almer
On 4/16/2019 7:57 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h2645.c | 20 >> 1 file changed, 20 insertions(+) >> >> diff --git a/libavcodec/cbs_h2

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-16 Thread James Almer
On 4/16/2019 7:45 PM, Mark Thompson wrote: > On 15/04/2019 22:17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs.c | 79 +++ >> libavcodec/cbs_internal.h | 20 +- >> 2 files chan

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: add support for Scalability Metadata

2019-04-16 Thread James Almer
On 4/16/2019 7:05 PM, Mark Thompson wrote: > On 14/04/2019 23:04, James Almer wrote: >> Signed-off-by: James Almer >> --- >> This will make the AV1RawObu struct weigh about ~3kb instead of ~1kb. >> >> libavcodec/av1.h | 33

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-16 Thread James Almer
On 4/16/2019 6:48 PM, Mark Thompson wrote: > On 11/04/2019 04:10, James Almer wrote: >> On 4/10/2019 3:30 PM, James Almer wrote: >>> The spec defines the valid range of values to be INT32_MIN + 1 to >>> INT32_MAX, inclusive. >>> >>> Signed-off-by: J

Re: [FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

2019-04-16 Thread James Almer
On 4/11/2019 12:10 AM, James Almer wrote: > On 4/10/2019 3:30 PM, James Almer wrote: >> The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, >> inclusive. >> >> Signed-off-by: James Almer >> --- >> A good example of why making offs

[FFmpeg-devel] [PATCH 2/5] avcodec/cbs_h2645: add helper macros for signed values

2019-04-15 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c | 20 1 file changed, 20 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index e74f8dce81..a205293b3c 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -255,6 +255,8 @@ static

[FFmpeg-devel] [PATCH 1/5] avcodec/cbs: add helper functions and macros to read and write signed values

2019-04-15 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs.c | 79 +++ libavcodec/cbs_internal.h | 20 +- 2 files changed, 98 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index c388be896b..726bd582f5 100644

[FFmpeg-devel] [PATCH 5/5] avcodec/cbs_av1: use the new signed value read/write functions

2019-04-15 Thread James Almer
Signed-off-by: James Almer --- The sample https://0x0.st/sljR.webm appears to be parsed the exact same way after this patch. libavcodec/cbs_av1.c | 68 ++-- 1 file changed, 8 insertions(+), 60 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec

[FFmpeg-devel] [PATCH 4/5] avcodec/cbs_h265: fix storage type for time_offset_value in Time Code SEI

2019-04-15 Thread James Almer
The spec defines it as an array of signed values, inferred to 0 when not present. Signed-off-by: James Almer --- Couldn't find any sample using it. libavcodec/cbs_h265.h | 2 +- libavcodec/cbs_h265_syntax_template.c | 7 +-- 2 files changed, 6 insertions(+), 3 deletions

[FFmpeg-devel] [PATCH 3/5] avcodec/cbs_h264: fix storage type for time_offset in Pic Timing SEI

2019-04-15 Thread James Almer
The spec defines it as a signed value. Signed-off-by: James Almer --- The only sample i could find with time_offset values it's in the fate suite, and in all cases it's 0. libavcodec/cbs_h264.h | 2 +- libavcodec/cbs_h264_syntax_template.c | 5 +++-- 2 files changed, 4

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: add support for Scalability Metadata

2019-04-14 Thread James Almer
Signed-off-by: James Almer --- This will make the AV1RawObu struct weigh about ~3kb instead of ~1kb. libavcodec/av1.h | 33 libavcodec/cbs_av1.h | 15 +- libavcodec/cbs_av1_syntax_template.c | 45 ++-- 3

Re: [FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_av1: add support for Padding OBUs

2019-04-14 Thread James Almer
On 4/14/2019 2:22 PM, Mark Thompson wrote: > On 13/04/2019 20:25, James Almer wrote: >> Based on itut_t35 Matadata OBU parsing code. >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1.c | 20 >> li

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: add a function to get a payload size without trailing zero bytes

2019-04-14 Thread James Almer
On 4/14/2019 2:17 PM, Mark Thompson wrote: > On 13/04/2019 20:21, James Almer wrote: >> Factor it out from cbs_av1_read_metadata_itut_t35() >> >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_av1.c | 11 +++ >> li

Re: [FFmpeg-devel] [PATCH] avcodec: add drop_changed_frames

2019-04-14 Thread James Almer
On 4/14/2019 3:29 PM, Hendrik Leppkes wrote: > On Sun, Apr 14, 2019 at 6:50 PM Gyan wrote: >> >> Implemented this patch >> http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241733.html >> >> >> in libavcodec as suggested by Michael >> > > This sure adds a lot of additional fields to the

Re: [FFmpeg-devel] [DECISION] Include more developers in the voting committee [#4]

2019-04-13 Thread James Almer
pporting this, 0 > against. > > So from now on, the voting committe consists of these people: > > Aman Gupta > Andreas Cadhalpun Andreas hasn't been around for a long time. > Carl Eugen Hoyos > Christophe Gisquet > Clément Bœsch > Ganesh Ajjanagadde Same with Ganesh.

Re: [FFmpeg-devel] [PATCH]lavfi/fspp: Add a cast to silence a clang warning

2019-04-13 Thread James Almer
On 4/13/2019 7:04 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences two warnings shown when compiling with clang: > libavfilter/vf_fspp.h:51:42: warning: implicit conversion from 'int' > to 'int16_t' (aka 'short') changes value from 44130 to -21406 > > Please comment, Carl Eugen > >

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: add a function to get a payload size without trailing zero bytes

2019-04-13 Thread James Almer
Factor it out from cbs_av1_read_metadata_itut_t35() Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 11 +++ libavcodec/cbs_av1_syntax_template.c | 10 +- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec

[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

2019-04-13 Thread James Almer
Based on itut_t35 Matadata OBU parsing code. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 20 + libavcodec/cbs_av1.h | 7 ++ libavcodec/cbs_av1_syntax_template.c | 32 3 files changed, 59 insertions

[FFmpeg-devel] [PATCH 2/2 v2] avcodec/cbs_av1: add support for Padding OBUs

2019-04-13 Thread James Almer
Based on itut_t35 Matadata OBU parsing code. Signed-off-by: James Almer --- libavcodec/cbs_av1.c | 20 libavcodec/cbs_av1.h | 7 +++ libavcodec/cbs_av1_syntax_template.c | 24 3 files changed, 51 insertions

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add support for Padding OBUs

2019-04-13 Thread James Almer
On 4/13/2019 4:21 PM, James Almer wrote: > Based on itut_t35 Matadata OBU parsing code. > > Signed-off-by: James Almer > --- > libavcodec/cbs_av1.c | 20 + > libavcodec/cbs_av1.h | 7 ++ > libavcodec/cbs_av1_s

  1   2   3   4   5   6   7   8   9   10   >