Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: Check input space

2019-05-14 Thread Kieran Kunhya
On Tue, 14 May 2019 at 20:42, Michael Niedermayer wrote: > Fixes: Timeout (33sec -> 78ms) > Fixes: > 14668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-5767073352908800 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-08 Thread Kieran Kunhya
> > if you dont return 3 fields you break the normative specification. This > speaks > about the "output of the decoding process" not how to interpret the output. > > I bring MPEG2 up here because we dont do what the normative spec says > because it doesnt make sense for us. It does make sense if

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-03 Thread Kieran Kunhya
> > > Kieran, > > Can you point to evidence on the same? An active legal threat to "a > developer writing an open source implementation of NDI"? > > With that in place, it wouldn't be ignored as a material fact, would it? > https://trac.ffmpeg.org/ticket/7589 Discussed in there. A few people in

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-03 Thread Kieran Kunhya
On Fri, 3 May 2019, 06:27 Jeyapal, Karthick, wrote: > > On Sun, Apr 28, 2019 at 4:02 PM Marton Balint wrote: > > > (In this case, NDI plugin is already open source). This is untrue. Furthermore, I am amazed you are all ignoring the fact this is an Open Source hostile company, actively

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Kieran Kunhya
> > [1] http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242574.html There are numerous inactive people in the voting committee, some for years. Why are they arbitrarily allowed to vote on this? Kieran ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] News: Removal of libndi

2019-03-25 Thread Kieran Kunhya
On Mon, 25 Mar 2019 at 13:56 Kieran Kunhya wrote: > On Mon, 25 Mar 2019 at 13:02 Yufei He wrote: > >> Hardware codecs and software codecs are taking different responsibilities. >> >> Thanks a lot. >> >> Yufei. >> > > Hi, > > You should

Re: [FFmpeg-devel] [PATCH] News: Removal of libndi

2019-03-25 Thread Kieran Kunhya
On Mon, 25 Mar 2019 at 13:02 Yufei He wrote: > Hardware codecs and software codecs are taking different responsibilities. > > Thanks a lot. > > Yufei. > Hi, You should expose the APIs to the hardware, people will buy more of them if they can program the chip to do things as they want. I

Re: [FFmpeg-devel] AVPixelFormat for YUYV 10 bit.

2019-03-25 Thread Kieran Kunhya
On Mon, 25 Mar 2019 at 13:53 Yufei He wrote: > Hi > > I think there may be one format missing in AVPixelFormat. > > AV_PIX_FMT_YUYV210 > For various reasons v210 and friends are implemented as a codec in FFmpeg. Kieran ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] News: Removal of libndi

2019-03-19 Thread Kieran Kunhya
0001-News-Removal-of-libndi.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4videodec: Check idx in mpeg4_decode_studio_block()

2019-03-11 Thread Kieran Kunhya
On Sun, 10 Mar 2019 at 04:43 Michael Niedermayer wrote: > Fixes: Out of array access > Fixes: > 13500/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5769760178962432 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] lavd: Remove libndi_newtek

2019-03-09 Thread Kieran Kunhya
They have not responded to any communications: https://trac.ffmpeg.org/ticket/7589 Kieran 0001-lavd-Remove-libndi_newtek.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Clear interlaced_dct for studio profile

2019-02-15 Thread Kieran Kunhya
ok On Fri, 15 Feb 2019 at 00:58 Michael Niedermayer wrote: > Fixes: Out of array access > Fixes: > 13090/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5408668986638336 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH] vf_showinfo: Fix timecode display

2019-01-24 Thread Kieran Kunhya
$subj - Indexing is wrong, off by one Kieran 0001-vf_showinfo-Fix-timecode-display.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-16 Thread Kieran Kunhya
On Thu, 17 Jan 2019 at 00:44 Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 12192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > > Before: > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > in 15423 ms > After: >

Re: [FFmpeg-devel] Transparency of sponsored works (was: avcodec: add photocd decoder)

2019-01-11 Thread Kieran Kunhya
On Fri, 11 Jan 2019 at 15:31 Nicolas George wrote: > Carl Eugen Hoyos (12019-01-11): > > I believe amount is never published (so far at least afair). > > I think it should. I wonder what other people think. > Are you completely out of your mind? Rega

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-25 Thread Kieran Kunhya
On Tue, 25 Dec 2018 at 22:17 Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > Before: Executed > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > in 11294 ms > After :

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/lagarith: Optimize case with singleton probability distribution

2018-12-24 Thread Kieran Kunhya
> > commit 0ca7a8deeffd33e05ae15a447259b32b6678c727 (HEAD -> master) > Author: Michael Niedermayer > Date: Mon Dec 24 01:14:50 2018 +0100 > > avcodec/lagarith: Optimize case with singleton probability distribution > > Fixes: Timeout > Fixes: >

Re: [FFmpeg-devel] [RFC] VDD FFmpeg session and community survey

2018-11-23 Thread Kieran Kunhya
> > > What if a majority of the committee is biased and bans everyone they > disagree with to take over the project? They certainly could. > What if the committee's decision is something the majority of the > developers disagree with? > > This is why I'm against formalizing such prodecures.

[FFmpeg-devel] Fwd: [OpenMedia] FOSDEM 2019 Open Media room - Call for speakers participation

2018-11-01 Thread Kieran Kunhya
-- Forwarded message - From: Zohar Babin Date: Fri, 12 Oct 2018 at 12:50 Subject: [OpenMedia] FOSDEM 2019 Open Media room - Call for speakers participation To: FOSDEM , Open Media devroom < open-media-devr...@lists.fosdem.org> Hi all, Join us on February 2, 2019 in Brussels for

[FFmpeg-devel] [PATCH] mpeg4video: Add SStP FATE test

2018-09-22 Thread Kieran Kunhya
0001-mpeg4video-Add-SStP-FATE-test.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv2] mpeg4video: Add Studio DPCM support

2018-08-23 Thread Kieran Kunhya
0001-mpeg4video-Add-Studio-DPCM-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add Studio DPCM support

2018-08-22 Thread Kieran Kunhya
On Wed, 22 Aug 2018 at 10:44 Carl Eugen Hoyos wrote: > 2018-08-22 1:29 GMT+02:00, Kieran Kunhya : > > $subj > > Please split the re-indentation and please fix the indentation of "else". > Would you mind explaining th

[FFmpeg-devel] [PATCH] mpeg4video: Add Studio DPCM support

2018-08-21 Thread Kieran Kunhya
$subj Depends on Michael's patch. I have a FATE sample frame. 0001-mpeg4video-Add-Studio-DPCM-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [GSOC][PATCH 2/3] lavc/cfhd:corrected decompanding for table 9 used in cfhd

2018-08-15 Thread Kieran Kunhya
On Tue, 14 Aug 2018 at 08:43 Gagandeep Singh wrote: > Second patch for fixing decompanding in table 9. > > Gagandeep Singh > Seems ok Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Sponsoring request

2018-07-19 Thread Kieran Kunhya
On Thu, 19 Jul 2018 at 14:04 Paul B Mahol wrote: > Hi, > > I want that FFmpeg community sponsor addition of new code I gonna > develop in following days/months. > > Thanks. > What code? I am happy to sponsor cleanup of libavfilter to be usable outside of ffmpeg.c and in a realtime environment.

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: Use bytestream2 for peaks

2018-07-15 Thread Kieran Kunhya
On Sat, 14 Jul 2018 at 00:14 Michael Niedermayer wrote: > This fixes out of array accesses > No testcase known > > Signed-off-by: Michael Niedermayer > Looks ok if Gagandeep is ok Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [GSOC][PATCH] lavc/cfhd:IP frame decoding (inverse 3d transform) introduced

2018-05-31 Thread Kieran Kunhya
Hi On Thu, 31 May 2018 at 12:25 Gagandeep Singh wrote: > --- > libavcodec/cfhd.c | 462 > ++ > libavcodec/cfhd.h | 15 +- > 2 files changed, 411 insertions(+), 66 deletions(-) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: deinterlacing introduced in cfhd

2018-05-21 Thread Kieran Kunhya
> > +static inline void interlaced_vertical_filter(int16_t *output, int16_t > *low, int16_t *high, > + int width, int linesize, int plane) > +{ > +int i; > +int16_t even, odd; > +for (i = 0; i < width; i++) { > + even = (*low - *high)/2; > + odd =

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: deinterlacing introduced in cfhd

2018-05-21 Thread Kieran Kunhya
Not really "deinterlacing", it would be "add interlaced file support" or similar. On Mon, 21 May 2018 at 20:17 Gagandeep Singh wrote: > +static inline void peak_table(int16_t *band, Peak *peak, int length) > +{ > +int i; > +for (i = 0; i < length; i++) > +

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/mpeg4videode: Eliminate out of loop VOP startcode reading for studio profile

2018-05-02 Thread Kieran Kunhya
> > About the past, it appears to me that there is a deeply rooted aversion by > some people toward some code. This just doesnt belong here. > Correct, mpeg4video decoding is some of the least understandable and undocumented code in the entirety of libavcodec. Decoding spans the following files

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4video: Detect reference studio streams as studio streams

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 22:57 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4video.h| 2 ++ > libavcodec/mpeg4videodec.c | 25 - > 2 files changed, 18 insertions(+), 9

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/mpeg4videode: Eliminate out of loop VOP startcode reading for studio profile

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 20:20 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/m4vdec: Fix detection of raw MPEG-4 ES Studio

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 22:57 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/m4vdec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/m4vdec.c b/libavformat/m4vdec.c > index

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpeg4video_parser: Fix incorrect spliting of MPEG-4 studio frames

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 22:57 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4video_parser.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/mpeg4video_parser.c >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mpeg4videodec: Move decode_studiovisualobject() parsing in the branch for visual object parsing

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 20:20 Michael Niedermayer wrote: > Fixes: runtime error: shift exponent -1 is negative > Fixes: > 7510/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5024523356209152 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/mpeg4videodec: Do not corrupt bits_per_raw_sample

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 20:20 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > OK ___

Re: [FFmpeg-devel] [GSoC] FFserver further development direction

2018-04-25 Thread Kieran Kunhya
On Wed, 25 Apr 2018 at 23:18 Nicolas George wrote: > Josh de Kock (2018-04-25): > > If anything, this should have never been added and a suitable > > external library should have been picked. > > This opinion should have been expressed three years ago. It was decided

Re: [FFmpeg-devel] lavc/mpeg4videodec: Do not ask for samples we already have

2018-04-02 Thread Kieran Kunhya
PCM samples. That one only has a small number of DPCM blocks which I can't even see when playing them back. Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv5] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-04-01 Thread Kieran Kunhya
0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/cfhd:fixed alpha channel decoding in gbrap12

2018-03-20 Thread Kieran Kunhya
> > ticket #6265, oops forgot this > Can you confirm this makes the png in the ticket look as expected? I was expecting the companding curve to also change for alpha. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Revert "Remove battleforthenet widget"

2018-03-04 Thread Kieran Kunhya
On Sun, 4 Mar 2018 at 22:59 Michael Niedermayer wrote: > On Sun, Mar 04, 2018 at 09:45:03AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Mar 4, 2018 at 9:24 AM, Compn wrote: > > > > > On Thu, 1 Mar 2018 06:59:45 -0500, "Ronald S. Bultje" > > >

Re: [FFmpeg-devel] [PATCH] Revert "Remove battleforthenet widget"

2018-03-04 Thread Kieran Kunhya
On Sun, 4 Mar 2018 at 14:50 Ronald S. Bultje wrote: > Hi, > > On Sun, Mar 4, 2018 at 9:24 AM, Compn wrote: > > > On Thu, 1 Mar 2018 06:59:45 -0500, "Ronald S. Bultje" > > wrote: > > > Again, please: no advertising, no politics. It was

Re: [FFmpeg-devel] FFmpeg 3.5 / 4.0

2018-02-19 Thread Kieran Kunhya
On Mon, 19 Feb 2018 at 16:06 James Almer wrote: > On 2/19/2018 5:54 AM, Paul B Mahol wrote: > > On 2/19/18, James Almer wrote: > >> On 2/18/2018 10:50 PM, Michael Niedermayer wrote: > >>> Hi > >>> > >>> Its 4 months since 3.4 was branched so its time for a

[FFmpeg-devel] [PATCHv4] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-02-10 Thread Kieran Kunhya
$subj. Still depends on simple_idct template patch Fixes crashes in ER 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-28 Thread Kieran Kunhya
Possibly fixed by below patch but frankly the ER code is impenetrable. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-28 Thread Kieran Kunhya
Patch updated to fix threading related crashes, thanks to Paul Mahol for assistance. Also fix segfaults on cut files by disabling unchecked bitstream reading. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-27 Thread Kieran Kunhya
Patch updated to possibly fix thread related bug reports. Tsan is better but not perfect. 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Avoid possibly aliasing violating casts

2018-01-27 Thread Kieran Kunhya
All 3 ok. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-27 Thread Kieran Kunhya
Patch updated. Still depends on [PATCH] simple_idct: Template functions to support an input bitdepth parameter. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Sat, Jan 27, 2018 at 12:33 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Fri, Jan 26, 2018 at 08:04:39PM +0000, Kieran Kunhya wrote: > > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > <mich...@niedermayer.cc > > > wrote: > > >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 10:53 AM, Carl Eugen Hoyos wrote: > 2018-01-22 11:41 GMT+01:00 Marton Balint : > > > Your command line shows gcc 4.7. Maybe this is > > some compiler issue then? > > I can also reproduce the issue with vanilla gcc 6.3.0, > so I don't

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Sun, Jan 21, 2018 at 12:37:21PM +0000, Kieran Kunhya wrote: > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > <mich...@niedermayer.cc> > > wrote: > > > >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 22:45 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote: > > > >>

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 15:34 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > >> > >> Only that I can not reproduce without your patch (and that I have > >> never seen this issu

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
> > Only that I can not reproduce without your patch (and that I have > never seen this issue before). > > Carl Eugen > I cannot reproduce this issue with ffplay on Ubuntu Linux. I would recommend running "make distclean" and recompiling. Kieran ___

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:42 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 14:33 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote: > > > >>

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 14:22 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > Can you reproduce the following issue that I see here? > When testing with ffplay, in ~50% of tries, videos look fine,

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:08 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 14:03 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote: > > > >>

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 13:37 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: > > > >> Hi > > > > Patch upd

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > Hi Patch updated. Some of the review comments I decided not to implement in order to keep closer to the spec. Regards, Kieran Kunhya 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-P

[FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2017-12-29 Thread Kieran Kunhya
$subj I'm not to happy about the s->block2 stuff, there are many ways of trying to resolve this (e.g union), so review welcome. I will add DPCM support in a later (currently unfinished) patch. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data

Re: [FFmpeg-devel] [RFC][PATCH] simple_idct: Template functions to support an input bitdepth parameter

2017-12-27 Thread Kieran Kunhya
On Wed, 27 Dec 2017 at 19:53 Michael Niedermayer wrote: > please call the functions ff_simple_idct_int16_10bit or something that > makes it > clear what the 2 numbers mean. > done > [...] is that faster than checking row 4-7 for 0 with sparse matrixes as occuring > in

[FFmpeg-devel] [RFC][PATCH] simple_idct: Template functions to support an input bitdepth parameter

2017-12-26 Thread Kieran Kunhya
For MPEG-4 Simple Studio Profile, I need to be able to support int32_t input coeffcients to the IDCT functions. I have attempted to implement this with the attached patch. Any comments would be appreciated, I'm pretty sure it is not optimal as-is. Regards, Kieran Kunhya 0001-simple_idct

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Limit error concealment to max_pixels

2017-11-20 Thread Kieran Kunhya
> > On Mon, 20 Nov 2017 at 17:26 Michael Niedermayer > wrote: > Error concealment is time consuming, limiting it in a pixel dependant way > allows > the decoder to be fuzzed with more frames quicker > How is this a reasonable fix considering you have submitted numerous

[FFmpeg-devel] [PATCH 2/2] h264dec: Remove mpegvideo dependency, it's not needed any more

2017-11-18 Thread Kieran Kunhya
$subj 0002-h264dec-Remove-mpegvideo-dependency-it-s-not-needed-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] libavcodec: Move ff_print_debug_info2 to mpegutils.c.

2017-11-18 Thread Kieran Kunhya
$subj 0001-libavcodec-Move-ff_print_debug_info2-to-mpegutils.c.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Kieran Kunhya
On Thu, 16 Nov 2017 at 18:21 Ronald S. Bultje wrote: > We are re-hashing old arguments here. I'm not really interested in that. > > My review comment is and remains: please remove the log msg. Otherwise, the > patch is perfectly fine. > I agree with Ronald's argument. I

Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 22:33 Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2017-11-04 21:27 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > > I need to remove MPEG-4 support from mpegvideo in order > > to upstream the following code: > > https://github.

[FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Kieran Kunhya
a new idct or use an existing (e.g ProRes) if applicable - DPCM mode (a bit like h264's mode) In particular I think this will break lowres. Is this ok or will the patch be blocked? Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 18:28 Michael Niedermayer wrote: > > The UUID can be corrupt as well. > > We shouldn't be printing random data from the bitstream to the users > > terminal. > > i agree > Ok, I will push unless someone objects. Kieran

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 6 May 2017 at 17:51 James Almer wrote: > The proper change here would be to look at the uuid and print only those > known to store printable strings, and of course after making sure they > are in fact printable. > As of now, that means x264's uuid only. > The UUID can

[FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-03 Thread Kieran Kunhya
This patch fixes very high memory usage on pathological streams. 0001-h2645-Allocate-a-single-buffer-per-packet.-Drastical.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] web/template_head2: Remove net neutrality script

2017-11-03 Thread Kieran Kunhya
On Thu, 2 Nov 2017 at 21:12 Lou Logan wrote: > I would prefer it if the site did not involve politics. > > I implemented a client side solution using an ad blocker, so consider > this patch dropped. > I agree, the popup is annoying. I would like to save the bees, whales,

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-11-02 Thread Kieran Kunhya
> > The idea would be that there would only be one uint8_t buffer and the > 2000 entries from te pool would point into that. > So as a larger NAL shifts through the 2000 the pointers would get > distributed differently but the size would not grow > Any variable size buffer the H2645NAL needs would

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-31 Thread Kieran Kunhya
On Tue, 31 Oct 2017 at 22:36 Niki Bowe wrote: > I was going to prepare a patch, but it sounds like Kieran is going to. > Thank you Kieran. Let me know if there's anything you want me to do, or if > you would prefer me to do it for the experience. > > As for the

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-31 Thread Kieran Kunhya
> > Am I missing something here? > > P.S. I see Kieran mailed the same thing as I wrote this. > Further to Derek's excellent explanation, I think the best way is to go back to the old "in-place" NAL parsing code for H264. I will prepare a patch to do this. Kieran

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-31 Thread Kieran Kunhya
> > This reduces memory consumption to linear from qudratic but i think > it still can be made to allocate very large amounts of memory. > That is with many small NAL units MAX_MBPAIR_SIZE would be allocated > for each.in worst case. > So this does fix the qudratic issue but not the OOM issue. >

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-31 Thread Kieran Kunhya
On Tue, 31 Oct 2017 at 02:26 Michael Niedermayer wrote: > On Thu, Oct 19, 2017 at 11:46:47AM -0700, Nikolas Bowe wrote: > > Found via fuzzing. > > /tmp/poc is a 1 MB mpegts file generated via fuzzing, where 1 packet has > many NALUs > > Before this change: > > $

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-30 Thread Kieran Kunhya
On Tue, 31 Oct 2017 at 01:42 Kieran Kunhya <kier...@obe.tv> wrote: > On Tue, 24 Oct 2017 at 00:56 Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > >> 2017-10-24 1:43 GMT+02:00 Niki Bowe <nbowe-at-google@ffmpeg.org>: >> > On Thu, Oct 19, 2017 at 3:39 P

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-30 Thread Kieran Kunhya
On Tue, 24 Oct 2017 at 00:56 Carl Eugen Hoyos wrote: > 2017-10-24 1:43 GMT+02:00 Niki Bowe : > > On Thu, Oct 19, 2017 at 3:39 PM, Carl Eugen Hoyos > > wrote: > > >> Does the patch have a measurable speed impact? > >> > > Is

Re: [FFmpeg-devel] [PATCH v4 2/2] rtp: rfc4175: add handler for YCbCr-4:2:2

2017-10-24 Thread Kieran Kunhya
> > Hi, > > I am surprised to see no mention on this work in changelog [1]. > > I would put: "partial support of SMPTE 2110-20 (RFC4175)". > > Thanks, > > Eloi > > [1]: https://github.com/FFmpeg/FFmpeg/blob/master/Changelog As an open source project we cannot cite unpublished documents. Kieran

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/scpr: optimize shift loop.

2017-09-08 Thread Kieran Kunhya
On Fri, 8 Sep 2017 at 22:29 Michael Niedermayer wrote: > Speeds code up from 50sec to 15sec > > Fixes Timeout > Fixes: 3242/clusterfuzz-testcase-5811951672229888 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check ld/cbd/crd

2017-09-03 Thread Kieran Kunhya
with obscure warnings. This happens on legal files as per my "SPS/PPS truncation" patch which scares them into thinking the file is broken. The same goes with spamming logs when there is some data corruption with warnings which are very obscure. Regards, Kieran Kunhya

Re: [FFmpeg-devel] [PATCH] h264: Make Truncating SPS/PPS message debug.

2017-09-02 Thread Kieran Kunhya
ping On Wed, 30 Aug 2017 at 14:44 Kieran Kunhya <kier...@obe.tv> wrote: > Padded SPS/PPS is perfectly legal. > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] h264: Make Truncating SPS/PPS message debug.

2017-08-30 Thread Kieran Kunhya
Padded SPS/PPS is perfectly legal. 0001-h264-Make-Truncating-SPS-PPS-message-debug.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Merge all libraries (was: all: avoid data imports across DLL) boundaries

2017-08-24 Thread Kieran Kunhya
> > I did not manage to find a real drawback. If somebody finds it a bad > idea, then please explain to me what benefit we get from having several > separate libraries. This is not a rhetorical question, I really would > like an explanation. But I do not agree with the obvious argument of > file

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

2017-08-23 Thread Kieran Kunhya
On Wed, 23 Aug 2017, 18:28 wm4 wrote: > On Wed, 23 Aug 2017 18:51:45 +0200 > "pkv.stream" wrote: > > > Hello > > > > the following patch extends number of output channel for decklink > > devices to 16. Previously it was limited to 2 or 8 audio

[FFmpeg-devel] [PATCH] vc2enc: Calculate average slice quantiser correctly

2017-07-24 Thread Kieran Kunhya
$subj 0001-vc2enc-Calculate-average-slice-quantiser-correctly.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Kieran Kunhya
On Sat, 22 Jul 2017 at 15:14 Nicolas George wrote: > Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit : > > The behaviour is based on assumptions: > > - copying audio data is cheap, so keeping data alignment is cheap, > > - copying video data is not cheap, so

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: Fix decoding regression due to height check

2017-07-22 Thread Kieran Kunhya
> > LGTM. Look at Libav repo, it is checked with a_height. > > Thank's. > Patch OK. As author of this code I would highly recommend not looking at libav repo because they broke a ton of stuff. Kieran ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-15 Thread Kieran Kunhya
> > > > Its just a automatically generated email signature > > for this specific one here, i think terrorism is a major problem the > world faces > Not so much because of terrorists or their victims but because of > what is being done by law makers and governments to counter terrorism. > (just

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-14 Thread Kieran Kunhya
On Thu, 13 Jul 2017 at 23:06 Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Wed, Jul 12, 2017 at 01:54:28PM +0000, Kieran Kunhya wrote: > > > > > > I actually would request a short note explaining the SUINTFLOAT type > usage. > > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

2017-07-12 Thread Kieran Kunhya
> > I actually would request a short note explaining the SUINTFLOAT type usage. > Something like: > +typedef unsignedSUINTFLOAT; // Equivalent to INTFLOAT, > Used as temporal cast to avoid undefined sign overflow operations. > > Maybe add such note to all "signed value in unsigned

Re: [FFmpeg-devel] [PATCH] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2017-07-10 Thread Kieran Kunhya
assign the > AVBufferRef pointer and assign the source field to NULL. > I can't do that, the source is const. Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2017-07-09 Thread Kieran Kunhya
$subj 0001-h264-Support-multi-field-closed-captions-by-using-AV.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/utvideodec: enable unchecked bitreader

2017-06-27 Thread Kieran Kunhya
On Tue, 27 Jun 2017 at 20:48 Michael Niedermayer wrote: > inner reader loop becomes 16% faster > > Signed-off-by: Michael Niedermayer > --- > libavcodec/utvideodec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Use intra_scantable in dct_unquantize_h263_intra_c()

2017-06-19 Thread Kieran Kunhya
On Tue, 20 Jun 2017, 00:38 Michael Niedermayer, wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c >

Re: [FFmpeg-devel] [PATCH] Add A53 Closed Captions to MPEG header if they are available.

2017-06-06 Thread Kieran Kunhya
> > The cc_count is only 5 bits, which mean that only 31 3-byte "closed caption > constructs" will fit in a "block".Testing this with 1080i60 material, I > found that 2 or 3 blocks was often necessary to hold all of the CC data. > > I tried ignoring that limit of 31 "constructs" per block, and

Re: [FFmpeg-devel] question on mosiac video issues -shortest

2017-05-23 Thread Kieran Kunhya
On Tue, 23 May 2017 at 10:26 Moritz Barsnick wrote: > On Sun, May 21, 2017 at 23:36:07 +, Kyle Douglas wrote: > > When using the param -shortest appears to have no impact on my ffmpeg > > command using multiple inputs as source. One is a looping slate video > that > > stops

Re: [FFmpeg-devel] FFMpeg GPL license Violations by Android apps

2017-05-15 Thread Kieran Kunhya
Hi, Out of interest, how did you automate this process? Is it as simple as looking for the FFmpeg configure string? Regards, Kieran Kunhya On Mon, 15 May 2017 at 16:36 riya khanna <riyakhanna1...@gmail.com> wrote: > Typo: We have inspected *1.6 million free* Google Playstore And

  1   2   3   4   >