Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-22 Thread Reimar Döffinger
On Tue, May 21, 2019 at 09:30:54PM +0200, Reimar Döffinger wrote: > > +#define SHIFT(v, shift) ((v) >> (shift)) > > +#define ABS_SHIFT(v, shift) ((v) > 0 ? SHIFT(v, shift) : -SHIFT(-v, shift)) > > Don't we have something like that already? Seems we don't > I thi

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Reimar Döffinger
dc += dc_pred[idx + 1].dc; > +count++; > +} Maybe do dc_pred += idx at the start and then only dc_pred[-6], dc_pred[6] etc? > +#define loop_stride 12 > +uint8_t loop[12 * loop_stride]; Hm, at 144 bytes, might it make sense to have in context instead of on stack? &g

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Reimar Döffinger
On Tue, May 21, 2019 at 11:15:03AM -0300, James Almer wrote: > > I have a feeling this loop should have a stop condition like v < > > SOME_LARGE_VALUE, say INT_MAX-255 or yuv_macroblock_count, to reject > > corrupt/malicious files and not cause undefined behavior > > Using get_bits_left(gb) would

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: add siren audio decoder

2019-05-21 Thread Reimar Döffinger
On Tue, May 21, 2019 at 04:51:19PM +0200, Moritz Barsnick wrote: > (It only matters on hardware which requires double precision software > emulation, but if explicitly using float, make sure to stick to float.) It's a best practice regardless of emulation or not. Even x86 has for example much

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Reimar Döffinger
On Mon, May 20, 2019 at 10:05:49AM +0200, Hendrik Leppkes wrote: > On Mon, May 20, 2019 at 9:44 AM Reimar Döffinger > wrote: > > On 20.05.2019, at 09:23, Mathieu Duponchelle > > wrote: > > > On 5/19/19 7:00 PM, Devin Heitmueller wrote: > > >> Are you

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-20 Thread Reimar Döffinger
On 20.05.2019, at 09:23, Mathieu Duponchelle wrote: > Thanks :) > > On 5/19/19 7:00 PM, Devin Heitmueller wrote: >> Hello Paul, >> >> On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: >>> On 5/17/19, Mathieu Duponchelle wrote: There isn't one, as I said the added indentation is

Re: [FFmpeg-devel] [PATCH] avcodec/v210dec: Fix alignment check for AVX2

2019-05-18 Thread Reimar Döffinger
On 18.05.2019, at 12:15, Michael Niedermayer wrote: > On Sat, May 18, 2019 at 12:02:55PM +0200, James Darnley wrote: >> On 2019-05-18 09:39, Michael Niedermayer wrote: >>> Fixes: "null pointer dereference" >>> Fixes: >>>

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-17 Thread Reimar Döffinger
to keep the feud going, please deal with the consequences yourself and stop dragging the whole project into your self-created messes. Sorry for the bluntness and my excuses if I ruined the chances for a peaceful weekend. Best regards, Reimar Döffinger. On 17.05.2019, at 21:25, Paul B Mahol

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-17 Thread Reimar Döffinger
On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: > ah, i see what you did there! it works perfectly, just missing > UPDATE_CACHE at the start and in the loop. > > test results on i7 decoding 3 minute long 4k video with vp4. Looks fairly close to noise to me, though for me it seemed a

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > > +static int read_mb_value(GetBitContext *gb) > > +{ > > +int v = 1; > > +int size; > > +OPEN_READER(re, gb); > &g

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > v = 127 + SHOW_UBITS(re, gb, 7); Sorry typo, must be 129 instead of 127. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > +OPEN_READER(re, gb); > + > +do { > +int bit; > +size = 0; > + > +UPDATE_CACHE(re, gb); > +bit =

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-15 Thread Reimar Döffinger
On Tue, May 14, 2019 at 08:41:02PM +0200, Lynne wrote: > May 14, 2019, 7:12 PM by one...@gmail.com: > > On 5/14/19, Carl Eugen Hoyos <> ceffm...@gmail.com > > > > wrote: > >>> Am 14.05.2019 um 19:17 schrieb Lynne <>>> d...@lynne.ee > >>> : >

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

2019-05-15 Thread Reimar Döffinger
On Wed, May 15, 2019 at 09:39:00AM +, Andreas Rheinhardt wrote: > > This problem really needs to be solved. The bitstream generated breaks the > > standard! > > > If I am not mistaken, then the bitstream generated doesn't break the > standard; it is just inconvenient for streaming purposes.

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-14 Thread Reimar Döffinger
On Tue, May 14, 2019 at 10:37:03PM +1000, Peter Ross wrote: > On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: > > On 12.05.2019, at 08:12, Peter Ross wrote: > > > +static int read_mb_value(GetBitContext *gb) > > > +{ > > >

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-14 Thread Reimar Döffinger
have other options. Compromise and consesus is always better. Though I admit a way to ask the mood more like a poll sounds interesting to me, maybe even anonymous? Best regards, Reimar Döffinger ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Reimar Döffinger
s it harder to enforce our license. Even if nothing happens, the work companies have to do to show compliance (because their customers require it or to reduce their risk) becomes much harder. Which is why the Linux kernel currently is working on cleaning up their license header mess. Best regards, Reimar D

Re: [FFmpeg-devel] Discussion of all-inclusive full stack builds

2019-05-12 Thread Reimar Döffinger
On Sun, May 12, 2019 at 12:07:42PM -0700, Tim Jones wrote: > On May 12, 2019, at 11:54 AM, Nicolas George wrote: > > > > Tim Jones (12019-05-12): > > > >> --disable-all-proprietary/--enable-all-proprietary > > > > As for this one, on the other hand, there will be opposition: we do not > > want

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Reimar Döffinger
On 12.05.2019, at 08:12, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > + > +do { > +size = 0; > +if (!get_bits1(gb)) > +break; > +v++; > +do { > +if (!get_bits1(gb)) > +

Re: [FFmpeg-devel] [PATCH v4] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-10 Thread Reimar Döffinger
tially many, many GB large video file for a 8-character string. A false positive has a REALLY high likelihood. I think this needs to be changed into a more clever approach, that actually knows where these strings can appear and removes them in a more targeted way... Best regards, Reimar Döffi

Re: [FFmpeg-devel] [PATCH v9] lavf/flv: Add XV (Xunlei Video) Support. fixes ticket #3720

2019-05-10 Thread Reimar Döffinger
On 10.05.2019, at 15:10, Shivam Goyal wrote: > > -> Making two avio contexts and one calling the other ( I am not sure if > i implemented it in the right way, but still i reached low level ). Can't you at least figure out the header size, decrypt the header and pass that to the normal header

Re: [FFmpeg-devel] [PATCH v3] lavf/h264: add support for h264 video from Arecont camera, fixes ticket #5154

2019-05-08 Thread Reimar Döffinger
cpy(pkt->data + new_size, data + j + 2, end - j -1); > +new_size += end - j - 1; > +w = 1; > +break; > +} else if (j + 1 > end && i > start && i <= end) { > +memcpy(pkt->data

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-08 Thread Reimar Döffinger
On Wed, May 08, 2019 at 03:06:37PM +0530, Swaraj Hota wrote: > On Wed, May 08, 2019 at 12:52:01AM +0200, Reimar Döffinger wrote: > > First, seeking should be handled specially, by resetting the state. > > You should not make the get_packet less efficient because of that. > &g

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-08 Thread Reimar Döffinger
On 08.05.2019, at 08:01, Carl Eugen Hoyos wrote: > Am Mi., 8. Mai 2019 um 00:52 Uhr schrieb Reimar Döffinger > : >> >> On 07.05.2019, at 12:00, Swaraj Hota wrote: >> >>> On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: >>

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-07 Thread Reimar Döffinger
On 07.05.2019, at 12:00, Swaraj Hota wrote: > On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: >> >> >>> +/*read video index*/ >>> +avio_seek(s->pb, 0xf8, SEEK_SET); >> [...] >>> +avio_skip(s->pb, ifv->vi

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-07 Thread Reimar Döffinger
On 07.05.2019, at 01:33, Lynne wrote: > May 6, 2019, 11:41 PM by barsn...@gmx.net: > >> On Mon, May 06, 2019 at 02:23:26 +0200, Lynne wrote: >> >>> This allowed for the exptabs to be computed just once on startup and >>> stored in a global array. >>> >> >> I have no real understanding of

[FFmpeg-devel] Quo vadis, code of conduct?

2019-05-05 Thread Reimar Döffinger
up to it, that is quite a different thing from standing up for it). My apologies for barging in here and starting this kind of thing. But if you haven't lately given it a thought where you stand on the topic, I take the liberty to ask you to. Best regards, Reimar Döffinger P.S.: I followed my own

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-05 Thread Reimar Döffinger
On Sun, May 05, 2019 at 10:05:17PM +0200, Carl Eugen Hoyos wrote: > Am So., 5. Mai 2019 um 21:59 Uhr schrieb Reimar Döffinger > : > > > +if (aud_magic == MKTAG('G','R','A','W')) { > > > +ifv->is_audio_present = 1; > > > +} else i

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-05 Thread Reimar Döffinger
_offset is ordered increasingly (as would be needed for binary search), but that property isn't really checked/enforced. > +av_freep(>vid_index); > +if (ifv->is_audio_present) > +av_freep(>aud_index); Shouldn't the if () be unnecessary? Best regards, Reimar Döffinger ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Reimar Döffinger
On 05.05.2019, at 18:04, Paul B Mahol wrote: > On 5/5/19, Reimar Döffinger wrote: >> On 04.05.2019, at 15:40, Paul B Mahol wrote: >>> Hi, >>> >>> I open voting for 7 days, for inclusion of colorhold filter in FFmpeg, >>> with minor changes. >&g

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Reimar Döffinger
ary vs. the normal development process? I so far assumed voting was purely a last-resort conflict resolution process. Is there a quorum required, or would a vote be accepted even if there was only one vote cast? Best regards, Reimar Döffinger ___ ffmpeg-

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-05 Thread Reimar Döffinger
On 03.05.2019, at 20:16, Michael Niedermayer wrote: > On Fri, May 03, 2019 at 11:08:35AM +0200, Carl Eugen Hoyos wrote: >> Am Fr., 3. Mai 2019 um 07:27 Uhr schrieb Jeyapal, Karthick >> : > >> And finally: What do you suggest to "punish the violator"? > > while this question wasnt directed at

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Reimar Döffinger
ifferent world views meet head-on, and hope you can discuss in that spirit :) Best regards, Reimar Döffinger ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Server upgrades

2019-02-06 Thread Reimar Döffinger
On 6 February 2019 11:46:52 CET, Michael Niedermayer wrote: >On Tue, Feb 05, 2019 at 05:03:02PM +, Eoff, Ullysses A wrote: >> I'm getting an ssl error >> with pwclient today. This is the first time I've tried using >pwclient since this >> upgrade, so not sure if it's related. >> >>

Re: [FFmpeg-devel] [PATCH] avcodec: increase AV_INPUT_BUFFER_PADDING_SIZE to 64

2018-01-08 Thread Reimar Döffinger
lt;= 52 failed at libavformat/oggparseogm.c:109 > > > Aborted (core dumped) > > > > How do you say this should be fixed? Why should > > AV_INPUT_BUFFER_PADDING_SIZE be lower or equal to 52? > > > > I have no idea about OGM, so i could use some help. > &g

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-16 Thread Reimar Döffinger
On Fri, Sep 15, 2017 at 02:16:58AM +0200, Michael Niedermayer wrote: > On Wed, Sep 13, 2017 at 08:11:38PM +0200, Reimar Döffinger wrote: > > On Wed, Sep 13, 2017 at 07:12:48PM +0200, Reimar Döffinger wrote: > > > This is the equivalent to what 7d317d4706b49d572a1eb5269438753b

Re: [FFmpeg-devel] [PATCH] configure: check if NAN can be used as a constant initializer

2017-09-13 Thread Reimar Döffinger
On Wed, Sep 13, 2017 at 02:49:59PM -0300, James Almer wrote: > On 9/13/2017 2:23 PM, Carl Eugen Hoyos wrote: > > 2017-09-13 19:10 GMT+02:00 James Almer : > >> Some targets, like NetBSD and DJGPP, don't seem to support it. > >> > >> Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-13 Thread Reimar Döffinger
On Wed, Sep 13, 2017 at 07:12:48PM +0200, Reimar Döffinger wrote: > This is the equivalent to what 7d317d4706b49d572a1eb5269438753be18362c7 > did for the codec-specific options. > av_opt_copy has specific handling so it's fine that we already copied > the whole context before. Btw, if

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-09-13 Thread Reimar Döffinger
On Wed, Aug 23, 2017 at 10:26:45PM +0200, Alexander Strasser wrote: > On 2017-08-22 17:23 +, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Tue Aug 22 18:36:26 2017 +0200| [a2e444d5bb2e3115d3afcc0cca9d1506c90436a2] > > | committer:

[FFmpeg-devel] [PATCH] avcodec/frame_thread_encoder: Fix AV_OPT_TYPE_STRING handling in avctx

2017-09-13 Thread Reimar Döffinger
This is the equivalent to what 7d317d4706b49d572a1eb5269438753be18362c7 did for the codec-specific options. av_opt_copy has specific handling so it's fine that we already copied the whole context before. Signed-off-by: Reimar Döffinger <reimar.doeffin...@gmx.de> --- liba

Re: [FFmpeg-devel] [WIP] libcodec2 wrapper + de/muxer in FFmpeg

2017-08-03 Thread Reimar Döffinger
On Thu, Aug 03, 2017 at 12:40:04AM +0200, Tomas Härdin wrote: > +//statically assert the size of avpriv_codec2_header > +//putting it here because all codec2 things depend on codec2utils > +switch(0) { > +case 0: > +case sizeof(avpriv_codec2_header) == 7: //if false then the

Re: [FFmpeg-devel] [PATCHv2 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

2017-08-02 Thread Reimar Döffinger
On 02.08.2017, at 19:53, Jorge Ramirez wrote: > On 08/02/2017 07:40 PM, Hendrik Leppkes wrote: >> On Wed, Aug 2, 2017 at 7:14 PM, Jorge Ramirez >> wrote: >>> I just think is wrong and I am a bit surprised we could have no real >>>

Re: [FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-29 Thread Reimar Döffinger
On 28.07.2017, at 12:07, James Le Cuirot wrote: > diff --git a/ffbuild/libffmpeg.mak b/ffbuild/libffmpeg.mak > new file mode 100644 > index 000..992cf3c > --- /dev/null > +++ b/ffbuild/libffmpeg.mak > @@ -0,0 +1,21 @@ > +LIBFFMPEG = $(SLIBPREF)ffmpeg$(SLIBSUF) >

Re: [FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-29 Thread Reimar Döffinger
On 29.07.2017, at 01:05, Ivan Kalvachev wrote: > On 7/29/17, Dominik 'Rathann' Mierzejewski wrote: >> On Saturday, 29 July 2017 at 00:20, Hendrik Leppkes wrote: >>> On Fri, Jul 28, 2017 at 12:07 PM, James Le Cuirot >>> wrote: >>

Re: [FFmpeg-devel] [PATCH 3/4] libavcodec: v4l2: add codec formats

2017-07-24 Thread Reimar Döffinger
On 24.07.2017, at 21:08, Jorge Ramirez-Ortiz wrote: > From: Alexis Ballier > > In addition, enable the multi planar raw formats. I see the existing code already does it like that, but I don't think that is the best way. Defining the macro

Re: [FFmpeg-devel] [PATCH 1/4] Move lavd/v4l2-common.* to lavc

2017-07-24 Thread Reimar Döffinger
Hmm... a bit weird that we have a file with a dash in the file name when everything else uses underscore... On 24.07.2017, at 21:08, Jorge Ramirez-Ortiz wrote: > From: Alexis Ballier > > In preparation to support the integation of the

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 13:32, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Jul 23, 2017 at 09:35:12AM +0200, Reimar Döffinger wrote: >> >> >> Btw the comodo certificate Michael mentioned is a domain-validation >> certificate for 7x the price of w

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 12:20, Nicolas George wrote: > >> +if (!q->last_pkt) { >> +q->first_pkt = pkt1; >> +} else { >> +q->last_pkt->next = pkt1; >> +} If kept, I would invert the condition, otherwise the else is essentially a double-negation. >> +

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 23.07.2017, at 09:27, Reimar Döffinger <reimar.doeffin...@gmx.de> wrote: > On 21.07.2017, at 15:31, Ricardo Constantino <wiia...@gmail.com> wrote: > >> On 18 July 2017 at 02:12, Gerion Entrup <gerion.entrup.ff...@flump.de> wrote: >>> Am Dienstag, 18.

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-23 Thread Reimar Döffinger
On 21.07.2017, at 15:31, Ricardo Constantino <wiia...@gmail.com> wrote: > On 18 July 2017 at 02:12, Gerion Entrup <gerion.entrup.ff...@flump.de> wrote: >> Am Dienstag, 18. Juli 2017, 01:52:53 CEST schrieb Reimar Döffinger: >>> On 18.07.2017, at 00:59, James A

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-22 Thread Reimar Döffinger
On 22.07.2017, at 10:45, Reimar Döffinger <reimar.doeffin...@gmx.de> wrote: > > Sorry for disturbing anyone's fun with too much philosophy ;) I also apologize that I sent my previous mail, which was the first on the topic, to the public mailing list. I SHOULD know better and contac

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-22 Thread Reimar Döffinger
On 21.07.2017, at 20:48, Paul B Mahol wrote: > On 7/21/17, Reimar Doeffinger wrote: >> On 21.07.2017, at 08:48, Paul B Mahol wrote: >> >>> On 7/20/17, Carl Eugen Hoyos wrote: 2017-07-20 17:46 GMT+02:00

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-21 Thread Reimar Döffinger
On 21.07.2017, at 08:48, Paul B Mahol wrote: > On 7/20/17, Carl Eugen Hoyos wrote: >> 2017-07-20 17:46 GMT+02:00 Vittorio Giovara : >> >>> +[AV_PIX_FMT_YUV444F32LE] = { 0, 0 }, >>> +[AV_PIX_FMT_YUV444F32BE] = { 0, 0 },

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-21 Thread Reimar Döffinger
On 21.07.2017, at 16:26, Paras Chadha wrote: > On Fri, Jul 21, 2017 at 3:27 AM, Carl Eugen Hoyos > wrote: > >> 2017-07-20 21:46 GMT+02:00 Paras Chadha : >> >>> +case AV_PIX_FMT_RGB24: >>> +case

Re: [FFmpeg-devel] [PATCHv2 1/2] avdevice/decklink_dec: add support for decoding teletext from 10bit ancillary data

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 18:48, Marton Balint wrote: > > On Wed, 19 Jul 2017, John Warburton wrote: > >> On Tue, Jul 18, 2017 at 6:10 PM, Marton Balint wrote: >>> On Sat, 8 Jul 2017, Marton Balint wrote: >>> This also add supports for 4K DeckLink cards because

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 12:03, Nicolas George wrote: > What I do insist on, is this: > > Look at the find_size() function in this patch: > https://ffmpeg.org/pipermail/ffmpeg-devel/2017-July/213076.html > > Then look at the fits_read_header() in this patch: >

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-19 Thread Reimar Döffinger
On 19.07.2017, at 12:03, Nicolas George wrote: > Le decadi 30 messidor, an CCXXV, Rostislav Pehlivanov a écrit : > >> I think the image2 demuxer shouldn't handle this type of junk/useless data >> filtering and would rather see a separate demuxer like the current patch >> which

Re: [FFmpeg-devel] SSL certificate for ffmpeg.org website is not valid anymore

2017-07-17 Thread Reimar Döffinger
On 18.07.2017, at 00:59, James Almer wrote: > On 7/17/2017 7:49 PM, Moritz Barsnick wrote: >> On Mon, Jul 10, 2017 at 13:53:02 +0300, Boris Pek wrote: >>> Latest news about this topic: >>> https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/FKXe-76GO8Y >> >> Ah,

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 15:08, Nicolas George wrote: > L'octidi 28 messidor, an CCXXV, Derek Buitenhuis a écrit : >> Why is there no decoder? > > Because the decoder is in a separate patch, and the demuxer in yet > another. And none of them can proceed until Paras Chadha starts

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-16 Thread Reimar Döffinger
On 16.07.2017, at 14:31, Paras Chadha wrote: > +static int write_keyword_value(uint8_t **bytestream, const char * keyword, > int value) > +{ > +int len, ret; > +uint8_t * header = * bytestream; > +len = strlen(keyword); > + > +memcpy(header, keyword,

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-15 Thread Reimar Döffinger
On 14.07.2017, at 19:04, Paras Chadha wrote: > +static int write_keyword_value(char * header, const char * keyword, int > value) > +{ > +int i, len, ret; > +len = strlen(keyword); > +for (i = 0; i < len; i++) { > +header[i] = keyword[i]; > +}

Re: [FFmpeg-devel] [PATCH] avcodec: add MagicYUV encoder

2017-07-14 Thread Reimar Döffinger
On 14.07.2017, at 16:30, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol Probably not making myself popular with that request, but maybe you could do a pass over the code and add comments for things that might be useful for people to know? If you need

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

2017-07-13 Thread Reimar Döffinger
On 13.07.2017, at 16:49, Derek Buitenhuis wrote: > On 7/13/2017 3:11 PM, wm4 wrote: >> We definitely use some C99 constructs in FFmpeg, but normally we don't >> use stdbool.h. > > Yeah, but we disallow others (like VLAs), so, yeah. I think it's more of a case of

Re: [FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

2017-07-13 Thread Reimar Döffinger
On 13.07.2017, at 14:10, "Geek.Song" wrote: > On Wed, Jul 12, 2017 at 1:50 PM, Steven Liu wrote: >> 2017-07-12 12:32 GMT+08:00 Geek.Song : >>> In ffmpeg.c: >>> // >>> // @ static int process_input_packet(InputStream *ist, const

Re: [FFmpeg-devel] Ticket 6375, Too many packets buffered for output stream

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 22:37, Hendrik Leppkes wrote: > > Either extremely badly intereleaved streams or streams that just start > super late in the file have always been very problematic for decoding, > resulting in various hacks over the years to add "best-guess" default >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 16:08, "Ronald S. Bultje" <rsbul...@gmail.com> wrote: > Hi, > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger <reimar.doeffin...@gmx.de> > wrote: > >> On 09.07.2017, at 02:52, "Ronald S. Bultje" <rsbul...@gmail

Re: [FFmpeg-devel] Ticket 6375, Too many packets buffered for output stream

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 13:09, Michael Niedermayer wrote: > Hi all > > It does appear this regression affects alot of people, judging from > the multiple different people in the ticket. > Also people ask me about this, for example baptiste yesterday hit it > too. > > I belive

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > wrote: > >> >> Does anyone object to this patch ? >> Or does anyone have a better idea on how to fix this ? >> if not id like to apply it > >

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-08 Thread Reimar Döffinger
On Tue, Jul 04, 2017 at 09:50:31PM +0530, Paras Chadha wrote: > On Tue, Jul 4, 2017 at 4:12 AM, Reimar Döffinger <reimar.doeffin...@gmx.de> > wrote: > > > +data_size *= naxisn[i]; > > > +if (data_size < 0) > > > +

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-08 Thread Reimar Döffinger
On Sat, Jul 08, 2017 at 12:59:09PM +0200, Nicolas George wrote: > Le sextidi 16 messidor, an CCXXV, Paras Chadha a écrit : > > So, now should i do this ? > > Based on what you explained here, FITS seems like just an image format, > without provisions for animations like GIF or PNG. Therefore, it

Re: [FFmpeg-devel] [PATCH 1/1] This change adds an encoder for Camera metadata motion. This is a type of sensor data associated with video, such as GPS, acceleration, gyro, and camera orientation. It

2017-07-07 Thread Reimar Döffinger
I don't know what you are trying to achieve, but an encoder that just copies things through makes no sense. If it's just about validating or logging some kind of parser or (bitstream-)filter probably makes more sense. Even if doing it as encoder, why should it be a video encoder instead of

Re: [FFmpeg-devel] [PATCH] configure: require pkg-config for libvorbis

2017-07-04 Thread Reimar Döffinger
On 04.07.2017, at 14:03, Ricardo Constantino <wiia...@gmail.com> wrote: > On 4 July 2017 at 07:54, Reimar Döffinger <reimar.doeffin...@gmx.de> wrote: >> On 30.06.2017, at 20:06, Ricardo Constantino <wiia...@gmail.com> wrote: >> >>> libvorbis comes with p

Re: [FFmpeg-devel] [PATCH] decode.c: Handle 0-size packets in compat_decode

2017-07-04 Thread Reimar Döffinger
On 04.07.2017, at 10:42, wm4 wrote: > Not really comfortable with the current patch. Why does it even touch > the compat_decode_partial_size handling path? Because that is the code that gets utterly confused by 0-size packets and breaks everything. For ac3 what happens is

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/utvideodec: Factor multiply out of inner loop

2017-07-04 Thread Reimar Döffinger
On 28.06.2017, at 10:52, Timo Rothenpieler wrote: > Am 27.06.2017 um 21:47 schrieb Michael Niedermayer: >> 0.5% faster loop >> >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/utvideodec.c | 6 -- >> 1 file changed, 4 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] configure: require pkg-config for libvorbis

2017-07-04 Thread Reimar Döffinger
On 30.06.2017, at 20:06, Ricardo Constantino wrote: > libvorbis comes with pkg-config files since at least v1.0.1, way back > in 2003. > > The extra check is needed for shared builds, as the pkg-config file > for vorbisenc doesn't include vorbis and ogg if --static isn't

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-04 Thread Reimar Döffinger
On 04.07.2017, at 00:51, Nicolas George <geo...@nsup.org> wrote: > Hi. Nice to see you back. > > Le sextidi 16 messidor, an CCXXV, Reimar Döffinger a écrit : >> This is more than 4kB of data on the stack. >> Large stack arrays have a huge amount of security

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-03 Thread Reimar Döffinger
> +static int64_t find_size(AVIOContext * pb, FITSContext * fits) > +{ > +int bitpix, naxis, dim_no, i, naxisn[999], groups=0; > +int64_t header_size = 0, data_size=0, ret, pcount=0, gcount=1, d; > +char buf[81], c; This is more than 4kB of data on the stack. Large stack arrays have

Re: [FFmpeg-devel] [PATCH 2/5] movenc: simplify codec_tag lookup

2017-07-03 Thread Reimar Döffinger
On 03.07.2017, at 17:17, Derek Buitenhuis wrote: > On 7/3/2017 2:18 AM, Michael Niedermayer wrote: >> breaks fate > > I'll look into it tonight; busy today. > > . > . > . > > Aside: > > I'll just add, though, that these two word 'breaks fate' emails > are kind of

Re: [FFmpeg-devel] [PATCH] decode.c: Handle 0-size packets in compat_decode

2017-07-03 Thread Reimar Döffinger
On 03.07.2017, at 21:07, wm4 <nfx...@googlemail.com> wrote: > On Mon, 3 Jul 2017 20:57:21 +0200 > Reimar Döffinger <reimar.doeffin...@gmx.de> wrote: > >> The old API did that just fine, and if we provide >> a compatibility layer it should at least be compatib

[FFmpeg-devel] [PATCH] decode.c: Handle 0-size packets in compat_decode

2017-07-03 Thread Reimar Döffinger
The old API did that just fine, and if we provide a compatibility layer it should at least be compatible. For the test-case (feeding AVParser output directly to decoder, failing to discard 0-size packets) just discarding 0-size packets at the start works, but not sure if in some cases we might

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-11 Thread Reimar Döffinger
On 11.05.2016, at 21:09, James Almer <jamr...@gmail.com> wrote: > On 5/11/2016 4:04 PM, Reimar Döffinger wrote: >> otherwise there's a risk that enabling the recently discussed >> -ftree-vecorize for that file specifically would give better results. > > Tree vectorize

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-05-11 Thread Reimar Döffinger
On 11.05.2016, at 17:00, Bruce Dawson wrote: > Microsoft is aware of the issue and is working on it. They might fix it. > They might not, however, because regressions in non-standard behavior are > not as serious. We will see. > > I'm committing a Chromium

Re: [FFmpeg-devel] 回复: Add ARM64 NEON optimization for HEVC decoder about Fate test

2016-05-11 Thread Reimar Döffinger
On 11.05.2016, at 14:03, Carl Eugen Hoyos wrote: > 章军海 <243186085 qq.com> writes: > >> I wonder how you all test FATE on arm or arm64 hardware. > > To actually test fate on small devices like mobile phones, > you have to use the configure option --target-exec and > point

Re: [FFmpeg-devel] [PATCH] swresample/arm: add ff_resample_common_apply_filter_{x4, x8}_{float, s16}_neon

2016-05-11 Thread Reimar Döffinger
On 11.05.2016, at 20:37, Michael Niedermayer wrote: > On Wed, May 11, 2016 at 06:39:20PM +0200, Matthieu Bouron wrote: >> From: Matthieu Bouron >> >> --- >> >> Hello, >> >> Here are some benchmark on a rpi2 of the attached patch. >>

Re: [FFmpeg-devel] [PATCH 2/2] configure: Enable GCC vectorization on ≥4.9

2016-05-08 Thread Reimar Döffinger
On 07.05.2016, at 02:56, Hendrik Leppkes wrote: > On Sat, May 7, 2016 at 2:02 AM, James Almer wrote: >> On 5/6/2016 8:48 PM, Timothy Gu wrote: >>> On Fri, May 06, 2016 at 12:08:14PM +0200, Hendrik Leppkes wrote: Just to document it, this has

Re: [FFmpeg-devel] [Patch] Add input swap functionality to movie filter (src_movie.c)

2016-05-06 Thread Reimar Döffinger
On 04.05.2016, at 17:01, "Felt, Patrick" wrote: > > On 5/4/16, 5:52 AM, "ffmpeg-devel on behalf of Clément Bœsch" > wrote: > >> >> [...] >>> +/* libavfilter documentation says that filter init will be

Re: [FFmpeg-devel] [PATCH] ffplay: force setting alsa buffer size

2016-05-01 Thread Reimar Döffinger
On Sat, Apr 30, 2016 at 10:17:33PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > ffplay.c | 7 +++ > 1 file changed, 7 insertions(+) I have a nagging feeling someone with better knowledge of ALSA and how we handle it might find a better solution, but

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-23 Thread Reimar Döffinger
On 23.04.2016, at 13:21, wm4 wrote: > On Sat, 23 Apr 2016 01:16:31 +0200 > Hendrik Leppkes wrote: > >> On Sat, Apr 23, 2016 at 1:02 AM, Bruce Dawson >> wrote: >>> I've noticed that when CONFIG_W64_DEMUXER is

Re: [FFmpeg-devel] [PATCH] ffplay: use 48 kHz for ALSA output

2016-04-21 Thread Reimar Döffinger
On 20.04.2016, at 23:59, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > ffplay.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/ffplay.c b/ffplay.c > index 804bcbc..89a34d2 100644 > --- a/ffplay.c > +++ b/ffplay.c > @@ -2578,12

Re: [FFmpeg-devel] [PATCH 3/3] configure: Remove -Wredundant-decls on OS/2 to suppress noise.

2016-04-21 Thread Reimar Döffinger
On 21.04.2016, at 06:02, Dave Yeo wrote: > On 04/20/16 07:40 PM, Michael Niedermayer wrote: >> On Thu, Apr 14, 2016 at 07:31:48PM -0700, Dave Yeo wrote: >>> From a417fdf752bd7c704ed5ba0c94c5cea96e1a91ff Mon Sep 17 00:00:00 2001 >>> From: Dmitriy Kuminov >>>

[FFmpeg-devel] [PATCH] colorspace.h: Remove unused macro argument.

2016-04-19 Thread Reimar Döffinger
--- libavcodec/dvbsub.c | 4 ++-- libavfilter/drawutils.c | 8 libavfilter/vf_drawbox.c | 4 ++-- libavutil/colorspace.h | 8 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/dvbsub.c b/libavcodec/dvbsub.c index 3cdbade..d2faef0 100644 ---

Re: [FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

2016-04-17 Thread Reimar Döffinger
On Sun, Apr 17, 2016 at 09:24:29PM +0200, Reimar Döffinger wrote: > On Sun, Apr 17, 2016 at 09:08:45PM +0200, Carl Eugen Hoyos wrote: > > -YUV_TO_RGB1(cb, cr); > > -YUV_TO_RGB2(r, g, b, y); > > +if (ctx->hdtv > 0) { > > +

Re: [FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

2016-04-17 Thread Reimar Döffinger
On Sun, Apr 17, 2016 at 09:08:45PM +0200, Carl Eugen Hoyos wrote: > -YUV_TO_RGB1(cb, cr); > -YUV_TO_RGB2(r, g, b, y); > +if (ctx->hdtv > 0) { > +YUV_TO_RGB1_CCIR(cb, cr); > +YUV_TO_RGB2_CCIR(r, g, b, y); > +} else { > +

Re: [FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

2016-04-17 Thread Reimar Döffinger
On Sun, Apr 17, 2016 at 09:49:58PM +0300, Jan Ekstrom wrote: > On Sun, Apr 17, 2016 at 9:44 PM, wm4 wrote: > > > > Ah that's funny. This indeed ruins everything. It looks like subtitle > > decoders should simply output YUV, and until we can fix it, a private > > option

Re: [FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

2016-04-17 Thread Reimar Döffinger
On Sun, Apr 17, 2016 at 09:41:32PM +0300, Jan Ekstrom wrote: > On Sun, Apr 17, 2016 at 9:21 PM, Reimar Döffinger > <reimar.doeffin...@gmx.de> wrote: > > In particular, I have an uncomfortable suspicion that > > PGS might be designed to match the movie's colour space, &

Re: [FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

2016-04-17 Thread Reimar Döffinger
On Sun, Apr 17, 2016 at 06:38:12PM +, Carl Eugen Hoyos wrote: > Reimar Döffinger gmx.de> writes: > > In particular, I have an uncomfortable suspicion that > > PGS might be designed to match the movie's colour space, > > in which case neither variant would give correct

Re: [FFmpeg-devel] [PATCH]lavc/pgssubdec: Fix palette colourspace

2016-04-17 Thread Reimar Döffinger
On Sun, Apr 17, 2016 at 05:54:00PM +, Carl Eugen Hoyos wrote: > wm4 googlemail.com> writes: > > What proves that the sample you have renders correctly now? > > Nothing. > > You think that it is more likely that the sample was > intentionally made to fool the vlc developers than to > help

Re: [FFmpeg-devel] Return value of av_log_format_line

2016-04-17 Thread Reimar Döffinger
On Sun, Apr 17, 2016 at 01:18:42PM +0200, Andreas Weis wrote: > Since av_log_format_line calls snprintf internally, that might be as > trivial as just forwarding the return value from that call. This probably wasn't done because snprintf isn't always implemented 100% right in this regard (too

Re: [FFmpeg-devel] Developer required for EBU-STL subtitle decoding support

2016-04-11 Thread Reimar Döffinger
not, it would be of great help if you could make samples available (if you can find any where you can get the ok to make available publicly). With such special formats regression testing is fairly important, but cannot be done without public samples. G

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libfaac, the internal AAC encoder is better

2016-04-10 Thread Reimar Döffinger
On 10.04.2016, at 20:00, Derek Buitenhuis wrote: > On 4/10/2016 5:42 PM, Michael Niedermayer wrote: >> this is not possible currently libfaac is twice as fast than the >> native encoder. > > Twice as fast and produces crap output. Someone like me almost certain

  1   2   3   4   5   6   >