Re: [FFmpeg-devel] [PATCH 0/3] avfilter/vf_scale_cuda: Various improvements

2019-05-15 Thread Timo Rothenpieler
On 14.05.2019 05:12, Philip Langdale wrote: After Sergey's bug report, I went and fixed a couple of other things I noticed while I was looking at the filter. Philip Langdale (3): avfilter/vf_scale_cuda: Fix incorrect scaling of > 8bit content avfilter/vf_scale_cuda: Add support for

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: make command processing error-resilient

2019-05-14 Thread Timo Rothenpieler
On 10/05/2019 15:55, Gyan wrote: At present, if the command args passed to drawtext contain any invalid values, ffmpeg may crash or, at best, stop drawing any text. Attached patch gets the filter to continue with existing parameters, if not all of the changes can be parsed or applied. This

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-05-11 Thread Timo Rothenpieler
On 04.05.2019 16:13, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_colorkey.c | 102 +- 4 files changed, 121

Re: [FFmpeg-devel] [PATCH 1/1] cuviddec: Add capability check for maximum macroblock count

2019-05-08 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] configure: enable ffnvcodec, nvenc, nvdec for ppc64

2019-05-08 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-02 Thread Timo Rothenpieler
On 28/04/2019 22:02, Marton Balint wrote: Hi All, There has been discussion on the mailing list several times about the inclusion of support for closed source components (codecs, formats, filters, etc) in the main ffmpeg codebase. Also the removal of libNDI happened without general

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

2019-04-24 Thread Timo Rothenpieler
On 24/04/2019 01:38, Carl Eugen Hoyos wrote: 2017-12-29 13:16 GMT+01:00, Cyber Sinh : Sorry for the diff instead of regular git patch. Here is the patch. Only saw this today after wondering why nobody tried using wsl before... I'm using WSL since a while, but never bothered trying to setup

Re: [FFmpeg-devel] [PATCH] cuviddec: improved way of finding out if a frame is interlaced or progressive

2019-04-23 Thread Timo Rothenpieler
applied, thanks. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] Patchwork attribution

2019-04-18 Thread Timo Rothenpieler
Ok.  Then shouldn't it assign 'Sam John via ffmpeg-devel' as the author? It did do that for 'Oliver Collyer via ffmpeg-devel', the string wrongly substituted here. This looks like a parser failure in Patchwork. Gyan If the patch is sent with git send-email, the From: header of the E-Mail is

Re: [FFmpeg-devel] Patchwork attribution

2019-04-18 Thread Timo Rothenpieler
On 18/04/2019 09:49, Gyan wrote: Patchwork can incorrectly assign ownership. See https://patchwork.ffmpeg.org/patch/12680/ The author is Sam John as identified by Message ID as well as the From field in the headers, yet Patchwork attributes this patch to "Oliver Collyer via ffmpeg-devel",

Re: [FFmpeg-devel] [PATCH v2] lavfi: add colorkey_opencl filter

2019-04-16 Thread Timo Rothenpieler
More a general question regarding OpenCL filters than related to this specific one. We are not integrating OpenCL acceleration into the relevant native filter anymore, like the very old original OpenCL infra worked, are we? So that vf_colorkey would just use OpenCL acceleration on its own

Re: [FFmpeg-devel] scaling option

2019-03-26 Thread Timo Rothenpieler
On 26/03/2019 13:47, Yufei He wrote: Hi Is there option for scaling on transcoding ? e.g. transcoding from a quadhd file to 640 * 480. Thanks. Yufei. Yes there is, but this is ffmpeg-devel, so not the place to ask user questions. smime.p7s Description: S/MIME Cryptographic Signature

Re: [FFmpeg-devel] [PATCH][FFmpeg-devel v2] Add GPU accelerated video crop filter

2019-03-25 Thread Timo Rothenpieler
On 25/03/2019 09:27, Tao Zhang wrote: Hi, Timo and Mark and I have been discussing this, and we think the right thing to do is add support to vf_scale_cuda to respect the crop properties on an input AVFrame. Mark posted a patch to vf_crop to ensure that the properties are set, and then the

Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

2019-03-25 Thread Timo Rothenpieler
On 20/03/2019 08:57, Zhong Li wrote: Currectly just standard header path and be found, check_type/struct will fail if vaapi is installed somewhere else. --- configure | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/configure b/configure index

Re: [FFmpeg-devel] [PATCH] Add GPU accelerated video crop filter

2019-03-23 Thread Timo Rothenpieler
On 23.03.2019 14:46, Steven Liu wrote: Documentation of the crop_cuda should be submitted together. Thanks Steven True, forgot about that. Should be almost identical to that of the regular crop filter. smime.p7s Description: S/MIME Cryptographic Signature

Re: [FFmpeg-devel] [PATCH] Add GPU accelerated video crop filter

2019-03-23 Thread Timo Rothenpieler
On 23.03.2019 12:31, UsingtcNower wrote: > diff --git a/configure b/configure > index 331393f..88f1e91 100755 > --- a/configure > +++ b/configure > @@ -2978,6 +2978,7 @@ scale_npp_filter_deps="ffnvcodec libnpp" > scale_cuda_filter_deps="ffnvcodec cuda_nvcc" >

Re: [FFmpeg-devel] [PATCHv3] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-15 Thread Timo Rothenpieler
So what's the final verdict here, can this be pushed or not? Timo - did you manage to test it over last weekend? I haven't found the time, sorry. I'm generally not opposed to this. It does not disrupt normal use, and spinning up nvenc does have a surprisingly hefty overhead, so it makes

Re: [FFmpeg-devel] [PATCH] configure: enable ffnvcodec, nvenc, nvdec for ppc64

2019-03-12 Thread Timo Rothenpieler
On 12/03/2019 09:52, Ruta Gadkari wrote: On 11/03/2019 15:51, Carl Eugen Hoyos wrote: 2019-03-11 11:16 GMT+01:00, Timo Rothenpieler : On 11/03/2019 09:40, Carl Eugen Hoyos wrote: 2019-03-11 6:36 GMT+01:00, Ruta Gadkari : Please find attached the patch, it enables ffnvcodec and nvenc, nvdec

Re: [FFmpeg-devel] [PATCH] ffnvcodec/compat: Fix CUdeviceptr definition for 64bit CPU

2019-03-11 Thread Timo Rothenpieler
On 11/03/2019 06:37, Ruta Gadkari wrote: Hi Please find the attached patch, it rectifies the definition of cuda device pointer for PPC64 architecture. PPC64 support is present from Video Codec SDK 9. Thanks Ruta Applied and released a new version of ffnvcodec 9. smime.p7s Description:

Re: [FFmpeg-devel] [PATCH] configure: enable ffnvcodec, nvenc, nvdec for ppc64

2019-03-11 Thread Timo Rothenpieler
On 11/03/2019 09:40, Carl Eugen Hoyos wrote: 2019-03-11 6:36 GMT+01:00, Ruta Gadkari : Please find attached the patch, it enables ffnvcodec and nvenc, nvdec, cuvid for PPC64 architecture. Is it supported on both little and big endian? Good question. This email message is for the sole use

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-08 Thread Timo Rothenpieler
On 08/03/2019 00:57, Carl Eugen Hoyos wrote: 2019-03-06 15:57 GMT+01:00, Oliver Collyer : Hi I needed the dynamic resolution changing feature of NVENC to be accessible through the ffmpeg libraries for a hobby project, so I added support and here is a patch. I will format this as a proper

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Reconfigure resolution on-the-fly

2019-03-07 Thread Timo Rothenpieler
looks good at first glance, will give it a test this weekend. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] use the correct option of pkg-config to check version

2019-03-04 Thread Timo Rothenpieler
This seems weird to me, why would there only be an issue on Ubuntu 16.04? I'd assume that the code in question has been tested quite a bit. Do you have an example of where and how it fails? smime.p7s Description: S/MIME Cryptographic Signature ___

Re: [FFmpeg-devel] [PATCH 0/5] Clean up CUDA SDK usage and remove non-free requirement

2019-02-27 Thread Timo Rothenpieler
On 21.02.2019 04:57, Philip Langdale wrote: I've been thinking about this for a while, but I only recently made the realisation that compiling cuda kernels to the ptx format does not introduce any non-free dependencies - the ptx files are an intermediate assembly code format that is actually

Re: [FFmpeg-devel] [PATCH] avfilter/vf_yadif_cuda: Relicence cuda kernel to MIT

2019-02-26 Thread Timo Rothenpieler
The patch seems to be corrupted by something. At least git am is refusing to apply it, and it looks very jumbled on patchwork. But it LGTM. Feel free to push. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/5] configure: Add an explicit check and option for nvcc

2019-02-26 Thread Timo Rothenpieler
On 21.02.2019 04:57, Philip Langdale wrote: The use of nvcc to compile cuda kernels is distinct from the use of cuda sdk libraries and linking against those libraries. We have previously not bothered to distinguish these two cases because all the filters that used cuda kernels also used the sdk.

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/cuda_check: avoid pointlessly exporting same symbol from two libraries

2019-02-14 Thread Timo Rothenpieler
On 15.02.2019 01:01, Carl Eugen Hoyos wrote: 2019-02-14 23:36 GMT+01:00, Carl Eugen Hoyos : please mention ticket #7735. Ping! I remembered the moment i pushed the patch, sorry. smime.p7s Description: S/MIME Cryptographic Signature ___

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/cuda_check: avoid pointlessly exporting same symbol from two libraries

2019-02-14 Thread Timo Rothenpieler
You changed libavfilter but didn't commit (I guess), please mention ticket #7735. (I didn't test myself, sorry if there is no issue!) I just completely missed the parts in libavfilter. I am thoroughly confused why this did not break compilation for me. Will push the missing part asap.

Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/cuda_check: avoid pointlessly exporting same symbol from two libraries

2019-02-14 Thread Timo Rothenpieler
On 14.02.2019 19:59, Carl Eugen Hoyos wrote: 2019-02-14 18:21 GMT+01:00, Hendrik Leppkes : On Thu, Feb 14, 2019 at 4:51 PM Carl Eugen Hoyos wrote: Am 14.02.2019 um 13:39 schrieb Timo Rothenpieler : ffmpeg | branch: master | Timo Rothenpieler | Fri Feb 8 22:47:01 2019 +0100

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/cuviddec: Add support for decoding HEVC 4:4:4 content

2019-02-14 Thread Timo Rothenpieler
On 14.02.2019 05:03, Philip Langdale wrote: This is the equivalent change for cuviddec after the previous change for nvdec. I made similar changes to the copying routines to handle pixel formats in a more generic way. Note that unlike with nvdec, there is no confusion about the ability of a

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/nvenc_hevc: adding B frame support

2019-02-14 Thread Timo Rothenpieler
On 13.02.2019 20:18, Timo Rothenpieler wrote: On 13.02.2019 09:52, Roman Arzumanyan wrote: Hello, Please find attached patch, it adds HEVC B-frames support to nvenc_hevc. This feature requires Video Codec SDK 9 + Turing card. Will it cause issues if set on an older card, or just plain get

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/nvenc_hevc: adding B frame support

2019-02-13 Thread Timo Rothenpieler
On 13.02.2019 09:52, Roman Arzumanyan wrote: Hello, Please find attached patch, it adds HEVC B-frames support to nvenc_hevc. This feature requires Video Codec SDK 9 + Turing card. Will it cause issues if set on an older card, or just plain get ignored? If it's ignored, this LGTM.

Re: [FFmpeg-devel] [PATCH] nv-codec-headers: Video Codec SDK 9 support

2019-02-13 Thread Timo Rothenpieler
On 13.02.2019 09:47, Roman Arzumanyan wrote: Hello, Please find attached patch for nv-codec-headers. It adds Video Codec SDK 9 support. Applied and followed up with a patch adding some more new fields from SDK 9.0.18. smime.p7s Description: S/MIME Cryptographic Signature

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/cuviddec: adding HEVC YUV444P decoding support

2019-02-13 Thread Timo Rothenpieler
On 13.02.2019 09:56, Roman Arzumanyan wrote: Hello, Please find attached patch, it adds HEVC YUV444P decoding support. Supported formats are AV_PIX_FMT_YUV444P, AV_PIX_FMT_YUV444P10LE, AV_PIX_FMT_YUV444P12LE. This feature requires Video Codec SDK 9. There is one big issue with this. And

Re: [FFmpeg-devel] Server upgrades

2019-02-06 Thread Timo Rothenpieler
On 06/02/2019 14:50, Reimar Döffinger wrote: As I remember, apache actually wants certificate and chain separately, so we might need to create and use 2 different ones (even if the difference is just a cat command or so).

Re: [FFmpeg-devel] Server upgrades

2019-02-06 Thread Timo Rothenpieler
On 06/02/2019 11:46, Michael Niedermayer wrote: There is also a new lets encrypt certificate, these expire frequently The problem probably is that the server didnt sent the full chain of certificates ive manually made a certificate that works now but reimars script needs an update so it cats all

Re: [FFmpeg-devel] 971108 - ffmpeg doesn't use GPU

2019-01-28 Thread Timo Rothenpieler
This list is about development of ffmpeg itself. You are probably looking for libav-users. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavd: Remove libndi newtek

2018-12-03 Thread Timo Rothenpieler
I contacted NewTek about this, here's the pretty much immediate response I got: On 03.12.2018 18:55, Andrew Cross wrote: Yikes, I am pretty surprised by this to be honest I think that our intent might have been entirely misconstrued. We are in no way trying to abuse anything anyone did and

Re: [FFmpeg-devel] [PATCH] libavfilter: scale_cuda filter adds dynamic command values

2018-11-26 Thread Timo Rothenpieler
On 26.11.2018 19:09, msanders wrote: Hi, This patch adds command support for dynamic change the size in the “scale_cuda” resize filter. In fact, it’s the first GPU filter accepting realtime commands. Using similar changes it’s possible to port it to other hwaccelerators. The only limitation

Re: [FFmpeg-devel] [PATCH] lavc/decode: allow users to shrink the hw frames pool size, if they so desire.

2018-11-26 Thread Timo Rothenpieler
On 25/11/2018 15:05, Mark Thompson wrote: I see what you're trying to do here, but I'm not sure that overloading this option is the best way to achieve it. This option has a specific meaning in terms of the consumer of the frames, and is intended to be negotiated (any consumers of hardware

[FFmpeg-devel] [PATCH] lavc/decode: allow users to shrink the hw frames pool size, if they so desire.

2018-11-23 Thread Timo Rothenpieler
--- libavcodec/decode.c| 9 + libavcodec/options_table.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index c89c77c43a..08ae8788a2 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -1256,10 +1256,11 @@

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuMemAllocPitch

2018-11-17 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose_npp: adding NV12 support to transpose_npp filter

2018-11-02 Thread Timo Rothenpieler
On 02/11/2018 13:35, Roman Arzumanyan wrote: Hello, This patch adds NV12 support to vf_transpose_npp filter. Now filter can be used in nvdec -> nvenc transcoding scenarios like this: ffmpeg -hwaccel cuvid -c:v h264_cuvid -i input.h264 -c:v h264_nvenc -vf transpose_npp="dir=clock" -y

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute V2

2018-11-02 Thread Timo Rothenpieler
LGTM, will apply next time I get a chance. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Timo Rothenpieler
On 02.11.2018 00:09, Soft Works wrote: That enum is _way_ too massive. Most of that seems entirely useless in the context of ffmpeg anyway, like all the 1D and 3D stuff, and probably most of the 2D stuff as well. I copied the full enum to have an exact match to cuda.h, but no problem, I can

Re: [FFmpeg-devel] [PATCH] Add CUDA function cuDeviceGetAttribute

2018-11-01 Thread Timo Rothenpieler
That enum is _way_ too massive. Most of that seems entirely useless in the context of ffmpeg anyway, like all the 1D and 3D stuff, and probably most of the 2D stuff as well. Can you trim it down to only those exact ones you need? Also, just get rid of the comments, we're not doing that

Re: [FFmpeg-devel] Maintainer of nv-codec-headers

2018-11-01 Thread Timo Rothenpieler
Send a patch to this list and I'll see if I can add it. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/vf_yadif_cuda: CUDA accelerated deinterlacer

2018-11-01 Thread Timo Rothenpieler
On 01.11.2018 21:54, Carl Eugen Hoyos wrote: 2018-10-26 17:56 GMT+02:00, Philip Langdale : Could you add some sample numbers about how fast the cuda variant is compared to cpu? I don't think such numbers are overly useful by themselves. The primary benefit here is that it's now possible to

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/vf_yadif_cuda: CUDA accelerated deinterlacer

2018-11-01 Thread Timo Rothenpieler
Not an export on CUDA code but it looks sensible to me, C part looks good as well. GTM once the yadiff changes have been acked. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvdec: Increase frame pool size to help deinterlacing

2018-11-01 Thread Timo Rothenpieler
On 26.10.2018 17:56, Philip Langdale wrote: With the cuda yadif filter in use, the number of mapped decoder frames could increase by two, as the filter holds on to additional frames. Signed-off-by: Philip Langdale --- libavcodec/nvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation feature via call Intel iHD driver

2018-10-23 Thread Timo Rothenpieler
On 23.10.2018 10:55, Moritz Barsnick wrote: On Tue, Oct 23, 2018 at 15:52:40 +0800, Zachary Zhou wrote: It supports clockwise rotation by 0/90/180/270 degrees defined in va/va_vpp.h, tested following command line on SKL platform Since these angles of rotation are called "transpose" in

Re: [FFmpeg-devel] [PATCH] avcodec/imm4: improve decoding of some files

2018-10-22 Thread Timo Rothenpieler
> @@ -205,9 +206,26 @@ static int decode_blocks(AVCodecContext *avctx, GetBitContext *gb, > static int decode_intra(AVCodecContext *avctx, GetBitContext *gb, AVFrame *frame) > { > IMM4Context *s = avctx->priv_data; > -int ret, x, y; > +int ret, x, y, offset = 0; > > -

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/nvdec: Add support for decoding HEVC 4:4:4 content

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 23:52, Philip Langdale wrote: On Sat, 20 Oct 2018 22:58:34 +0200 Timo Rothenpieler wrote: +// It it semantically incorrect to use AX_PIX_FMT_YUV444P16 for either the 10 +// or 12 bit case, but ffmpeg and nvidia disagree on which end the padding +// bits go

Re: [FFmpeg-devel] [PATCH 0/5] Add nvidia hw decode support for HEVC 4:4:4 content

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 23:31, Carl Eugen Hoyos wrote: 2018-10-20 23:16 GMT+02:00, Timo Rothenpieler : On 20.10.2018 23:00, Carl Eugen Hoyos wrote: 2018-10-20 22:46 GMT+02:00, Philip Langdale : The big discussion was about the new pixel formats. I would like to get to a clear conclusion

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/nvenc: Accept YUV444P10_MSB and YUV444P12_MSB content

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 23:34, Marton Balint wrote: On Sat, 20 Oct 2018, Timo Rothenpieler wrote: On 20.10.2018 22:47, Philip Langdale wrote: 12bit is implicitly truncated to 10bit as part of doing this, but we already do that for P016 and YUV444P16. Huh? I thought one of the reasons of adding

Re: [FFmpeg-devel] [PATCH 0/5] Add nvidia hw decode support for HEVC 4:4:4 content

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 23:00, Carl Eugen Hoyos wrote: 2018-10-20 22:46 GMT+02:00, Philip Langdale : The big discussion was about the new pixel formats. I would like to get to a clear conclusion on this otherwise, this patch series goes nowhere forever Wouldn't it be an alternative to first commit the

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/nvenc: Accept YUV444P10_MSB and YUV444P12_MSB content

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 22:47, Philip Langdale wrote: 12bit is implicitly truncated to 10bit as part of doing this, but we already do that for P016 and YUV444P16. I've bundled a single version bump and changelog entry in this change to reflect the updates to all three of nvdec/nvenc/cuviddec.

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/cuviddec: Add support for decoding HEVC 4:4:4 content

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 22:47, Philip Langdale wrote: This is the equivalent change for cuviddec after the previous change for nvdec. I made similar changes to the copying routines to handle pixel formats in a more generic way. Note that unlike with nvdec, there is no confusion about the ability of a

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/nvdec: Explicitly mark codecs that support 444 output formats

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 22:46, Philip Langdale wrote: With the introduction of HEVC 444 support, we technically have two codecs that can handle 444 - HEVC and MJPEG. In the case of MJPEG, it can decode, but can only output one of the semi-planar formats. That means we need additional logic to decide

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/nvdec: Add support for decoding HEVC 4:4:4 content

2018-10-20 Thread Timo Rothenpieler
On 20.10.2018 22:46, Philip Langdale wrote: The latest generation video decoder on the Turing chips supports decoding HEVC 4:4:4. Supporting this is relatively straight-forward; we need to account for the different chroma format and pick the right output and sw formats at the right times. There

Re: [FFmpeg-devel] #7496: Access to the reference track (dolby vision) of a stream

2018-10-16 Thread Timo Rothenpieler
On 16.10.2018 19:25, dmitrij.gresser...@loewe.de wrote: Hello, i need access to the reference track of a stream in a mp4 file. ISO/IEC 14496-12:2005 describes this as the track_ID of the Track Reference Box. Here is my approach attached as a patch. Adding a field just for this seems a bit

Re: [FFmpeg-devel] avcodec/libopenh264enc.c

2018-10-11 Thread Timo Rothenpieler
This patch is corrupted, also needs a more meaningful commit message. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/5] avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats

2018-10-09 Thread Timo Rothenpieler
On 09/10/2018 02:32, Carl Eugen Hoyos wrote: 2018-10-08 21:59 GMT+02:00, Timo Rothenpieler : So, to be able to use these hardware compatible formats, we need definitions for them in ffmpeg. Right now, I need this for nvdec, but Vulkan also uses the same format definitions. Sorry

Re: [FFmpeg-devel] [PATCH 1/5] avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats

2018-10-08 Thread Timo Rothenpieler
So, to be able to use these hardware compatible formats, we need definitions for them in ffmpeg. Right now, I need this for nvdec, but Vulkan also uses the same format definitions. Sorry if this was already done and I forgot but please explain why you cannot use YUV444P16 for this use-case. If

Re: [FFmpeg-devel] [PATCH 1/5] avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats

2018-10-08 Thread Timo Rothenpieler
On 08/10/2018 09:24, Marton Balint wrote: On Sun, 7 Oct 2018, Philip Langdale wrote: Currently, ffmpeg defines a set of YUV444P formats for use where the bits-per-pixel are between 8 and 16 bits. In these formats, the bits are packed in the MSBs of the 16 bits of available storage. On the

Re: [FFmpeg-devel] [PATCH 1/5] avutil: Add YUV444P10_LSB and YUV444P12_LSB pixel formats

2018-10-07 Thread Timo Rothenpieler
On 07.10.2018 19:50, Philip Langdale wrote: Currently, ffmpeg defines a set of YUV444P formats for use where the bits-per-pixel are between 8 and 16 bits. In these formats, the bits are packed in the MSBs of the 16 bits of available storage. On the other hand, all the hardware vendors have

Re: [FFmpeg-devel] [PATCH] avcodec/nvdec: Add support for decoding HEVC 4:4:4 content

2018-10-07 Thread Timo Rothenpieler
On 07.10.2018 04:19, Philip Langdale wrote: The latest generation video decoder on the Turing chips supports decoding HEVC 4:4:4. Supporting this is relatively straight-forward; we need to account for the different chroma format and pick the right output and sw formats at the right times. There

Re: [FFmpeg-devel] FFmpeg 4.1

2018-09-20 Thread Timo Rothenpieler
On 20/09/2018 00:32, Michael Niedermayer wrote: On Wed, Sep 19, 2018 at 10:31:19PM +0200, Marton Balint wrote: On Fri, 14 Sep 2018, Michael Niedermayer wrote: Hi all its almost 5 months since 4.0 so its time to make a new release. Are there any suggestions for a name ? If not ill pick

Re: [FFmpeg-devel] [PATCH] Revert "avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

2018-09-13 Thread Timo Rothenpieler
So, what do we do now? Honor the doxy and stop trying to manipulate what's meant to be an user owned pointer/buffer, officially break the API and declare it's meant to be allocated by the user but then ownership is passed to the library during or after the avcodec_open2() call, or just revert

Re: [FFmpeg-devel] [PATCH] avfilter: add nvidia NPP based transpose filter

2018-09-10 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter: add nvidia NPP based transpose filter

2018-09-09 Thread Timo Rothenpieler
From: Roman Arzumanyan Signed-off-by: Timo Rothenpieler --- configure | 5 +- doc/filters.texi | 42 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_transpose_npp.c

Re: [FFmpeg-devel] [PATCH] avfilter: add nvidia NPP based transpose filter

2018-09-09 Thread Timo Rothenpieler
On 9/9/2018 2:12 AM, Michael Niedermayer wrote: On Sat, Sep 08, 2018 at 03:49:29PM +0200, Timo Rothenpieler wrote: From: Roman Arzumanyan Signed-off-by: Timo Rothenpieler --- I'm not overly a fan of a rotate filter that only support 90° angles either. So here's my modified version

Re: [FFmpeg-devel] [PATCH] avfilter: add nvidia NPP based transpose filter

2018-09-08 Thread Timo Rothenpieler
On 9/8/2018 5:38 PM, Paul B Mahol wrote: I'll probably remove the interp_algo from this before committing, hard coding it to nearest neighbor. I'm unable to see any difference between them for perfect 90DEG angles except that NN is easily 10 times faster than the current default Cubic. Perhaps

Re: [FFmpeg-devel] [PATCH] avfilter: add nvidia NPP based transpose filter

2018-09-08 Thread Timo Rothenpieler
On 9/8/2018 3:49 PM, Timo Rothenpieler wrote: From: Roman Arzumanyan Signed-off-by: Timo Rothenpieler --- I'm not overly a fan of a rotate filter that only support 90° angles either. So here's my modified version of the original transpose filter, which now behaves the exact same

[FFmpeg-devel] [PATCH] avfilter: add nvidia NPP based transpose filter

2018-09-08 Thread Timo Rothenpieler
From: Roman Arzumanyan Signed-off-by: Timo Rothenpieler --- I'm not overly a fan of a rotate filter that only support 90° angles either. So here's my modified version of the original transpose filter, which now behaves the exact same as the software transpose filter. Additionally, I removed

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-04 Thread Timo Rothenpieler
On 9/4/2018 3:54 PM, Moritz Barsnick wrote: On Tue, Sep 04, 2018 at 07:43:10 +, Roman Arzumanyan wrote: Hi Timo, Refactored the patch according to your review: +{ "interp_algo","Interpolation algorithm used for transposing", OFFSET(interp_algo), AV_OPT_TYPE_INT,{ .i64 =

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-03 Thread Timo Rothenpieler
I did some re-formating and added the missing configure bit. Updated patch for that can be found on Github: https://github.com/BtbN/FFmpeg/commit/3e9ad52cfbebfade0d26758dad862e0c0a002c91 https://github.com/BtbN/FFmpeg/commit/3e9ad52cfbebfade0d26758dad862e0c0a002c91.patch smime.p7s

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-03 Thread Timo Rothenpieler
Minus the missing configure dependency, documentation entry and minor bump, the filter looks fine to me code wise. Two issues though: From my understanding, it's not a transpose filter, but a rotation one, fixed to 90 degree angles. Unless I'm missing something in the code, it's not doing

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-08-30 Thread Timo Rothenpieler
Thanks! I'm a bit short on time at the moment, but I'll try to have a look during the weekend. If someone else also wants to give a review, please go ahead! smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] configure: speedup x2-x8

2018-08-25 Thread Timo Rothenpieler
Please use git send-email to send your patches, or at least send each patch, created by git format-patch, as individual attachment. Your files seem to contain multiple patches one after another, which makes them very hard to follow. But nice work! Let's hope this does not cause any

Re: [FFmpeg-devel] [PATCH] avcodec/utils: document allocation requirement of extradata

2018-08-25 Thread Timo Rothenpieler
On 8/25/2018 5:15 PM, Michael Niedermayer wrote: On Fri, Aug 24, 2018 at 08:53:29PM +0200, Timo Rothenpieler wrote: --- libavcodec/avcodec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 31e50d5a94..2c5e78c88d 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH] avcodec/utils: document allocation requirement of extradata

2018-08-24 Thread Timo Rothenpieler
--- libavcodec/avcodec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 31e50d5a94..2c5e78c88d 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1616,6 +1616,7 @@ typedef struct AVCodecContext { * The allocated memory

[FFmpeg-devel] [PATCH] avcodec/utils: document allocation requirement of extradata

2018-08-24 Thread Timo Rothenpieler
--- libavcodec/avcodec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 31e50d5a94..5ec7a2430b 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1616,6 +1616,7 @@ typedef struct AVCodecContext { * The allocated memory

Re: [FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-08-20 Thread Timo Rothenpieler
On 8/17/2018 2:38 PM, Carl Eugen Hoyos wrote: 2018-05-03 19:42 GMT+02:00, Timo Rothenpieler : Slightly refactored nvenc part can be found here: https://github.com/BtbN/FFmpeg/commit/e5d85ac3 Will push tomorrow if no issue with it comes up. Why is there no option to disable Closed Captions

Re: [FFmpeg-devel] [PATCH] avformat/librtmp: fix returning EOF from Read/Write

2018-07-31 Thread Timo Rothenpieler
Am 28.07.2018 um 11:48 schrieb Jan Ekström: On Thu, Jul 26, 2018 at 1:20 PM, Timo Rothenpieler wrote: --- libavformat/librtmp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c index f3cfa9a8e2..43013e46e0 100644

Re: [FFmpeg-devel] [PATCH] avformat/librtmp: fix returning EOF from Read/Write

2018-07-27 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/librtmp: fix returning EOF from Read/Write

2018-07-27 Thread Timo Rothenpieler
I did a 24h test with this, and it seems to fix the issue. Will apply and backport to 4.0 in 24h if nobody objects. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avformat/librtmp: fix returning EOF from Read/Write

2018-07-26 Thread Timo Rothenpieler
--- libavformat/librtmp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c index f3cfa9a8e2..43013e46e0 100644 --- a/libavformat/librtmp.c +++ b/libavformat/librtmp.c @@ -261,7 +261,10 @@ static int rtmp_write(URLContext

Re: [FFmpeg-devel] mistake in patch "Add lensfun filter"

2018-07-12 Thread Timo Rothenpieler
On 12/07/2018 06:40, Stephen Seo wrote: Hi, It appears I used the wrong license in libavfilter/vf_lensfun.c It derives from the Lensfun library that uses (L)GPL3, but I used GPL2 by mistake. Should I 'git send-email' the whole patch again with this mistake resolved, or should I email another

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: fix version detection on cygwin

2018-06-27 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: fix version detection on cygwin

2018-06-17 Thread Timo Rothenpieler
Am 17.06.2018 um 17:48 schrieb Mark Thompson: On 15/06/18 15:52, Timo Rothenpieler wrote: --- libavcodec/qsvenc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h index d48272224c..bb175c5df8 100644 --- a/libavcodec/qsvenc.h

[FFmpeg-devel] [PATCH] avcodec/qsvenc: fix version detection on cygwin

2018-06-15 Thread Timo Rothenpieler
--- libavcodec/qsvenc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h index d48272224c..bb175c5df8 100644 --- a/libavcodec/qsvenc.h +++ b/libavcodec/qsvenc.h @@ -45,7 +45,7 @@ #define QSV_HAVE_LA_DS QSV_VERSION_ATLEAST(1, 8)

Re: [FFmpeg-devel] [PATCH] lavc/nvenc: enable nvenc encoder instance reuse (v2)

2018-06-15 Thread Timo Rothenpieler
applied smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/nvenc: enable nvenc encoder instance reuse (v2)

2018-06-13 Thread Timo Rothenpieler
-if (ctx->encoder_flushing) -return AVERROR_EOF; +if (ctx->encoder_flushing) { +if (avctx->internal->draining) +return AVERROR_EOF; + +ctx->encoder_flushing = 0; +ctx->first_packet_output = 0; +ctx->initial_pts[0] = AV_NOPTS_VALUE; +

Re: [FFmpeg-devel] [PATCH 2/5] avutil/hwcontext_cuda: add CUstream in cuda hwctx

2018-06-09 Thread Timo Rothenpieler
Am 09.06.2018 um 03:25 schrieb James Almer: On 5/9/2018 5:49 AM, Timo Rothenpieler wrote: On 08.05.2018 23:00, James Almer wrote: On 5/8/2018 3:36 PM, Timo Rothenpieler wrote: --- configure | 6 -- doc/APIchanges | 3 +++ libavutil/hwcontext_cuda.c | 3

[FFmpeg-devel] [PATCH] avfilter/dnn_backend_native: fix leaks in error paths

2018-06-08 Thread Timo Rothenpieler
Fixes CID #1435888 --- libavfilter/dnn_backend_native.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/dnn_backend_native.c b/libavfilter/dnn_backend_native.c index 6e80dd3663..e0a9ec5003 100644 --- a/libavfilter/dnn_backend_native.c +++ b/libavfilter/dnn_backend_native.c @@

Re: [FFmpeg-devel] [PATCH] lavc/nvenc: enable nvenc encoder instance reuse after draining

2018-06-07 Thread Timo Rothenpieler
On 07.06.2018 06:38, Pavel Koshevoy wrote: > --- > libavcodec/nvenc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index b4186c0bec..8928eacc70 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -2181,6 +2181,12 @@ int

Re: [FFmpeg-devel] NVIDIA CUVID decoding issue.

2018-06-05 Thread Timo Rothenpieler
On 04.06.2018 12:27, Nánási Ferenc wrote: > Hi! > I'm trying to transcode H.264 Stream to HEVC. Everything just working > fine when I'm using the in-built CPU decoder, but when I turn on the > Hardware-accelerated CUVID module, it throws some error with most of my > streams. > * > **FFMPEG

Re: [FFmpeg-devel] [PATCH] avformat/hls: tag as AVFMT_TS_DISCONT

2018-05-17 Thread Timo Rothenpieler
> I think I'm against this. HLS streams do not typically contain > timestamp resets (even if they could). Otherwise you might as well add > this flag to the Matroska demuxer. Besides, it would break some of my > code, which uses this flag as a heuristic to detect mpeg-ts style > non-container

Re: [FFmpeg-devel] [PATCH] avutil/error: hidden macro av_err2str for C++

2018-05-17 Thread Timo Rothenpieler
On 17.05.2018 06:46, Zhao Zhili wrote: > --- > libavutil/error.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavutil/error.h b/libavutil/error.h > index 71df4da..8a35fef 100644 > --- a/libavutil/error.h > +++ b/libavutil/error.h > @@ -116,8 +116,10 @@ static inline char

  1   2   3   4   5   6   7   >