Re: [FFmpeg-devel] [PATCH] Revert lavc/utils: Do not require dimensions for PNG.

2014-07-14 Thread wm4
On Mon, 14 Jul 2014 01:57:52 +0200 Michael Niedermayer michae...@gmx.at wrote: On Sun, Jul 13, 2014 at 07:32:56PM +0100, Derek Buitenhuis wrote: mplayer-specifc hacks should not be in our codebase. mplayer should fix it's own code. It is not our responsibility to work around their broken

Re: [FFmpeg-devel] [PATCH] Revert lavc/utils: Do not require dimensions for PNG.

2014-07-14 Thread wm4
On Mon, 14 Jul 2014 09:15:20 +0200 Reimar Döffinger reimar.doeffin...@gmx.de wrote: I actually think it worked with a lot of formats, not just PNG (which is not an argument for the hack though). This is also related to encoders which can in principle support resolution changes. That is

Re: [FFmpeg-devel] [PATCH] Revert lavc/utils: Do not require dimensions for PNG.

2014-07-14 Thread Derek Buitenhuis
On 7/14/2014 8:15 AM, Reimar Döffinger wrote: There is also the issue about how much sense the check makes: while I decided to do it (slightly) more properly, a fix would be to just set width/height to 320x240 no matter what you actually encode in the end. This is a bad idea. API users don't

Re: [FFmpeg-devel] [PATCH] Revert lavc/utils: Do not require dimensions for PNG.

2014-07-13 Thread Derek Buitenhuis
On 7/13/2014 9:17 PM, Reimar Döffinger wrote: Well, IMHO if this is a requirement that was added, I would say it was an API change, and MPlayer might just be the first where the API change was detected. Indeed there should have been a version bump in 419ade4b6193c6eb626cda01b21e7091f42b2cc2.