Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-22 Thread Michael Niedermayer
On Thu, Jan 22, 2015 at 02:44:55PM +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 5 + 1 file changed, 5 insertions(+) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-22 Thread Derek Buitenhuis
On 1/22/2015 2:44 PM, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 5 + 1 file changed, 5 insertions(+) This is v2. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-21 Thread Michael Niedermayer
On Wed, Jan 21, 2015 at 03:18:48PM +, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 923c750..5e4931a 100644 ---

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-21 Thread Derek Buitenhuis
On 1/21/2015 4:28 PM, Michael Niedermayer wrote: this is missing pic==NULL checks or should be under the if() above or something like that No? It has X265_TYPE_AUTO as the fallback if it is NULL. Just like libx264.c:

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-21 Thread Timo Rothenpieler
No? It has X265_TYPE_AUTO as the fallback if it is NULL. Just like libx264.c: Is falls back to that if pic-pict_type is NULL, but if pic is NULL, it will just crash. signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-21 Thread Derek Buitenhuis
On 1/21/2015 4:46 PM, Timo Rothenpieler wrote: No? It has X265_TYPE_AUTO as the fallback if it is NULL. Just like libx264.c: Is falls back to that if pic-pict_type is NULL, but if pic is NULL, it will just crash. I meant to send a reply saying I misread, but responded to the wrong mail in my

[FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

2015-01-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/libx265.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 923c750..5e4931a 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -226,6 +226,11 @@ static