Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-28 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 02:34:42PM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 02:24:40PM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 12:16:35PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: [...] Sorry, I seem to have lost track of what you

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-28 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: Did you try the patch with pkg-config only detection? And try to add --pkg-config=true to trick the detect function. So, I did try myself Sorry, I was away and still didn't test all new tickets. [~/src/ffmpeg]☭ dash ./configure --disable-everything

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-28 Thread Clément Bœsch
On Thu, Aug 28, 2014 at 01:18:55PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: Did you try the patch with pkg-config only detection? And try to add --pkg-config=true to trick the detect function. So, I did try myself Sorry, I was away and still didn't test

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 11:23:41AM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: I thought the purpose is to allow educated developers to use pkg-config while (uneducated) users (like me) will not understand how this is easier than using configure parameters.

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 12:16:35PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: [...] Sorry, I seem to have lost track of what you fear will not work if pkg-config is used for x264 detection but will fallback to the current system if pkg-config does not find the

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-21 Thread Clément Bœsch
On Thu, Aug 21, 2014 at 02:24:40PM +0200, Clément Bœsch wrote: On Thu, Aug 21, 2014 at 12:16:35PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: [...] Sorry, I seem to have lost track of what you fear will not work if pkg-config is used for x264 detection but

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-20 Thread Clément Bœsch
On Tue, Jun 17, 2014 at 11:05:39PM +0200, Clément Bœsch wrote: --- Changelog | 2 ++ configure | 4 +--- doc/encoders.texi | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Changelog b/Changelog index 40a7751..268205c 100644 --- a/Changelog +++

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-20 Thread Clément Bœsch
On Sat, Aug 16, 2014 at 03:27:17PM +0200, Clément Bœsch wrote: On Fri, Aug 15, 2014 at 06:49:39AM +, Carl Eugen Hoyos wrote: [...] But really that's insane, because I know you will end-up hardcoding all kind of linker flags to these fallback calls, Yes, some external

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-16 Thread Clément Bœsch
On Fri, Aug 15, 2014 at 06:49:39AM +, Carl Eugen Hoyos wrote: [...] But really that's insane, because I know you will end-up hardcoding all kind of linker flags to these fallback calls, Yes, some external libraries that never have additional dependencies currently depend on

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-15 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: No it won't work because require_pkg_config dies if it fails, so you can fallback after it. True. Of course we can add another require_pkg_config2() that takes some explicit linking flags in addition to the user ones as a fallback. Sounds useful to me.

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-14 Thread Carl Eugen Hoyos
Clément Bœsch u at pkh.me writes: Carl, do you want the fallback to work just when pkg-config is not available I believe this would still leave some use-cases unsolved. or do you actually want a real fallback when it is present but didn't succeed? This is the preferred solution imo.

Re: [FFmpeg-devel] [PATCH 2/3] build: rely on pkg-config for libx264 probing

2014-08-14 Thread Clément Bœsch
On Thu, Aug 14, 2014 at 05:37:25PM +, Carl Eugen Hoyos wrote: Clément Bœsch u at pkh.me writes: Carl, do you want the fallback to work just when pkg-config is not available I believe this would still leave some use-cases unsolved. or do you actually want a real fallback when