[FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Derek Buitenhuis
Some formats require this, such as v210. The consensus seems to be to write it by default. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- This is a silent behavior change, and I have updated the API doc accordingly. --- doc/APIchanges| 3 +++ libavformat/movenc.c | 2 +-

Re: [FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Robert Krüger
On Tue, Feb 24, 2015 at 6:34 PM, Michael Niedermayer michae...@gmx.at wrote: On Tue, Feb 24, 2015 at 03:11:44PM +, Derek Buitenhuis wrote: Some formats require this, such as v210. The consensus seems to be to write it by default. Signed-off-by: Derek Buitenhuis

Re: [FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Michael Niedermayer
On Tue, Feb 24, 2015 at 03:11:44PM +, Derek Buitenhuis wrote: Some formats require this, such as v210. The consensus seems to be to write it by default. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- This is a silent behavior change, and I have updated the API doc

Re: [FFmpeg-devel] [PATCHv2][RFC] mov: Write colr atom by default

2015-02-24 Thread Derek Buitenhuis
On 2/24/2015 5:46 PM, Robert Krüger wrote: is this correct for all mov, mp4, 3gp, psp, ... ? or should it be writteb by default only for some of them ? Good point, but this raises the whole ugly question of the least crappy way of setting a default for only one format in the monster that is