Re: [FFmpeg-devel] [PATCH v2 1/7] lavc/qsvenc: enable ICQ and ICQ_LA on Linux

2018-11-28 Thread Li, Zhong
> > On 05/11/18 12:15, Zhong Li wrote: > > > ICQ/ICQ_LA are enabled with MSDK V1.28 > > > > > > One example of ICQ_LA: > > > ffmpeg -hwaccel qsv -c:v h264_qsv -i in.mp4 -c:v h264_qsv > > > -global_quality 25 -look_ahead 1 out.mp4 > > > > > > Signed-off-by: Zhong Li > > > --- > > > ICQ mode will

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-11-28 Thread Jeyapal, Karthick
On 11/28/18 5:13 PM, Andrey Semashev wrote: > This commit ensures that all (potentially, long) filesystem activity is > performed when the user calls av_write_trailer on the DASH libavformat > context, not when freeing the context. Also, this defers media segment > deletion until after the media

Re: [FFmpeg-devel] [PATCH v3] libavfilter: add transpose_vaapi filter

2018-11-28 Thread Zhou, Zachary
Thanks for the comments, reply inline, and sent out new version of the patch. > -Original Message- > From: Guo, Yejun > Sent: Wednesday, November 28, 2018 4:12 PM > To: FFmpeg development discussions and patches > Cc: Zhou, Zachary > Subject: RE: [FFmpeg-devel] [PATCH v3] libavfilter:

Re: [FFmpeg-devel] [PATCH, v4] lavc/qsvenc: add VDENC support for H264

2018-11-28 Thread Fu, Linjie
> -Original Message- > From: Li, Zhong > Sent: Thursday, November 29, 2018 12:36 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH,v4] lavc/qsvenc: add VDENC support for > H264 > > > From: ffmpeg-devel

[FFmpeg-devel] [PATCH v4] libavfilter: add transpose_vaapi filter

2018-11-28 Thread Zachary Zhou
Swap width and height when do clock/cclock rotation Add 180/180_flip options ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -hwaccel_output_format vaapi -i input.264 -vf "transpose_vaapi=clock_flip" -c:v h264_vaapi output.h264 Signed-off-by: Zachary Zhou --- configure

[FFmpeg-devel] [PATCH,v5] lavc/qsvenc: add VDENC support for H264

2018-11-28 Thread Linjie Fu
Add VDENC(lowpower mode) support for QSV H264 It's an experimental function(like lowpower in vaapi) with some limitations: - CBR/VBR require HuC which should be explicitly loaded via i915 module parameter(i915.enable_guc=2 for linux kernel version >= 4.16) Use option "-low_power 1" to enable

[FFmpeg-devel] [PATCH] refine filters to be in alphabetical order in configure

2018-11-28 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- configure | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 3e9222e..37a39e3 100755 --- a/configure +++ b/configure @@ -3395,10 +3395,10 @@ drawtext_filter_suggest="libfontconfig libfribidi"

Re: [FFmpeg-devel] [PATCH, v4] lavc/qsvenc: add VDENC support for H264

2018-11-28 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Linjie Fu > Sent: Wednesday, November 28, 2018 12:45 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH,v4] lavc/qsvenc: add VDENC support for > H264 > > Add VDENC(lowpower mode) support

Re: [FFmpeg-devel] [PATCH] libavfilter/idet: fix double count and offset accuracy on progressive frame

2018-11-28 Thread pon pon
>Please avoid top-posting here, Thannk you for your advice. I'll take care. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/hevc_parser: add 4 bytes startcode condition in hevc_find_frame_end

2018-11-28 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Thursday, November 29, 2018 02:14 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavc/hevc_parser: add 4

[FFmpeg-devel] [PATCH] [RFC] channel_layout: add support for ambisonics

2018-11-28 Thread Rostislav Pehlivanov
This is an RFC to add support for tagging channel layouts as ambisonics in a backward-compatible way. For now ambisonics up to third order are supported. The functions have been updated to support and propagate the AV_CH_LAYOUT_AMBISONICS flag. This is messy but does not require a new API for

[FFmpeg-devel] [PATCH] avcodec/msmpeg4dec: Skip frame if its smaller than 1/8 of the minimal size

2018-11-28 Thread Michael Niedermayer
Frames that small are not valid and of limited use for error concealment, while being very computationally intensive to process. Fixes: Timeout Fixes: 11318/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSMPEG4V1_fuzzer-5710884555456512 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/msmpeg4dec: Skip frame if its smaller than 1/8 of the minimal size

2018-11-28 Thread Michael Niedermayer
On Wed, Nov 28, 2018 at 10:06:12AM +0100, Hendrik Leppkes wrote: > On Wed, Nov 28, 2018 at 1:54 AM Michael Niedermayer > wrote: > > > > Fixes: Timeout > > Fixes: > > 11318/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSMPEG4V1_fuzzer-5710884555456512 > > > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: allow encoding channel mapping 2

2018-11-28 Thread Rostislav Pehlivanov
On Wed, 28 Nov 2018 at 20:35, Michael Niedermayer wrote: > On Tue, Nov 27, 2018 at 06:13:54PM +0800, Felicia Lim wrote: > > Friendly ping. Please let me know if there are any changes I should make > to > > this patch? > > will apply, seems noone else cares about it ... > > thanks > > [...] > --

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: allow encoding channel mapping 2

2018-11-28 Thread Rostislav Pehlivanov
On Fri, 27 Jul 2018 at 20:44, Felicia Lim wrote: > --- > libavcodec/libopusenc.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/libavcodec/libopusenc.c b/libavcodec/libopusenc.c > index 4ae81b0bb2..6b450ec317 100644 > --- a/libavcodec/libopusenc.c > +++

Re: [FFmpeg-devel] [PATCH]lavf/rawdec: Do not mark raw subtitle streams as data streams

2018-11-28 Thread Carl Eugen Hoyos
2018-11-28 21:21 GMT+01:00, Michael Niedermayer : > On Tue, Nov 27, 2018 at 06:24:15PM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch improves the "ffmpeg -i" output for raw dvbsub files. >> >> Please comment, Carl Eugen > >> rawdec.c | 11 +++ >> rawdec.h |4 +++- >> 2

[FFmpeg-devel] [PATCH]lavc/mpeg12dec: Read Closed Captions from second field

2018-11-28 Thread Carl Eugen Hoyos
Hi! Attached patch fixes reading Closed Captions from a field-encoded mpeg2video sample from the libav-user mailing list. Please review, Carl Eugen From 045a485ffedb3344560070a58a2def659be81700 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 28 Nov 2018 22:45:00 +0100 Subject:

Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-11-28 Thread Moritz Barsnick
On Mon, Oct 01, 2018 at 18:09:46 +0200, Mina wrote: Nit: > +be chosen in the range [1,20] and default value is 1. [...] > +chosen in the range [0.2,1024.0] and default value = 1. A bit inconsistent here, with "is" vs. "=". > +The max number of iterations for performing the algorithm. Must be

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: allow encoding channel mapping 2

2018-11-28 Thread Michael Niedermayer
On Tue, Nov 27, 2018 at 06:13:54PM +0800, Felicia Lim wrote: > Friendly ping. Please let me know if there are any changes I should make to > this patch? will apply, seems noone else cares about it ... thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH]lavf/rawdec: Do not mark raw subtitle streams as data streams

2018-11-28 Thread Michael Niedermayer
On Tue, Nov 27, 2018 at 06:24:15PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves the "ffmpeg -i" output for raw dvbsub files. > > Please comment, Carl Eugen > rawdec.c | 11 +++ > rawdec.h |4 +++- > 2 files changed, 14 insertions(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: don't treat I/O errors as EOF

2018-11-28 Thread Rodger Combs
> On Nov 28, 2018, at 13:19, Marton Balint wrote: > > > > On Wed, 28 Nov 2018, Rodger Combs wrote: > >> pb->eof_reached is set on error, so we need to check pb->error, >> even after checking pb->eof_reached or avio_feof(pb), or else we >> can end up returning AVERROR_EOF instead of the

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-28 Thread Michael Niedermayer
On Tue, Nov 27, 2018 at 11:03:50PM +0100, Martin Vignali wrote: > utils.c |4 > 1 file changed, 4 insertions(+) > 16e7e76e9bde70f7604c3df1a5ec42828e38555b > 0001-avcodec-utils-add-YUVA444P12-and-YUVA422P12-to-pixfm.patch > From db7fb1bd052ff3dba0fe3510912214aa6e66d56b Mon Sep 17

Re: [FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: don't treat I/O errors as EOF

2018-11-28 Thread Marton Balint
On Wed, 28 Nov 2018, Rodger Combs wrote: pb->eof_reached is set on error, so we need to check pb->error, even after checking pb->eof_reached or avio_feof(pb), or else we can end up returning AVERROR_EOF instead of the actual error code. Why eof_reached is set in the first place on error?

Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

2018-11-28 Thread Thilo Borgmann
>> V2 changes: >> - fixed some spelling mistakes in filters.texi >> - fixed some text format error in filters.texi Will apply soon if there are no further comments. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavc/hevc_parser: add 4 bytes startcode condition in hevc_find_frame_end

2018-11-28 Thread Michael Niedermayer
On Tue, Nov 27, 2018 at 08:16:55PM +0800, Linjie Fu wrote: > The startcode before VPS,SPS,PPS and the first NALU in an AU is 4 bytes. > Blindly taking the startcode as 3 bytes will leave 0x00 in last packet > and may lead to some warnings in parse_nal_units when s->flags is set to >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegenc: extend muxing PCM-DVD to other depths

2018-11-28 Thread Michael Niedermayer
On Tue, Nov 27, 2018 at 12:29:26PM +0100, Paul B Mahol wrote: > Fixes #6783. > > Signed-off-by: Paul B Mahol > --- > libavformat/mpegenc.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) breaks: make fate-mpegps-remuxed-pcm-demux TESTmpegps-remuxed-pcm-demux ---

Re: [FFmpeg-devel] [PATCH] avcodec/opus: set skip_samples

2018-11-28 Thread Michael Niedermayer
On Tue, Nov 27, 2018 at 03:18:14PM +0100, Paul B Mahol wrote: > Fixes #5258. > > Signed-off-by: Paul B Mahol > --- > libavcodec/opus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) breaks fate make: *** [fate-seek-mkv-codec-delay] Error 139 make: *** [fate-opus-tron.6ch.tinypkts]

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Added an option to ignore io errors

2018-11-28 Thread Jeyapal, Karthick
On 11/27/18 9:52 PM, Carl Eugen Hoyos wrote: > 2018-11-26 11:25 GMT+01:00, Karthick J : > > When dashenc has to run for long duration(say 24x7 live stream), one can > > enable this option to ignore the io failure of few segment's upload due to > > an intermittent network issues. > > When the

[FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Added an option to ignore io errors

2018-11-28 Thread Karthick J
When dashenc has to run for long duration(say 24x7 live stream), one can enable this option to ignore the io failure of few segment's upload due to an intermittent network issues. When the network connection recovers dashenc will continue with the upload of the current segments, leading to the

[FFmpeg-devel] [PATCH v2 1/2] avformat/dashenc: Handled the error from dashenc_io_open()

2018-11-28 Thread Karthick J
--- libavformat/dashenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 6ce70e0076..2f403257c0 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -527,8 +527,12 @@ static void

Re: [FFmpeg-devel] [PATCH 2/2] lavf/dashenc: Delete HLS manifests on trailer writing if remove_at_exit is set.

2018-11-28 Thread Jeyapal, Karthick
On 11/28/18 5:06 PM, Andrey Semashev wrote: > This fixes HLS manifests being left behind if remove_at_exit is set. > --- > libavformat/dashenc.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index a7d8c4e237..af3f0ee167

Re: [FFmpeg-devel] [PATCH 1/2] lavf/dashenc: Don't put non-mp4 streams in HLS manifests.

2018-11-28 Thread Jeyapal, Karthick
On 11/28/18 5:06 PM, Andrey Semashev wrote: > The only native HLS implementation in the wild (Safari browser) doesn't > support WebM. And at least some MSE-based players (e.g. shaka-player) > cannot handle WebM media segments when playing HLS. So just skip non-mp4 > streams from HLS manifests.

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Fix file URI handling when deleting files.

2018-11-28 Thread Jeyapal, Karthick
On 11/28/18 4:46 PM, Andrey Semashev wrote: > The URI used to open the output streams may be an actual URI with "file" > scheme, > according to https://tools.ietf.org/html/rfc8089. This commit makes file > deletion routine recognize file URIs and extract the actual filesystem path > from it.

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming.

2018-11-28 Thread Jeyapal, Karthick
On 11/28/18 4:41 PM, Andrey Semashev wrote: > The global_sidx flag causes errors like the following in movenc when media > segment removal is enabled via windos_size or remove_at_exit: > > Non-consecutive fragments, writing incorrect sidx > Unable to re-open output file for the second pass

Re: [FFmpeg-devel] [PATCH] avformat/movenc : Don't write sidx for empty urls

2018-11-28 Thread Jeyapal, Karthick
>On 11/28/18, 8:19 PM, "Moritz Barsnick" wrote: > >On Wed, Nov 28, 2018 at 20:10:11 +0530, Karthick J wrote: >> +// If url is an empty string("") don't write sidx atom. >> +if (s->url[0] == '\0') >> +return res; > >Probably clearer if you return 0, as res

[FFmpeg-devel] [PATCH v2] avformat/movenc : Don't write sidx for empty urls

2018-11-28 Thread Karthick J
When movenc is used by other segmenting muxers such as dashenc, url field is always empty. In such cases it is better to not write sidx, instead of throwing errors. --- libavformat/movenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

Re: [FFmpeg-devel] [PATCH] libavfilter/idet: fix double count and offset accuracy on progressive frame

2018-11-28 Thread Carl Eugen Hoyos
2018-11-28 7:52 GMT+01:00, pon pon : > I have attached logs in tichet #7565. No... Please avoid top-posting here, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/movenc : Don't write sidx for empty urls

2018-11-28 Thread Moritz Barsnick
On Wed, Nov 28, 2018 at 20:10:11 +0530, Karthick J wrote: > +// If url is an empty string("") don't write sidx atom. > +if (s->url[0] == '\0') > +return res; Probably clearer if you return 0, as res hasn't been assigned anything up to this point, except its

[FFmpeg-devel] [PATCH] avformat/movenc : Don't write sidx for empty urls

2018-11-28 Thread Karthick J
When movenc is used by other segmenting muxers such as dashenc, url field is always empty. In such cases it is better to not write sidx, instead of throwing errors. --- libavformat/movenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index

[FFmpeg-devel] [PATCH] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-11-28 Thread Andrey Semashev
This commit ensures that all (potentially, long) filesystem activity is performed when the user calls av_write_trailer on the DASH libavformat context, not when freeing the context. Also, this defers media segment deletion until after the media trailers are written. --- libavformat/dashenc.c | 19

[FFmpeg-devel] [PATCH 2/2] lavf/dashenc: Delete HLS manifests on trailer writing if remove_at_exit is set.

2018-11-28 Thread Andrey Semashev
This fixes HLS manifests being left behind if remove_at_exit is set. --- libavformat/dashenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index a7d8c4e237..af3f0ee167 100644 --- a/libavformat/dashenc.c +++

[FFmpeg-devel] [PATCH 1/2] lavf/dashenc: Don't put non-mp4 streams in HLS manifests.

2018-11-28 Thread Andrey Semashev
The only native HLS implementation in the wild (Safari browser) doesn't support WebM. And at least some MSE-based players (e.g. shaka-player) cannot handle WebM media segments when playing HLS. So just skip non-mp4 streams from HLS manifests. Note that such streams will still be described by the

[FFmpeg-devel] [PATCH] lavf/dashenc: Fix file URI handling when deleting files.

2018-11-28 Thread Andrey Semashev
The URI used to open the output streams may be an actual URI with "file" scheme, according to https://tools.ietf.org/html/rfc8089. This commit makes file deletion routine recognize file URIs and extract the actual filesystem path from it. It also fixes strerror use, which may not be thread-safe.

[FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming.

2018-11-28 Thread Andrey Semashev
The global_sidx flag causes errors like the following in movenc when media segment removal is enabled via windos_size or remove_at_exit: Non-consecutive fragments, writing incorrect sidx Unable to re-open output file for the second pass (faststart) --- libavformat/dashenc.c | 2 +- 1 file

Re: [FFmpeg-devel] [PATCH] os_support: define socket shutdown SHUT_xxx macros if they are not defined

2018-11-28 Thread Peter Ross
sys/socket.h (with WIN32 guard) is needed to check if the SHUT_xxx macro exists. and because of this, SHUT_xxx defs have been moved into the CONFIG_NETWORK block, since they only affect network capable platforms. --- This is a minor reworking of Dave's suggestion to make it work on *nix and

Re: [FFmpeg-devel] Add 16-bit Depth pixel format

2018-11-28 Thread Pablo Rubio Fernández
Yes, it is like gray16. But gray16le is already in use to Y16 pixel format. For this reason, I think that best way to add Z16 pixel format is creating it. I'm not an expert, any help will be appreciated. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/msmpeg4dec: Skip frame if its smaller than 1/8 of the minimal size

2018-11-28 Thread Hendrik Leppkes
On Wed, Nov 28, 2018 at 1:54 AM Michael Niedermayer wrote: > > Fixes: Timeout > Fixes: > 11318/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSMPEG4V1_fuzzer-5710884555456512 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH v3] libavfilter: add transpose_vaapi filter

2018-11-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Zachary Zhou > Sent: Wednesday, November 28, 2018 2:54 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Zhou, Zachary > Subject: [FFmpeg-devel] [PATCH v3] libavfilter: add transpose_vaapi filter > >