Re: [FFmpeg-devel] Add alternative delogo algorithm for my donation

2018-12-12 Thread uwe . freese
Hello Kyle, You should also try vf_removelogo. It is supposedly better than the more simple vf_delogo. I tried (with a box in a PNG mask as logo cover). That is no alternative both quality wise and from usability point of view: 1. It gave me blurry borders with several pixels widths from

[FFmpeg-devel] [PATCH] avcodec/mpeg: Initialize quarter_sample parameter from previous thread.

2018-12-12 Thread Andriy Gelman
Fixes #7410. The value of sub-pixel precision for me/mc can change during an Intra frame. In multi-threaded decoding this change is not propagated to other frame threads causing decoding artifacts. This patch initializes the sub-pixel precision parameter from previous thread, which fixes the

Re: [FFmpeg-devel] [PATCH] lavf/mov: ensure only one tkhd per trak

2018-12-12 Thread Baptiste Coudurier
Hi, > On Dec 12, 2018, at 6:53 PM, chcunningham wrote: > > Chromium fuzzing produced a whacky file with extra tkhds. This caused > an AVStream that was already in use to be corrupted by assigning it a > new id, which blows up later in mov_read_trun because the >

[FFmpeg-devel] [PATCH] lavf/id3v2: fail read_apic on EOF reading mimetype

2018-12-12 Thread chcunningham
avio_read may return EOF, leaving the mimetype array unitialized. fail early when this occurs to avoid using the array in an unitialized state. --- libavformat/id3v2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index

[FFmpeg-devel] [PATCH] lavf/mov: ensure only one tkhd per trak

2018-12-12 Thread chcunningham
Chromium fuzzing produced a whacky file with extra tkhds. This caused an AVStream that was already in use to be corrupted by assigning it a new id, which blows up later in mov_read_trun because the MOVFragmentStreamInfo.index_entry now points OOB. --- libavformat/isom.h | 3 ++- libavformat/mov.c

[FFmpeg-devel] [PATCH] avcodec/ivi: Avoid mbs memleak

2018-12-12 Thread Michael Niedermayer
Fixes: 11696/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INDEO5_fuzzer-5740319635668992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ivi.c | 6 ++ 1 file changed, 6 insertions(+)

[FFmpeg-devel] [PATCH 2/2] lavu: relax the condition to do hwframe unmapping.

2018-12-12 Thread Ruiling Song
This patch aims to fix failure of hwmap/hwunmap working against passthrough mode filters like with transpose_opencl: [vaapi_frame] "hwmap,transpose_opencl=passthrough=landscape, hwmap=derive_device=vaapi:reverse=1" [vappi_frame] If the frame meet the pass-through criteria, then the output of the

[FFmpeg-devel] [PATCH 1/2] lavfi/vf_hwmap: make hwunmap from software frame work.

2018-12-12 Thread Ruiling Song
This patch was used to fix the second hwmap filter issue: [vaapi_frame] hwmap [software filters] hwmap [vaapi_frame] For such case, we also need to allocate the hardware frame and map it back to software. Signed-off-by: Ruiling Song --- libavfilter/vf_hwmap.c | 125

Re: [FFmpeg-devel] [PATCH]lavc/ivi: Fix a Google-reported memleak

2018-12-12 Thread Michael Niedermayer
On Tue, Dec 04, 2018 at 12:34:27AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch is supposed to fix a memleak from clusterfuzz, untested... > > Please review, Carl Eugen > ivi.c |1 + > 1 file changed, 1 insertion(+) > f2714b796264d65e5f38b014966d810a168a919f >

Re: [FFmpeg-devel] [PATCH V1 2/2] lavc/vaapi_encode: fix slices number check.

2018-12-12 Thread myp...@gmail.com
On Tue, Dec 11, 2018 at 6:59 AM Mark Thompson wrote: > > On 10/12/2018 01:56, myp...@gmail.com wrote: > > On Mon, Dec 10, 2018 at 2:08 AM Mark Thompson wrote: > >> > >> On 06/12/2018 10:39, Jun Zhao wrote: > >>> Fix slice number check logic. Only when the user setting slices > >>> number more

Re: [FFmpeg-devel] [PATCH] ffmpeg: implement input file stream disabling

2018-12-12 Thread Michael Niedermayer
On Thu, Dec 13, 2018 at 01:20:22AM +0530, Gyan wrote: > > On 13-12-2018 12:50 AM, Michael Niedermayer wrote: > >On Wed, Dec 12, 2018 at 10:25:46AM +0530, Gyan wrote: > >>On 12-12-2018 03:40 AM, Michael Niedermayer wrote: > >>>On Mon, Dec 10, 2018 at 08:57:44PM +0530, Gyan wrote: > At

Re: [FFmpeg-devel] [PATCH] avformat/wavdec: add support for 'id3 ' chunk

2018-12-12 Thread Michael Niedermayer
On Wed, Dec 12, 2018 at 07:08:16PM +0100, Paul B Mahol wrote: > Fixes #5700. > > Signed-off-by: Paul B Mahol > --- > libavformat/wavdec.c | 12 > 1 file changed, 12 insertions(+) patch probably ok a fate test would be usefull for this and other bugfixes/features thanks [...] --

Re: [FFmpeg-devel] [PATCH]lavfi/signalstats: Cast AV_RN16() output to int.

2018-12-12 Thread Carl Eugen Hoyos
2018-12-12 23:45 GMT+01:00, Paul B Mahol : > On 12/12/18, Carl Eugen Hoyos wrote: >> 2018-12-11 3:16 GMT+01:00, Carl Eugen Hoyos : >> >>> I suspect attached patch fixes a bug on some platforms, silences a >>> warning. >>> >>> Please comment, Carl Eugen >> >> Ping. > > lgtm Patch applied. Thank

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-12 Thread Carl Eugen Hoyos
2018-12-12 23:44 GMT+01:00, Paul B Mahol : > On 12/12/18, Carl Eugen Hoyos wrote: >> 2018-12-12 23:30 GMT+01:00, Paul B Mahol : >>> On 12/12/18, Carl Eugen Hoyos wrote: Hi! Attached patch fixes ticket #4553 for me. Please comment, Carl Eugen >>> >>> I do not like what

Re: [FFmpeg-devel] Add alternative delogo algorithm for my donation

2018-12-12 Thread Kyle Swanson
Hi, On 12/11/18, uwe.fre...@gmx.de wrote: > Hello, > > I would like that the delogo filter is improved by an alternative way of > removing the logo. It's the "UGLARM" mode known from Virtual Dub's > DeLogo filter and ffdshow. > I used it many years (under Windows), but now moving to Linux miss

Re: [FFmpeg-devel] [PATCH]lavfi/signalstats: Cast AV_RN16() output to int.

2018-12-12 Thread Paul B Mahol
On 12/12/18, Carl Eugen Hoyos wrote: > 2018-12-11 3:16 GMT+01:00, Carl Eugen Hoyos : > >> I suspect attached patch fixes a bug on some platforms, silences a >> warning. >> >> Please comment, Carl Eugen > > Ping. lgtm ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-12 Thread Paul B Mahol
On 12/12/18, Carl Eugen Hoyos wrote: > 2018-12-12 23:30 GMT+01:00, Paul B Mahol : >> On 12/12/18, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> Attached patch fixes ticket #4553 for me. >>> >>> Please comment, Carl Eugen >>> >> >> I do not like what you did to G729Context. > >> Please rewrite patch.

Re: [FFmpeg-devel] [PATCH]lavfi/signalstats: Cast AV_RN16() output to int.

2018-12-12 Thread Carl Eugen Hoyos
2018-12-11 3:16 GMT+01:00, Carl Eugen Hoyos : > I suspect attached patch fixes a bug on some platforms, silences a warning. > > Please comment, Carl Eugen Ping. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-12 Thread Carl Eugen Hoyos
2018-12-12 23:30 GMT+01:00, Paul B Mahol : > On 12/12/18, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes ticket #4553 for me. >> >> Please comment, Carl Eugen >> > > I do not like what you did to G729Context. > Please rewrite patch. > Move relevant parts into G729ChannelContext

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-12 Thread Paul B Mahol
On 12/12/18, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4553 for me. > > Please comment, Carl Eugen > I do not like what you did to G729Context. Please rewrite patch. Move relevant parts into G729ChannelContext chan[2]; ___

[FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

2018-12-12 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4553 for me. Please comment, Carl Eugen From 64114575e9015608c0266df5a6339f526e9dd233 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 12 Dec 2018 23:19:59 +0100 Subject: [PATCH] lavc/g729dec: Support stereo streams. Fixes ticket #4553. ---

Re: [FFmpeg-devel] [FFmpeg-cvslog] opusenc: fix infinite loop if flushing encoder upon init

2018-12-12 Thread Carl Eugen Hoyos
2018-12-12 21:09 GMT+01:00, Rostislav Pehlivanov : > ffmpeg | branch: master | Rostislav Pehlivanov | Wed > Dec 12 20:05:33 2018 +| [83db1efd42bd4d89a5a78bb3001481e009d99304] | > committer: Rostislav Pehlivanov > > opusenc: fix infinite loop if flushing encoder upon init > > The issue is that

Re: [FFmpeg-devel] [PATCH] ffmpeg: implement input file stream disabling

2018-12-12 Thread Gyan
On 13-12-2018 12:50 AM, Michael Niedermayer wrote: On Wed, Dec 12, 2018 at 10:25:46AM +0530, Gyan wrote: On 12-12-2018 03:40 AM, Michael Niedermayer wrote: On Mon, Dec 10, 2018 at 08:57:44PM +0530, Gyan wrote: At Michael's suggestion, this patch lets -vn/-an/-sn/-dn work for input files.

Re: [FFmpeg-devel] [PATCH] ffmpeg: implement input file stream disabling

2018-12-12 Thread Michael Niedermayer
On Wed, Dec 12, 2018 at 10:25:46AM +0530, Gyan wrote: > > On 12-12-2018 03:40 AM, Michael Niedermayer wrote: > >On Mon, Dec 10, 2018 at 08:57:44PM +0530, Gyan wrote: > >>At Michael's suggestion, this patch lets -vn/-an/-sn/-dn work for input > >>files. Individual streams can still be let through

Re: [FFmpeg-devel] [PATCH 3/3] Add ADPCM IMA CRYO APC encoder

2018-12-12 Thread Michael Niedermayer
On Wed, Dec 12, 2018 at 01:25:15PM +0100, Tomas Härdin wrote: > ons 2018-12-12 klockan 00:05 +0100 skrev Michael Niedermayer: > > On Mon, Dec 10, 2018 at 12:32:51PM +0100, Tomas Härdin wrote: > > > > > >  Changelog  |1 + > > >  libavcodec/adpcmenc.c  |   33

[FFmpeg-devel] [PATCH] avformat/utils: add support for reading ID3 tags at start of wav

2018-12-12 Thread Paul B Mahol
Fixes #4140. Signed-off-by: Paul B Mahol --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 93e588ee1e..7afef545fe 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -646,7 +646,7 @@

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/gif: enable encoding single gif image per frame

2018-12-12 Thread Carl Eugen Hoyos
2018-12-12 17:32 GMT+01:00, Paul B Mahol : > Unbreaks gif image2 muxer. If you commit the patches together I believe this one needs a micro version bump, alternative is to add it to some of the commits. Thank you! Carl Eugen ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] avformat/wavdec: add support for 'id3 ' chunk

2018-12-12 Thread Paul B Mahol
Fixes #5700. Signed-off-by: Paul B Mahol --- libavformat/wavdec.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c index e280be4d44..6ab0a49313 100644 --- a/libavformat/wavdec.c +++ b/libavformat/wavdec.c @@ -34,6 +34,7 @@ #include

[FFmpeg-devel] [PATCH 6/6] avcodec/codec_desc: extend gif description

2018-12-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/codec_desc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 4850e4fb43..73f343ce24 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -723,7 +723,7 @@ static

[FFmpeg-devel] [PATCH 2/6] avcodec/gif: add support for alpha

2018-12-12 Thread Paul B Mahol
Based on patch by Bjorn Roche. Fixes #6813. Signed-off-by: Paul B Mahol --- libavcodec/gif.c | 168 --- 1 file changed, 144 insertions(+), 24 deletions(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index 3074b7f7db..c158ae3180 100644 ---

[FFmpeg-devel] [PATCH 3/6] avformat/gifdec: export sample aspect ratio

2018-12-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/gifdec.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/gifdec.c b/libavformat/gifdec.c index 8993ca615c..1f3ac8d8d9 100644 --- a/libavformat/gifdec.c +++ b/libavformat/gifdec.c @@ -99,7 +99,7 @@ static int

[FFmpeg-devel] [PATCH 4/6] avcodec/gif: enable encoding single gif image per frame

2018-12-12 Thread Paul B Mahol
Unbreaks gif image2 muxer. Signed-off-by: Paul B Mahol --- libavcodec/gif.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index c158ae3180..19c0f1b318 100644 --- a/libavcodec/gif.c +++ b/libavcodec/gif.c @@ -51,6

[FFmpeg-devel] [PATCH 5/6] avformat/gif: extend description

2018-12-12 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/gif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/gif.c b/libavformat/gif.c index 548abf46ba..82cad01455 100644 --- a/libavformat/gif.c +++ b/libavformat/gif.c @@ -202,7 +202,7 @@ static const AVClass gif_muxer_class

[FFmpeg-devel] [PATCH v2 1/2] avformat/dashenc : Refactored HLS media playlist related code

2018-12-12 Thread Karthick J
Made it as a separate function, so that it could be reused (in future) --- libavformat/dashenc.c | 135 +++--- 1 file changed, 75 insertions(+), 60 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 585b34cb97..f797b7bd1c 100644 ---

[FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Added support for Low-latency HLS(Experimental)

2018-12-12 Thread Karthick J
Apple doesn't have an official spec for LHLS. Meanwhile hls.js player folks are trying to standardize a open LHLS spec. The draft spec is available in https://github.com/video-dev/hlsjs-rfcs/blob/lhls-spec/proposals/0001-lhls.md This option will also try to comply with the above open spec, till

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Added support for Low-latency HLS(LHLS)

2018-12-12 Thread Jeyapal, Karthick
On 12/12/18 9:10 PM, Moritz Barsnick wrote: > On Wed, Dec 12, 2018 at 12:48:21 +0530, Karthick J wrote: >> Apple doesn't have an official spec for LHLS. Meanwhile hls.js player folks >> are >> trying to standardize a open LHLS spec. The draft spec is available in >>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Added support for Low-latency HLS(LHLS)

2018-12-12 Thread Moritz Barsnick
On Wed, Dec 12, 2018 at 12:48:21 +0530, Karthick J wrote: > Apple doesn't have an official spec for LHLS. Meanwhile hls.js player folks > are > trying to standardize a open LHLS spec. The draft spec is available in > https://github.com/video-dev/hlsjs-rfcs/blob/lhls-spec/proposals/0001-lhls.md >

Re: [FFmpeg-devel] [PATCH] avcodec/gifdec: truncate too big width/height for invalid gif files

2018-12-12 Thread Carl Eugen Hoyos
2018-12-12 13:47 GMT+01:00, Tomas Härdin : > mån 2018-12-10 klockan 13:34 +0100 skrev Paul B Mahol: >> Fixes #6874. >> >> > Signed-off-by: Paul B Mahol >> --- >> libavcodec/gifdec.c | 16 >> 1 file changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/libavcodec/gifdec.c

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Nicolas George
Paul B Mahol (2018-12-12): > Demuxer only split file into small packets, no data is trimmed. > Encoder & muxer currently expect completely another format > where muxer writes stuff like disposal method which should > be really encoder job. > With this patch muxer only modifies delay between two

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Paul B Mahol
On 12/12/18, Nicolas George wrote: > Paul B Mahol (2018-12-12): >> It needs that because decoder & demuxer work that way. > > This answer do not say anything. Please elaborate enough as to be > convincing. And put it in the commit message. Demuxer only split file into small packets, no data is

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Nicolas George
Paul B Mahol (2018-12-12): > It needs that because decoder & demuxer work that way. This answer do not say anything. Please elaborate enough as to be convincing. And put it in the commit message. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Paul B Mahol
On 12/12/18, Nicolas George wrote: > Paul B Mahol (2018-12-11): >> Now "-c copy" works. >> Update FATE files. >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/gif.c| 127 +++- >> libavformat/gif.c | 242 ++ >>

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Nicolas George
Paul B Mahol (2018-12-11): > Now "-c copy" works. > Update FATE files. > > Signed-off-by: Paul B Mahol > --- > libavcodec/gif.c| 127 +++- > libavformat/gif.c | 242 ++ > tests/ref/fate/gifenc-bgr4_byte | 346

Re: [FFmpeg-devel] [PATCH] avcodec/gifdec: truncate too big width/height for invalid gif files

2018-12-12 Thread Paul B Mahol
On 12/12/18, Tomas Härdin wrote: > mån 2018-12-10 klockan 13:34 +0100 skrev Paul B Mahol: >> Fixes #6874. >> >> > Signed-off-by: Paul B Mahol >> --- >> libavcodec/gifdec.c | 16 >> 1 file changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/libavcodec/gifdec.c

Re: [FFmpeg-devel] [PATCH] avcodec/gifdec: truncate too big width/height for invalid gif files

2018-12-12 Thread Tomas Härdin
mån 2018-12-10 klockan 13:34 +0100 skrev Paul B Mahol: > Fixes #6874. > > > Signed-off-by: Paul B Mahol > --- >  libavcodec/gifdec.c | 16 >  1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/gifdec.c b/libavcodec/gifdec.c > index

Re: [FFmpeg-devel] [PATCH 3/3] Add ADPCM IMA CRYO APC encoder

2018-12-12 Thread Tomas Härdin
ons 2018-12-12 klockan 00:05 +0100 skrev Michael Niedermayer: > On Mon, Dec 10, 2018 at 12:32:51PM +0100, Tomas Härdin wrote: > > > >  Changelog  |1 + > >  libavcodec/adpcmenc.c  |   33 + > >  libavcodec/allcodecs.c |1 +

Re: [FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

2018-12-12 Thread Paul B Mahol
On 12/11/18, Carl Eugen Hoyos wrote: > 2018-12-11 17:40 GMT+01:00, Paul B Mahol : >> On 12/11/18, Carl Eugen Hoyos wrote: >>> 2018-12-11 17:37 GMT+01:00, Paul B Mahol : On 12/11/18, Paul B Mahol wrote: > On 12/11/18, Carl Eugen Hoyos wrote: >> 2018-12-11 17:18 GMT+01:00, Paul B

[FFmpeg-devel] [PATCH 2/2] add an example to show how to fill the ROI info

2018-12-12 Thread Guo, Yejun
This patchset contains two patches. - the first patch finished the code and ask for upstreaming. - the second patch (this patch) is just a quick example and not ask for upstreaming. to verify it, the command line looks like: ./ffmpeg -i .../path_to_1920x1080_video_file -vf scale=1920:1080 -c:v

[FFmpeg-devel] [PATCH 1/2] add support for ROI-based encoding

2018-12-12 Thread Guo, Yejun
This patchset contains two patches. - the first patch (this patch) finished the code and ask for upstream. - the second patch is just a quick example on how to generate ROI info. The encoders such as libx264 support different QPs offset for different MBs, it makes possible for ROI-based encoding.