Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC modes

2019-02-05 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Eoff, Ullysses A > Sent: Tuesday, February 05, 2019 8:51 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC >

Re: [FFmpeg-devel] Server upgrades

2019-02-05 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl > Eugen Hoyos > Sent: Tuesday, February 05, 2019 4:57 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Server upgrades > > 2019-02-05 18:03 GMT+01:00,

Re: [FFmpeg-devel] Server upgrades

2019-02-05 Thread Carl Eugen Hoyos
2019-02-05 18:03 GMT+01:00, Eoff, Ullysses A : >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Michael Niedermayer >> Sent: Friday, February 01, 2019 4:53 AM >> To: FFmpeg development discussions and patches >> Subject: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix muxing EAC3 with delay_moov

2019-02-05 Thread Niki Bowe
On Tue, Feb 5, 2019 at 4:33 PM Niki Bowe wrote: > Hi Carl. > You are of course correct. > Attached replacement patch. > > > On Mon, Feb 4, 2019 at 6:24 PM Carl Eugen Hoyos > wrote: > >> 2019-02-05 3:11 GMT+01:00, Nikolas Bowe : >> >> > +if (mov->tracks[i].eac3_priv) >> > +

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix muxing EAC3 with delay_moov

2019-02-05 Thread Niki Bowe
Hi Carl. You are of course correct. Attached replacement patch. On Mon, Feb 4, 2019 at 6:24 PM Carl Eugen Hoyos wrote: > 2019-02-05 3:11 GMT+01:00, Nikolas Bowe : > > > +if (mov->tracks[i].eac3_priv) > > +av_freep(>tracks[i].eac3_priv); > > I would have expected that the

[FFmpeg-devel] [PATCH] configure: warn about disabled explicitly enabled components

2019-02-05 Thread Marton Balint
If we enable a component but a dependant library is disabled, then the enabled component gets silently disabled. Warning about disabled explicitly enabled components allows configure to show the missing dependencies and if --fatal-warnings is used it can also fail if the user wants it so. For

[FFmpeg-devel] [PATCH 2/3] libavcodec/cbs: Don't zero twice

2019-02-05 Thread Andreas Rheinhardt
Up until now, a fragment that got reused was zeroed twice: Once during uninit and once during reading the next packet/extradata/buffer. The second zeroing has now been made optional. This is also in preparation of actually reusing a fragment's units array. Otherwise it would be lost during

[FFmpeg-devel] [PATCH 1/3] libavcodec/cbs: Add ability to keep the units array.

2019-02-05 Thread Andreas Rheinhardt
Currently, a fragment's unit array is constantly reallocated during splitting of a packet. This commit adds the ability to keep the unit array by distinguishing between the number of allocated and the number of valid units in the unit array. Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH 0/3] cbs: Reuse the units array

2019-02-05 Thread Andreas Rheinhardt
Currently, in a lot of places where cbs is used there is a fragment in the relevant context that is constantly reused to decompose and recompose packets. This currently works as follows: The fragment (which is already zeroed at the very beginning) is zeroed at the beginning of the process of

[FFmpeg-devel] [PATCH 3/3] cbs: Stop reallocating fragment unit arrays

2019-02-05 Thread Andreas Rheinhardt
This commit changes various places that make use of cbs to keep the fragments' unit arrays instead of constantly reallocating them. The more units a packet is split into, the bigger the benefit. So MPEG-2 benefits the most; for a video coming from an NTSC-DVD (usually 32 units per frame) the

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

2019-02-05 Thread Baptiste Coudurier
Hi Niki, > On Feb 4, 2019, at 6:03 PM, Niki Bowe wrote: > > Hi Baptiste. > I agree. This patch does cause it to fail in mov_write_header in the given > example, by propagating the errors returned from mov_write_ac3_tag. > > It is not always extradata related. > Eg EAC3 parses the packets

Re: [FFmpeg-devel] [PATCH 0/2] ARIB STD-B24 caption decoding using libaribb24

2019-02-05 Thread Jan Ekström
On Tue, Feb 5, 2019 at 1:56 AM Carl Eugen Hoyos wrote: > > 2019-02-02 15:21 GMT+01:00, Jan Ekström : > > On Sat, Feb 2, 2019 at 3:55 PM Carl Eugen Hoyos wrote: > >> > >> 2019-02-02 14:31 GMT+01:00, Jan Ekström : > >> > >> > I will proceed to making a FATE test > >> > >> You cannot add fate tests

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-02-05 Thread Paul B Mahol
On 2/1/19, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/median.h | 47 > libavfilter/median_template.c | 152

Re: [FFmpeg-devel] Server upgrades

2019-02-05 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Friday, February 01, 2019 4:53 AM > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] Server upgrades > > Hi all > > The OS and related

Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC modes

2019-02-05 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Monday, February 04, 2019 1:26 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC > modes > > On 28/01/2019

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 Thread Michael Niedermayer
On Tue, Feb 05, 2019 at 11:20:03AM +0100, Bodecs Bela wrote: > > 2019.02.05. 0:45 keltezéssel, Carl Eugen Hoyos írta: > >2019-02-03 16:24 GMT+01:00, Marton Balint : > >> > >>On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: > >> > >>>2019-01-28 2:00 GMT+01:00, Marton Balint : > If we enable a

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 Thread Devin Heitmueller
On Tue, Feb 5, 2019 at 6:29 AM Carl Eugen Hoyos wrote: > How would this be better than printing a warning if the feature > could not be enabled as it is already done in some situations? In most systems I've worked with, if I say "enable something" and it cannot be enabled I want the ./configure

Re: [FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-02-05 Thread Carl Eugen Hoyos
2019-01-28 0:47 GMT+01:00, Mark Thompson : > +if (avctx->color_range == AVCOL_RANGE_MPEG) { > +av_log(avctx, AV_LOG_WARNING, "Input video does not appear " > + "to use full-range: output colours may be incorrect.\n"); The wording seems not ideal to me: Are you not sure

Re: [FFmpeg-devel] [PATCH v2 06/11] vaapi_encode_vp9: Enable support for more RC modes

2019-02-05 Thread Carl Eugen Hoyos
2019-01-28 0:47 GMT+01:00, Mark Thompson : > --- > libavcodec/vaapi_encode_vp9.c | 41 +-- > 1 file changed, 25 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/vaapi_encode_vp9.c b/libavcodec/vaapi_encode_vp9.c > index 97142dcc49..f89fd0d07a 100644 > ---

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 Thread Carl Eugen Hoyos
2019-02-05 11:20 GMT+01:00, Bodecs Bela : > > 2019.02.05. 0:45 keltezéssel, Carl Eugen Hoyos írta: >> 2019-02-03 16:24 GMT+01:00, Marton Balint : >>> >>> On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: >>> 2019-01-28 2:00 GMT+01:00, Marton Balint : > If we enable a component but a dependant

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 Thread Carl Eugen Hoyos
2019-02-05 10:13 GMT+01:00, Hendrik Leppkes : > On Tue, Feb 5, 2019 at 2:43 AM Carl Eugen Hoyos wrote: >> >> 2019-02-05 1:13 GMT+01:00, Hendrik Leppkes : >> > On Tue, Feb 5, 2019 at 1:01 AM Carl Eugen Hoyos >> > wrote: >> >> >> >> 2019-02-05 0:53 GMT+01:00, Marton Balint : >> >> > >> >> > >> >>

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 Thread Bodecs Bela
2019.02.05. 0:45 keltezéssel, Carl Eugen Hoyos írta: 2019-02-03 16:24 GMT+01:00, Marton Balint : On Sun, 3 Feb 2019, Carl Eugen Hoyos wrote: 2019-01-28 2:00 GMT+01:00, Marton Balint : If we enable a component but a dependant library is disabled, then the enabled component get silently

Re: [FFmpeg-devel] [PATCHv2] configure: request explicitly enabled components

2019-02-05 Thread Bodecs Bela
2019.02.03. 12:46 keltezéssel, Marton Balint írta: On Mon, 28 Jan 2019, Marton Balint wrote: If we enable a component but a dependant library is disabled, then the enabled component get silently disabled. Requesting all explicitly enabled components allows configure to fail and show the

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 Thread Hendrik Leppkes
On Tue, Feb 5, 2019 at 2:43 AM Carl Eugen Hoyos wrote: > > 2019-02-05 1:13 GMT+01:00, Hendrik Leppkes : > > On Tue, Feb 5, 2019 at 1:01 AM Carl Eugen Hoyos wrote: > >> > >> 2019-02-05 0:53 GMT+01:00, Marton Balint : > >> > > >> > > >> > On Tue, 5 Feb 2019, Carl Eugen Hoyos wrote: > >> > > >> >>