Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-09-07 Thread Aaron Boushley
Can I get a review on this. Anywhere we have code calling out and performing undefined behavior we should clean that up. Aaron On Sat, Jul 27, 2019 at 7:58 AM Aaron Boushley wrote: > > The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. > Each of these use `continue;` as the er

Re: [FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-07 Thread Hyun Yoo
Sorry about this. At first I commit with git format-patch & send-email on my desktop but it was discarded because I didn't subcribe to devel mailing list. After join the ml I forwarded the mail on mobile gmail which might cause the extra newline mess. What should I do now? git send-email commit the

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-07 Thread Michael Niedermayer
On Sat, Sep 07, 2019 at 11:11:25PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_scale.c | 26 ++ > 1 file changed, 22 insertions(+), 4 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF21

Re: [FFmpeg-devel] [PATCH v1] avformat/movenc: split empty text sample when duration overflow

2019-09-07 Thread Jan Ekström
Hi, On Sun, Sep 8, 2019 at 12:28 AM Jun Li wrote: > Some details: > Current implementation will insert one empty sample whenever there is a gap > between two captions lines. But when the gap's duration is way too big, the > sample's duration will exceed MP4's limitation, thus mov muxer will fail

Re: [FFmpeg-devel] [PATCH 1/2] avformat/avformat: Introduced `AVInputFormat.read_timestamp2` to fix keyframe seeking for formats that rely on `read_timestamp` for seeking

2019-09-07 Thread Darren Mo
I think I understand some of what you are saying. You are saying that after the bisection, continuously step backwards + read forward while doubling the step size until the keyframe is found? Some questions: - What is the difference between the lowercase k and the uppercase K in your diagram? A

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-07 Thread Andrey Semashev
On 2019-09-07 18:32, Limin Wang wrote: On Sat, Sep 07, 2019 at 05:19:55PM +0200, Michael Niedermayer wrote: On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote: Because lavf_container is sometimes called with only 2 arguments, fate tests produce bash errors like this: tests/fate

Re: [FFmpeg-devel] [PATCH] avformat: Fix probing on some JPEGs

2019-09-07 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 05:00:14PM -0700, Niki Bowe wrote: > As it turns out the last patch still lets a lot of jpegs get misidentified. > > This new version avoids the problem by checking for jpeg magic at the start. > > I also added a FATE test, and attached the jpeg for the test. > > > > On

Re: [FFmpeg-devel] [PATCH v1] avformat/movenc: split empty text sample when duration overflow

2019-09-07 Thread Jun Li
On Fri, Sep 6, 2019 at 4:10 PM Jun Li wrote: > Fix #7637 > One empty/end sample is created and inserted between two caption lines > when there is a gap. > This patch is to split the sample into multiple ones when its duration is > too long (>= INT_MAX). > --- > libavformat/movenc.c | 24

Re: [FFmpeg-devel] [PATCH v1] swscale/swscale: various cosmetics for the code style

2019-09-07 Thread Andriy Gelman
On Sat, 07. Sep 23:50, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libswscale/swscale.c | 40 > 1 file changed, 12 insertions(+), 28 deletions(-) > > diff --git a/libswscale/swscale.c b/libswscale/swscale.c > i

[FFmpeg-devel] [PATCH] avcodec/h2645_parse: simplify memset call

2019-09-07 Thread Andriy Gelman
From: Andriy Gelman Removed (new_size - pkt->nals_allocated) because this value is always 1 during the call. --- libavcodec/h2645_parse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index 307e8643e6..ef6a6b4b4f 100644

Re: [FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-07 Thread Michael Niedermayer
On Sat, Sep 07, 2019 at 07:23:13PM +0900, Hyun Yoo wrote: > From: Hyun Yoo > > rtsp_st->sdp_payload_type is the first codec in 'm=' tag > st->codecpar->id is the first supported codec in 'a=' tag > the two is not guaranteed to be same for example when > 1) the order between attributes is random(r

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-07 Thread Marton Balint
On Wed, 4 Sep 2019, Anthony Delannoy wrote: Hi I'm still interested to have those three commits merged (update in attachments). Ok, below are some more comments. But I'd like to see data decoder in the future to use more easily EPG/NIT/BAT etc tables. Will it be possible? With modificati

[FFmpeg-devel] [PATCH v1] swscale/swscale: various cosmetics for the code style

2019-09-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/swscale.c | 40 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 4069550..3e2ebd5 100644 --- a/libswscale/swscale.c +++ b/libswscal

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-07 Thread Limin Wang
On Sat, Sep 07, 2019 at 05:19:55PM +0200, Michael Niedermayer wrote: > On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote: > > Because lavf_container is sometimes called with only 2 arguments, > > fate tests produce bash errors like this: > > > > tests/fate-run.sh: 299: test: =: une

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-07 Thread Michael Niedermayer
On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote: > Because lavf_container is sometimes called with only 2 arguments, > fate tests produce bash errors like this: > > tests/fate-run.sh: 299: test: =: unexpected operator > > This commit fixes this. > --- > tests/fate-run.sh | 2 +-

Re: [FFmpeg-devel] [PATCH v1 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-07 Thread Limin Wang
On Fri, Sep 06, 2019 at 08:08:48PM +0200, Michael Niedermayer wrote: > On Sat, Jul 27, 2019 at 08:18:16PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_scale.c | 29 + > > 1 file changed, 25 ins

[FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_scale: change filter_frame interface to activate interface

2019-09-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_scale.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index cb42794..5c1d811 100644 --- a/libavfilter/vf_scale.c +++ b/libavfi

[FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_scale: split the scale_frame function from filter_frame for activate function support

2019-09-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_scale.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index bf340b8..cb42794 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_s

Re: [FFmpeg-devel] [PATCH v3 3/3] FATE: add a test for freeezedetect

2019-09-07 Thread Limin Wang
On Sat, Aug 24, 2019 at 07:38:59PM +0200, Marton Balint wrote: > > > On Sat, 24 Aug 2019, Limin Wang wrote: > > >On Fri, Aug 23, 2019 at 08:27:22PM +0200, Michael Niedermayer wrote: > >>On Fri, Aug 23, 2019 at 08:17:09PM +0800, lance.lmw...@gmail.com wrote: > >>> From: Limin Wang > >>> > Signed

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/qdm2: Check frame size

2019-09-07 Thread Michael Niedermayer
On Fri, Sep 06, 2019 at 11:08:06PM +0200, Paul B Mahol wrote: > Are you sure this is not band aid but actually real fix? Sorry, I did not see your reply yesterday before applying the change. Without a real (non fuzzer) sample and no reference specification or reference implementation that is ope

[FFmpeg-devel] [PATCH] avformat/hlsenc: print warning at the end when upload the last segment failed

2019-09-07 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index f881bb9d60..10e90c3839 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2601,6 +2601,8 @@ static int hls_write_trailer(struct

[FFmpeg-devel] [PATCH] rtsp: fix wrong codec setup for some sdp

2019-09-07 Thread Hyun Yoo
From: Hyun Yoo rtsp_st->sdp_payload_type is the first codec in 'm=' tag st->codecpar->id is the first supported codec in 'a=' tag the two is not guaranteed to be same for example when 1) the order between attributes is random(rfc4566 doesn't force it) 2) the first codec is same for 'm=' and 'a='