Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-28 Thread James Zern
On Fri, Jan 17, 2020 at 1:56 PM Wonkap Jang wrote: > > Hi James, > > On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to enable three > > preset temporal structures

Re: [FFmpeg-devel] [PATCH 02/13] lavc/ass: add support for configuring default style via AVOptions

2020-01-28 Thread rcombs
> On Jan 27, 2020, at 08:28, Moritz Barsnick wrote: > > On Fri, Jan 24, 2020 at 20:01:49 -0600, rcombs wrote: >> +static int invert_ass_alpha(uint32_t c) >> +{ >> +uint32_t a = c >> 24; >> +return ((255 - a) << 24) | (c & 0xff); >> +} > > You're inverting the "leftmost" 8 bits of

Re: [FFmpeg-devel] [PATCH] avformat/mov: update extensions

2020-01-28 Thread Gyan
On 29-01-2020 05:52 am, Carl Eugen Hoyos wrote: Am Mo., 27. Jan. 2020 um 18:07 Uhr schrieb Gyan : As I mentioned, the benefit is for cli users able to specify `-f ext` as well as `-h demuxer=ext` I cannot reproduce this... That will depend on my patch that adds av_find_input_format2. I

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-28 Thread Pedro Arthur
Em ter., 28 de jan. de 2020 às 21:20, Carl Eugen Hoyos escreveu: > > Am Mi., 22. Jan. 2020 um 13:09 Uhr schrieb Martin Storsjö : > > > If it takes time to get the test to that point, I would suggest reverting > > the existing two tests for now. > > Did this when I realized that the existing test

[FFmpeg-devel] Fix undefined behavior in ff_configure_buffers_for_index()

2020-01-28 Thread Dale Curtis
When e2_pts == INT64_MIN and e1_pts >= 0 the calculation of e2_pts - e1_pts will overflow an int64_t. So instead check for overflow and default to |time_tolerance| if the value is too large for an int64_t. Signed-off-by: Dale Curtis From 412751f4747faf34e3dba088dc55290783eb6bd5 Mon Sep 17

[FFmpeg-devel] [PATCH]lavf/nut: Explicitely add tags for NV12 and NV21

2020-01-28 Thread Carl Eugen Hoyos
Hi! Mentioned tags are already used in nut by fate. Please comment, Carl Eugen From dd52b20ce2eea008a0c58c09f768e5ef92133578 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 29 Jan 2020 01:43:24 +0100 Subject: [PATCH] lavf/nut: Explicitely add NV12/NV21 tags. These are already used

Re: [FFmpeg-devel] [PATCH] avformat/mov: update extensions

2020-01-28 Thread Carl Eugen Hoyos
Am Mo., 27. Jan. 2020 um 18:07 Uhr schrieb Gyan : > As I mentioned, the benefit is for cli users able to specify `-f ext` > as well as `-h demuxer=ext` I cannot reproduce this... Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] fate/filter-video.mak: do not use bit-exact check for dnn_processing

2020-01-28 Thread Carl Eugen Hoyos
Am Mi., 22. Jan. 2020 um 13:09 Uhr schrieb Martin Storsjö : > If it takes time to get the test to that point, I would suggest reverting > the existing two tests for now. Did this when I realized that the existing test breaks fate without SAMPLES on all platforms. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Carl Eugen Hoyos
Am Di., 28. Jan. 2020 um 22:28 Uhr schrieb Paul B Mahol : > +static int isansicode(int x) > +{ > +return (x == 0x1B) || (x >= 0x20 && x < 0x7f); I would have expected at least CR and LF, maybe also the tabulator, to be valid characters. Carl Eugen

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-01-28 Thread Asaf Kave
On Sun, Jan 26, 2020, 12:31 Asaf Kave wrote: > > > On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave wrote: > >> >> >> On Tue, Jan 21, 2020 at 8:17 PM Lynne wrote: >> >>> Jan 20, 2020, 08:42 by kavea...@gmail.com: >>> >>> > Ping >>> > >>> >>>

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..69aad64790 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -34,6 +34,13 @@ #include

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Nicolas George
Paul B Mahol (12020-01-28): > I certainly could write one which does not use locale, if that is ok with you? You know better than me on this issue. I was just pointing something that may have been forgotten. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Paul B Mahol
On 1/28/20, Nicolas George wrote: > Peter Ross (12020-01-29): >> > +for (int i = 0; i < p->buf_size; i++) >> > +cnt += !!isprint(p->buf[i]); > > This depends on locale settings. Is it on purpose? I certainly could write one which does not use locale, if that is ok with you? > >

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Nicolas George
Peter Ross (12020-01-29): > > +for (int i = 0; i < p->buf_size; i++) > > +cnt += !!isprint(p->buf[i]); This depends on locale settings. Is it on purpose? Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Add threshold for IFF_ILBM

2020-01-28 Thread Peter Ross
On Thu, Jan 23, 2020 at 12:36:39AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (32 -> 1sec) > Fixes: > 20138/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5634665251864576 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Peter Ross
On Tue, Jan 28, 2020 at 02:17:35PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 8d48f2c45c..a8fb9dc8f3 100644 > ---

[FFmpeg-devel] [PATCH 2/3] avcodec/pngdec: Check amount decoded

2020-01-28 Thread Michael Niedermayer
Fixes: Timeout (70sec -> 243ms) Fixes: 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 Fixes: 16927/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5170612070252544 Fixes:

[FFmpeg-devel] [PATCH 1/3] avcodec/apedec: Fix integer overflows in predictor_decode_mono_3950()

2020-01-28 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147407150 + -1871606 cannot be represented in type 'int' Fixes: 18702/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5679095417667584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 3/3] avcodec/lagarith: Sanity check scale

2020-01-28 Thread Michael Niedermayer
A value of 24 and above can collaps the range to 0 which would not work. Fixes: Timeout (75sec -> 21sec) Fixes: 18707/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-5708950892969984 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

2020-01-28 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-01-24 13:04:08) > On Tue, Jan 21, 2020 at 07:44:46PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-01-21 15:43:48) > > > On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2020-01-16 17:51:28) >

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/pngdec: Check amount decoded

2020-01-28 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 01:28:39AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (70sec -> 243ms) > Fixes: > 16097/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5664690889293824 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2020-01-28 Thread Anton Khirnov
Quoting Nicolas George (2020-01-14 17:07:56) > Anton Khirnov (12020-01-14): > > No. If you want to mix multiple streams, then your mixing filter should > > support multiple streams. It is certainly in no way "natural" or correct > > to invent a scheme for stream multiplexing through channel

[FFmpeg-devel] [PATCH 1/2] libavcodec/amfenc_hevc.c: Fix constant QP settings for I, P

2020-01-28 Thread OvchinnikovDmitrii
--- libavcodec/amfenc_hevc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c index 7c9a33ab33..8b4d289fac 100644 --- a/libavcodec/amfenc_hevc.c +++ b/libavcodec/amfenc_hevc.c @@ -254,10 +254,10 @@ static av_cold int

[FFmpeg-devel] [PATCH 2/2] libavcodec/amfenc_hevc.c: Fix Profile level option on AMF HEVC.

2020-01-28 Thread OvchinnikovDmitrii
Patch was made by Sitan Liu The same code already exists in amfenc_h264.c --- libavcodec/amfenc_hevc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c index 8b4d289fac..77e57d2461 100644 --- a/libavcodec/amfenc_hevc.c

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mov: Free encryption data on error

2020-01-28 Thread Michael Niedermayer
On Mon, Jan 27, 2020 at 09:28:18AM +0100, Andreas Rheinhardt wrote: > Fixes memleak and Coverity issue #1439587. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mov.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mov: Don't leak MOVFragmentStreamInfo on error

2020-01-28 Thread Michael Niedermayer
On Mon, Jan 27, 2020 at 09:28:19AM +0100, Andreas Rheinhardt wrote: > Fixes Coverity issue #1441933. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mov.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avfilter/asrc_sinc: Don't allocate arrays separately

2020-01-28 Thread Michael Niedermayer
On Mon, Jan 27, 2020 at 09:36:51AM +0100, Paul B Mahol wrote: > LGTM will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato signature.asc

Re: [FFmpeg-devel] [IMPORTANT] FOSDEM meeting

2020-01-28 Thread Jean-Baptiste Kempf
On Tue, Jan 28, 2020, at 09:08, Paul B Mahol wrote: > On 1/28/20, Jean-Baptiste Kempf wrote: > > On Mon, Jan 27, 2020, at 14:52, Paul B Mahol wrote: > >> > If you cannot go to FOSDEM for money reasons, please contact me. Both > >> > FFmpeg > >> > and VideoLAN can sponsor your venue to Brussels! >

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_zoompan: fix shaking when zooming

2020-01-28 Thread Robert Deibel
On 28.01.20 15:46, Paul B Mahol wrote: On 1/28/20, Robert Deibel wrote: On 27.01.20 16:44, Paul B Mahol wrote: On 1/27/20, Robert Deibel wrote: -y = *dy = av_clipd(*dy, 0, FFMAX(in->height - h, 0)); -var_values[VAR_Y] = *dy; -y &= ~((1 << s->desc->log2_chroma_h) - 1); - -out

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_zoompan: fix shaking when zooming

2020-01-28 Thread Paul B Mahol
On 1/28/20, Robert Deibel wrote: > On 27.01.20 16:44, Paul B Mahol wrote: >> On 1/27/20, Robert Deibel wrote: >>> -y = *dy = av_clipd(*dy, 0, FFMAX(in->height - h, 0)); >>> -var_values[VAR_Y] = *dy; >>> -y &= ~((1 << s->desc->log2_chroma_h) - 1); >>> - >>> -out =

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_zoompan: fix shaking when zooming

2020-01-28 Thread Robert Deibel
On 27.01.20 16:44, Paul B Mahol wrote: On 1/27/20, Robert Deibel wrote: -y = *dy = av_clipd(*dy, 0, FFMAX(in->height - h, 0)); -var_values[VAR_Y] = *dy; -y &= ~((1 << s->desc->log2_chroma_h) - 1); - -out = ff_get_video_buffer(outlink, outlink->w, outlink->h); +out =

Re: [FFmpeg-devel] [PATCH 1/5] avformat/format: add av_find_input_format2

2020-01-28 Thread Andreas Rheinhardt
Gyan Doshi: > Identifies demuxer by extension if search by short name fails. > --- > libavformat/avformat.h | 7 +++ > libavformat/format.c | 14 +- > libavformat/version.h | 2 +- > 3 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avformat.h

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/avdct: Clear IDCTDSPContext context

2020-01-28 Thread Michael Niedermayer
On Mon, Jan 27, 2020 at 11:49:49PM -0300, James Almer wrote: > On 1/27/2020 9:25 PM, Michael Niedermayer wrote: > > On Mon, Jan 27, 2020 at 06:09:28PM -0300, James Almer wrote: > >> On 1/27/2020 5:54 PM, Michael Niedermayer wrote: > >>> Fixes use of uninitialized variable and segfault > >>> > >>>

[FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/tty.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/tty.c b/libavformat/tty.c index 8d48f2c45c..a8fb9dc8f3 100644 --- a/libavformat/tty.c +++ b/libavformat/tty.c @@ -24,6 +24,8 @@ * Tele-typewriter

Re: [FFmpeg-devel] [PATCH] avfilter/scale: fix CID 1457833

2020-01-28 Thread Anton Khirnov
Quoting Gyan (2020-01-17 10:40:22) > > > On 16-01-2020 09:07 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2020-01-16 13:59:47) > >> --- > >> libavfilter/vf_scale.c | 6 ++ > >> 1 file changed, 2 insertions(+), 4 deletions(-) > >> > >> diff --git a/libavfilter/vf_scale.c

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: correct to representative names for mov.c

2020-01-28 Thread Gyan
On 28-01-2020 02:33 pm, Hendrik Leppkes wrote: On Tue, Jan 28, 2020 at 9:55 AM Gyan wrote: On 28-01-2020 01:37 pm, Hendrik Leppkes wrote: On Tue, Jan 28, 2020 at 8:46 AM Gyan Doshi wrote: --- libavformat/mov.c | 6 +++--- libavformat/utils.c | 2 +- 2 files changed, 4

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Michael Niedermayer
On Tue, Jan 28, 2020 at 08:17:11AM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/tty.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tty.c b/libavformat/tty.c > index 8d48f2c45c..c127500fa1 100644 > ---

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: correct to representative names for mov.c

2020-01-28 Thread Hendrik Leppkes
On Tue, Jan 28, 2020 at 9:55 AM Gyan wrote: > > > > On 28-01-2020 01:37 pm, Hendrik Leppkes wrote: > > On Tue, Jan 28, 2020 at 8:46 AM Gyan Doshi wrote: > >> --- > >> libavformat/mov.c | 6 +++--- > >> libavformat/utils.c | 2 +- > >> 2 files changed, 4 insertions(+), 4 deletions(-) > >> >

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: correct to representative names for mov.c

2020-01-28 Thread Gyan
On 28-01-2020 01:37 pm, Hendrik Leppkes wrote: On Tue, Jan 28, 2020 at 8:46 AM Gyan Doshi wrote: --- libavformat/mov.c | 6 +++--- libavformat/utils.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mov: correct to representative names for mov.c

2020-01-28 Thread Hendrik Leppkes
On Tue, Jan 28, 2020 at 8:46 AM Gyan Doshi wrote: > > --- > libavformat/mov.c | 6 +++--- > libavformat/utils.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 064fa88137..064d2b5f6e 100644 > --- a/libavformat/mov.c >

Re: [FFmpeg-devel] [IMPORTANT] FOSDEM meeting

2020-01-28 Thread Paul B Mahol
On 1/28/20, Jean-Baptiste Kempf wrote: > On Mon, Jan 27, 2020, at 14:52, Paul B Mahol wrote: >> On 1/27/20, Jean-Baptiste Kempf wrote: >> > Hello fellow developers, >> > >> > As a reminder, this week-end is the FOSDEM, in Brussels. >> > >> > As promised, we will do a FFmpeg developer meeting,

Re: [FFmpeg-devel] [IMPORTANT] FOSDEM meeting

2020-01-28 Thread Liu Steven
> 在 2020年1月27日,下午3:29,Jean-Baptiste Kempf 写道: > > Hello fellow developers, > > As a reminder, this week-end is the FOSDEM, in Brussels. Looks very interesting. > > As promised, we will do a FFmpeg developer meeting, where we will vote on the > decisions taken during VDD. > Notably, re-elect