Hi Caleb,
There is a space missing in the commit message before "fast-fail".
Few minor comments below.
Looks good otherwise -- it works as expected on an MXF file that
contains JPEG 2000 Part 15 code-blocks.
Looking forward to the full implementation!
Best,
-- Pierre
On Tue, Apr 19, 2022 at
> On May 3, 2022, at 5:35 AM, Vignesh Venkatasubramanian
> wrote:
>
> Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
>
> AVIF Specification: https://aomediacodec.github.io/av1-avif
>
> Sample usage for still image:
> ffmpeg -i image.png -c:v libaom-av1 -avif-image 1
David Fletcher:
> Following today's posts about help with submitting patches I realised I
> sent the libmad patch yesterday in the wrong format. Apologies, I was
> not familiar with the git format patches.
>
> Hopefully the attached version is now in the correct format against the
> current
> -Original Message-
> From: ffmpeg-devel On Behalf Of Soft
> Works
> Sent: Tuesday, May 3, 2022 6:27 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Cc: Traian Coza
> Subject: Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap
> subtitle conversion
On Mon, May 2, 2022 at 2:35 PM Vignesh Venkatasubramanian
wrote:
>
> Add an AVIF muxer by re-using the existing the mov/mp4 muxer.
>
> AVIF Specification: https://aomediacodec.github.io/av1-avif
>
> Sample usage for still image:
> ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif
>
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of Soft
> Works
> Sent: Wednesday, January 12, 2022 4:37 AM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [RFC] QSV: Introduce min Compile-SDK
> Version and check for
> -Original Message-
> From: ffmpeg-devel On Behalf Of Mark
> Thompson
> Sent: Tuesday, May 3, 2022 10:32 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] hwcontext: Skip derivation
> checking for an existing device if options are set
>
> On 03/05/2022 01:14,
> -Original Message-
> From: ffmpeg-devel On Behalf Of Mark
> Thompson
> Sent: Tuesday, May 3, 2022 10:23 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutils/hwcontext: add derive-
> device function which searches for existing devices in both directions
>
On 03/05/2022 01:14, Soft Works wrote:
-Original Message-
From: ffmpeg-devel On Behalf Of Mark
Thompson
Sent: Tuesday, May 3, 2022 2:09 AM
To: FFmpeg development discussions and patches
Subject: [FFmpeg-devel] [PATCH] hwcontext: Skip derivation checking
for an existing device if
On 03/05/2022 01:11, Soft Works wrote:
-Original Message-
From: ffmpeg-devel On Behalf Of Mark
Thompson
Sent: Tuesday, May 3, 2022 1:57 AM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutils/hwcontext: add derive-
device function which searches for existing
Following today's posts about help with submitting patches I realised I
sent the patch yesterday to add wolfSSL as a TLS backend in the wrong
format. Apologies, I was not familiar with the git format patches.
Hopefully the attached version is now in the correct format against the
current master
Following today's posts about help with submitting patches I realised I
sent the libmad patch yesterday in the wrong format. Apologies, I was
not familiar with the git format patches.
Hopefully the attached version is now in the correct format against the
current master branch.
The bug report
Used libass to render text-based subtitles in the AVSubtitle structure during
transcoding.
This enables text to bitmap subtitle track conversion
This only works with --enable-libass. Otherwise, nothing should change.
Minor version bump required (field appended to AVCodecContext).
---
I've modified my previous patch to fix a number of aesthetic issues.
First, I have only one commit now.
Second, I have read the Contributing section and I think I respected all the
conventions mentionned there.
Third, I have rebased my commit to be up-to-date with the central repo.
Tell me if
Thanks, I'll do that. I did read a bit of Contributing, but not entirely.
And I read after writing the code, so there are some things I wasn't aware
of at the time of writing the code.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On 5/3/22 13:01, Traian Coza wrote:
I already made the commits, tho, what do you suggest I do? Should I modify
the messages?
___
You'll have to send another patchset. You append -v2 to your "git
format-patch" command-line to generate a second
On 5/3/22 12:17, Traian Coza wrote:
Thanks, I finally managed to submit my patch with your instructions.
However, I see that the "Less secure apps" setting will no longer be
available in a month. What do you plan on doing then? (I see you also use
gmail)
You'll have to enable two-factor
I already made the commits, tho, what do you suggest I do? Should I modify
the messages?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
Whether an ICC profile is present or not, the libjxl
encoder wrapper should now properly read colorspace tags
and forward them to libjxl appropriately, rather than just
assume sRGB as before. It will also print warnings when
colorimetric assumptions are made about the input data.
---
Whether an ICC profile is present or not, the decoder
should now properly tag the colorspace of pixel data
received by the decoder.
---
libavcodec/libjxldec.c | 84 --
1 file changed, 81 insertions(+), 3 deletions(-)
diff --git a/libavcodec/libjxldec.c
Add proper colorspace handling and tagging to the libjxl
decoder and encoder wrappers.
Changes
v2:
- avoid misusing AVMasteringDisplayMetadata
- ignore custom primaries in header (very rare without iccp)
Leo Izen (2):
avcodec/libjxldec: properly tag output colorspace
avcodec/libjxlenc:
Paul B Mahol (12022-05-03):
> Sorry but i think this needs to be in libavfilter instead of libavcodec.
>
> And for libavfilter one needs to add proper, not hacky, subtitle support to
> library.
I completely agree.
Also, the patches neglect a lot of the directives in the developer
documentation,
Fixes: Timeout
Fixes:
47043/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-4824799337119744
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
tools/target_dec_fuzzer.c | 1 +
1 file
Signed-off-by: Michael Niedermayer
---
libavcodec/smacker.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
index 179c70f1ee..5d94a54179 100644
--- a/libavcodec/smacker.c
+++ b/libavcodec/smacker.c
@@
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Traian Coza
> Sent: Tuesday, May 3, 2022 6:13 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Traian Coza
> Subject: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle
> conversion functionality!
>
> I added the possibility of
On Tue, May 3, 2022 at 6:13 PM Traian Coza wrote:
> I added the possibility of converting text-based subtitle tracks (such as
> subrip or ass) to bitmap-based subtitle tracks (such as dvd_subtitle).
>
> I accomplished this by using libass, and basically using the code from
> vf_subtitles.c to
Thanks, I finally managed to submit my patch with your instructions.
However, I see that the "Less secure apps" setting will no longer be
available in a month. What do you plan on doing then? (I see you also use
gmail)
On Tue, May 3, 2022 at 11:53 AM Leo Izen wrote:
> On 5/3/22 00:12, Traian
---
fftools/ffmpeg.c| 2 +-
libavcodec/avcodec.c| 9 +
libavcodec/text_to_bitmap.c | 13 +++--
libavcodec/text_to_bitmap.h | 8 +++-
4 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index
---
fftools/text_to_bitmap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fftools/text_to_bitmap.c b/fftools/text_to_bitmap.c
index 0f165e7722..e05e485713 100644
--- a/fftools/text_to_bitmap.c
+++ b/fftools/text_to_bitmap.c
@@ -122,7 +122,8 @@ void
---
libavcodec/text_to_bitmap.c | 9 ++---
libavcodec/text_to_bitmap.h | 6 +++---
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavcodec/text_to_bitmap.c b/libavcodec/text_to_bitmap.c
index 50c72afc55..273564cb67 100644
--- a/libavcodec/text_to_bitmap.c
+++
---
fftools/ffmpeg.c | 4 +++-
fftools/text_to_bitmap.c | 27 ++-
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 251a3ce427..b4d3d491de 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3244,7
---
fftools/ffmpeg.c| 50 ---
libavcodec/Makefile | 1 +
libavcodec/avcodec.h| 9 ++
libavcodec/text_to_bitmap.c | 170
libavcodec/text_to_bitmap.h | 18
libavfilter/vf_subtitles.c | 97
6
---
fftools/ffmpeg.c| 39 ++---
libavcodec/text_to_bitmap.c | 58 +++--
libavfilter/vf_subtitles.c | 18
3 files changed, 58 insertions(+), 57 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index
---
{libavcodec => fftools}/text_to_bitmap.c | 0
{libavcodec => fftools}/text_to_bitmap.h | 0
2 files changed, 0 insertions(+), 0 deletions(-)
rename {libavcodec => fftools}/text_to_bitmap.c (100%)
rename {libavcodec => fftools}/text_to_bitmap.h (100%)
diff --git
---
fftools/Makefile | 2 ++
fftools/ffmpeg.c | 6 --
fftools/text_to_bitmap.c | 14 +++---
fftools/text_to_bitmap.h | 14 --
libavcodec/Makefile | 1 -
libavcodec/avcodec.c | 9 -
6 files changed, 13 insertions(+), 33 deletions(-)
---
libavcodec/text_to_bitmap.c | 47 -
libavcodec/text_to_bitmap.h | 25 +---
2 files changed, 68 insertions(+), 4 deletions(-)
diff --git a/libavcodec/text_to_bitmap.c b/libavcodec/text_to_bitmap.c
index c419e89c20..52d161d7b1 100644
---
---
fftools/ffmpeg.c | 29 ++---
libavfilter/vf_subtitles.c | 9 -
2 files changed, 30 insertions(+), 8 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index dea2aec2ce..a74800bb68 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@
---
fftools/ffmpeg.c | 12 ++--
libavfilter/vf_subtitles.c | 1 -
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 53717d3ebb..dea2aec2ce 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -2422,9 +2422,8 @@ static
---
fftools/ffmpeg.c | 47 ++-
libavfilter/vf_subtitles.c | 117 +
2 files changed, 163 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index a85ed18b08..53717d3ebb 100644
--- a/fftools/ffmpeg.c
+++
I added the possibility of converting text-based subtitle tracks (such as
subrip or ass) to bitmap-based subtitle tracks (such as dvd_subtitle).
I accomplished this by using libass, and basically using the code from
vf_subtitles.c to render text subtitles and store the images in the AVSubtitle
On 5/3/22 00:12, Traian Coza wrote:
Hi! I am new to contributing to FFmpeg, and I have a technical question.
I'm trying to submit a patch, but it's a fairly large patch, which I've
made in multiple commits. I don't know how to generate the email for this
patch. The example command given on the
Whether an ICC profile is present or not, the libjxl
encoder wrapper should now properly read colorspace tags
and forward them to libjxl appropriately, rather than just
assume sRGB as before. It will also print warnings when
colorimetric assumptions are made about the input data.
---
I know, but when I click on "New Pull Request" on ffstaging/FFmpeg, it
automatically sets the "base repository" to FFmpeg/FFmpeg, and I can't
change it to ffstaging/FFmpeg (see image). Am I doing something wrong,
perhaps?
[image: image.png]
___
Whether an ICC profile is present or not, the decoder
should now properly tag the colorspace of pixel data
received by the decoder.
---
libavcodec/libjxl.h| 9 +++
libavcodec/libjxldec.c | 121 -
2 files changed, 127 insertions(+), 3 deletions(-)
Add proper colorspace handling and tagging to the libjxl
decoder and encoder wrappers.
Leo Izen (2):
avcodec/libjxldec: properly tag output colorspace
avcodec/libjxlenc: properly read input colorspace
libavcodec/libjxl.h| 9 +++
libavcodec/libjxldec.c | 121
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Traian Coza
> Sent: Tuesday, May 3, 2022 5:37 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Need help submitting a patch
>
> Hey Softworks, when I try to open a pull request
Hey Softworks, when I try to open a pull request on that repo it says "An
owner of this repository has limited the ability to open a pull request to
users that are collaborators on this repository." So I am not a
collaborator, can you add me as a collaborator so I can do my pull request?
I've seen
Traian Coza (12022-05-03):
> Sorry about the "top posting" my client does it automatically.
It's a poor craftsman who blames their tools.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
Sorry about the "top posting" my client does it automatically.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
Sounds great, thanks! It's great that there's this functionality somewhere.
I'm not used to this email stuff.
On Tue, May 3, 2022 at 10:08 AM Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Nicolas George
> > Sent: Tuesday, May 3, 2022 3:31 PM
> >
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Nicolas George
> Sent: Tuesday, May 3, 2022 3:31 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Need help submitting a patch
>
> Traian Coza (12022-05-03):
> > Thanks. I'll
This can be necessary to e.g. force a fixed-point audio codec.
Signed-off-by: Andreas Rheinhardt
---
tests/fate-run.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 4f8988b964..2606fcb917 100755
--- a/tests/fate-run.sh
+++
Signed-off-by: Andreas Rheinhardt
---
tests/fate/filter-video.mak | 10 ++
tests/ref/fate/filter-meta-4560-rotate0 | 2 ++
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 68f4c084f8..b9f3ef238b
Michael Niedermayer:
> On Thu, Mar 31, 2022 at 12:49:55AM +0200, Andreas Rheinhardt wrote:
>> This is possible, because every given FFCodec has to implement
>> exactly one of these. Doing so decreases sizeof(FFCodec) and
>> therefore decreases the size of the binary.
>> Notice that in case of
Andreas Rheinhardt:
> Traian Coza:
>> Thanks. I'll use the ffstaging/FFmpeg repo. I didn't know about that, it
>> seems much simpler. I've tried using -n (n= number of commits), but it only
>> generates n emails, I only want 1.
>>
>> I have another concern before I create a pull request. I ran
Traian Coza (12022-05-03):
> Thanks. I'll use the ffstaging/FFmpeg repo. I didn't know about that, it
> seems much simpler.
It is not supported by the core of the project.
> I've tried using -n (n= number of commits), but it only
> generates n emails, I only want 1.
Look at
Traian Coza:
> Thanks. I'll use the ffstaging/FFmpeg repo. I didn't know about that, it
> seems much simpler. I've tried using -n (n= number of commits), but it only
> generates n emails, I only want 1.
>
> I have another concern before I create a pull request. I ran 'make fate'
> like it says on
Thanks. I'll use the ffstaging/FFmpeg repo. I didn't know about that, it
seems much simpler. I've tried using -n (n= number of commits), but it only
generates n emails, I only want 1.
I have another concern before I create a pull request. I ran 'make fate'
like it says on the website for
Traian Coza (12022-05-03):
> Hi! I am new to contributing to FFmpeg, and I have a technical question.
>
> I'm trying to submit a patch, but it's a fairly large patch, which I've
> made in multiple commits. I don't know how to generate the email for this
> patch. The example command given on the
This removes a dependency of checkasm on lavc/v210_enc.o
and also allows to inline ff_v210enc_init() irrespectively of
interposing.
This dependency pulled basically all of libavcodec into checkasm,
in particular all codecs.
This also makes checkasm work when using shared Windows builds:
On
This removes a dependency of checkasm on lavc/v210_dec.o
and also allows to inline ff_v210dec_init() irrespectively of
interposing.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/v210dec.c | 29 +--
libavcodec/v210dec.h | 1 -
libavcodec/v210dec_init.h | 61
This removes a dependency of checkasm on lavfi/vf_nlmeans.o
and also allows to inline ff_nlmeans_init() irrespectively of
interposing.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_nlmeans.c | 108 +-
libavfilter/vf_nlmeans.h | 1 -
This removes a dependency of checkasm on lavfi/vf_threshold.o
and also allows to inline ff_threshold_init() irrespectively of
interposing.
With this patch checkasm no longer pulls all of lavfi and lavf in.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/threshold.h | 1 -
This removes a dependency of checkasm on lavfi/vf_hflip.o
and also allows to inline ff_hflip_init() irrespectively of
interposing.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/hflip.h | 1 -
libavfilter/vf_hflip.c | 88 +
This removes a dependency of checkasm on lavfi/vf_gblur.o
and also allows to inline ff_gblur_init() irrespectively of
interposing.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/gblur.h | 1 -
libavfilter/vf_gblur.c | 89 +-
libavfilter/vf_gblur_init.h
This removes a dependency of checkasm on lavfi/vf_eq.o
and also allows to inline ff_eq_init() irrespectively of
interposing.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_eq.c | 27 ---
libavfilter/vf_eq.h | 26 +-
2 files changed, 25
This removes a dependency of checkasm on lavfi/vf_blend.o
and also allows to inline ff_blend_init() irrespectively of
interposing.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/blend.h | 1 -
libavfilter/vf_blend.c | 176 +--
This allows to inline it in af_afir.c (regardless of interposing);
moreover it removes a dependency of the checkasm test on
lavfi/af_afir.o.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/af_afir.c| 25 -
libavfilter/af_afirdsp.h | 29 -
Only the AudioFIRDSPContext and the functions for its initialization
are needed outside of lavfi/af_afir.c.
Also rename the header to af_afirdsp.h to reflect the change.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/af_afir.c | 71 +-
libavfilter/af_afir.h
69 matches
Mail list logo
